Re: [PATCH] i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-20 Thread Wolfram Sang
On Tue, Nov 18, 2014 at 09:00:58PM +0400, Alexander Kochetkov wrote: > commit 1d7afc95946487945cc7f5019b41255b72224b70 (i2c: omap: ack IRQ in parts) > changed the interrupt handler to complete transfers without clearing > XRDY (AL case) and ARDY (NACK case) flags. XRDY or ARDY interrupts will be >

Re: [PATCH] Fixes: 1d7afc9 i2c: omap: ack IRQ in parts

2014-11-20 Thread Wolfram Sang
> > Tested on Beagleboard XM C. > > > > Signed-off-by: Alexander Kochetkov > > Cc: # v3.7+ > > This is good, but subject is wrong. That fixes line should not be the > subject, it should be here after Cc :-) I'll take this as an Ack unless you protest. signature.asc Description: Digital sign

Re: [PATCH v2 2/3] ARM: OMAP2+: hwmod: AM335x/AM43x: add hwmod support for tscadc on am43x-evm

2014-11-20 Thread Paul Walmsley
On Fri, 21 Nov 2014, Vignesh R wrote: > On 11/20/2014 12:39 PM, Paul Walmsley wrote: > > On Tue, 4 Nov 2014, Vignesh R wrote: > > > >> This patch adds hwmod support for tscadc to work on am43xx-evm. The am33xx > >> hwmod structures of tscadc has been moved to ipblock_data so that it can > >> be re

Re: [PATCH v2 2/3] ARM: OMAP2+: hwmod: AM335x/AM43x: add hwmod support for tscadc on am43x-evm

2014-11-20 Thread Vignesh R
On 11/20/2014 12:39 PM, Paul Walmsley wrote: > On Tue, 4 Nov 2014, Vignesh R wrote: > >> This patch adds hwmod support for tscadc to work on am43xx-evm. The am33xx >> hwmod structures of tscadc has been moved to ipblock_data so that it can >> be reused in am43xx. The clock domain names are separat

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-20 Thread Alexander Kochetkov
21 нояб. 2014 г., в 3:16, Alexander Kochetkov написал(а): > commit 6d9939f651419a63e091105663821f9c7d3fec37 (i2c: omap: split out [XR]DR > and [XR]RDY) changed the way how errata i207 (I2C: RDR Flag May Be Incorrectly > Set) get handled. It's is seen if open 6d9939f651419a63e09^ and 6d9939f65141

[PATCH] i2c: omap: fix i207 errata handling

2014-11-20 Thread Alexander Kochetkov
commit 6d9939f651419a63e091105663821f9c7d3fec37 (i2c: omap: split out [XR]DR and [XR]RDY) changed the way how errata i207 (I2C: RDR Flag May Be Incorrectly Set) get handled. 6d9939f6514 code doesn't correspond to workaround provided by errata. According to errata ISR must filter out spurious RDR b

[PATCH 3/3] drivers: bus: Move omap gpmc code to live under drivers

2014-11-20 Thread Tony Lindgren
Just move to drivers as further clean-up can now happen there finally. Cc: Arnd Bergmann Cc: Roger Quadros Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/Kconfig | 1 + arch/arm/mach-omap2/Makefile | 2 +- drivers/bus/Kconfig

[PATCH 0/3] Move omap GPMC to live in drivers/bus

2014-11-20 Thread Tony Lindgren
Hi all, Looks like we can now finally move omap GPMC (General Purpose Memory Controller) to live under drivers for further clean-up work. Regards, Tony Tony Lindgren (3): ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header ARM: OMAP2+: Move GPMC initcall to devices.c dri

[PATCH 2/3] ARM: OMAP2+: Move GPMC initcall to devices.c

2014-11-20 Thread Tony Lindgren
This will us allow to just move gpmc.c to live under drivers in the next patch. Note that we now also remove the omap specific check for the initcall. That's OK as gpmc_probe() checks for the pdata and bails out for other platforms compiled in. Cc: Arnd Bergmann Cc: Roger Quadros Signed-off-by:

[PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header

2014-11-20 Thread Tony Lindgren
We still need to support platform data for omap3 until it's booting in device tree only mode. So let's add platform_data/omap-gpmc.h for that, and a minimal linux/omap-gpmc.h for the save and restore used by the PM code. Once omap3 boots in device tree only mode, we can make the data structures in

[PATCH 3/4] i2c: omap: don't reset controller if Arbitration Lost detected

2014-11-20 Thread Alexander Kochetkov
Arbitration Lost is a expected situation in a multimaster environment. IP correctly detect it. The only reason for reseting IP in the AL case is to be sure to avoid advisory 1.94 (omap3) and errata i595 (omap4): "I2C: After an Arbitration is Lost the Module Incorrectly Starts the Next Transfer" wi

[PATCH 1/4] i2c: omap: cleanup register definitions

2014-11-20 Thread Alexander Kochetkov
Delete STAT_AD0 mask as unrelated to current IP (omap1?). Delete DEBUG conditional around SYSTEST masks group. Add SYSTEST functional mode masks for SCL and SDA. Add STAT_BF mask. Signed-off-by: Alexander Kochetkov --- drivers/i2c/busses/i2c-omap.c | 10 +++--- 1 file changed, 7 insertions

[PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-20 Thread Alexander Kochetkov
In a multimaster environment, after IP software reset, BB-bit value doesn't correspond to the current bus state. It may happen what BB-bit will be 0, while the bus is busy due to another I2C master activity. Any transfer started when BB=0 and bus is busy wouldn't be completed by IP and results in

[PATCH 4/4] i2c: omap: add notes related to i2c multimaster mode

2014-11-20 Thread Alexander Kochetkov
No functional changes. Signed-off-by: Alexander Kochetkov --- drivers/i2c/busses/i2c-omap.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 47103e7..4e3642c 100644 --- a/drivers/i2c/busses/i2c-

[RFC 0/4] i2c: omap: patch series related to multimaster mode

2014-11-20 Thread Alexander Kochetkov
Here is the patch series intended to improve stability of i2c-omap driver in the i2c multimaster environments. Tested on Beagleboard XM C. For now all fine. No controller timeouts, no data corruptions. Also impelemented i2c bus fault detection during startup and after reset. So, instead of the m

Re: [PATCH] i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-20 Thread Aaro Koskinen
On Tue, Nov 18, 2014 at 09:00:58PM +0400, Alexander Kochetkov wrote: > commit 1d7afc95946487945cc7f5019b41255b72224b70 (i2c: omap: ack IRQ in parts) > changed the interrupt handler to complete transfers without clearing > XRDY (AL case) and ARDY (NACK case) flags. XRDY or ARDY interrupts will be >

Re: [PATCH v2 0/3] Add support for ADC on am437x-gp and am43x-epos-evm

2014-11-20 Thread Paul Walmsley
On Fri, 14 Nov 2014, Tony Lindgren wrote: > * Vignesh R [141113 20:09]: > > > > On Tuesday 04 November 2014 04:45 PM, Vignesh R wrote: > > > This series of patches enable ADC on am437x-gp-evm and am43x-epos-evm. > > > The ADC clock hwmod data of am33xx has been moved to commom place so that > >

[PATCH] MAINTAINERS: add maintainer for OMAP hwmod data

2014-11-20 Thread Paul Walmsley
I wind up reviewing and committing most of the OMAP hwmod data patches, so, add myself to MAINTAINERS there so folks will cc me. Signed-off-by: Paul Walmsley Cc: Tony Lindgren Cc: Benoît Cousson --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINER

[PATCH 3/7] dwc3: dwc3-keystone: fix error return code

2014-11-20 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 0/7] fix error return code

2014-11-20 Thread Julia Lawall
The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ... when !

Re: [GIT PULL] ARM: OMAP2+: some clock/hwmod patches for v3.19

2014-11-20 Thread Paul Walmsley
On Fri, 14 Nov 2014, Tony Lindgren wrote: > Pulling into omap-for-v3.19/soc thanks. FYI, looks like there are > few more open hwmod related threads you may want to look at: Thanks for the ping... > [PATCH v2 0/3] Add support for ADC on am437x-gp and am43x-epos-evm Just posted some comments abou

[GIT PULL] ARM: OMAP2+: some more hwmod & clock patches for v3.19

2014-11-20 Thread Paul Walmsley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Tony, The following changes since commit 79005fbd3e1d671d08c45c9140ee9826efdc367c: ARM: OMAP2+: hwmod: drop unnecessary list initialization (2014-11-13 09:36:55 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/lin

Re: [RFC PATCH] ARM: DRA: hwmod: RTC: Add reset function for RTC

2014-11-20 Thread Paul Walmsley
On Thu, 20 Nov 2014, Lokesh Vutla wrote: > On Monday 17 November 2014 10:13 AM, Lokesh Vutla wrote: > > RTC IP have kicker feature which prevents spurious writes to its registers. > > In order to write into any of the RTC registers, KICK values has te be > > written to KICK registers. Currently hw

Re: [PATCH 2/2] i2c: omap: fix "Too much work in one IRQ" irq handling

2014-11-20 Thread Wolfram Sang
Hi, thanks for the list! > latest, v3 (same as v2, fixed subject line): > https://patchwork.ozlabs.org/patch/412095/ Yes, I have an eye on this one. Only waiting for the test results from older platforms by Aaro. > Sorry, for making so much noise. No problem, this is part of the process. Still

Re: [PATCH 2/2] i2c: omap: fix "Too much work in one IRQ" irq handling

2014-11-20 Thread Alexander Kochetkov
Hello, 18 нояб. 2014 г., в 19:12, Wolfram Sang написал(а): > I got confused with all the patches sent out for his issues. Can you ack > them once you are fine and mention if you consider them important for > this or the next release? That would be really helpful! Duplicate/Obsolete (v1): https

Re: [GIT PULL 2/3] omap gpmc changes for v3.19

2014-11-20 Thread Tony Lindgren
* Tony Lindgren [141120 08:11]: > * Arnd Bergmann [141120 03:04]: > > On Wednesday 12 November 2014, Tony Lindgren wrote: > > > GPMC (General Purpose Memory Controller) changes for omaps. These > > > changes allow us to drop dependencies to bootloader timings now > > > that the known device tree

Re: [GIT PULL 2/3] omap gpmc changes for v3.19

2014-11-20 Thread Tony Lindgren
* Arnd Bergmann [141120 03:04]: > On Wednesday 12 November 2014, Tony Lindgren wrote: > > GPMC (General Purpose Memory Controller) changes for omaps. These > > changes allow us to drop dependencies to bootloader timings now > > that the known device tree entries have been fixed. So we can now > >

Re: [GIT PULL 1/2] omap non-urgent fixes for v3.19

2014-11-20 Thread Tony Lindgren
* Arnd Bergmann [141120 01:48]: > On Tuesday 11 November 2014, Tony Lindgren wrote: > > > > Fixes for omap3 that are not urgent. Mostly to remove unnecessary > > noise during the boot with pointless errors and warnings. > > > > >

Re: [GIT PULL 2/2] omap prcm clean-up for v3.19

2014-11-20 Thread Tony Lindgren
* Arnd Bergmann [141120 03:10]: > On Tuesday 11 November 2014, Tony Lindgren wrote: > > Clean-up series for omap PRCM (Power Reset Clock Module) from > > Tero Kristo to move things a bit closer to becoming a proper > > device driver. > > Pulled into next/soc, as some of the changes seem slightly

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-20 Thread Richard Cochran
On Thu, Nov 20, 2014 at 07:26:00PM +0530, Sekhar Nori wrote: > I tested this using lcd7 cape connected to beaglebone black. The latest > kernel I could find on this board was a TI BSP based v3.14 kernel. So I > had to port these patches to that kernel. Cc Robert Nelson to see if he > knows about a

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-20 Thread Richard Cochran
Brad, What you wrote is just the kind of thing one would like to see in the cover letter or change log... On Thu, Nov 20, 2014 at 02:23:30PM +, Griffis, Brad wrote: > In that thread the user was registering multiple press events for a single > press. By increasing the udelay to 1.5ms they w

RE: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-20 Thread Griffis, Brad
> -Original Message- > From: Nori, Sekhar > Sent: Thursday, November 20, 2014 7:56 AM > > I also tested this series on AM335x EVM using the v3.18-rc5 kernel. > Again, no breakage but no improvement as well. The primary goal was not necessarily to improve performance of the touchscreen its

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-20 Thread Sekhar Nori
On Tuesday 18 November 2014 10:42 PM, Dmitry Torokhov wrote: > On Tue, Nov 18, 2014 at 02:30:05PM +, Lee Jones wrote: >> On Fri, 14 Nov 2014, Vignesh R wrote: >> >>> In one shot mode, sequencer automatically disables all enabled steps at >>> the end of each cycle. (both ADC steps and TSC steps)

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
Hi Pavel, On 11/20/2014 01:12 PM, Pavel Machek wrote: Hi! I would also swap the segments of a property name to follow the convention as in case of "regulator-max-microamp". Updated version: == Optional properties for child nodes: - max

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
On 11/19/2014 10:45 AM, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same, but white LED block should be updated with different value. I think

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Pavel Machek
Hi! > >> But regulators already have "regulator-max-microamp" property. So what > >> about: > >> > >> max-microamp : maximum intensity in microamperes of the LED > >> (torch LED for flash devices) > >> max-flash-microamp : initial intensity in microamperes of the > >>

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Pavel Machek
Hi! > I would also swap the segments of a property name to follow the convention > as in case of "regulator-max-microamp". > > Updated version: > > == > > Optional properties for child nodes: > - max-microamp : maximum intensity in microam

Re: [PATCH 01/15] clk: divider: replace bitfield width with mask

2014-11-20 Thread James Hogan
On 20/11/14 11:19, Tero Kristo wrote: > On 11/20/2014 01:15 AM, James Hogan wrote: >> - Updated assignment of clk_divider::width in imx, rockchip, st, sunxi, >>ti clock components to use mask instead (not tested), using the >>following semantic patch: > > Hi James/Mike, > > This patch cur

Re: [PATCH 01/15] clk: divider: replace bitfield width with mask

2014-11-20 Thread Tero Kristo
On 11/20/2014 01:15 AM, James Hogan wrote: From: Mike Turquette The forthcoming Device Tree binding for the divider clock type will use a bitfield mask instead of bitfield width, which is what the current basic divider implementation uses. This patch replaces the u8 width in struct clk_divider

Re: [GIT PULL 2/2] omap prcm clean-up for v3.19

2014-11-20 Thread Arnd Bergmann
On Tuesday 11 November 2014, Tony Lindgren wrote: > Clean-up series for omap PRCM (Power Reset Clock Module) from > Tero Kristo to move things a bit closer to becoming a proper > device driver. Pulled into next/soc, as some of the changes seem slightly more invasive than what I'd expect from a pur

Re: [GIT PULL 2/2] omap driver changes for v3.19

2014-11-20 Thread Arnd Bergmann
On Friday 14 November 2014, Tony Lindgren wrote: > Few omap driver changes to add minimal device tree support > for the omap 1w driver, and to fix resume and interrupt issues > on the l3-noc driver. Pulled into next/drivers, thanks! Arnd -- To unsubscribe from this list: send the line "un

Re: [GIT PULL 2/3] omap gpmc changes for v3.19

2014-11-20 Thread Arnd Bergmann
On Wednesday 12 November 2014, Tony Lindgren wrote: > GPMC (General Purpose Memory Controller) changes for omaps. These > changes allow us to drop dependencies to bootloader timings now > that the known device tree entries have been fixed. So we can now > require proper timings to be configured and

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-20 Thread Tomi Valkeinen
Hi Mark, On 13/11/14 10:05, Tomi Valkeinen wrote: > Hi Mark, > > On 13/11/14 00:23, Mark Brown wrote: >> On Wed, Nov 12, 2014 at 04:40:51PM +0200, Jyri Sarha wrote: >> >>> It would make the most sense to get these in trough fbdev tree. So it >>> would be nice to get acked-bys (if the patches are

Re: [GIT PULL 1/3] omap device tree changes for v3.19

2014-11-20 Thread Arnd Bergmann
On Wednesday 12 November 2014, Tony Lindgren wrote: > The following changes since commit cac7f2429872d3733dc3f9915857b1691da2eb2f: > > Linux 3.18-rc2 (2014-10-26 16:48:41 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap >

Re: [GIT PULL 1/2] omap soc changes for v3.19

2014-11-20 Thread Arnd Bergmann
On Friday 14 November 2014, Tony Lindgren wrote: > The following changes since commit cac7f2429872d3733dc3f9915857b1691da2eb2f: > > Linux 3.18-rc2 (2014-10-26 16:48:41 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap > ta

Re: voice calls on N900 working (off-line) was Re: N900 modem support in 3.18-rc1

2014-11-20 Thread Pavel Machek
Hi! > Ok, so realtime audio does not work due to some pulseaudio problems, > but I was able to record a (silent) call and then replay it with > > pacat --rate 4000 ../../../pulseaudio2.raw > > on my PC. I have yet to do some testing on the microphone side. Did someone get pulseaudio to work on

voice calls on N900 working (off-line) was Re: N900 modem support in 3.18-rc1

2014-11-20 Thread Pavel Machek
Hi! > > REed pulseaudio modules that use cmtspeech will be ready sooner than later > > (I believe in 2-3 monts from now), see on gitorious how fast we progressed > > with -record and -music modules. Sure, -voice module is way more > > complicated, but lots of it is already opensourced, we just nee

Re: [GIT PULL 1/2] omap non-urgent fixes for v3.19

2014-11-20 Thread Arnd Bergmann
On Tuesday 11 November 2014, Tony Lindgren wrote: > > Fixes for omap3 that are not urgent. Mostly to remove unnecessary > noise during the boot with pointless errors and warnings. > Pulled into next/fixes-non-critical. We didn't ha

Re: [RFC PATCH] ARM: DRA: hwmod: RTC: Add reset function for RTC

2014-11-20 Thread Lokesh Vutla
Hi Paul, On Monday 17 November 2014 10:13 AM, Lokesh Vutla wrote: > RTC IP have kicker feature which prevents spurious writes to its registers. > In order to write into any of the RTC registers, KICK values has te be > written to KICK registers. Currently hwmod is updating the IDLEMODE in rtc > sys

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
Hi Pavel, Sakari, On 11/19/2014 06:53 PM, Sakari Ailus wrote: Hi Jacek and Pavel, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same, but white

Re: [PATCH] ARM: DRA7: hwmod data: Add missing UART hwmod data

2014-11-20 Thread Paul Walmsley
On Tue, 21 Oct 2014, Nishanth Menon wrote: > From: Ambresh K > > We had constrainted hwmod entries to entries in dts which were present > only for default mapped interrupts, the ones such as UARTs > 6 which > needed IRQ crossbar configured were never added to hwmod database. > > Add them now th