Re: [PATCH 14/15] twl4030_charger: Increase current carefully while watching voltage.

2015-03-04 Thread NeilBrown
On Mon, 2 Mar 2015 22:29:45 +0100 Pavel Machek wrote: > On Tue 2015-02-24 15:33:53, NeilBrown wrote: > > The USB Battery Charging spec (BC1.2) suggests a dedicated > > charging port can deliver from 0.5 to 5.0A at between 4.75 and 5.25 > > volts. > > > > To choose the "correct" current voltage s

Re: [PATCH 15/15] twl4030_charger: assume a 'charger' can supply maximum current.

2015-03-04 Thread NeilBrown
On Mon, 2 Mar 2015 22:29:39 +0100 Pavel Machek wrote: > On Tue 2015-02-24 15:33:53, NeilBrown wrote: > > If it cannot, we will stop pulling more current when voltage drops. > > Can you justify it a bit more? > > I mean... maybe there's a fuse in the charger? Or maybe it will supply > the curren

Re: [PATCH 12/15] twl4030_charger: add software controlled linear charging mode.

2015-03-04 Thread NeilBrown
On Mon, 2 Mar 2015 22:09:26 +0100 Pavel Machek wrote: > On Tue 2015-02-24 15:33:52, NeilBrown wrote: > > Add a 'continuous' option for usb charging which enabled > > the "linear" charging mode of the twl4030. > > Documentation/ :-). ! > > > Linear charging does a good job with not so reliable

Re: [PATCH 09/15] twl4030_charger: allow max_current to be managed via sysfs.

2015-03-04 Thread NeilBrown
On Mon, 2 Mar 2015 22:05:26 +0100 Pavel Machek wrote: > On Tue 2015-02-24 15:33:52, NeilBrown wrote: > > 'max_current' sysfs attributes are created which allow the > > max to be set. > > Whenever a current source changes, the default is restored. > > This will be followed by a uevent, so user-spa

Re: [PATCH 04/15] twl4030_charger: use runtime_pm to keep usb phy active while charging.

2015-03-04 Thread NeilBrown
On Wed, 25 Feb 2015 07:24:43 + Lee Jones wrote: > On Tue, 24 Feb 2015, NeilBrown wrote: > > > The twl4030 usb phy needs to be active while we are using > > the USB VBUS as a current source for charging. > > In particular, the usb3v1 regulator must be enabled and the > > PHY_PWR_PHYPWD bit mu

[PATCH v2 1/2] ARM: OMAP2+: Use pdata-quirks for wkup_m3 deassert_hardreset

2015-03-04 Thread Dave Gerlach
Use pdata-quirks to provide platform data required for reset of the wkup_m3 during boot. Signed-off-by: Dave Gerlach --- This patch requires the pdata introduced in this patch: https://www.mail-archive.com/linux-omap@vger.kernel.org/msg114622.html arch/arm/mach-omap2/pdata-quirks.c | 13 +++

[PATCH v2 0/2] ARM: OMAP2+: wkup_m3_rproc support patches

2015-03-04 Thread Dave Gerlach
Hi, This series adds the mach-omap2 code for the wkup_m3_rproc driver submitted here [1]. pdata-quirks patch requires the pdata added with patch 3 of the aforementioned series. The dt patch was previously included as part of the rproc series here [2]. Changes are: v1->v2: -Because the firmware lo

[PATCH v2 2/2] ARM: dts: am33xx: Move wkup_m3 node to soc node and add ranges

2015-03-04 Thread Dave Gerlach
Signed-off-by: Suman Anna Signed-off-by: Dave Gerlach --- arch/arm/boot/dts/am33xx.dtsi | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index acd3705..086415c 100644 --- a/arch/arm/boot/dts/a

[PATCH v2 1/3] remoteproc: add a rproc ops for performing address translation

2015-03-04 Thread Dave Gerlach
From: Suman Anna The rproc_da_to_va API is currently used to perform any device to kernel address translations to meet the different needs of the remoteproc core/drivers (eg: loading). The functionality is achieved within the remoteproc core, and is limited only for carveouts allocated within the

[PATCH v2 2/3] Documentation: dt: add ti,am3353-wkup-m3 bindings

2015-03-04 Thread Dave Gerlach
Add the device tree bindings document for ti,am3353-wkup-m3 which is used by the wkup_m3_rproc driver. Signed-off-by: Dave Gerlach --- .../bindings/remoteproc/wkup_m3_rproc.txt | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bi

[PATCH v2 3/3] remoteproc: wkup_m3: Add wkup_m3 remoteproc driver

2015-03-04 Thread Dave Gerlach
Add a remoteproc driver to load the firmware for and boot the wkup_m3 present on am33xx and am43xx. The wkup_m3 is an integrated Cortex M3 that allows the SoC to enter the lowest possible power state by taking control from the MPU after it has gone into its own low power state and shutting off any

[PATCH v2 0/3] remoteproc: Introduce wkup_m3_rproc driver

2015-03-04 Thread Dave Gerlach
Hi, This patch series is version two of the series to add a wkup_m3_rproc driver for TI AM335x SoCs. This family of SoCs contains an ARM Cortex M3 coprocessor that is responsible for low-level power tasks that cannot be handled by the main ARM Cortex A8 so firmware running from the CM3 can be used

Re: [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver

2015-03-04 Thread Nishanth Menon
On 03/04/2015 04:58 PM, Tony Lindgren wrote: > * Paul Bolle [150304 14:58]: >> Nishanth Menon schreef op di 03-03-2015 om 18:00 [-0600]: >>> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig >>> index ee9f44ad7f02..8e463d75fbb2 100644 >>> --- a/drivers/pinctrl/Kconfig >>> +++ b/driver

[PATCH v8 0/4] hwspinlock core & omap dt support

2015-03-04 Thread Suman Anna
Hi Ohad, This is the latest version of the hwspinlock dt support series, rebased onto v4.0-rc1 and addressing the long discussion on the bindings in v7 [1]. I really hope that this series can make it into 4.1. Mark, Can you please provide your Acked-by for the binding documents so that Ohad can

[PATCH v8 3/4] Documentation: dt: add the omap hwspinlock bindings document

2015-03-04 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the DT bindings information for OMAP hwspinlock module. Cc: Rob Herring Cc: Mark Rutland Signed-off-by: Suman Anna --- v8: Removed the previous information about hwlock-base-id, and

[PATCH v8 2/4] hwspinlock/core: add device tree support

2015-03-04 Thread Suman Anna
This patch adds a new OF-friendly API of_hwspin_lock_get_id() for hwspinlock clients to use/request locks from a hwspinlock device instantiated through a device-tree blob. This new API can be used by hwspinlock clients to get the id for a specific lock using the phandle + args specifier, so that it

[PATCH v8 4/4] hwspinlock/omap: add support for dt nodes

2015-03-04 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing with the traditional platform device instantiation. Signed-off-by: Suman Anna [t...@atomide.com: ack for legacy

[PATCH v8 1/4] Documentation: dt: add common bindings for hwspinlock

2015-03-04 Thread Suman Anna
This patch adds the generic common bindings used to represent a hwlock device and use/request locks in a device-tree build. Each hwspinlock provider should have the '#hwlock-cells' property, which represents the number of cells to be used for representing a specific hwspinlock. Client users shall

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 11:14:32PM +0100, Marek Belisko wrote: > + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values > + for charging calibration (see example) > + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values > + for discharging calibrati

Re: [PATCH v3 4/6] ARM: dts: omap3-gta04: Add battery support

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 11:14:33PM +0100, Marek Belisko wrote: > Signed-off-by: Marek Belisko > --- > arch/arm/boot/dts/omap3-gta04.dtsi | 30 ++ > 1 file changed, 30 insertions(+) DTS changes must go via omap-dt tree once the driver changes have been merged. --

Re: [PATCH 06/21] drm/omap: check CRTC color format earlier

2015-03-04 Thread Laurent Pinchart
Hi Daniel, On Friday 27 February 2015 13:07:57 Daniel Vetter wrote: > On Thu, Feb 26, 2015 at 03:20:14PM +0200, Tomi Valkeinen wrote: > > When setting a color format to a DRM plane, the DRM core checks whether > > the format is supported by the HW. However, it seems that when setting > > the color

Re: [PATCH 06/21] drm/omap: check CRTC color format earlier

2015-03-04 Thread Laurent Pinchart
Hi Tomi, On Monday 02 March 2015 11:55:48 Tomi Valkeinen wrote: > On 27/02/15 14:07, Daniel Vetter wrote: > > On Thu, Feb 26, 2015 at 03:20:14PM +0200, Tomi Valkeinen wrote: > >> When setting a color format to a DRM plane, the DRM core checks whether > >> the format is supported by the HW. However

Re: [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver

2015-03-04 Thread Tony Lindgren
* Paul Bolle [150304 14:58]: > Nishanth Menon schreef op di 03-03-2015 om 18:00 [-0600]: > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > index ee9f44ad7f02..8e463d75fbb2 100644 > > --- a/drivers/pinctrl/Kconfig > > +++ b/drivers/pinctrl/Kconfig > > @@ -160,6 +160,17 @@ confi

Re: [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver

2015-03-04 Thread Paul Bolle
Nishanth Menon schreef op di 03-03-2015 om 18:00 [-0600]: > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index ee9f44ad7f02..8e463d75fbb2 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -160,6 +160,17 @@ config PINCTRL_TEGRA_XUSB > select PINCON

OMAP baseline test results for v4.0-rc2

2015-03-04 Thread Paul Walmsley
Here are some basic OMAP test results for Linux v4.0-rc2. Logs and other details at: http://www.pwsan.com/omap/testlogs/test_v4.0-rc2/20150303123351/ Test summary Build: uImage: Pass ( 3/ 3): omap1_defconfig, omap1_defconfig_1510innovator_only, omap1_defco

Re: [PATCHv2 0/2] N900 Modem Speech Support

2015-03-04 Thread Pavel Machek
On Wed 2015-03-04 21:36:50, Aaro Koskinen wrote: > On Wed, Mar 04, 2015 at 08:24:19PM +0100, Pavel Machek wrote: > > @@ -1239,8 +1234,8 @@ static long cs_char_ioctl(struct file *file, unsigned > > int cmd, > > > > if (copy_to_user((void __user *)arg, &ifver, sizeof(ifver))) > >

Re: [PATCHv2 0/2] N900 Modem Speech Support

2015-03-04 Thread Pavel Machek
Hi! CMT speech (CMT_SPEECH) [N/m/y/?] (NEW) ? CONFIG_CMT_SPEECH: If you say Y here, you will enable the CMT speech protocol used by Nokia modems. If unsure, say N. Normally, we also specify name of the module in config text. .. which is strange, because I selected "m" and can't find cmt_spee

Re: [PATCHv2 0/2] N900 Modem Speech Support

2015-03-04 Thread Aaro Koskinen
On Wed, Mar 04, 2015 at 08:24:19PM +0100, Pavel Machek wrote: > @@ -1239,8 +1234,8 @@ static long cs_char_ioctl(struct file *file, unsigned > int cmd, > > if (copy_to_user((void __user *)arg, &ifver, sizeof(ifver))) > r = -EFAULT; > - break; >

Re: [PATCHv2 0/2] N900 Modem Speech Support

2015-03-04 Thread Pavel Machek
Hi! > This patchset contains the missing speech data support for the > Nokia N900 modem. > > Userland access goes via /dev/cmt_speech. The API is implemented in > libcmtspeechdata, which is used by ofono and the freesmartphone.org project. > Apart from that the device is also used by the phone bi

reboot command - fail with power save support

2015-03-04 Thread Ran Shalit
Hello, I added power support to kernel menuconfig, such as cpuidle, and it seems to work fine. I also validated in counter that cpu gets into retention. The strange thing is that reboot now doesn't work and more: it starts printing garbage, but does not continue with reboot. Is there any idea ? T

Re: [PATCH] ASoC: omap-pcm: Allow only formats with 1, 2, and 4 byte physical size

2015-03-04 Thread Mark Brown
On Tue, Mar 03, 2015 at 01:28:53PM +0200, Jyri Sarha wrote: > sDMA support only transfer elements with 1, 2, and 4 byte physical > size. Initialize the pcm driver accordingly. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 3/4] mmc: sdio: support switching to 1-bit before turning off clocks

2015-03-04 Thread Tony Lindgren
* NeilBrown [150303 21:29]: > On Tue, 3 Mar 2015 14:53:55 -0800 Tony Lindgren wrote: > > > > --- a/arch/arm/boot/dts/omap3-gta04.dtsi > > +++ b/arch/arm/boot/dts/omap3-gta04.dtsi > > @@ -367,6 +367,7 @@ > > }; > > > > &mmc2 { > > + interrupts-extended = <&intc 86 &omap3_pmx_core 0x12e>; >

Re: [PATCH] dma: cppi41: add missing directions bitfield

2015-03-04 Thread Vinod Koul
On Wed, Feb 25, 2015 at 04:54:02PM -0600, Felipe Balbi wrote: > Without those we will see a kernel WARN() > when loading musb on am335x devices. > > Signed-off-by: Felipe Balbi > --- > drivers/dma/cppi41.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/cppi41.c b/drivers/d

Re: [PATCHv2 1/2] HSI: cmt_speech: Add cmt-speech driver

2015-03-04 Thread Paul Bolle
A license nit only. Sebastian Reichel schreef op di 03-03-2015 om 01:44 [+0100]: > --- /dev/null > +++ b/drivers/hsi/clients/cmt_speech.c > @@ -0,0 +1,1457 @@ > +/* > + * cmt_speech.c - HSI CMT speech driver > + * > + * Copyright (C) 2008,2009,2010 Nokia Corporation. All rights reserved. > + * > +

Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-04 Thread Pavel Machek
Hi! > does this help? > > /* >* For ichg_eoc, the hardware only supports reg values matching >* 100000, and requires the be stored in the high nibble >* of TWL4030_BCIMFTH8 >*/ A bit, yes. Add "." at the end of sentence ;-). (Now I'd need to study

Re: [PATCH 11/15] twl4030_charger: enable manual enable/disable of usb charging.

2015-03-04 Thread Pavel Machek
On Wed 2015-03-04 17:15:09, NeilBrown wrote: > On Mon, 2 Mar 2015 22:03:42 +0100 Pavel Machek wrote: > > > On Tue 2015-02-24 15:33:52, NeilBrown wrote: > > > 'off' or 'auto' to > > > > > > /sys/class/power/twl4030_usb/mode > > > > > > will now enable or disable charging from USB port. Normall

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-04 Thread Pavel Machek
Hi! > > New /sys files should be documented somewhere...? > > Preferably with the code... > > > Does it make sense to change "440k" -> "440KOhm"? > > Interesting question. I prefer to avoid including units in files - bare > numbers is better. But there is no number to match "floating" unless

Re: [PATCH 06/15] twl4030_charger: split uA calculation into a function.

2015-03-04 Thread NeilBrown
On Mon, 2 Mar 2015 22:05:18 +0100 Pavel Machek wrote: > On Tue 2015-02-24 15:33:51, NeilBrown wrote: > > We will need this calculation in other places, so > > create functions to map between register value and uA value. > > > > Signed-off-by: NeilBrown > > Acked-by: Pavel Machek Thanks. >

Re: [PATCH 0/6] mmc: omap_hsmmc: simplify cover/card detect logic

2015-03-04 Thread Andreas Fenkart
2015-03-04 6:31 GMT+01:00 NeilBrown : > On Tue, 3 Mar 2015 13:28:12 +0100 Andreas Fenkart wrote: >> While cover detect is only used by one platform (rx51), it >> complicates the card detect logic. By separating the code >> paths they both become easier to understand and maintain >> >> Patches hav