Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Geert Uytterhoeven
Hi Russell, On Wed, Apr 1, 2015 at 11:59 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Apr 01, 2015 at 02:54:59PM -0700, Kevin Hilman wrote: Your patch on top of Geert's still compiles fine for me with gcc-4.7.3. However, I'm not sure how specific we can be on the

Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653

2015-04-02 Thread Pavel Machek
Hi! Hi Pawel, My apologies for the very late reply. On Thu, Apr 02, 2015 at 04:38:46PM +0200, Pavel Machek wrote: We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation.

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Kevin Hilman
On Thu, Apr 2, 2015 at 12:12 PM, Lina Iyer lina.i...@linaro.org wrote: On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier marc.zyng...@arm.com wrote: -static int unmap_and_move(new_page_t

Re: [PATCHv4] media: i2c/adp1653: devicetree support for adp1653

2015-04-02 Thread Javier Martinez Canillas
Hello Pavel, I haven't reviewed the patch since I'm not familiar with the hardware but just wanted to point out a couple of things that I spot: On Thu, Apr 2, 2015 at 10:34 PM, Pavel Machek pa...@ucw.cz wrote: We are moving to device tree support on OMAP3, but that currently breaks ADP1653

[PATCHv4] media: i2c/adp1653: devicetree support for adp1653

2015-04-02 Thread Pavel Machek
We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation. Signed-off-by: Pavel Machek pa...@ucw.cz --- Fixed feedback by Sakari. Please apply,

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Lina Iyer
On Thu, Apr 02 2015 at 15:12 -0600, Kevin Hilman wrote: On Thu, Apr 2, 2015 at 12:12 PM, Lina Iyer lina.i...@linaro.org wrote: On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier

Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653

2015-04-02 Thread Sakari Ailus
Hi Pawel, On Thu, Apr 02, 2015 at 10:30:44PM +0200, Pavel Machek wrote: Hi! Hi Pawel, My apologies for the very late reply. On Thu, Apr 02, 2015 at 04:38:46PM +0200, Pavel Machek wrote: We are moving to device tree support on OMAP3, but that currently breaks ADP1653

[PATCH v2] crypto: omap-sham: Add the offset of sg page to vaddr

2015-04-02 Thread Lokesh Vutla
kmap_atomic() gives only the page address of the input page. Driver should take care of adding the offset of the scatterlist within the page to the returned page address. omap-sham driver is not adding the offset to page and directly operates on the return vale of kmap_atomic(), because of which

Re: [PATCH] crypto: omap-sham: Check for HIGHMEM before mapping SG pages

2015-04-02 Thread Lokesh Vutla
Hi Herbert, On Wednesday 01 April 2015 07:48 PM, Herbert Xu wrote: On Tue, Mar 31, 2015 at 09:52:23AM +0530, Lokesh Vutla wrote: Commit 26a05489ee0e (crypto: omap-sham - Map SG pages if they are HIGHMEM before accessing) says that HIGHMEM pages may not be mapped so we must kmap them before

Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Alexandre Belloni
Hi, On 02/04/2015 at 18:14:11 +0530, Lokesh Vutla wrote : Here is the updated patch. You should probably send it properly using git send-email, have a look at the --in-reply-to parameter, else, I'm not sure Andrew will be able to pick it up. Thanks! -- Alexandre Belloni, Free Electrons

Re: [rtc-linux] [PATCH 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
Hi, On Wednesday 01 April 2015 09:22 PM, Alexandre Belloni wrote: Hi, On 01/04/2015 at 11:24:56 +0530, Lokesh Vutla wrote : RTC module contains a kicker mechanism to prevent any spurious writes from changing the register values. This mechanism requires two MMR writes to the KICK0 and KICK1

[PATCH v2 0/3] rtc: omap: Fix misc bugs

2015-04-02 Thread Lokesh Vutla
This patch series fixes miscellaneous bugs in OMAP RTC driver. Tested on BeagleBone-Black. Logs: http://pastebin.ubuntu.com/10723287/ V1 patches can be seen here: http://www.mail-archive.com/linux-omap%40vger.kernel.org/msg115839.html Lokesh Vutla (3): rtc: omap: Unlock and Lock rtc

[PATCH v3 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
RTC module contains a kicker mechanism to prevent any spurious writes from changing the register values. This mechanism requires two MMR writes to the KICK0 and KICK1 registers with exact data values before the kicker lock mechanism is released. Currently the driver release the lock in the probe

[PATCH v2 2/3] rtc: omap: Update Kconfig for OMAP RTC

2015-04-02 Thread Lokesh Vutla
RTC is present in AM43xx and DRA7xx also. Updating the Kconfig to depend on ARCH_OMAP or ARCH_DAVINCI Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- drivers/rtc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v2 3/3] rtc: omap: use module_platform_driver

2015-04-02 Thread Lokesh Vutla
module_platform_driver_probe() prevents driver from requesting probe deferral. So using module_platform_drive() to support probe deferral. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- drivers/rtc/rtc-omap.c | 5 +++-- 1 file

[PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
RTC module contains a kicker mechanism to prevent any spurious writes from changing the register values. This mechanism requires two MMR writes to the KICK0 and KICK1 registers with exact data values before the kicker lock mechanism is released. Currently the driver release the lock in the probe

Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
On Thursday 02 April 2015 06:03 PM, Alexandre Belloni wrote: On 02/04/2015 at 16:39:09 +0530, Lokesh Vutla wrote : [..snip..] } +static inline void am3352_rtc_unlock(struct omap_rtc *rtc) +{ +rtc_writel(rtc, OMAP_RTC_KICK0_REG, KICK0_VALUE); +rtc_writel(rtc, OMAP_RTC_KICK1_REG,

Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Alexandre Belloni
On 02/04/2015 at 16:39:09 +0530, Lokesh Vutla wrote : RTC module contains a kicker mechanism to prevent any spurious writes from changing the register values. This mechanism requires two MMR writes to the KICK0 and KICK1 registers with exact data values before the kicker lock mechanism is

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Lina Iyer
On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier marc.zyng...@arm.com wrote: -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page, - unsigned long

[PATCHv3] media: i2c/adp1653: devicetree support for adp1653

2015-04-02 Thread Pavel Machek
We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation. Signed-off-by: Pavel Machek pa...@ucw.cz --- I'm not sure if it is device tree or media framework, either everyone waits for someone else, or

Re: [PATCH] ti-soc-thermal: implement omap3 support

2015-04-02 Thread Pavel Machek
+/* Thresholds and limits for OMAP34XX MPU temperature sensor */ +static struct temp_sensor_data omap34xx_mpu_temp_sensor_data = { + .min_freq = 32768, + .max_freq = 32768, + .max_temp = -99000, + .min_temp = 99000, This looks mixed up. Also, perhaps use

[PATCHv2] ti-soc-thermal: implement omap3 support

2015-04-02 Thread Pavel Machek
This adds support for OMAP3 chips to ti-soc-thermal. As requested by TI people, it is marked unreliable and warning is printed. Signed-off-by: Pavel Machek pa...@ucw.cz --- Patch is against thermal linus tree, please apply so that it has chance for 4.1. v2: fixed min/max temp diff --git

Re: [PATCH v8 0/4] hwspinlock core omap dt support

2015-04-02 Thread Suman Anna
Mark, On 03/18/2015 04:57 PM, Suman Anna wrote: Hi Mark, On 03/12/2015 04:24 AM, Ohad Ben-Cohen wrote: Hi Suman, On Thu, Mar 5, 2015 at 4:01 AM, Suman Anna s-a...@ti.com wrote: This is the latest version of the hwspinlock dt support series, rebased onto v4.0-rc1 and addressing the long

Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653

2015-04-02 Thread Sakari Ailus
Hi Pawel, My apologies for the very late reply. On Thu, Apr 02, 2015 at 04:38:46PM +0200, Pavel Machek wrote: We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation. Signed-off-by: Pavel Machek