Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-10 Thread Peter Chen
On Thu, Sep 10, 2015 at 05:17:36PM +0300, Roger Quadros wrote: > On 10/09/15 08:35, Peter Chen wrote: > > On Wed, Sep 09, 2015 at 01:21:50PM +0300, Roger Quadros wrote: > >> On 09/09/15 11:45, Peter Chen wrote: > >>> On Wed, Sep 09, 2015 at 12:33:20PM +0300, Roger Quadros wrote: > On 09/09/15

RE: mysterious crashes on OMAP5 uevm

2015-09-10 Thread Woodruff, Richard
> From: linux-arm-kernel [mailto:linux-arm-kernel- > boun...@lists.infradead.org] On Behalf Of Russell King - ARM Linux > > There are 2 workarounds that I know which make the problem go > > away (one is enough): > > - recompile Xorg with -marm (I'm using Debian armhf so it's > > >>

Re: [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get

2015-09-10 Thread Tony Lindgren
* Kevin Hilman [150910 10:03]: > On Tue, Sep 1, 2015 at 8:03 AM, Tony Lindgren wrote: > > * Grygorii Strashko [150901 07:57]: > >> On 09/01/2015 05:50 PM, Tony Lindgren wrote: > >> >> > >> >>On -next, Above crash signature could be related to race > >> >>"ARM: OMAP2+: omap-device: fix race defer

Re: [PATCH 03/13] twl4030_charger: correctly handle -EPROBE_DEFER from devm_usb_get_phy_by_node

2015-09-10 Thread Tony Lindgren
* Sebastian Reichel [150910 13:31]: > Hi, > > On Thu, Sep 10, 2015 at 10:08:50AM +0200, Sebastian Reichel wrote: > > > Probably best that Sebastian does it as there's another fix needed > > > too. It seems the following are needed: > > > > > > - Revert $subject patch 3fc3895e4fe1 ("twl4030_charg

Re: [PATCH 03/13] twl4030_charger: correctly handle -EPROBE_DEFER from devm_usb_get_phy_by_node

2015-09-10 Thread Sebastian Reichel
Hi, On Thu, Sep 10, 2015 at 10:08:50AM +0200, Sebastian Reichel wrote: > > Probably best that Sebastian does it as there's another fix needed > > too. It seems the following are needed: > > > > - Revert $subject patch 3fc3895e4fe1 ("twl4030_charger: correctly > > handle -EPROBE_DEFER from devm_

Re: [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get

2015-09-10 Thread Kevin Hilman
On Tue, Sep 1, 2015 at 8:03 AM, Tony Lindgren wrote: > * Grygorii Strashko [150901 07:57]: >> On 09/01/2015 05:50 PM, Tony Lindgren wrote: >> >> >> >>On -next, Above crash signature could be related to race >> >>"ARM: OMAP2+: omap-device: fix race deferred probe of omap_hsmmc vs >> >>omap_device

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-10 Thread Roger Quadros
On 10/09/15 08:35, Peter Chen wrote: > On Wed, Sep 09, 2015 at 01:21:50PM +0300, Roger Quadros wrote: >> On 09/09/15 11:45, Peter Chen wrote: >>> On Wed, Sep 09, 2015 at 12:33:20PM +0300, Roger Quadros wrote: On 09/09/15 11:13, Peter Chen wrote: > On Wed, Sep 09, 2015 at 12:08:10PM +0300,

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-10 Thread Roger Quadros
On 10/09/15 12:28, Li Jun wrote: > On Wed, Sep 09, 2015 at 01:01:14PM +0300, Roger Quadros wrote: > ... ... > >> +return -EINVAL; > > Return non-zero, then if err, do we need call usb_otg_add_hcd() after > usb_otg_register_hcd() fails? You should not call usb_otg_

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-10 Thread Li Jun
On Wed, Sep 09, 2015 at 01:01:14PM +0300, Roger Quadros wrote: ... ... > +return -EINVAL; > >>> > >>> Return non-zero, then if err, do we need call usb_otg_add_hcd() after > >>> usb_otg_register_hcd() fails? > >> > >> You should not call usb_otg_register_hcd() but usb_add_hcd(). > >>

Re: [PATCH 09/21] ARM: davinci: Add set dma_mask to eDMA devices

2015-09-10 Thread Peter Ujfalusi
On 09/10/2015 11:45 AM, Arnd Bergmann wrote: > On Thursday 10 September 2015 11:37:38 Peter Ujfalusi wrote: >> +static u64 da8xx_edma0_dmamask = DMA_BIT_MASK(32); >> + >> static struct platform_device da8xx_edma0_device = { >> .name = "edma", >> .id = 0, >>

Re: [PATCH 08/21] ARM/dmaengine: edma: Remove limitation on the number of eDMA controllers

2015-09-10 Thread Peter Ujfalusi
On 09/10/2015 11:40 AM, Arnd Bergmann wrote: > On Thursday 10 September 2015 11:37:37 Peter Ujfalusi wrote: >> bla-bla and bla >> >> Signed-off-by: Peter Ujfalusi > > You may want to expand on that a bit. I'm sorry about this.. I believed I did checked all the commit message. Will be updated in

Re: mysterious crashes on OMAP5 uevm

2015-09-10 Thread Dr. H. Nikolaus Schaller
Am 10.09.2015 um 10:30 schrieb Russell King - ARM Linux : > On Thu, Sep 10, 2015 at 08:42:57AM +0200, Dr. H. Nikolaus Schaller wrote: >> >> Am 08.09.2015 um 23:07 schrieb Tony Lindgren : >> >>> * Grazvydas Ignotas [150908 13:44]: On Tue, Sep 8, 2015 at 4:38 PM, Tony Lindgren wrote:

Re: [PATCH 00/21] dmaengine/ARM: Merge the edma drivers into one

2015-09-10 Thread Arnd Bergmann
On Thursday 10 September 2015 11:37:29 Peter Ujfalusi wrote: > > with this series the edma two driver setup will be changed to have only one > driver to support eDMA3. The legacy edma interface will be removed and eDMA > can > only be used via dmaengine API from this point on. > In order to do th

Re: [PATCH 09/21] ARM: davinci: Add set dma_mask to eDMA devices

2015-09-10 Thread Arnd Bergmann
On Thursday 10 September 2015 11:37:38 Peter Ujfalusi wrote: > +static u64 da8xx_edma0_dmamask = DMA_BIT_MASK(32); > + > static struct platform_device da8xx_edma0_device = { > .name = "edma", > .id = 0, > .dev = { > .platform_data = &da

[PATCH 02/21] ARM: common: edma: Remove unused functions

2015-09-10 Thread Peter Ujfalusi
We no longer have users for these functions so they can be removed. Remove also unused enums from the header file. Signed-off-by: Peter Ujfalusi --- arch/arm/common/edma.c | 376 - include/linux/platform_data/edma.h | 33 2 files changed, 409

[PATCH 00/21] dmaengine/ARM: Merge the edma drivers into one

2015-09-10 Thread Peter Ujfalusi
Hi, with this series the edma two driver setup will be changed to have only one driver to support eDMA3. The legacy edma interface will be removed and eDMA can only be used via dmaengine API from this point on. In order to do the merge the following improvements has been done: - One driver instanc

[PATCH 05/21] ARM/dmaengine: edma: Move of_dma_controller_register to the dmaengine driver

2015-09-10 Thread Peter Ujfalusi
If the of_dma_controller is registered in the non dmaengine driver we could have race condition: the of_dma_controller has been registered, but the dmaengine driver is not yet probed. Drivers requesting DMA channels during this window will fail since we do not yet have dmaengine drivers registered.

[PATCH 08/21] ARM/dmaengine: edma: Remove limitation on the number of eDMA controllers

2015-09-10 Thread Peter Ujfalusi
bla-bla and bla Signed-off-by: Peter Ujfalusi --- arch/arm/common/edma.c | 22 +- drivers/dma/edma.c | 17 - 2 files changed, 13 insertions(+), 26 deletions(-) diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 15b68ce98ec7..0f29997c62df 1

[PATCH 07/21] ARM/dmaengine: edma: Public API to use private struct pointer

2015-09-10 Thread Peter Ujfalusi
Instead of relying on indexes pointing to edma private date in the global pointer array, pass the private data pointer via the public API. Signed-off-by: Peter Ujfalusi --- arch/arm/common/edma.c | 305 ++--- drivers/dma/edma.c | 79 ++

[PATCH 03/21] dmaengine: edma: Simplify and optimize the edma_execute path

2015-09-10 Thread Peter Ujfalusi
The code path in edma_execute() and edma_callback() can be simplified and make it more optimal. There is not need to call in to edma_execute() when the transfer has been finished for example. Also the handling of missed/first or next batch of paRAMs can be done in a more optimal way. Signed-off-by

[PATCH 04/21] ARM: davinci/common: Convert edma driver to handle one eDMA instance per driver

2015-09-10 Thread Peter Ujfalusi
Currently we have one device created to handle all (maximum 2) eDMAs in the system. With this change all eDMA instance will have it's own device/driver. This change is needed for further cleanups in the eDMA driver stack since the one device/driver to handle all eDMAs in the system was not flexible

[PATCH 14/21] dmaengine: edma: Cleanup regarding the use of dev around the code

2015-09-10 Thread Peter Ujfalusi
Be consistent and do not mix the use of dev, &pdev->dev, etc in the functions. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 0b46d4263ec6..71de1c843bb4

[PATCH 06/21] ARM: common: edma: Internal API to use pointer to 'struct edma'

2015-09-10 Thread Peter Ujfalusi
Merge the iomem into the 'struct edma' and change the internal (static) functions to use pointer to the edma_cc instead of the ctlr number. Signed-off-by: Peter Ujfalusi --- arch/arm/common/edma.c | 400 - 1 file changed, 197 insertions(+), 203 del

[PATCH 12/21] dmaengine: edma: Parameter alignment and long line fixes

2015-09-10 Thread Peter Ujfalusi
Makes the code a bit more readable. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 84 -- 1 file changed, 44 insertions(+), 40 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 153869c9e13c..bed09ce22ff2 100644 --

[PATCH 09/21] ARM: davinci: Add set dma_mask to eDMA devices

2015-09-10 Thread Peter Ujfalusi
The upcoming change to merge the arch/arm/common/edma.c into drivers/dma/edma.c will need this change when booting daVinci devices in no DT mode. Signed-off-by: Peter Ujfalusi --- arch/arm/mach-davinci/devices-da8xx.c | 8 arch/arm/mach-davinci/dm355.c | 8 +++- arch/arm/mac

[PATCH 13/21] dmaengine: edma: Use devm_kcalloc when possible

2015-09-10 Thread Peter Ujfalusi
When allocating a memory for number of items it is better (looks better) to use devm_kcalloc. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index bed09ce22ff2..0b46d4263ec6 1006

[PATCH 11/21] dmaengine: edma: Allocate memory dynamically for bitmaps and structures

2015-09-10 Thread Peter Ujfalusi
Instead of using defines to specify the size of different arrays and bitmaps, allocate the memory for them based on the information we get from the HW itself. Since these defines are set based on the worst case, there are devices where they are not valid. Signed-off-by: Peter Ujfalusi --- driver

[PATCH 16/21] dmaengine: edma: Use the edma_write_slot instead open coded memcpy_toio

2015-09-10 Thread Peter Ujfalusi
edma_write_slot() is for writing an entire paRAM slot. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 5b97c11a33af..e735147ccece 100644 --- a/drivers/dma/edma.c +++ b/drivers

[PATCH 10/21] ARM/dmaengine: edma: Merge the two drivers under drivers/dmaengine

2015-09-10 Thread Peter Ujfalusi
Move the code out from arch/arm/common and merge it inside of the dmaengine driver. This change is done with as minimal change to the code as possible to avoid any possibilities to introducing regression. Signed-off-by: Peter Ujfalusi --- arch/arm/Kconfig |1 - arch/arm/com

[PATCH 15/21] dmaengine: edma: Use dev_dbg instead pr_debug

2015-09-10 Thread Peter Ujfalusi
We have access to dev, so it is better to use the dev_dbg for debug prints. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 71de1c843bb4..5b97c11a33af 1

[PATCH 18/21] dmaengine: edma: Consolidate the comments for functions

2015-09-10 Thread Peter Ujfalusi
Remove or rewrite the comments for the internal functions. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 86 +++--- 1 file changed, 11 insertions(+), 75 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 2c6be4c62a73.

[PATCH 19/21] dmaengine: edma: Simplify the interrupt handling

2015-09-10 Thread Peter Ujfalusi
With the merger of the arch/arm/common/edma.c code into the dmaengine driver, there is no longer need to have per channel callback/data storage for interrupt events. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 444 - 1 file changed,

Re: [PATCH 08/21] ARM/dmaengine: edma: Remove limitation on the number of eDMA controllers

2015-09-10 Thread Arnd Bergmann
On Thursday 10 September 2015 11:37:37 Peter Ujfalusi wrote: > bla-bla and bla > > Signed-off-by: Peter Ujfalusi You may want to expand on that a bit. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More

[PATCH 20/21] dmaengine: edma: Move the pending error check into helper function

2015-09-10 Thread Peter Ujfalusi
In the ccerr interrupt handler the code checks for pending errors in the error status registers in two different places. Move the check out to a helper function. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff

[PATCH 21/21] dmaengine: edma: Simplify and optimize ccerr interrupt handler

2015-09-10 Thread Peter Ujfalusi
No need to run through the bits in QEMR and CCERR events since they will not trigger any action, so just clearing the errors there is fine. In case of the missed event the loop can be optimized so we spend less time to handle the event. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 64 +

[PATCH 17/21] dmaengine: edma: Print warning when linking slots from different eDMA

2015-09-10 Thread Peter Ujfalusi
Warning message in case of linking between paRAM slots in different eDMA controllers. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index e735147ccece..2c6be4c62a73 100644 --- a/drivers/dma/edma

[PATCH 01/21] ARM: common: edma: Fix channel parameter for irq callbacks

2015-09-10 Thread Peter Ujfalusi
In case when the interrupt happened for the second eDMA the channel number was incorrectly passed to the client driver. Signed-off-by: Peter Ujfalusi CC: --- arch/arm/common/edma.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/edma.c b/arch/arm/common

Re: mysterious crashes on OMAP5 uevm

2015-09-10 Thread Russell King - ARM Linux
On Thu, Sep 10, 2015 at 08:42:57AM +0200, Dr. H. Nikolaus Schaller wrote: > > Am 08.09.2015 um 23:07 schrieb Tony Lindgren : > > > * Grazvydas Ignotas [150908 13:44]: > >> On Tue, Sep 8, 2015 at 4:38 PM, Tony Lindgren wrote: > >>> * Grazvydas Ignotas [150908 05:50]: > Hi, > > t

Re: [PATCH 03/13] twl4030_charger: correctly handle -EPROBE_DEFER from devm_usb_get_phy_by_node

2015-09-10 Thread Sebastian Reichel
Hi, On Tue, Sep 08, 2015 at 01:14:17PM -0700, Tony Lindgren wrote: > * Kevin Hilman [150908 11:36]: > > On Wed, Sep 2, 2015 at 6:07 AM, Tony Lindgren wrote: > > > * Neil Brown [150901 23:23]: > > >> Kevin Hilman writes: > > >> > > >> > ping... this boot failure has now landed in mainline > > >

Re: [PATCH RFC 4/5] ASoC: davinci-mcasp: Get rid of bclk_lrclk_ratio in private data

2015-09-10 Thread Jyri Sarha
On 09/09/15 21:27, Jyri Sarha wrote: The slot_width is for essentially same thing. Instead of storing bclk_lrclk_ratio, just store the slot_width. Comments has been updated accordingly and some variable names changed to more descriptive. Signed-off-by: Jyri Sarha --- sound/soc/davinci/davinci