RE: [PATCH v5 2/5] OMAP4: Adding voltage driver support

2010-12-28 Thread Anand Sawant
Thara, > -Original Message- > From: Thara Gopinath [mailto:th...@ti.com] > Sent: Monday, December 20, 2010 10:31 PM > To: linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Cc: khil...@deeprootsystems.com; p...@pwsan.com; b- > cous...@ti.com; vishwanath...@ti.com; saw...

RE: [PATCH v6 09/10] OMAP3: PM: Adding debug support to Voltage and Smartreflex drivers

2010-12-28 Thread Anand Sawant
eate_x8("vp_stepmin", S_IRUGO, vdd- > >debug_dir, > + &(vdd->vp_reg.vstepmin_stepmin)); > + (void) debugfs_create_x16("vp_smpswaittimemax", > S_IRUGO, > + vdd->debug_dir, > +

RE: [PATCH v6 01/10] OMAP3: PM: Adding voltage driver support.

2010-12-28 Thread Anand Sawant
Thara, Here are some comments on the voltage layer; many of them are cosmetic in nature. > -Original Message- > From: Thara Gopinath [mailto:th...@ti.com] > Sent: Monday, December 20, 2010 10:29 PM > To: linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Cc: khil...@dee