+/* Dummy regulator for pwm-backlight driver */ static struct
+regulator_consumer_supply backlight_supply =
+ REGULATOR_SUPPLY(enable, NULL);
'enable' is just too generic, the device name should be also provided:
REGULATOR_SUPPLY(enable, pwm-backlight);
You're right. I don't
+static void pwm_backlight_enable(struct backlight_device *bl) {
+ struct pwm_bl_data *pb = dev_get_drvdata(bl-dev);
+
+ /* Bail if we are already enabled. */
+ if (pb-enabled)
+ return;
+
+ pwm_enable(pb-pwm);
+
+ if (regulator_enable(pb-enable_supply) !=
From: Thierry Reding [mailto:thierry.red...@avionic-design.de]
Sent: Wednesday, March 13, 2013 1:59 PM
To: Andrew Chew
Cc: Peter Ujfalusi; Alex Courbot; linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator
to pwm-backlight
* PGP Signed
On Wed, Mar 13, 2013 at 02:10:16PM -0700, Andrew Chew wrote:
+static void pwm_backlight_enable(struct backlight_device *bl) {
+ struct pwm_bl_data *pb = dev_get_drvdata(bl-dev);
+
+ /* Bail if we are already enabled. */
+ if (pb-enabled
The pwm-backlight driver now takes a mandatory regulator that is gotten
during driver probe. Initialize a dummy regulator to satisfy this
requirement.
Signed-off-by: Andrew Chew ac...@nvidia.com
---
Changed the device name of the backlight regulator supply to pwm-backlight,
per Peter's comment
,
then a fixed regulator can be instantiated to control the GPIO.
The backlight enable regulator can be specified in the device tree node
for the backlight, or can be done with legacy board setup code in the
usual way.
Signed-off-by: Andrew Chew ac...@nvidia.com
Reviewed-by: Alexandre Courbot acour
From: Thierry Reding [mailto:thierry.red...@avionic-design.de]
Sent: Tuesday, March 12, 2013 12:01 AM
To: Andrew Chew
Cc: peter.ujfal...@ti.com; Alex Courbot; linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: OMAP: board-4430sdp: Provide regulator to
pwm-backlight
* PGP Signed
On 03/12/2013 02:54 AM, Andrew Chew wrote:
The pwm-backlight driver now takes a mandatory regulator that is
gotten during driver probe. Initialize a dummy regulator to satisfy
this requirement.
Can you point me to the commit which makes a regulator mandatory for
pwm-backlight?
Why
been patched, this series can be applied in order to
maintain bisectability.
Andrew Chew (2):
ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight
pwm_bl: Add mandatory backlight enable regulator
.../bindings/video/backlight/pwm-backlight.txt | 14 +
arch/arm/mach-omap2
The pwm-backlight driver now takes a mandatory regulator that is gotten
during driver probe. Initialize a dummy regulator to satisfy this
requirement.
Signed-off-by: Andrew Chew ac...@nvidia.com
---
arch/arm/mach-omap2/board-4430sdp.c |5 +
1 file changed, 5 insertions(+)
diff --git
,
then a fixed regulator can be instantiated to control the GPIO.
The backlight enable regulator can be specified in the device tree node
for the backlight, or can be done with legacy board setup code in the
usual way.
Signed-off-by: Andrew Chew ac...@nvidia.com
Reviewed-by: Alexandre Courbot acour
The pwm-backlight driver now takes a mandatory regulator that is gotten
during driver probe. Initialize a dummy regulator to satisfy this
requirement.
Signed-off-by: Andrew Chew ac...@nvidia.com
---
This patch, along with many more soon to follow, attempts to satisfy the new
mandatory regulator
12 matches
Mail list logo
