Re: [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-01-15 Thread Anna, Suman
Felipe, On 01/14/2014 08:04 AM, Felipe Balbi wrote: Hi again, On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote: diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c index 9f56fb2..194886e 100644 --- a/drivers/hwspinlock/omap_hwspinlock.c +++

Re: [PATCHv4 7/7] hwspinlock/omap: enable build for AM33xx, AM43xx DRA7xx

2014-01-14 Thread Anna, Suman
Felipe, On 01/14/2014 07:12 AM, Felipe Balbi wrote: On Mon, Jan 13, 2014 at 06:19:24PM -0600, Suman Anna wrote: HwSpinlocks are supported on AM33xx, AM43xx and DRA7xx SoC device families as well. The IPs are identical to that of OMAP4/OMAP5, except for the number of locks. Add a depends on to

Re: [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-01-14 Thread Anna, Suman
Felipe, On 01/14/2014 08:04 AM, Felipe Balbi wrote: Hi again, On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote: diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c index 9f56fb2..194886e 100644 --- a/drivers/hwspinlock/omap_hwspinlock.c +++

Re: [PATCHv4 7/7] hwspinlock/omap: enable build for AM33xx, AM43xx DRA7xx

2014-01-14 Thread Anna, Suman
On 01/14/2014 11:29 AM, Felipe Balbi wrote: On Tue, Jan 14, 2014 at 10:51:31AM -0600, Anna, Suman wrote: Felipe, On 01/14/2014 07:12 AM, Felipe Balbi wrote: On Mon, Jan 13, 2014 at 06:19:24PM -0600, Suman Anna wrote: HwSpinlocks are supported on AM33xx, AM43xx and DRA7xx SoC device families

Re: [PATCH] ARM: dts: OMAP2: fix interrupt number for rng

2014-01-08 Thread Anna, Suman
Tony, On 01/07/2014 06:28 PM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [131223 15:01]: The irq data for rng module defined in hwmod data previously missed the OMAP_INTC_START relative offset, so the interrupt number is probably misconfigured during the DT node addition adjusting for

Re: [PATCH 2/7] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2013-12-23 Thread Anna, Suman
On 12/17/2013 06:53 AM, Florian Vaussard wrote: omap_iommu_attach() returns NULL or ERR_PTR in case of error, but omap_iommu_attach_dev() only checks for IS_ERR. Thus a NULL return value (in case driver_find_device fails) will cause the kernel to panic when omap_iommu_attach_dev() dereferences

Re: [PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: OMAP2+ is heading towards a full device tree boot for 3.14. Currently, the iommu used by the OMAP3 camera subsystem is not yet converted. It cannot be probed as necessary data are only passed through device tree. Patches 1 and 2 are

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non-initialized iommu. Perform bus_set_iommu() only if

Re: [PATCH 6/7] ARM: OMAP2+: Remove legacy data from hwmod for omap3 isp iommu

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: The data are now passed using the devicetree. Patch is good by itself. A similar change is needed for the IVA MMU as well. regards Suman Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch ---

Re: [PATCH 4/7] iommu/omap: Allow enable/disable even without pdata

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: When booting with a devietree, no platform data is provided. Do not prematurely exit iommu_enable() and iommu_disable() in such a case. Platform data may still be needed if we were to go with the pdata quirks approach for handling

Re: [PATCH 5/7] ARM: dts: Complete data for isp iommu

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Add missing information required to probe the iommu for the camera subsystem. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3 ARM: OMAP2+: Fix more missing data for omap3.dtsi file adds basic DT bits. But the driver is not yet converted, so this will not work and driver will not be probed. Convert

Re: [PATCH 6/7] ARM: OMAP2+: Remove legacy data from hwmod for omap3 isp iommu

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: The data are now passed using the devicetree. Patch is good by itself. A similar change is needed for the IVA MMU as well. As I understood, the IVA MMU is still not integrated into the iommu core, as its implementation lives

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non-initialized iommu. Perform bus_set_iommu() only if

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3 ARM: OMAP2+: Fix more missing data for omap3.dtsi file adds basic DT bits. But the driver is not yet converted, so this will not work and driver will not be probed.

Re: [PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: OMAP2+ is heading towards a full device tree boot for 3.14. Currently, the iommu used by the OMAP3 camera subsystem is not yet converted. It cannot be probed as necessary data are only passed through device tree. Patches 1 and 2 are

Re: [PATCH 5/7] ARM: dts: Complete data for isp iommu

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/23/2013 03:34 PM, Florian Vaussard wrote: Hi Suman, On 12/23/2013 08:12 PM, Anna, Suman wrote: Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Add missing information required to probe the iommu for the camera subsystem. Signed-off-by: Florian Vaussard

Re: [PATCHv3 0/8] omap hwspinlock dt support

2013-11-12 Thread Anna, Suman
Hi, This is an updated series addressing the review comments from the v2 series. The hwmod patches have been dropped from the repost as per Paul's request, they have already been queued. Mark, Any comments on this series? Tony has picked up the OMAP DTS patches for 3.13, and so the

RE: find real users and drivers of rpmsg

2013-07-10 Thread Anna, Suman
Barry, On Mon, Jul 8, 2013 at 10:31 AM, Barry Song 21cn...@gmail.com wrote: hi Ohad/all, i am trying to find some real users of rpmsg, here i only get samples/rpmsg/rpmsg_client_sample.c, does it mean other real drivers are out of mainline? Yes where could i get them? TI

RE: [GIT PULL 7/7] omap mailbox move to drivers for v3.11 merge window

2013-06-20 Thread Anna, Suman
Arnd, On Tuesday 18 June 2013, Tony Lindgren wrote: The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap

RE: [PATCH 1/2] ARM: dts: OMAP5: add PWM capability to timer nodes missing it

2013-05-31 Thread Anna, Suman
Benoit, Tony, On 04/17/2013 06:23 PM, Suman Anna wrote: OMAP5 has 6 timers (GPTimers 5, 6, 8 to 11) that are capable of PWM. The PWM capability property is missing from the node definitions of couple of timers, and this has been fixed. Signed-off-by: Suman Anna s-a...@ti.com ---

RE: [PATCH 2/2] ARM: OMAP4+: Add a timer attribute for timers that can interrupt IPU

2013-04-18 Thread Anna, Suman
Jon, On 04/17/2013 07:04 PM, Jon Hunter wrote: On 04/17/2013 06:23 PM, Suman Anna wrote: Some instances of the DMTIMER peripheral on OMAP4+ devices have the ability to interrupt the on-chip image processor unit (IPU) subsystem (a common name for the dual Cortex-M3 subsystem on OMAP4

RE: [GIT PULL] mailbox driver framework for v3.10 merge window

2013-04-09 Thread Anna, Suman
On Thursday 04 April 2013, Anna, Suman wrote: OMAP and ST-Ericsson platforms are both using mailbox to communicate with some coprocessors. This series creates a consolidated framework, living under drivers/mailbox. The changes mainly contain: - create a mailbox framework independent from

[GIT PULL] mailbox driver framework for v3.10 merge window

2013-04-04 Thread Anna, Suman
The following changes since commit f6161aa153581da4a3867a2d1a7caf4be19b6ec9: Linux 3.9-rc2 (2013-03-10 16:54:19 -0700) are available in the git repository at: git://github.com/sumananna/mailbox.git dbx500-prcmu-mailbox for you to fetch changes up to

RE: [PATCHv3 02/14] ARM: OMAP2+: mbox: remove dependencies with soc.h

2013-03-26 Thread Anna, Suman
Paul, The OMAP mailbox platform driver code has been cleaned up to remove the dependencies with soc.h in preparation for moving the mailbox code to drivers folder. The code relied on cpu_is_xxx/soc_is_xxx macros previously to pick the the right set of mailbox devices and register with

RE: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-03-21 Thread Anna, Suman
Stephen, I have hosted the series at [3]. Can you pull this into linux-next sometime next week? [3] https://github.com/sumananna/mailbox/commits/dbx500-prcmu-mailbox Please quote git URLs ... I guessed you meant git://github.com/sumananna/mailbox.git, branch dbx500-prcmu-mailbox ?

RE: [PATCHv3 03/14] mailbox: OMAP: introduce mailbox framework

2013-03-13 Thread Anna, Suman
On Wed, Mar 13, 2013 at 4:24 AM, Suman Anna s-a...@ti.com wrote: From: Omar Ramirez Luna omar.l...@linaro.org (...) Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org [s-a...@ti.com: Kconfig fixes for build errors] Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Tony Lindgren

RE: [PATCHv3 01/14] mailbox: rename pl320-ipc specific mailbox.h

2013-03-12 Thread Anna, Suman
On Tue, Mar 12, 2013 at 10:23:50PM -0500, Suman Anna wrote: The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework.

RE: [PATCH v2 00/13] drivers: mailbox: framework creation

2013-02-13 Thread Anna, Suman
On Wed, Feb 13, 2013 at 02:36:32PM +0100, Linus Walleij wrote: On Tue, Feb 12, 2013 at 5:56 AM, Suman Anna s-a...@ti.com wrote: I have hosted the series at [3]. [3] https://github.com/sumananna/mailbox/commits/dbx500-prcmu-mailbox Suman, I suggest you ask Stepgen Rothwell to

Re: [PATCH] omap: iommu: fix pte attributes for super section

2011-06-28 Thread Anna, Suman
On Mon, May 16, 2011 at 2:11 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Anna, Suman s-a...@ti.com Subject: [PATCH] omap: iommu: fix pte attributes for super section Date: Tue, 10 May 2011 10:25:17 -0700 From 5796d8d8a0ea5aee342b78ca6ead229971cff6c5 Mon Sep 17 00:00:00 2001 From

[PATCH] omap: iommu: fix pte attributes for super section

2011-05-10 Thread Anna, Suman
From 5796d8d8a0ea5aee342b78ca6ead229971cff6c5 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Wed, 4 May 2011 17:45:37 -0500 Subject: [PATCH] omap: iommu: fix pte attributes for super section The PTE programming causes a 16MB entry to be interpreted as a 4K entry because of the

[PATCH 1/5 v2] omap2/3/4: mailbox: remove compiler warning

2010-02-23 Thread Anna, Suman
From 02c45559105c62343e31226fe67117231ea10c35 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Mon, 25 Jan 2010 18:27:21 -0600 Subject: [PATCH] omap2/3/4: mailbox: remove compiler warning Remove a compiler warning in device-specific mailbox module. Signed-off-by: Suman Anna

RE: [RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-23 Thread Anna, Suman
Omar, +#if defined(CONFIG_ARCH_OMAP2420) /* IVA */ err_iva1: - omap_mbox_unregister(mbox_dsp_info); + if (cpu_is_omap2420()) + omap_mbox_unregister(mbox_dsp_info); +#endif why not moving omap_mbox_unregister to the block containing the ifdefs? at least you won't

RE: [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-22 Thread Anna, Suman
Hi Santosh, -Original Message- From: Shilimkar, Santosh Sent: Saturday, February 20, 2010 12:47 PM To: Anna, Suman; linux-omap@vger.kernel.org Cc: hiroshi.d...@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam Subject: RE: [PATCH 1/5] omap2/3/4: mailbox: remove compiler

RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic

2010-02-22 Thread Anna, Suman
Hi Santosh, -Original Message- From: Shilimkar, Santosh Sent: Saturday, February 20, 2010 12:53 PM To: Anna, Suman; linux-omap@vger.kernel.org Cc: hiroshi.d...@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam Subject: RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic

RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic

2010-02-22 Thread Anna, Suman
Hi Benoit, -Original Message- From: Cousson, Benoit Sent: Sunday, February 21, 2010 7:36 AM To: Shilimkar, Santosh; Anna, Suman; linux-omap@vger.kernel.org Cc: hiroshi.d...@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam Subject: RE: [PATCH 2/5] omap: mailbox: correct OMAP4

RE: [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-22 Thread Anna, Suman
Tony, -Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Monday, February 22, 2010 3:37 PM To: Anna, Suman Cc: Shilimkar, Santosh; linux-omap@vger.kernel.org; hiroshi.d...@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam Subject: Re: [PATCH 1/5] omap2/3

[RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-22 Thread Anna, Suman
From 657358cd06a3f20bef2472945991749bacef12e6 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Mon, 25 Jan 2010 18:27:21 -0600 Subject: [PATCH] omap2/3/4: mailbox: remove compiler warning Remove a compiler warning in device-specific mailbox module. Signed-off-by: Suman Anna

RE: [PATCH] omap: mailbox: unregister correct mbox device for omap2420

2010-02-22 Thread Anna, Suman
Hi Aguilar, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Aguilar Pena, Leed Sent: Monday, February 22, 2010 5:55 PM To: linux-omap@vger.kernel.org Cc: t...@atomide.com; Hiroshi DOYU Subject: [PATCH] omap: mailbox:

[PATCH 0/5] Mailbox: Fix issues for OMAP4

2010-02-18 Thread Anna, Suman
From f2e895f74544876572adbe3328aa27d20aa1aec4 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Thu, 18 Feb 2010 14:34:39 -0600 Subject: [PATCH 0/5] Mailbox: Fix issues for OMAP4 This patchset has fixes for OMAP4 mailbox SYSCONFIG register. Also included are patches for improving

[PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-18 Thread Anna, Suman
From 78d00b562548e1d95ad12a4d8121be67950daf68 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Mon, 25 Jan 2010 18:27:21 -0600 Subject: [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning Remove a compiler warning in device-specific mailbox module. Signed-off-by: Suman Anna

[PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic

2010-02-18 Thread Anna, Suman
From 18beb1784db07e4eb2b9d10783a309b5caccb979 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Fri, 5 Feb 2010 17:20:26 -0600 Subject: [PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic OMAP4 mailbox has a different MAILBOX_SYSCONFIG register. There is now no AutoIdle. The

[PATCH 2/5] omap: mailbox: correct OMAP4 reset logic

2010-02-18 Thread Anna, Suman
From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Tue, 26 Jan 2010 16:55:29 -0600 Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic OMAP4 mailbox has a different register set. There is no MAILBOX_SYSSTATUS register. The reset

[PATCH 4/5] omap2/3/4: mailbox: use dedicated work queue for handling mailbox rx interrupt

2010-02-18 Thread Anna, Suman
From 7410bf2d5c569c83a594b99a62d03b939e4f10b8 Mon Sep 17 00:00:00 2001 From: Rob Clark r...@ti.com Date: Mon, 4 Jan 2010 19:22:03 +0530 Subject: [PATCH 4/5] omap2/3/4: mailbox: use dedicated work queue for handling mailbox rx interrupt keventd_wq is a shared work-queue, and should not be used

[PATCH 5/5] omap2/3/4: mailbox: retries in case of FIFO full

2010-02-18 Thread Anna, Suman
From f2e895f74544876572adbe3328aa27d20aa1aec4 Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Fri, 4 Dec 2009 15:52:42 -0600 Subject: [PATCH 5/5] omap2/3/4: mailbox: retries in case of FIFO full This patch enables check for the mailbox fifo full Without this check in some