Thanks Thomas,
> > + unsigned int length = 0, id = 0;
> > + int hw_mod_name_len = 16;
> > + char oh_name[hw_mod_name_len];
> > + char *name = "omap4-keypad";
> > +
> > + length = snprintf(oh_name, hw_mod_name_len, "kbd");
> > +
> > + oh = omap_hwmod_lookup(oh_name);
> > + if (!oh) {
Felipe,
> >+static struct omap4_keypad_platform_data sdp4430_keypad_data = {
> >+.keymap_data= &sdp4430_keymap_data,
> >+.rows = 8,
> >+.cols = 8,
> >+.device_enable = omap_device_enable,
> >+.device_shutdown= oma
From: Eric Dumazet
Fix the allocation length of rx skbuff.
Based on discussion http://lkml.org/lkml/2010/5/26/501
Signed-off-by: Abraham Arce
---
drivers/net/ks8851.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ks8851.c b/drivers/net/ks8851.c
i
Hi Tony,
> Please test this with omap3_defconfig too, and make sure it does not break
> things for omap2 and omap3.
Tested, no problems...
> > +int omap4_init_kp(struct omap4_keypad_platform_data *kp)
> > +{
> > + struct omap_hwmod *oh;
> > + struct omap_device *od;
> > + struct omap4_keyp
From: Syed Rafiuddin
Update OMAP4430 configuration to enable OMAP4 keyboard driver
Signed-off-by: Syed Rafiuddin
Signed-off-by: Abraham Arce
---
arch/arm/configs/omap_4430sdp_defconfig |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/configs/omap_4430sdp_def
Keyboard support for SDP OMAP4430
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/board-4430sdp.c | 104 +++
1 files changed, 104 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.c
index be7a
Register keyboard device with hwmod framework
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/devices.c | 59 +
1 files changed, 59 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 2271b9
OMAP4 keyboard controller includes:
- built-in scanning algorithm
- debouncing feature
Driver implementation is based on matrix_keypac.c
Signed-off-by: Syed Rafiuddin
Signed-off-by: Abraham Arce
Signed-off-by: Dmitry Torokhov
---
arch/arm/plat-omap/include/plat/omap4-keypad.h | 23 ++
d
Keyboard controller for OMAP4 includes
- built-in scanning algorithm
- debouncing feature
- handling mechanism up to 9 x 9 keys
- wake-up event generation
Dependency on hwmod changes for OMAP4
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28188.html
Tested using SDP4430 board in
Hi Dmitry,
> On Tue, May 18, 2010 at 06:13:48PM -0500, Arce, Abraham wrote:
> > Hi,
> >
> > Here you have the list of changes done so far for OMAP4 Keyboard
> > Controller Support v2. I'll appreciate if someone else has more comments
> > to share.
> &g
Thanks Eric, David,
[..]
> > > > - if (skb_shinfo(skb)->nr_frags) {
> > > > + if (skb_shinfo(skb)->nr_frags && skb_has_frags(skb)) {
> > > > int i;
> > > > for (i = 0; i < skb_shinfo(skb)->nr_frags; i++)
> > > >
Thanks David,
> > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > index f8abf68..eb81f76 100644
> > --- a/net/core/skbuff.c
> > +++ b/net/core/skbuff.c
> > @@ -334,7 +334,7 @@ static void skb_release_data(struct sk_buff *skb)
> > if (!skb->cloned ||
> > !atomic_sub_return(skb->n
Hi,
I am able to avoid the NULL pointer dereference but not sure if the handling
is the correct one... find the patch below...
> I have 2 scenarios in which I am getting a NULL pointer dereference:
>
> 1) root filesystem over nfs
> 2) telnet connection
>
> The issue appeared on this commit
>
>
Hi,
> > Bad news: Same results I got as in linus tree - NAK for NFS booting :(
> > full log: http://pastebin.mozilla.org/725960
> > from the log, I dont see the driver probe even starting up or any
> > reports as you posted above (which I guess is from Blaze)..
> >
> As Tony pointed out, those pat
Hi,
Here you have the list of changes done so far for OMAP4 Keyboard
Controller Support v2. I'll appreciate if someone else has more comments
to share.
Vikram.Pandita.01| struct omap_device global
Govindraj.Raja.01| Extra space between interrupt and probe functions
---
[PATCH v2 1/4] In
Vikram,
> From: Pandita, Vikram
[..]
> >+
> >+struct omap_device *od;
>
> Any reason to have this global?
Not really... I'll change it local to the keyboard init function, thanks!
Best Regards
Abraham
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a me
From: Syed Rafiuddin
Update OMAP4430 configuration to enable OMAP4 keyboard driver
Signed-off-by: Abraham Arce
---
arch/arm/configs/omap_4430sdp_defconfig |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/configs/omap_4430sdp_defconfig
b/arch/arm/configs/omap
Keyboard support for SDP OMAP4430
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/board-4430sdp.c | 157 +++
1 files changed, 157 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.c
index 6cce
OMAP4 keyboard controller includes:
- built-in scanning algorithm
- debouncing feature
Driver implementation is based on matrix_keypac.c
Signed-off-by: Syed Rafiuddin
Signed-off-by: Abraham Arce
---
drivers/input/keyboard/Kconfig| 10 +
drivers/input/keyboard/Makefile |
Add omap device driver interfaces to enable hwmod framework
Signed-off-by: Abraham Arce
---
include/linux/input/matrix_keypad.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/linux/input/matrix_keypad.h
b/include/linux/input/matrix_keypad.h
index c964cd7.
Keyboard controller for OMAP4 includes
- built-in scanning algorithm
- debouncing feature
- handling mechanism up to 9 x 9 keys
- wake-up event generation
Dependency on hwmod changes for OMAP4
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28188.html
--
v1
http://www.mail-archi
Against for-next branch
---
Add __attribute__ ((unused))
arch/arm/mach-omap2/clockdomains.h:58
warning: 'gfx_sgx_wkdeps' defined but not used
arch/arm/mach-omap2/mux.c:52
warning: 'mux_phys' defined but not used
Initialize to 0
arch/arm/plat-omap/gpio.c
In functio
> > Sorry for jumping into the comments late. Thought this was sorted out. Key
> scanning
> > and debounce timeouts etc still there. Having all these things in ISR itself
> isn't good
> > idea.
> >
> > Dmitry,
> > Don't you think its optimal to push the key-scanning and debounce timeout
> code
> >
Dmitry,
2 comments + one question before sending next version...
[...]
> > > > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > > > > +{
> > > >
> > > > Why is iti threaded? I fo not see anything that will sleep.
> >
> >
> > It was implemented based on previous comments...
>
Tony,
> > Enable network chip Micrel KS8851 for OMAP4430 SDP
> >
> > - Based on mainline version 2.6.34 rc7
> > - Tested in OMAP4430 SDP
> >
> > Throughput measurements using nuttcp application:
> > 11.9375 MB / 10.06 sec =9.9519 Mbps 92 %TX 0 %RX 0 retrans 7.87 msRTT
> >
> > --
> >
> > All
Hi again Dmitry,
> No worries, although at first I was surprised that Trilok spoke exactly
> the same words I did ;)
>
:)
> > > > > +
> > > > > +/* Interrupt thread handler thread */
> > > > > +
> > > > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > > > > +{
> > > >
> > >
Sorry for the confusion in your name Dmitry...
Thanks for your comments...
[snip]
> > > +
> > > +/* Interrupt thread handler thread */
> > > +
> > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > > +{
> >
> > Why is iti threaded? I fo not see anything that will sleep.
It w
Hi Trilok,
Thanks for your comments...
[snip]
> > +
> > +/* Interrupt thread handler thread */
> > +
> > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > +{
>
> Why is iti threaded? I fo not see anything that will sleep.
It was implemented based on previous comments...
>
Enable KS8851 SPI support +
Networking Support
- Packet Socket
- TCP/IP
Network Filesystems
- NFS Client
- Root Filesystem on NFS
Signed-off-by: Abraham Arce
---
arch/arm/configs/omap_4430sdp_defconfig | 57 +-
1 files changed, 55 insertions(+), 2 deleti
Enable Micrel KS8851 SPI network chip for OMAP4430
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/board-4430sdp.c | 81 +++
1 files changed, 81 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430
From: Syed Rafiuddin
Change dependency to ARCH_OMAP2PLUS to allow systems based on
omap24xx, omap34xx or omap44xx
Signed-off-by: Syed Rafiuddin
Signed-off-by: Abraham Arce
---
drivers/spi/Kconfig |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/Kconfig
Enable network chip Micrel KS8851 for OMAP4430 SDP
- Based on mainline version 2.6.34 rc7
- Tested in OMAP4430 SDP
Throughput measurements using nuttcp application:
11.9375 MB / 10.06 sec =9.9519 Mbps 92 %TX 0 %RX 0 retrans 7.87 msRTT
--
All patches have been tagged as version 3
[PATCH
Manjunath,
> > > > > > > +
> > > > > > > +static void omap_ethernet_init(void)
> > > > > > > +{
> > > > > > > + gpio_request(ETHERNET_KS8851_POWER_ENABLE, "ethernet");
> > > > > > > + gpio_direction_output(ETHERNET_KS8851_POWER_ENABLE, 1);
> > > > > > > + gpio_request(ETHERNET_KS8851_QUART, "quart
Thanks Kevin,
> > Keyboard controller for OMAP4 with built-in scanning algorithm.
> > The following implementations are used:
> >
> > - matrix_keypac.c logic
> > - hwmod framework
> > - threaded irq
> >
> > Signed-off-by: Syed Rafiuddin
> > Signed-off-by: Abraham Arce
>
> Some general com
> > > > +
> > > > +static void omap_ethernet_init(void)
> > > > +{
> > > > + gpio_request(ETHERNET_KS8851_POWER_ENABLE, "ethernet");
> > > > + gpio_direction_output(ETHERNET_KS8851_POWER_ENABLE, 1);
> > > > + gpio_request(ETHERNET_KS8851_QUART, "quart");
> > > > + gpio_direc
Felipe,
Thanks for your comments...
[..]
> >+#include
> >+#include
>
> should the platform_driver know about hwmod and omap_device ? Paul ?
> Kevin ?
Working on these changes...
>
> >+struct omap_keypad {
> >+
>
> unnecessary blank line.
Removed
>
> >+ struct platform_device *pde
Manjunath,
> > +
> > +static void omap_ethernet_init(void)
> > +{
> > + gpio_request(ETHERNET_KS8851_POWER_ENABLE, "ethernet");
> > + gpio_direction_output(ETHERNET_KS8851_POWER_ENABLE, 1);
> > + gpio_request(ETHERNET_KS8851_QUART, "quart");
> > + gpio_direction_output(ETHERNET_KS8851_QUAR
From: Syed Rafiuddin
Change dependency to ARCH_OMAP2PLUS to allow systems based on
omap24xx, omap34xx or omap44xx
Signed-off-by: Syed Rafiuddin
Signed-off-by: Abraham Arce
---
drivers/spi/Kconfig |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/Kconfig
Enable KS8851 SPI support +
Networking Support
- Packet Socket
- TCP/IP
Network Filesystems
- NFS Client
- Root Filesystem on NFS
Signed-off-by: Abraham Arce
---
arch/arm/configs/omap_4430sdp_defconfig | 57 +-
1 files changed, 55 insertions(+), 2 delet
Enable Micrel KS8851 SPI network chip for OMAP4430
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/board-4430sdp.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.
From: Syed Rafiuddin
Add OMAP4 data to allow McSPI driver built
Signed-off-by: Syed Rafiuddin
Signed-off-by: Shubhro
Signed-off-by: Santosh Shilimkar
Signed-off-by: Abraham Arce
---
drivers/spi/Kconfig |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi
Enable network chip Micrel KS8851 for OMAP4430 SDP
- Based on mainline version 2.6.34 rc6
- Tested in OMAP4430 SDP
Throughput measurements using nuttcp application:
11.9375 MB / 10.06 sec =9.9519 Mbps 92 %TX 0 %RX 0 retrans 7.87 msRTT
Patches
[PATCH v2 1/3] OMAP4: SPI: Fix Driver Kconfi
Hi Tony,
> > config SPI_OMAP24XX
> > - tristate "McSPI driver for OMAP24xx/OMAP34xx"
> > - depends on ARCH_OMAP2 || ARCH_OMAP3
> > + tristate "McSPI driver for OMAP24xx/OMAP34xx/OMAP44xx"
> > + depends on ARCH_OMAP24XX || ARCH_OMAP34XX || ARCH_OMAP4
> > help
> > - SPI master contr
Hi,
This is an update regarding the status on the patches needed to have KS8851 SNL
SPI based network controller in OMAP4430.
This patch has been accepted
0001-OMAP4-Clocks-Change-SPI-Instance-Names.patch
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg26951.html
No comments for t
Hi,
Thanks all for your comments; I am working to incorporate all of them so next
version is posted. Please find for now completed and pending action items:
Completed
Vimal.Singh.01 | Signed-off-by missing in patch
Vimal.Singh.02 | row/column interpretation in board file
Vimal.Singh.03 | 0
Enable KS8851 SPI support +
Networking Support
- Packet Socket
- TCP/IP
Network Filesystems
- NFS Client
- Root Filesystem on NFS
Signed-off-by: Abraham Arce
---
arch/arm/configs/omap_4430sdp_defconfig | 57 +-
1 files changed, 55 insertions(+), 2 delet
Enable Micrel KS8851 SPI network chip for OMAP4430
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/board-4430sdp.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.
From: Syed Rafiuddin
Add OMAP4 data to allow McSPI driver built
Signed-off-by: Syed Rafiuddin
Signed-off-by: Shubhro
Signed-off-by: Santosh Shilimkar
Signed-off-by: Abraham Arce
---
drivers/spi/Kconfig |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi
Change the name for the spi instances on omap44xx_clks to match
the names omap2 spi driver gives:
omap-mcspi.1 -> omap2_mcspi.1
omap-mcspi.2 -> omap2_mcspi.2
omap-mcspi.3 -> omap2_mcspi.3
omap-mcspi.4 -> omap2_mcspi.4
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/clock44xx_data.c |8
Enable network chip Micrel KS8851 for OMAP4430 SDP
- Based on mainline version 2.6.34 rc5
- Tested in OMAP4430 SDP
- One dependency
http://patchwork.ozlabs.org/patch/50363/
Throughput measurements using nuttcp application:
11.9375 MB / 10.07 sec =9.9441 Mbps 95 %TX 0 %RX 0 retrans 7.90
Hi Trilok!
> > - matrix_keypac.c logic
> > - hwmod framework
>
> Do we have hwmod framework mainlined in the kernel?
Not yet but wanted to gather initial comments to be ready once framework is
pushed
>
> >
> > +config KEYBOARD_OMAP4
> > + tristate "TI OMAP4 keypad support"
> > +
Thanks Vimal,
> > Signed-off-by: Abraham Arce
> > ---
>
> 'Form: Syed Rafiuddin', but not 'Signed-off-by:'... is it correct?
Yes, it is missing, added it in 02 && 03 patches...
> >
> > - KEY(7, 0, KEY_UNKNOWN),
> > + KEY(7, 0, KEY_LEFTSHIFT),
> > KEY(7, 1, KEY_ENTER),
> >
From: Syed Rafiuddin
Update OMAP4430 default configuration to add OMAP4 keyboard driver
Signed-off-by: Abraham Arce
---
arch/arm/configs/omap_4430sdp_defconfig |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/configs/omap_4430sdp_defconfig
b/arch/arm/configs
From: Syed Rafiuddin
Keyboard support for SDP OMAP4430
Signed-off-by: Abraham Arce
---
arch/arm/mach-omap2/board-4430sdp.c | 61 ++
1 files changed, 25 insertions(+), 36 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/boar
Keyboard controller for OMAP4 with built-in scanning algorithm.
The following implementations are used:
- matrix_keypac.c logic
- hwmod framework
- threaded irq
Signed-off-by: Syed Rafiuddin
Signed-off-by: Abraham Arce
---
drivers/input/keyboard/Kconfig|9 +
drivers/input/key
Keyboard controller for OMAP4 includes
- built-in scanning algorithm
- debouncing feature
- handling mechanism up to 9 x 9 keys
- wake-up event generation
These patches have been tested in a SDP4430 board.
Taking OMAP4 TI tree as code base, omap4_next-wip branch
http://dev.omapzoom.org/?p=
Hi,
I need some help to figure out the best way to incorporate omap4 keypad in
linux omap.
First approach, I have a patch that creates a new file, omap4-keypad.c with the
following implementations:
- Based on matrix keypac logic
- Using hwmod framework
- Using threaded irq
Second approach,
Hi Tom
> Does anyone have tslib running well on an OMAP3?
>
> I have a LogicPD Zoom LPD3430 thing and a TI OMAP3430 SDP dev board,
> and both have similar issues. The touchscreen is on /dev/input/event1 and
> works, but is so inaccurate, it's almost unusable. After running
> ts_calibrate
> I'm tes
58 matches
Mail list logo
