Re: [PATCH v5 0/4] mtd:nand:omap2: clean-up of supported ECC schemes

2013-08-20 Thread Artem Bityutskiy
On Tue, 2013-08-20 at 13:20 +, Gupta, Pekon wrote: > Hi Artem, Brian, I'll try to go through old e-mails now, and especially ubi/ubifs ones, including yours, and I'll let Brian handle your patches, if I can? :-) I checked them, and they looked good to me: Signed-off-by: Art

Re: [PATCH v1 0/4] mtd: nand: omap: add support for BCH16_ECC

2013-08-02 Thread Artem Bityutskiy
I wonder if anyone in the list could help reviewing this? -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mtd: nand: omap2: Fix compilation warning

2013-08-02 Thread Artem Bityutskiy
Johansson > > --- > > Thanks much.. > But just to remind, this commit fb1585b in linux-next needs to be reverted. > This patch is leftover by mistake because other dependent patches of > this series were dropped. This will not only break omap2-nand driver, > but might also

Re: [PATCH v4 0/4] mtd:nand:omap2: clean-up of supported ECC schemes

2013-07-03 Thread Artem Bityutskiy
ion; > + } > --- > However, if you are still seeing this, could you please send me your config? I compile tested your patches too, and did not see any issues with my omap2_defconfig. -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line

Re: [PATCH v4 0/4] mtd:nand:omap2: clean-up of supported ECC schemes

2013-07-01 Thread Artem Bityutskiy
bs there, and git log makes the table look messy. Please, use spaces instead next time. Thanks! -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/4] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe

2013-07-01 Thread Artem Bityutskiy
n. I'd suggest to also put stuff like this to comments in the code. > This patch > - separates the configurations for various ECC schemes. > - fixes dependency issues based on Kconfig options. > - cleans up redundant code > > Signed-off-by: Pekon Gupta This does not app

Re: [PATCH v5 3/3] mtd: devices: elm: Low power transition support

2013-07-01 Thread Artem Bityutskiy
re support, so that > configurations are preserved across hardware power-off/on transitions. > > Signed-off-by: Philip Avinash > Signed-off-by: Pekon Gupta Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsu

Re: MTD : cannot reserve enough PEBs for bad PEB handling

2013-05-15 Thread Artem Bityutskiy
he various option values correctly for > mkfs.ubifs and ubinize. > > But since I'm getting the warning, can anyone explain where I've gone > wrong ? This is because UBI is trying to reserve 40 PEBs for bad block handling. Why so much? See the explanations here: htt

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-15 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 11:13 +0200, Artem Bityutskiy wrote: > On Wed, 2013-03-13 at 11:12 +, Mark Jackson wrote: > > Sorry ... this just locks up the unit. > > OK, I've reproduced the issue with 3.9-rc2 in nandsim, see the details > below. The patch I proposed did

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-15 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 13:40 +, Mark Jackson wrote: > On 14/03/13 12:23, Artem Bityutskiy wrote: > > On Thu, 2013-03-14 at 14:18 +0200, Artem Bityutskiy wrote: > >>> Is this size larger than the allocated buffer ? > >> > >> I believe so. > > >

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 14:18 +0200, Artem Bityutskiy wrote: > > Is this size larger than the allocated buffer ? > > I believe so. Err, I mean, the buffer is large enough. I do not believe there is a stupid bug like too small buffer. This code has worked for years and I do not think it

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 12:02 +, Mark Jackson wrote: > But there's also a call to crc with a size of 122880 bytes, and that's > when the oops occurs. > This is when we do the atomic LEB change. > Is this size larger than the allocated buffer ? I believe so. -- Best Reg

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
eration, and submits the buffer to the MTD layer for the I/O. If your NAND driver is trying to DMA this memory, you may be in trouble, because vmalloced memory is often not DMA-able on many systems, especially ARM systems which do not have coherent cache support. -- Best Regards, Artem Bityutskiy -

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 09:54 +, Mark Jackson wrote: > On 14/03/13 09:13, Artem Bityutskiy wrote: > > On Wed, 2013-03-13 at 11:12 +, Mark Jackson wrote: > >> Sorry ... this just locks up the unit. > > > > OK, I've reproduced the issue with 3.9-rc2 in nand

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
e problem 3. ubinize.cfg - is needed for 'reproduce.sh'. Thanks! >From a173f8e9296562e5ece3dd2936d799001897d6c6 Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Thu, 14 Mar 2013 10:49:23 +0200 Subject: [PATCH] UBIFS: make space fixup work in the remount case The UBIFS space f

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-13 Thread Artem Bityutskiy
); > > return err; > > > > Sorry ... this just locks up the unit. Am I right that to reproduce it I need any image with the 'fixup' flag set, then I should put it on the flash, mount it R/O and then remount R/W. Right? -- Best Regards, Artem Bityutskiy -- To uns

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-12 Thread Artem Bityutskiy
+ err = check_free_space(c); if (err) goto out; @@ -1684,12 +1690,6 @@ static int ubifs_remount_rw(struct ubifs_info *c) err = dbg_check_space_info(c); } - if (c->space_fixup) { - err = ubifs_fixup_free_space(c); - i

Re: [PATCH v4 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc

2013-01-17 Thread Artem Bityutskiy
NAND flash in am335x-platforms and hardware based BCH error > correction. OK, I've applied them. I dropped the part that updates the documentation. Please, handle it separately when Daniel's patches are in. Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/3] mtd: omap-onenand: pass device_node in platform data

2013-01-17 Thread Artem Bityutskiy
On Tue, 2013-01-15 at 19:48 -0300, Ezequiel Garcia wrote: > I saw you have acked the gpmc patch on nand. > Can I add your Acked-by on this one, when I send the rebased patch set? Yes, I saw this series which depends on Daniel Mack's work. It looks good. You can add Acked-by: Artem

Re: [PATCH v8 2/5] mtd: omap-nand: pass device_node in platform data

2013-01-15 Thread Artem Bityutskiy
On Tue, 2013-01-15 at 11:26 -0800, Tony Lindgren wrote: > * Artem Bityutskiy [130115 11:12]: > > On Tue, 2013-01-15 at 10:52 -0800, Tony Lindgren wrote: > > > Artem, > > > > > > Looks like this patch related to making GPMC work with DT was > > > neve

Re: [PATCH v8 2/5] mtd: omap-nand: pass device_node in platform data

2013-01-15 Thread Artem Bityutskiy
parately with the MTD patches? Please, go ahead! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/3] mtd nand : onfi need to be probed in 8 bits mode

2012-12-03 Thread Artem Bityutskiy
On Tue, 2012-11-06 at 11:51 +0100, Matthieu CASTET wrote: > - NAND_CMD_READID want an address that it is not scaled on x16 device (it is > always 0x20) > - NAND_CMD_PARAM want 8 bits data > > Signed-off-by: Matthieu CASTET Pushed this one to l2-mtd.git, thanks! -- Best

Re: [PATCH 2/3] mtd nand : add NAND_BUSWIDTH_AUTO to autodetect bus width

2012-11-30 Thread Artem Bityutskiy
are read work 8 byte mode. Pushed this one alone to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 3/3] omap3 nand : use NAND_BUSWIDTH_AUTO

2012-11-16 Thread Artem Bityutskiy
thieu's patches. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v3] mtd: omap: nand: Remove 0xFF's that prefixed 16bit NAND addresses

2012-11-15 Thread Artem Bityutskiy
On Thu, 2012-11-15 at 09:48 -0500, Christopher Harvey wrote: > On Thu, Nov 15, 2012 at 01:02:09PM +0200, Artem Bityutskiy wrote: > > On Mon, 2012-10-29 at 15:51 -0400, Christopher Harvey wrote: > > > In 16bit NAND mode the GPMC would send the address 0xNN as 0xFFNN > > &g

Re: [PATCH v3] mtd: omap: nand: Remove 0xFF's that prefixed 16bit NAND addresses

2012-11-15 Thread Artem Bityutskiy
This commit also changes the high byte in the command > output register, but they are ignored by NAND chips anyway. > > Most chips seem fine with the extra 0xFFs, but the ONFI spec says > otherwise. > > Signed-off-by: Christopher Harvey Pushed to l2-mtd.git, thanks! -- Best R

Re: [GIT PULL] OMAP-GPMC related cleanup for common zImage

2012-10-15 Thread Artem Bityutskiy
linux-kernel.git tags/gpmc-czimage FWIW, the mtd changes look OK, and this stuff is very OMAP-specific, so merging everything through the OMAP tree makes a lot of sense. Thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] mtd: omap2-nand: avoid unaligned DMA accesses, fall back on prefetch method

2012-09-27 Thread Artem Bityutskiy
ned buffers? > Perhaps a better method is to fetch the first few unaligned bytes > with the prefetch method, and then continue with DMA. However, > since it's hard to force an unaligned buffer, it's also hard to > test that this method works. Yes, this would be a lot cleaner. -

Re: [PATCH] mtd: nand: omap2: Fix the nand-disk led trigger

2012-09-26 Thread Artem Bityutskiy
we did to MTD api. Instead of calling 'chip->waitfunc()' directly from everywhere, have a wrapper 'nand_wati()' function, which can do things common to all drivers, and then actually call the underlying '->waitfunc()'. So in this case, it can do the LED stuff. -- B

Re: [PATCH 1/2] mtd/nand/omap2: fix omap_nand_remove segfault

2012-08-31 Thread Artem Bityutskiy
; This patch fixes following error when unloading the omap2 module: Added "Cc: sta...@vger.kernel.org" to both patches and pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs

2012-08-25 Thread Artem Bityutskiy
remove it. > > Signed-off-by: Afzal Mohammed Acked-by: Artem Bityutskiy -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 00/10] Prepare for GPMC driver conversion (w.r.t MTD)

2012-06-27 Thread Artem Bityutskiy
hat Russel King patched the omap2.c file in patch series which switches to the DMA engine, so I expect conflicts. You can check his tree, I guess. The subjects were: [CFT 09/11] mtd: omap2: add DMA engine support [CFT 10/11] mtd: omap2: remove private DMA API implementation -- Best Regards, A

Re: [PATCH v2 00/10] Prepare for GPMC driver conversion (w.r.t MTD)

2012-06-27 Thread Artem Bityutskiy
d this, but the MTD changes look good an the quick glance. Feel free to add Acked-by: Artem Bityutskiy Thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

RE: [PATCH v2 08/10] ARM: OMAP2+: gpmc: Modify interrupt handling

2012-06-27 Thread Artem Bityutskiy
ted series ? No, thanks. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

RE: [PATCH 00/10] Prepare for GPMC driver conversion (w.r.t MTD)

2012-06-14 Thread Artem Bityutskiy
ot have time to review your patches, but they look OK on the quick glance. Thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 08/10] ARM: OMAP2+: gpmc: Modify interrupt handling

2012-06-13 Thread Artem Bityutskiy
On Wed, 2012-06-13 at 17:03 +0530, Afzal Mohammed wrote: > +/* XXX: Only NAND irq has been considered,currently these are the only ones > used > + */ > +#define GPMC_NR_IRQ 2 I guess "XXX" means "Warning"? Why not to use plain English? :-) --

Re: [CFT 09/11] mtd: omap2: add DMA engine support

2012-06-07 Thread Artem Bityutskiy
s - and then it doesn't matter what goes in when and by > whom. Oh, sure, sorry, I actually wanted to say that these to patches should _not_ got via the MTD tree. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [CFT 09/11] mtd: omap2: add DMA engine support

2012-06-07 Thread Artem Bityutskiy
private DMA API. > > Tested-by: Grazvydas Ignotas > Signed-off-by: Russell King I guess it is makes sense to make this stuff to go in via the OMAP tree. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

RE: [PATCH 0/3] GPMC NAND isr using standard API

2012-05-21 Thread Artem Bityutskiy
st Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v3] ARM: OMAP3: gpmc: add BCH ecc api and modes

2012-05-11 Thread Artem Bityutskiy
On Thu, 2012-05-10 at 19:45 +0200, Ivan Djelic wrote: > On Thu, May 10, 2012 at 04:52:18PM +0100, Artem Bityutskiy wrote: > > On Thu, 2012-05-10 at 17:17 +0200, Ivan Djelic wrote: > > > But in order to do so, I need the changes that Afzal has submitted > > > (in particul

Re: [PATCH v3] ARM: OMAP3: gpmc: add BCH ecc api and modes

2012-05-10 Thread Artem Bityutskiy
a new, single MTD patch. But this is not going to happen this merge window as I understood, may be not even the next one. We need to make UBIFS happy sooner than that, I think. So may be we go forward with your original patch? -- Best Regards, Artem Bityutskiy signature.asc Description: This

Re: [PATCH v3] ARM: OMAP3: gpmc: add BCH ecc api and modes

2012-05-10 Thread Artem Bityutskiy
zal. Ivan, so are you going to send new patches early enough to make them hit 3.5? Can you please then re-send all the dependent patches again and again describe what depends on what, because I am getting lost :-) -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] ARM: OMAP1: fix compilation issue in board-sx1.c

2012-05-09 Thread Artem Bityutskiy
On Tue, 2012-05-08 at 17:17 -0700, Tony Lindgren wrote: > * Artem Bityutskiy [120508 07:02]: > > From: Artem Bityutskiy > > > > SX1 board requirese i2c, so select it in Kconfig, otherwise I have the > > following build error: > > Thanks applying into fixes-no

[PATCH] ARM: OMAP1: fix compilation issue in board-sx1.c

2012-05-08 Thread Artem Bityutskiy
From: Artem Bityutskiy SX1 board requirese i2c, so select it in Kconfig, otherwise I have the following build error: arch/arm/mach-omap1/board-sx1.c: In function 'sx1_i2c_write_byte': arch/arm/mach-omap1/board-sx1.c:58:2: error: implicit declaration of function 'i2c_get_ad

Re: [PATCH v2 3.4-rc6] MTD: NAND: ams-delta: fix request_mem_region() failure

2012-05-08 Thread Artem Bityutskiy
On Tue, 2012-05-08 at 10:03 +0300, Artem Bityutskiy wrote: > On Mon, 2012-05-07 at 22:51 +0200, Janusz Krzysztofik wrote: > > A call to request_mem_region() has been introduced in the omap-gpio > > driver recently (commit 96751fcbe5438e95514b025e9cee7a6d38038f40, > > "gp

Re: [PATCH v2 3.4-rc6] MTD: NAND: ams-delta: fix request_mem_region() failure

2012-05-08 Thread Artem Bityutskiy
rning: unused variable 'res' [-Wunused-variable] -------- -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v3.4-rc3] MTD: NAND: ams-delta: Fix request_mem_region() failure

2012-04-25 Thread Artem Bityutskiy
f having an illusion of exclusive memory region ownership. But this is up to the OMAP community - I can take this patch to my l2-mtd tree if you get an ack from Tony or other OMAP guys. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] ARM: OMAP3: gpmc: add BCH ecc api and modes

2012-04-25 Thread Artem Bityutskiy
On Wed, 2012-04-25 at 08:23 -0700, Tony Lindgren wrote: > Hi, > > * Artem Bityutskiy [120425 07:52]: > > On Tue, 2012-04-17 at 10:48 +0200, Ivan Djelic wrote: > > > This patch adds a simple BCH ecc computation api, similar to the > > > existing Hamming ecc api.

Re: [PATCH v3.4-rc3] MTD: NAND: ams-delta: Fix request_mem_region() failure

2012-04-25 Thread Artem Bityutskiy
sz Krzysztofik How about race conditions? Where is the guarantee that these 2 drivers won't affect each other when doing I/O at the same time to the same HW resources? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] ARM: OMAP3: gpmc: add BCH ecc api and modes

2012-04-25 Thread Artem Bityutskiy
ng UBIFS actually usable on OMAP platforms which use BCH ECC. There are 2 other MTD patches which depend on this - so I wonder if it is easier to merge this one via the MTD tree, providing it has your/others' ack(s). Thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] mtd: omap2: fix resource leak in prefetch-busy path

2012-04-22 Thread Artem Bityutskiy
On Wed, 2012-04-11 at 04:04 +0300, Grazvydas Ignotas wrote: > If prefetch engine is busy, current code "forgets" to call > dma_unmap_single(), which results in a deadlock later, so add it. > > Signed-off-by: Grazvydas Ignotas Pushed to l2-mtd.git, thanks! -- Best Reg

Re: [PATCH 0/5] mtd: plat_nand: Add default partition parser and use it

2012-04-02 Thread Artem Bityutskiy
information as chip.part_probe_types. > > Signed-off-by: H Hartley Sweeten Pushed the series to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [GIT PULL] HSI framework

2012-03-07 Thread Artem Bityutskiy
led into 3.4? Hi, Because this question is for Linus, he should be in "To:" instead of "Cc:" - correcting. -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented

2012-02-02 Thread Artem Bityutskiy
rds, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented

2012-01-30 Thread Artem Bityutskiy
the fix. http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/283d43b9ce2952535aa89c0195085e2a1b7e5fce Also attached. From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Mon, 16 Jan 2012 11:07:16 +0200 Subject: [P

Re: Linux 3.3-1 out - merge window closed

2012-01-25 Thread Artem Bityutskiy
On Wed, 2012-01-25 at 13:47 +0200, Pekka Enberg wrote: > On Wed, Jan 25, 2012 at 1:35 PM, Artem Bityutskiy > wrote: > >> There is a signed tag (hsi_for_3.3), but said it so is true that my key > >> was signed only by one person. Today I've managed to meet Artem > &

Re: Linux 3.3-1 out - merge window closed

2012-01-25 Thread Artem Bityutskiy
use > > Torvalds cannot verify who you are, and/or that there is no signed > > tag on it? GPG keys are getting mandatory, though it's sad if it's > > becoming a barrier to entry. > > > > There is a signed tag (hsi_for_3.3), but said it so is true that my key

Re: [GIT PULL] HSI framework

2012-01-19 Thread Artem Bityutskiy
upstream. I believe this code base is more than worth merging since it has many users and it has proven itself in real Nokia products. Would you please pull it? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 5/7] MTD: NAND: ams-delta: use GPIO instead of custom I/O

2011-12-21 Thread Artem Bityutskiy
M: OMAP1: ams-delta: convert latches to > basic_mmio_gpio" > > Signed-off-by: Janusz Krzysztofik > Cc: David Woodhouse > Cc: Tony Lindgren Looks good, thanks! Reviewed-by: Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-omap"

Re: [PATCH] mdt nand: omap2+ use platform options

2011-12-04 Thread Artem Bityutskiy
On Fri, 2011-12-02 at 09:28 -0800, Brian Norris wrote: > On Fri, Dec 2, 2011 at 2:20 AM, Grazvydas Ignotas wrote: > > On Thu, Dec 1, 2011 at 10:42 AM, Artem Bityutskiy > > wrote: > >> On Tue, 2011-11-29 at 10:00 +0100, Jan Weitzel wrote: > >>> Signed-off-by:

Re: [PATCH] mdt nand: omap2+ use platform options

2011-12-02 Thread Artem Bityutskiy
On Fri, 2011-12-02 at 12:20 +0200, Grazvydas Ignotas wrote: > On Thu, Dec 1, 2011 at 10:42 AM, Artem Bityutskiy wrote: > > On Tue, 2011-11-29 at 10:00 +0100, Jan Weitzel wrote: > >> Signed-off-by: Jan Weitzel > > > > Pushed to l2-mtd-2.6.git, thank you! >

Re: [PATCH] mdt nand: omap2+ use platform options

2011-12-01 Thread Artem Bityutskiy
On Tue, 2011-11-29 at 10:00 +0100, Jan Weitzel wrote: > Options from struct omap_nand_platform_data are not used. > Apply options after nand_scan_ident to avoid overwrite due to > NAND_CHIPOPTIONS_MSK. > So you can pass options from platformcode > > Signed-off-by: Jan Weitzel Pushed to l2-mtd-2.

Re: [PATCH] MTD: nand: Making MTD_NAND_OMAP2 depend on ARCH_OMAP2PLUS

2011-11-17 Thread Artem Bityutskiy
On Wed, 2011-11-16 at 10:48 +0530, Shubhrajyoti D wrote: > Making MTD_NAND_OMAP2 depend on ARCH_OMAP2PLUS instead of > oring with ARCH2/3/4. > > Reported-by: Russell King > Signed-off-by: Shubhrajyoti D Pushed to l2-mtd-2.6, thanks! Artem. -- To unsubscribe from this list: send the line "uns

Re: HSI framework for linux-next

2011-10-28 Thread Artem Bityutskiy
to see it integrated, if possible, for 3.3 > > Latest discussion for integration: > https://lkml.org/lkml/2011/10/20/177 Stephen, I confirm that this is useful and solid framework, works well, and we are also interested to see it upstream. Thanks! -- Best Regards, Artem Bityutskiy sig

RE: [PATCH] ti816x: add support for nand on ti8168 evm

2011-09-19 Thread Artem Bityutskiy
On Mon, 2011-09-19 at 17:04 +0530, Saxena, Parth wrote: > Artem, > I will re-post this patch to linux-omap list and Tony. Can I add your name in > the 'Acked-by' section? No, I did not review this patch. -- Best Regards, Artem Bityutskiy -- To unsubscribe from this

Re: [PATCH] ti816x: add support for nand on ti8168 evm

2011-09-18 Thread Artem Bityutskiy
++ > 1 files changed, 39 insertions(+), 0 deletions(-) Please, send this patch to Tony, I think it should go in via the omap tree, not via the MTD tree. -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body o

Re: [PATCH v2] MTD: Nand: use MTD_NAND_OMAP2 for OMAP4

2011-07-22 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 09:28 +0200, Jan Weitzel wrote: > use MTD_NAND_OMAP2 also for OMAP4 arch. > testes wit omap4430 > > Signed-off-by: Jan Weitzel > --- > v2: add menuconfig description Pushed to l2-mtd-2.6.git, thanks. -- Best Regards, Artem Bityutskiy -- To unsubscr

Re: [PATCH] MTD: Nand: use MTD_NAND_OMAP2 for OMAP4

2011-07-19 Thread Artem Bityutskiy
depends on ARM && (ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP4) > help > - Support for NAND flash on Texas Instruments OMAP2 and OMAP3 > platforms. > + Support for NAND flash on Texas Instruments OMAP2, OMAP3 and OMAP4 > + platforms. -- Best Regards, Artem B

Re: [PATCH RESEND] omap : nand : fix subpage ecc issue with prefetch

2011-05-12 Thread Artem Bityutskiy
gt; Signed-off-by: Kishore Kadiyala > Signed-off-by: Vimal Singh > Reported-by: Bryan DE FARIA > Cc: sta...@kernel.org [2.6.35+] Pushed to l2-mtd-2.6.git, thanks. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] omap : nand : fix subpage ecc issue with prefetch

2011-05-06 Thread Artem Bityutskiy
On Fri, 2011-05-06 at 13:00 +0530, Vimal Singh wrote: > On Fri, May 6, 2011 at 12:18 AM, Artem Bityutskiy wrote: > > On Mon, 2011-05-02 at 16:40 +0530, Kishore Kadiyala wrote: > >> For prefetch engine, read and write got broken in commit '2c01946c'. > >> W

Re: [PATCH] omap : nand : fix subpage ecc issue with prefetch

2011-05-05 Thread Artem Bityutskiy
with more explanation and analysis of the problem and how it was fixed.This commit message is not very understandable. And then it needs also: Cc: sta...@kernel.org [2.6.36+] Right? And then we could send it upstream. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from th

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Artem Bityutskiy
On Fri, 2011-04-29 at 11:03 -0700, Brian Norris wrote: > As promised (but too late?): > > Acked-by: Brian Norris No, not late, I rebase my l2 tree with no shame :-) But once the patch hits the real mtd tree, then we never change it. So, I've added you tag, thanks. -- Best

RE: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Artem Bityutskiy
On Fri, 2011-04-29 at 19:52 +0530, Saxena, Parth wrote: > > > -Original Message- > > From: Artem Bityutskiy [mailto:dedeki...@gmail.com] > > Sent: Thursday, April 28, 2011 11:01 PM > > To: Saxena, Parth; Brian Norris > > Cc: linux-...@lists.infradead.or

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Artem Bityutskiy
On Thu, 2011-04-28 at 20:30 +0300, Artem Bityutskiy wrote: > On Wed, 2011-04-27 at 17:39 +0530, Saxena, Parth wrote: > > This patch solves the above issue for omap by initialising > > badblockbits. We are working further on this to find a generic fix > > to the problem in nan

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-28 Thread Artem Bityutskiy
which was accidentally removed, how about this patch From: Artem Bityutskiy Date: Thu, 28 Apr 2011 20:26:59 +0300 Subject: [PATCH] mtd: return badblockbits back In commit c7b28e25cb9beb943aead770ff14551b55fa8c79 the initialization of the backblockbits was accidentally removed. This patch returns it back

Re: [PATCH v3] ARM: omap2: mtd split nand_scan in ident and tail

2011-04-20 Thread Artem Bityutskiy
ms. > > Signed-off-by: Jan Weitzel > Reviewed-by: Vimal Singh Jan, thanks for the patch, pushed to l2-mtd-2.6.git. And apologies that I missed. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body

Re: [PATCH] ARM: omap2: mtd split nand_scan in ident and tail

2011-04-15 Thread Artem Bityutskiy
goto out_release_mem_region; > > + } > > + > > #ifdef CONFIG_MTD_PARTITIONS > > err = parse_mtd_partitions(&info->mtd, part_probes, &info->parts, 0); > > if (err > 0) > > So no comments? Is any rework needed? Without this patch I am n

Re: [PATCH 1/2] MTD: s3c2410_nand: Add option to disable hw ECC at runtime

2011-04-15 Thread Artem Bityutskiy
On Thu, 2011-04-14 at 16:48 +0200, Lars-Peter Clausen wrote: > On 04/14/2011 02:08 PM, Artem Bityutskiy wrote: > > On Tue, 2011-04-12 at 21:47 +0200, Lars-Peter Clausen wrote: > >> From: Holger Freyther > >> > >> This patch adds a flag to the s3c2410_

Re: [GIT PULL] omap changes for v2.6.39 merge window

2011-03-31 Thread Artem Bityutskiy
for pain and suffering. If I understand correctly, this is exactly what Linaro would need to do. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH v2 1/1] omap3: nand: report corrected ecc errors

2011-03-07 Thread Artem Bityutskiy
o Patch against linux-next-20110225. > o Added comments explaining return codes. Pushed to l2-mtd-2.6.git, thanks. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger

Re: [PATCH 4/4] mtd: OneNAND: OMAP2: increase multiblock erase verify timeout

2011-02-17 Thread Artem Bityutskiy
he interrupt mode is used to wait for the > > command end. > > > > Signed-off-by: Roman Tereshonkov > > I'll queue this series. Anybody from MTD list care to ack this patch? Acked-by: Artem Bityutskiy -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe fro

Re: [PATCH 1/2] mtd: Add nand_base feature to align subpage read buffers

2011-01-18 Thread Artem Bityutskiy
@@ -474,6 +474,7 @@ struct nand_buffers { > * additional error status checks (determine if errors are > * correctable). > * @write_page: [REPLACEABLE] High-level page write function > + * @align_subpage: [OPTIONAL] Aligns subpage re

Re: Huge ubi or ubifs sync slowdown since 2.6.32

2010-12-22 Thread Artem Bityutskiy
ug this deeper? Can you try this on nandsim and see if there are still differences? You can make nandsim slower by injecting an udelay somewhere. Try this on your x86 host - this way you'll narrow this down to an OMAP-specific or platform-independent problem. -- Best Regards, Artem Bityut

Re: UBIFS not mounting on linux-omap 2.6.36

2010-12-21 Thread Artem Bityutskiy
ubifs although the same procedure works with older kernels and > works > with the linux-omap 2.6.37 master. Well, the only hint I can give is some kind of bisecting, but probably you do not need such hint :-) -- Best Regards, Artem Bityutskiy (Битюцкий Артём) -- To unsubscribe

Re: [PATCH] MTD: NAND: ams-delta: drop omap_read/write, use ioremap

2010-12-19 Thread Artem Bityutskiy
ch > 'MTD: NAND: ams-delta: convert to platform driver'. > > Signed-off-by: Janusz Krzysztofik Pushed to l2-mtd-2.6.git, thanks! -- Best Regards, Artem Bityutskiy (Битюцкий Артём) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body

Re: [PATCH] MTD: NAND: ams-delta: select for built-in by default

2010-12-19 Thread Artem Bityutskiy
gured for > being built into the kernel if the Amstrad Delta board is also selected. > > Created against linux-2.6.37-rc5. > > Signed-off-by: Janusz Krzysztofik Pushed to l2-mtd-2.6.git, thanks. -- Best Regards, Artem Bityutskiy (Битюцкий Артём) -- To unsubscribe from

Re: [PATCH v2] MTD: NAND: ams-delta: convert to platform driver

2010-12-15 Thread Artem Bityutskiy
> machine types. > > Convert it to a platform driver, that should be free from this issue. > > Created and tested against linux-2.6.37-rc5 on Amstrad Delta. > > Signed-off-by: Janusz Krzysztofik Pushed to l2-mtd-2.6.git, thanks! -- Best Regards, Artem Bityutskiy (Артё

Re: [PATCH] MTD: NAND: ams-delta: convert to platform driver

2010-12-14 Thread Artem Bityutskiy
to split this few small patches - this one is too difficult to review, at least for me. Thanks! -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH V2] omap: nand: remove hardware ECC as default

2010-12-03 Thread Artem Bityutskiy
e patch, and you can merge it yourself, MTD tree is slow. I hope dwmw2 will not beat me for this, but unless he quickly jumps in and confirms he takes care of this patch, just go ahead an merge it. I've put dwmw2 to "To:", just in case. -- Best Regards, Artem Bityutskiy (Артём Битюц

Re: [PATCH 1/1] mtd: OneNAND: fix bufferram management when chip has 2-planes.

2010-10-26 Thread Artem Bityutskiy
bit (0x58) > with 2 planes from Numonyx and CONFIG_MTD_ONENAND_2X_PROGRAM set to y > > Signed-off-by: Enric Balletbo i Serra Kyungmin, would be nice to have your ack/nack. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-om

Re: [PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw read/write

2010-10-25 Thread Artem Bityutskiy
ude/asm/io.h IMHO. so that there are no overlaps as this. > > Indeed. This patch is complete nonsense. Removing from my l2 tree. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a mess

Re: [PATCH v3] OMAP2/3: NAND: Convert write/read functions to raw read/write

2010-10-11 Thread Artem Bityutskiy
inally declared here > > Signed-off-by: G, Manjunath Kondaiah > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-...@lists.infradead.org I've pushed this patch to my l2-mtd-2.6.git. -- Best Regards, Artem Bityutskiy (Битюцкий Артём) -- To unsubscribe from this list: sen

Re: [PATCH v3] OMAP: NAND: Fix static declaration warning

2010-10-11 Thread Artem Bityutskiy
ed-off-by: G, Manjunath Kondaiah > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-...@lists.infradead.org > Cc: Tony Lindgren > Cc: Nishanth Menon I've pushed this patch to my l2-mtd-2.6.git. -- Best Regards, Artem Bityutskiy (Битюцкий Артём) -- To unsubscribe from this l

Re: [PATCH] nand: omap2: Missing arg to gpmc_prefetch_reset()

2010-10-04 Thread Artem Bityutskiy
On Mon, 2010-10-04 at 10:52 +0200, Loïc Minier wrote: > On Mon, Oct 04, 2010, Artem Bityutskiy wrote: > > FYI, a similar patch is already in Linus' tree, so I'm dropping it from > > my tree > > Ok, thanks; is there something I should have done to get this patch &

Re: [PATCH] nand: omap2: Missing arg to gpmc_prefetch_reset()

2010-10-04 Thread Artem Bityutskiy
30. Signed-off-by: Daniel J Blueman Signed-off-by: Linus Torvalds -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] nand: omap2: Missing arg to gpmc_prefetch_reset()

2010-09-26 Thread Artem Bityutskiy
nsfer': > drivers/mtd/nand/omap2.c:416: error: too few arguments to function > 'gpmc_prefetch_reset' > > Signed-off-by: Loïc Minier Looks like a regression which should be merged to 2.6.36. I've taken this patch to l2-mtd-2.6.git, will ping dwmw2 about the need

[PATCH] omap: device: improve errors handling

2010-07-12 Thread Artem Bityutskiy
From: Artem Bityutskiy Do not forget to check the 'platform_device_add_data()' error code in 'omap_device_build_ss()'. Signed-off-by: Artem Bityutskiy Acked-by: Nishanth Menon --- arch/arm/plat-omap/omap_device.c |4 +++- 1 files changed, 3 insertions(+), 1 deleti

Re: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-12 Thread Artem Bityutskiy
On Fri, 2010-07-09 at 16:20 +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > Do not forget to check the 'platform_device_add_data()' error code > in 'omap_device_build_ss()'. > > Signed-off-by: Artem Bityutskiy Please, discard this patch, I&

Re: [PATCH]omap:dmtimer:no null check for kzalloc

2010-07-11 Thread Artem Bityutskiy
__func__); > + return -ENOMEM; > + } do not use concatenation ('\'), this is probably not what you want. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe lin

RE: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-09 Thread Artem Bityutskiy
On Fri, 2010-07-09 at 11:00 -0500, Menon, Nishanth wrote: > > -Original Message- > > From: Artem Bityutskiy [mailto:dedeki...@gmail.com] > > Sent: Friday, July 09, 2010 10:51 AM > > > > On Fri, 2010-07-09 at 10:51 -0500, Nishanth Menon wrote: > > &g

  1   2   >