[PATCH] MAINTAINERS: omap_hsmmc: remove myself from MAINTAINERS

2014-09-17 Thread Balaji T K
As I won't be able to maintain omap_hsmmc driver Signed-off-by: Balaji T K balaji...@gmail.com --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5e7866a..b296e43 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6540,10 +6540,9

Re: [PATCH v14 2/6] mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state

2014-05-29 Thread Balaji T K
-by: Balaji T K balaj...@ti.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 129569d..332d3d2 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -56,6 +56,7 @@ #define OMAP_HSMMC_RSP54 0x0118 #define OMAP_HSMMC_RSP76

Re: [PATCH v14 6/6] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-05-29 Thread Balaji T K
will still happen through the IP block. Idea of remuxing the pins by Tony Lindgren. Code contributions from Tony Lindgren and Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Acked-by: Balaji T K balaj...@ti.com Hi Chris/Ulf

Re: [PATCH v13 1/7] mmc: omap_hsmmc: install dummy pm runtime hooks if !CONFIG_PM_RUNTIME

2014-05-23 Thread Balaji T K
On Friday 23 May 2014 02:00 PM, Andreas Fenkart wrote: Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 272e0ee..c62d9dd 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -199,7

Re: [PATCH v13 3/7] mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state

2014-05-23 Thread Balaji T K
On Friday 23 May 2014 02:00 PM, Andreas Fenkart wrote: Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Acked-by: Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host

Re: [PATCH v13 7/7] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-05-23 Thread Balaji T K
will still happen through the IP block. Idea of remuxing the pins by Tony Lindgren. Code contributions from Tony Lindgren and Balaji T K balaj...@ti.com Acked-by: Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git

Re: [PATCH v2 6/6] mmc: omap_hsmmc: split omap-dma header file

2014-05-20 Thread Balaji T K
On Monday 19 May 2014 10:24 PM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [140519 04:54]: On Saturday 17 May 2014 03:11 AM, Tony Lindgren wrote: - -#if defined(CONFIG_DMA_OMAP) || defined(CONFIG_DMA_OMAP_MODULE) -bool omap_dma_filter_fn(struct dma_chan *, void *); -#else -static inline

Re: [PATCH v2 6/6] mmc: omap_hsmmc: split omap-dma header file

2014-05-19 Thread Balaji T K
On Saturday 17 May 2014 03:11 AM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [140509 09:47]: moving dmaengine consumer specific function to omap-dmaengine.h to Resolve build failure seen with sh-allmodconfig: include/linux/omap-dma.h:171:8: error: expected identifier before numeric

[PATCH] mmc: omap_hsmmc: use IS_ERR macro for error checking

2014-05-15 Thread Balaji T K
Debounce clock is optional, use IS_ERR macro instead of NULL pointer check. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 18 +++--- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

Re: [PATCH v2 1/6] mmc: omap_hsmmc: use devm_clk_get

2014-05-15 Thread Balaji T K
On Monday 12 May 2014 07:20 PM, Ulf Hansson wrote: On 12 May 2014 15:33, Balaji T K balaj...@ti.com wrote: On Monday 12 May 2014 02:03 PM, Ulf Hansson wrote: On 9 May 2014 18:46, Balaji T K balaj...@ti.com wrote: With devm_clk_get conversion clk_put can be removed in clean up path Signed

Re: [PATCH v2 6/6] mmc: omap_hsmmc: split omap-dma header file

2014-05-15 Thread Balaji T K
On Friday 09 May 2014 10:16 PM, Balaji T K wrote: moving dmaengine consumer specific function to omap-dmaengine.h to Resolve build failure seen with sh-allmodconfig: include/linux/omap-dma.h:171:8: error: expected identifier before numeric constant make[4]: *** [drivers/mmc/host

Re: [PATCH v2 1/6] mmc: omap_hsmmc: use devm_clk_get

2014-05-12 Thread Balaji T K
On Monday 12 May 2014 02:03 PM, Ulf Hansson wrote: On 9 May 2014 18:46, Balaji T K balaj...@ti.com wrote: With devm_clk_get conversion clk_put can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 15 --- 1 files changed

[PATCH v2 3/6] mmc: omap_hsmmc: use devm_request_threaded_irq

2014-05-09 Thread Balaji T K
With devm_request_threaded_irq conversion free_irq can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

[PATCH v2 5/6] mmc: omap_hsmmc: fix cmd23 multiblock read/write

2014-05-09 Thread Balaji T K
Check for set block count command fails always since host-cmd is set to NULL in the same function incorrectly. Correct host-cmd usage properly. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/6] mmc: omap_hsmmc: use devm_clk_get

2014-05-09 Thread Balaji T K
With devm_clk_get conversion clk_put can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c

[PATCH v2 4/6] mmc: omap_hsmmc: use devm_ioremap_resource

2014-05-09 Thread Balaji T K
With devm_ioremap_resource conversion release_mem_region, iounmap can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 19 +-- 1 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c

[PATCH v2 0/6] mmc: omap_hsmmc: convert to use devm_* and fixes

2014-05-09 Thread Balaji T K
v2: use devm_ioremap_resource add cmd23 multiblock read/write fix Balaji T K (6): mmc: omap_hsmmc: use devm_clk_get mmc: omap_hsmmc: use devm_request_irq mmc: omap_hsmmc: use devm_request_threaded_irq mmc: omap_hsmmc: use devm_ioremap_resource mmc: omap_hsmmc: fix cmd23 multiblock read

[PATCH v2 2/6] mmc: omap_hsmmc: use devm_request_irq

2014-05-09 Thread Balaji T K
With devm_request_irq conversion free_irq can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH v2 6/6] mmc: omap_hsmmc: split omap-dma header file

2014-05-09 Thread Balaji T K
...@arm.linux.org.uk Cc: Tony Lindgren t...@atomide.com Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |2 +- include/linux/omap-dma.h | 19 +-- include/linux/omap-dmaengine.h | 21 + 3 files changed, 23 insertions(+), 19

Re: [PATCH v11 2/7] mmc: omap_hsmmc: Enable SDIO interrupt

2014-05-09 Thread Balaji T K
;a=commitdiff_plain;h=010810d22f6f49ac03da4ba384969432e0320453 [2] http://comments.gmane.org/gmane.linux.kernel.mmc/20446 Cc: Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Hi Andreas, Thanks for the new patch series. Minor nit below

Re: [PATCH v11 4/7] mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state

2014-05-09 Thread Balaji T K
On Friday 09 May 2014 04:50 AM, Andreas Fenkart wrote: Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com Looks good to me Acked-by: Balaji T K balaj...@ti.com diff --git

Re: [PATCH v11 7/7] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-05-09 Thread Balaji T K
will still happen through the IP block. Idea of remuxing the pins by Tony Lindgren. Code contributions from Tony Lindgren and Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Conflicts: drivers/mmc/host/omap_hsmmc.c

Re: [PATCH v11 6/7] mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks

2014-05-09 Thread Balaji T K
/log/?id=refs/heads/mmc-next Other than that: Acked-by: Balaji T K balaj...@ti.com @@ -2258,11 +2257,6 @@ static int omap_hsmmc_probe(struct platform_device *pdev) omap_hsmmc_disable_irq(host); - pinctrl = devm_pinctrl_get_select_default(pdev-dev); - if (IS_ERR(pinctrl

Re: [PATCH v11 5/7] mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected

2014-05-09 Thread Balaji T K
off, the irq handler will continue and cause a SIGBUS on the first register access. Signed-off-by: Andreas Fenkart afenk...@gmail.com Acked-by: Balaji T K balaj...@ti.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 14857d7..47a5982 100644 --- a/drivers/mmc

Re: [PATCH v10 5/5] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-05-02 Thread Balaji T K
will still happen through the IP block. Idea of remuxing the pins by Tony Lindgren. Code contributions from Tony Lindgren and Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Thanks Andreas for the patch series. Few comments

Re: [PATCH v10 4/5] mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks

2014-05-02 Thread Balaji T K
On Monday 28 April 2014 01:10 PM, Andreas Fenkart wrote: These are predefined states of the driver model. When not present, as if not set in the device tree, they simple become no-ops. So it is always safe to call them. This is not the simplest implementation, on AM335x at least, we could witch

Re: [PATCH v10 2/5] mmc: omap_hsmmc: bug: abort runtime suspend if pending sdio irq detected

2014-05-02 Thread Balaji T K
On Monday 28 April 2014 01:10 PM, Andreas Fenkart wrote: on multicores, an sdio irq handler could be running in parallel to runtime suspend. In the worst case it could be waiting for the spinlock held by the runtime suspend. When runtime suspend is complete and the functional clock (fclk) turned

Re: [PATCH v10 1/5] mmc: omap_hsmmc: Enable SDIO interrupt

2014-05-02 Thread Balaji T K
;a=commitdiff_plain;h=010810d22f6f49ac03da4ba384969432e0320453 [2] http://comments.gmane.org/gmane.linux.kernel.mmc/20446 Cc: Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

Re: [PATCH 9/9] mmc: omap_hsmmc: enable wakeup event for sdio

2014-05-02 Thread Balaji T K
On Friday 21 March 2014 09:47 PM, Balaji T K wrote: To detect sdio irqs properly without spurious events, OMAP4 needs IWE in CON and CTPL, CLKEXTFREE in HCTL to be set Signed-off-by: Balaji T K balaj...@ti.com Hi Andreas, Can you please test this patch on top of your current(v10) series

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-24 Thread Balaji T K
On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote: Hi, this series lets us access the newer registers introduced back in OMAP4 which give us some valid information about the OMAP HSMMC IP like max block size, support for ADMA, support for Retention. Support for Retention looks

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-24 Thread Balaji T K
On Thursday 24 April 2014 08:09 PM, Felipe Balbi wrote: On Thu, Apr 24, 2014 at 08:01:19PM +0530, Balaji T K wrote: On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote: Hi, this series lets us access the newer registers introduced back in OMAP4 which give us some valid information about

Re: [PATCH 3/5] mmc: host: omap_hsmmc: introduce new accessor functions

2014-04-24 Thread Balaji T K
On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote: we introduce new accessors which provide for register access with and without offsets. This is just to make sure newer versions of the IP can access the new registers prepended at the beginning of the address space. Signed-off-by: Felipe

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-24 Thread Balaji T K
On Tuesday 22 April 2014 09:18 PM, Felipe Balbi wrote: Hi, On Tue, Apr 22, 2014 at 09:00:12PM +0530, Balaji T K wrote: On Monday 21 April 2014 11:02 PM, Felipe Balbi wrote: Hi, On Wed, Mar 26, 2014 at 07:04:45PM -0500, Felipe Balbi wrote: this series lets us access the newer registers

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-22 Thread Balaji T K
On Monday 21 April 2014 11:02 PM, Felipe Balbi wrote: Hi, On Wed, Mar 26, 2014 at 07:04:45PM -0500, Felipe Balbi wrote: this series lets us access the newer registers introduced back in OMAP4 which give us some valid information about the OMAP HSMMC IP like max block size, support for ADMA,

Re: OMAP baseline test results for v3.14

2014-04-03 Thread Balaji T K
e002264f7e45d7661b237045577052fd0b40f89c Author: Balaji T K balajitk at ti.com Date: Mon Oct 21 00:25:18 2013 +0530 mmc: omap_hsmmc: Fix pbias_disable for omap4 pbias_disable is set to protect the mmc pbias i/o cells in DT boot by preventing voltage switch. Currently

Re: [PATCH 6/9] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-25 Thread Balaji T K
ulf.hans...@linaro.org: On 21 March 2014 17:17, Balaji T K balaj...@ti.com wrote: From: Andreas Fenkart afenk...@gmail.com There have been various patches floating around for enabling the SDIO IRQ for hsmmc, but none of them ever got merged. Probably the reason for not merging the SDIO interrupt

Re: [PATCH v9 resend 1/3] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-21 Thread Balaji T K
On Friday 21 March 2014 05:50 PM, Andreas Fenkart wrote: Thanks Andreas for the patch series I rebased against latest mmc-next, made few changes to your patch. I have hosted your series along with devm cleanups on a branch[1] for testing [1]

[PATCH 1/9] mmc: omap_hsmmc: use devm_clk_get

2014-03-21 Thread Balaji T K
With devm_clk_get conversion clk_put can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c

[PATCH 2/9] mmc: omap_hsmmc: use devm_request_irq

2014-03-21 Thread Balaji T K
With devm_request_irq conversion free_irq can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH 0/9] mmc: omap_hsmmc: convert to use devm_* and enable sdio irq

2014-03-21 Thread Balaji T K
Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO interrupt mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux Balaji T K (6): mmc: omap_hsmmc: use devm_clk_get mmc: omap_hsmmc: use devm_request_irq

[PATCH 3/9] mmc: omap_hsmmc: use devm_request_threaded_irq

2014-03-21 Thread Balaji T K
With devm_request_threaded_irq conversion free_irq can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

[PATCH 5/9] mmc: omap_hsmmc: use devm_ioremap

2014-03-21 Thread Balaji T K
With devm_ioremap conversion iounmap can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 9952673

[PATCH 6/9] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-21 Thread Balaji T K
Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 207 ++-- include/linux/platform_data/mmc-omap.h |1 + 2 files changed, 196 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

[PATCH 4/9] mmc: omap_hsmmc: use devm_request_mem_region

2014-03-21 Thread Balaji T K
With devm_request_mem_region conversion release_mem_region can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc

[PATCH 7/9] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-03-21 Thread Balaji T K
through the IP block. Idea of remuxing the pins and some minor changes by Tony Lindgren. Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Signed-off-by: Balaji T K balaj...@ti.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 50

[PATCH 8/9] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux

2014-03-21 Thread Balaji T K
From: Andreas Fenkart afenk...@gmail.com Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Signed-off-by: Balaji T K balaj...@ti.com

[PATCH 9/9] mmc: omap_hsmmc: enable wakeup event for sdio

2014-03-21 Thread Balaji T K
To detect sdio irqs properly without spurious events, OMAP4 needs IWE in CON and CTPL, CLKEXTFREE in HCTL to be set Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host

Re: [PATCH 4/9] mmc: omap_hsmmc: use devm_request_mem_region

2014-03-21 Thread Balaji T K
On Friday 21 March 2014 09:48 PM, Felipe Balbi wrote: On Fri, Mar 21, 2014 at 09:47:33PM +0530, Balaji T K wrote: With devm_request_mem_region conversion release_mem_region can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 11

Re: [PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-03-07 Thread Balaji T K
On Wednesday 05 March 2014 02:00 PM, Andreas Fenkart wrote: Hi, 2014-02-28 18:04 GMT+01:00 Balaji T K balaj...@ti.com: On Tuesday 25 February 2014 06:07 PM, Andreas Fenkart wrote: For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special

Re: [PATCH RESEND] mmc: omap_hsmmc: support more DT properties

2014-03-04 Thread Balaji T K
/devicetree/bindings/mmc/mmc.txt. Signed-off-by: Daniel Mack zon...@gmail.com Acked-by: Balaji T K balaj...@ti.com --- This is a resend of a patch that was already acked by Balaji T K: http://www.spinics.net/lists/linux-mmc/msg25029.html Hi Chris, To make it easier for you, I have collected

Re: [PATCH RESEND v11 6/7] ARM: OMAP: enable SYSCON and REGULATOR_PBIAS in omap2plus_defconfig

2014-03-03 Thread Balaji T K
On Wednesday 26 February 2014 10:31 PM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [140219 07:00]: Enable REGULATOR_PBIAS needed for SD card on most OMAPs. Signed-off-by: Balaji T K balaj...@ti.com I belive this is the only one missing my ack: Acked-by: Tony Lindgren t...@atomide.com

[PATCH 0/2] mmc: omap_hsmmc: checkpatch cleanup

2014-02-28 Thread Balaji T K
fixes for checkpatch warnings. Balaji T K (2): mmc: omap_hsmmc: fix return error code for of_get_hsmmc_pdata mmc: omap_hsmmc: remove redundant reset done drivers/mmc/host/omap_hsmmc.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) -- 1.7.5.4 -- To unsubscribe from

[PATCH 1/2] mmc: omap_hsmmc: fix return error code for of_get_hsmmc_pdata

2014-02-28 Thread Balaji T K
of_get_hsmmc_pdata returns a pointer, returning NULL is invalid, return ERR_PTR for error case. Signed-off-by: Balaji T K balaj...@ti.com Reported-by: Dan Carpenter dan.carpen...@oracle.com --- drivers/mmc/host/omap_hsmmc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/2] mmc: omap_hsmmc: remove redundant reset done

2014-02-28 Thread Balaji T K
Remove redundant reset done check since omap hwmod layer ensures IP reset. Signed-off-by: Balaji T K balaj...@ti.com Reported-by: Dan Carpenter dan.carpen...@oracle.com --- drivers/mmc/host/omap_hsmmc.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host

Re: [PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-02-28 Thread Balaji T K
, I see throughput in the range of KBs. Will give another try with Tony's version. Thanks and Regards, Balaji T K +static struct of_data omap4_data = { + .offset = 0x100, +}; +static struct of_data am33xx_data = { + .offset = 0x100, + .flags = OMAP_HSMMC_SWAKEUP_MISSING

Re: SD card timeout problems on Nokia N900 (omap_hsmmc on OMAP3)

2014-02-26 Thread Balaji T K
either Chris or Tony pick the whole series for 3.15 Couple of tested-by will surely help. Thanks and Regards, Balaji T K -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH RESEND v10 0/7] mmc: omap_hsmmc: pbias dt and cleanup

2014-02-26 Thread Balaji T K
On Wednesday 26 February 2014 07:34 PM, Florian Vaussard wrote: Hi, On 02/19/2014 03:56 PM, Balaji T K wrote: Few cleanups to reduce code indent, Add pbias_regulator support and adapt omap_hsmmc to use pbias regulator to configure required voltage on mmc1 pad(SD card) i/o rails on OMAP SoCs

Re: [PATCH V2 2/2] ARM: dts: omap3-ldp: fix mmc configuration

2014-02-20 Thread Balaji T K
that all relevant pins are configured for non-MMC boot mode. Signed-off-by: Nishanth Menon n...@ti.com looks good to me Acked-by: Balaji T K balaj...@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH RESEND v10 0/7] mmc: omap_hsmmc: pbias dt and cleanup

2014-02-19 Thread Balaji T K
Few cleanups to reduce code indent, Add pbias_regulator support and adapt omap_hsmmc to use pbias regulator to configure required voltage on mmc1 pad(SD card) i/o rails on OMAP SoCs. Balaji T K (7): mmc: omap_hsmmc: use devm_regulator API mmc: omap_hsmmc: handle vcc and vcc_aux independently

[PATCH RESEND v11 1/7] mmc: omap_hsmmc: use devm_regulator API

2014-02-19 Thread Balaji T K
Use devm_regulator API, while at it use devm_regulator_get_optional for optional vmmc_aux supply Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- drivers/mmc/host/omap_hsmmc.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH RESEND v11 6/7] ARM: OMAP: enable SYSCON and REGULATOR_PBIAS in omap2plus_defconfig

2014-02-19 Thread Balaji T K
Enable REGULATOR_PBIAS needed for SD card on most OMAPs. Signed-off-by: Balaji T K balaj...@ti.com --- arch/arm/configs/omap2plus_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index

[PATCH RESEND v11 4/7] mmc: omap_hsmmc: adapt hsmmc to use pbias regulator

2014-02-19 Thread Balaji T K
In DT case, PBAIS registers are programmed via regulator, use regulator APIs to control PBIAS. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/drivers/mmc

[PATCH RESEND v11 3/7] regulator: add pbias regulator support

2014-02-19 Thread Balaji T K
pbias register controls internal power supply to sd card i/o pads in most OMAPs (OMAP2-5, DRA7). Control bits for selecting voltage level and enabling/disabling are in the same PBIAS register. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com Acked-by: Mark Brown

[PATCH RESEND v11 7/7] mmc: omap_hsmmc: remove pbias workaround

2014-02-19 Thread Balaji T K
remove pbias workaround Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- drivers/mmc/host/omap_hsmmc.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c

[PATCH RESEND v11 5/7] ARM: dts: add pbias dt node

2014-02-19 Thread Balaji T K
Add pbias regulator node as a child of system control module - syscon. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/boot/dts/dra7.dtsi | 17 + arch/arm/boot/dts/omap2430.dtsi | 17 + arch/arm/boot/dts

[PATCH RESEND v11 2/7] mmc: omap_hsmmc: handle vcc and vcc_aux independently

2014-02-19 Thread Balaji T K
handle vcc and vcc_aux independently to reduce indent. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- drivers/mmc/host/omap_hsmmc.c | 54 +++-- 1 files changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers

Re: [PATCH] mmc: omap_hsmmc: support more DT properties

2014-02-18 Thread Balaji T K
/devicetree/bindings/mmc/mmc.txt. Signed-off-by: Daniel Mack zon...@gmail.com looks good to me Acked-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

Re: [PATCH V2 1/2] mmc: omap_hsmmc: Add support for quirky omap3 hsmmc controller

2014-02-18 Thread Balaji T K
-off-by: Nishanth Menon n...@ti.com looks good to me Acked-by: Balaji T K balaj...@ti.com --- Changes since v1: - new compatible flag as suggested by Tony which contains the relevant controller flag to work around the erratum V1: https://patchwork.kernel.org/patch/3514851

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-05 Thread Balaji T K
On Tuesday 04 February 2014 08:48 PM, Nishanth Menon wrote: On 02/04/2014 06:44 AM, Balaji T K wrote: On Tuesday 21 January 2014 04:59 AM, Nishanth Menon wrote: When device is booted using devicetree, platforms impacted by Erratum 2.1.1.128 is not detected easily in the mmc driver

Re: [PATCH v10 0/7] mmc: omap_hsmmc: pbias dt and cleanup

2014-02-04 Thread Balaji T K
On Monday 13 January 2014 09:06 PM, Balaji T K wrote: Few cleanups to reduce code indent, Add pbias_regulator support and adapt omap_hsmmc to use pbias regulator to configure required voltage on mmc1 pad(SD card) i/o rails on OMAP SoCs. Hi Tony, Considering the dependencies with regulator

Re: [PATCH/RFC] dmaengine: omap-dma: split header file

2014-02-04 Thread Balaji T K
On Friday 24 January 2014 10:21 PM, Balaji T K wrote: To Resolve build failure seen with sh-allmodconfig: include/linux/omap-dma.h:171:8: error: expected identifier before numeric constant make[4]: *** [drivers/mmc/host/omap_hsmmc.o] Error 1 due to CCR redefinition, move dmaengine

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-04 Thread Balaji T K
reads Rather than ti,errata.. specific property, something like caps no/disable multiblock read is more readable in my opinion, Otherwise Acked-by: Balaji T K balaj...@ti.com Examples: diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 014bfe5..f2d5940 100644

Re: [PATCH] ARM: dts: omap3-ldp: fix mmc configuration

2014-02-04 Thread Balaji T K
, Balaji T K to ensure that all relevant pins are configured for non-MMC boot mode. Signed-off-by: Nishanth Menon n...@ti.com --- ti,erratum-2.1.1.128 introduced in https://patchwork.kernel.org/patch/3514851/ hence depends on the same. arch/arm/boot/dts/omap3-ldp.dts | 22 ++ 1

Re: [patch 1/2] mmc: omap_hsmmc: remove a duplicative test

2014-01-30 Thread Balaji T K
On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote: Static checkers complain that testing for both next and !next is duplicative. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Looks good to me Acked-by: Balaji T K balaj...@ti.com diff --git a/drivers/mmc/host/omap_hsmmc.c b

Re: [patch 2/2] mmc: omap_hsmmc: checking for ERR_PTR instead of NULL

2014-01-30 Thread Balaji T K
On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote: The of_get_hsmmc_pdata() function returns NULL on error, it doesn't return ERR_PTRs. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

Re: [patch] mmc: omap_hsmmc: precedence bug in omap_hsmmc_context_restore()

2014-01-30 Thread Balaji T K
On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote: On Thu, Aug 22, 2013 at 08:16:28PM +0530, Balaji T K wrote: On Thursday 22 August 2013 06:26 PM, Dan Carpenter wrote: '!' has higher precedence than '' so this doesn't work as intended although since RESETDONE is 1 it would work

[PATCH/RFC] dmaengine: omap-dma: split header file

2014-01-24 Thread Balaji T K
-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |2 +- include/linux/omap-dma.h | 19 +-- include/linux/omap-dmaengine.h | 21 + 3 files changed, 23 insertions(+), 19 deletions

Re: [PATCH/RFC] dmaengine: omap-dma: split header file

2014-01-24 Thread Balaji T K
On Friday 24 January 2014 10:21 PM, Balaji T K wrote: To Resolve build failure seen with sh-allmodconfig: include/linux/omap-dma.h:171:8: error: expected identifier before numeric constant make[4]: *** [drivers/mmc/host/omap_hsmmc.o] Error 1 due to CCR redefinition, move dmaengine

[PATCH 4/5] mmc: omap_hsmmc: add cmd23 support

2014-01-21 Thread Balaji T K
Add set block count command support for close ended multiblock read/write. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 21 + 1 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

[PATCH 5/5] mmc: omap_hsmmc: add autocmd23 support

2014-01-21 Thread Balaji T K
Add support for autocmd23 support Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 39 --- 1 files changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH 0/5] mmc: omap_hsmmc: add support for set block count

2014-01-21 Thread Balaji T K
Balaji T K (5): mmc: omap_hsmmc: save clock rate to use in interrupt context mmc: omap_hsmmc: fix request done for sbc error case mmc: omap_hsmmc: split dma setup mmc: omap_hsmmc: add cmd23 support mmc: omap_hsmmc: add autocmd23 support drivers/mmc/host/omap_hsmmc.c | 88

[PATCH 2/5] mmc: omap_hsmmc: fix request done for sbc error case

2014-01-21 Thread Balaji T K
mrq is not populated for set block count(cmd23) command. Use block read/write mmc_commond pointer for request done and avoid NULL pointer access in error case for sbc (cmd23). Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |2 +- 1 files changed, 1 insertions

[PATCH 1/5] mmc: omap_hsmmc: save clock rate to use in interrupt context

2014-01-21 Thread Balaji T K
clk_get_rate throws DEBUG_LOCKS_WARN_ON(in_interrupt()) warning if called from interrupt context. use cached clock rate in set_data_timeout, so that set_data_timeout can be called from interrupt context. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c |4 +++- 1

[PATCH 3/5] mmc: omap_hsmmc: split dma setup

2014-01-21 Thread Balaji T K
split start dma function into setup and start dma to keep track of host_cookie when cmd23 support is enabled along with async request. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 26 ++ 1 files changed, 18 insertions(+), 8 deletions

Re: Multiple CCR definitions

2014-01-17 Thread Balaji T K
...@ti.com Acked-by: Felipe Balbi ba...@ti.com Acked-by: Balaji T K balaj...@ti.com Signed-off-by: Chris Ball c...@laptop.org --- drivers/mmc/host/Kconfig |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index

Re: [PATCH 0/3] ARM: dts: am43x/am335x-evm: add SD card hotplug support

2014-01-15 Thread Balaji T K
On Friday 27 December 2013 09:59 PM, Balaji T K wrote: Balaji T K (3): ARM: dts: am335x-evm: add SD card hotplug support ARM: dts: am335x-evmsk: add SD card hotplug support ARM: dts: am43x-epos-evm: add SD card hotplug support arch/arm/boot/dts/am335x-evm.dts |9

Re: [PATCH v10 5/7] ARM: dts: add pbias dt node

2014-01-15 Thread Balaji T K
On Monday 13 January 2014 09:06 PM, Balaji T K wrote: Add pbias regulator node as a child of system control module - syscon. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com Hi Benoit, Gentle Ping, Let me know if you have any comments. --- arch/arm/boot

Re: [PATCH v9 4/7] mmc: omap_hsmmc: adapt hsmmc to use pbias regulator

2014-01-13 Thread Balaji T K
On Friday 10 January 2014 11:51 PM, Michael Trimarchi wrote: Hi On Fri, Jan 10, 2014 at 6:30 PM, Balaji T K balaj...@ti.com wrote: In DT case, PBAIS registers are programmed via regulator, use regulator APIs to control PBIAS. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host

[PATCH v10 0/7] mmc: omap_hsmmc: pbias dt and cleanup

2014-01-13 Thread Balaji T K
Few cleanups to reduce code indent, Add pbias_regulator support and adapt omap_hsmmc to use pbias regulator to configure required voltage on mmc1 pad(SD card) i/o rails on OMAP SoCs. Balaji T K (7): mmc: omap_hsmmc: use devm_regulator API mmc: omap_hsmmc: handle vcc and vcc_aux independently

[PATCH v10 1/7] mmc: omap_hsmmc: use devm_regulator API

2014-01-13 Thread Balaji T K
Use devm_regulator API, while at it use devm_regulator_get_optional for optional vmmc_aux supply Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- drivers/mmc/host/omap_hsmmc.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v10 2/7] mmc: omap_hsmmc: handle vcc and vcc_aux independently

2014-01-13 Thread Balaji T K
handle vcc and vcc_aux independently to reduce indent. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- drivers/mmc/host/omap_hsmmc.c | 54 +++-- 1 files changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers

[PATCH v10 3/7] regulator: add pbias regulator support

2014-01-13 Thread Balaji T K
pbias register controls internal power supply to sd card i/o pads in most OMAPs (OMAP2-5, DRA7). Control bits for selecting voltage level and enabling/disabling are in the same PBIAS register. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com Acked-by: Mark Brown

[PATCH v10 4/7] mmc: omap_hsmmc: adapt hsmmc to use pbias regulator

2014-01-13 Thread Balaji T K
In DT case, PBAIS registers are programmed via regulator, use regulator APIs to control PBIAS. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/drivers/mmc

[PATCH v10 6/7] ARM: OMAP: enable SYSCON and REGULATOR_PBIAS in omap2plus_defconfig

2014-01-13 Thread Balaji T K
Enable REGULATOR_PBIAS needed for SD card on most OMAPs. Signed-off-by: Balaji T K balaj...@ti.com --- arch/arm/configs/omap2plus_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index

[PATCH v10 5/7] ARM: dts: add pbias dt node

2014-01-13 Thread Balaji T K
Add pbias regulator node as a child of system control module - syscon. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/boot/dts/dra7.dtsi | 17 + arch/arm/boot/dts/omap2430.dtsi | 17 + arch/arm/boot/dts

[PATCH v10 7/7] mmc: omap_hsmmc: remove pbias workaround

2014-01-13 Thread Balaji T K
remove pbias workaround Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- drivers/mmc/host/omap_hsmmc.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c

Re: [PATCH v8 1/7] mmc: omap_hsmmc: use devm_regulator API

2014-01-10 Thread Balaji T K
On Thursday 09 January 2014 08:48 PM, Felipe Balbi wrote: Hi, On Thu, Jan 09, 2014 at 08:20:56PM +0530, Balaji T K wrote: Use devm_regulator API, while at it use devm_regulator_get_optional for optional vmmc_aux supply Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t

Re: [PATCH v7 5/7] ARM: dts: add pbias dt node

2014-01-10 Thread Balaji T K
On Friday 10 January 2014 05:02 PM, Mark Rutland wrote: On Wed, Jan 08, 2014 at 02:51:46PM +, Balaji T K wrote: On Tuesday 07 January 2014 05:53 PM, Balaji T K wrote: On Tuesday 07 January 2014 04:27 PM, Mark Rutland wrote: On Tue, Jan 07, 2014 at 10:18:15AM +, Balaji T K wrote

[PATCH v9 0/7] mmc: omap_hsmmc: pbias dt and cleanup

2014-01-10 Thread Balaji T K
Few cleanups to reduce code indent, Add pbias_regulator support and adapt omap_hsmmc to use pbias regulator to configure required voltage on mmc1 pad(SD card) i/o rails on OMAP SoCs. v9 changes: remove simple-bus, add phandle for syscon in dt node Balaji T K (7): mmc: omap_hsmmc: use

[PATCH v9 5/7] ARM: dts: add pbias dt node

2014-01-10 Thread Balaji T K
Add pbias regulator node as a child of system control module - syscon. Signed-off-by: Balaji T K balaj...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/boot/dts/dra7.dtsi | 17 + arch/arm/boot/dts/omap2430.dtsi | 17 + arch/arm/boot/dts

  1   2   3   4   >