Replace the regular kzalloc and ioremap with the devm_ equivalent
to simplify error handling.
Add the missing devm_request_mem_region to reserve the region used
by the driver.
Signed-off-by: Benoit Cousson
Cc: Tarun Kanti DebBarma
---
drivers/gpio/gpio-omap.c | 35
b/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.4/dt_gpio
Regards,
Benoit
[1] http://www.spinics.net/lists/linux-omap/msg64694.html
Benoit Cousson (6):
gpio/omap: Remove bank->id information and misc cleanup
gpio/omap: Use devm_ API and add request_mem_region
gpio/omap: Add DT su
Hi Tony,
Here are a couple of DTS files updates for 3.4.
Vaibhav sent a couple more DTS but they are still pending Grant's Acked-by.
Thanks,
Benoit
The following changes since commit b01543dfe67bb1d191998e90d20534dc354de059:
Linus Torvalds (1):
Linux 3.3-rc4
are available i
On 2/22/2012 7:29 PM, Stephen Warren wrote:
Rob Herring wrote at Wednesday, February 22, 2012 10:23 AM:
On 02/22/2012 08:31 AM, Cousson, Benoit wrote:
On 2/22/2012 3:23 PM, Rob Herring wrote:
On 02/15/2012 10:04 AM, Benoit Cousson wrote:
Adapt the GPIO driver to retrieve information from a
On 2/24/2012 4:09 PM, DebBarma, Tarun Kanti wrote:
Hi Benoit,
On Fri, Feb 24, 2012 at 7:26 PM, Cousson, Benoit wrote:
On 2/24/2012 2:53 PM, DebBarma, Tarun Kanti wrote:
On Fri, Feb 24, 2012 at 7:02 PM, Cousson, Benoitwrote:
On 2/24/2012 2:24 PM, DebBarma, Tarun Kanti wrote:
Hi
On 2/24/2012 3:14 PM, Rob Herring wrote:
On 02/23/2012 04:46 PM, Cousson, Benoit wrote:
...
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index bc2bd69..afef0f7 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -93,6 +93,11 @@ struct gpio_bank
Salut Paul,
On 2/21/2012 11:02 PM, Paul Walmsley wrote:
Salut Benoît,
On Mon, 20 Feb 2012, Cousson, Benoit wrote:
3.3-rc4 is broken in the DT case because of the serial driver. And it
looks like it is due to this fix. We cannot rely on pdata anymore in
DT, and in that case it leads to an
On 2/24/2012 2:53 PM, DebBarma, Tarun Kanti wrote:
On Fri, Feb 24, 2012 at 7:02 PM, Cousson, Benoit wrote:
On 2/24/2012 2:24 PM, DebBarma, Tarun Kanti wrote:
Hi Benoit,
On Fri, Feb 24, 2012 at 4:07 PM, DebBarma, Tarun Kanti
wrote:
On Fri, Feb 24, 2012 at 3:41 PM, Cousson, Benoit
On 2/24/2012 2:24 PM, DebBarma, Tarun Kanti wrote:
Hi Benoit,
On Fri, Feb 24, 2012 at 4:07 PM, DebBarma, Tarun Kanti
wrote:
On Fri, Feb 24, 2012 at 3:41 PM, Cousson, Benoit wrote:
+ Tarun
On 2/24/2012 12:08 AM, Tony Lindgren wrote:
* Cousson, Benoit[120223 14:14]:
The GPIO driver
On 2/24/2012 1:58 PM, Rajendra Nayak wrote:
On Friday 24 February 2012 06:21 PM, Cousson, Benoit wrote:
On 2/24/2012 12:35 PM, Rajendra Nayak wrote:
On Friday 24 February 2012 05:02 PM, T Krishnamoorthy, Balaji wrote:
On Thu, Feb 23, 2012 at 5:31 PM, Rajendra Nayak wrote:
...
+Required
hink of some
common compatible string without causing confusion.
It depends, can we detect that using HW revision?
In that case, there is no need to differentiate again with compatible.
Regards,
Benoit
+ Should be "ti,omap4-hsmmc", for OMAP4 controllers
+- ti,hwmods: Must be "mmc
to identify the IP version, so since OMAP3 is
using OMAP2 IP, I do not think there is a need to add a new compatible
string for OMAP3. The should only be documented in the binding potentially.
The advantage is that that will avoid adding an extra compatible string
in the driver as well whereas t
On 2/24/2012 12:10 PM, Aneesh V wrote:
On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote:
Hi Aneesh,
[...]
+struct emif_data {
+ u8 duplicate;
+ u8 temperature_level;
+ u32 irq;
+ spinlock_t lock; /* lock to prevent races */
Nit: That comment is useless, since you already have
+ Tarun
On 2/24/2012 12:08 AM, Tony Lindgren wrote:
* Cousson, Benoit [120223 14:14]:
The GPIO driver is still relying on internal OMAP IRQ defines that
are not relevant anymore if OMAP is built with SPARSE_IRQ.
Great :)
Please note that this patch is still RFC, because I do not know
how
fix might be broken for OMAP1 MPUIO case.
Signed-off-by: Benoit Cousson
---
Hi Tony,
Please note that this patch is still RFC, because I do not know how to fix
properly the ugly cpu_class_is_omap1 and the dependency with IH_MPUIO_BASE to
detect a MPUIO.
I'm still sending it, because
If CONFIG_SPARSE_IRQ is set, the irqdescs will be allocated with
NR_IRQS entries at boot time and thus will shift all the entries
allocated dynamically by irq_alloc_descs for nothing.
Set NR_IRQS to NR_IRQS_LEGACY if CONFIG_SPARSE_IRQ is set.
Signed-off-by: Benoit Cousson
---
arch/arm/plat
request an IRQ > 16.
Allocate the array using the fixed MAX_IRQS value (128).
Signed-off-by: Benoit Cousson
Cc: Santosh Shilimkar
---
arch/arm/mach-omap2/omap-wakeupgen.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c
b/arch/
not a real driver after this fix, and
will require a massive cleanup...
Signed-off-by: Benoit Cousson
---
arch/arm/mach-omap2/gpmc.c | 22 +++---
1 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index dfffbbf
-by: Benoit Cousson
---
arch/arm/plat-omap/include/plat/irqs-44xx.h | 144 ---
arch/arm/plat-omap/include/plat/irqs.h | 15 +++-
2 files changed, 12 insertions(+), 147 deletions(-)
delete mode 100644 arch/arm/plat-omap/include/plat/irqs-44xx.h
diff --git a/arch
equivalent.
Signed-off-by: Benoit Cousson
Cc: Santosh Shilimkar
---
arch/arm/mach-omap2/omap_l3_noc.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_l3_noc.c
b/arch/arm/mach-omap2/omap_l3_noc.c
index d15225f..46e44f4 100644
--- a/arch/arm/mach
when DT convertion will be done :-(
I started removing as well the IRQs definition header to start tracking
the bad drivers that still need to be cleaned or hwmod or DT adapted.
Regards,
Benoit
Benoit Cousson (5):
ARM: OMAP2+: l3_noc: Remove references to static IRQ defines
ARM: OMAP: irqs
.
Nit: The subject should be:
"ARM: OMAP4: hwmod data: Do not get DSP out of reset at boot time"
Regards,
Benoit
On Thu, Feb 23, 2012 at 6:51 PM, Tero Kristo wrote:
From: Rajendra Nayak
With no driver handling DSP/TESLA, if brought out of reset, it stays
active and does not asse
On 2/23/2012 4:51 PM, Nicolas Ferre wrote:
On 02/23/2012 11:03 AM, Cousson, Benoit :
Salut Nico,
Coucou Benoit ;-)
On 2/22/2012 11:59 AM, Nicolas Ferre wrote:
On 01/27/2012 06:29 PM, Cousson, Benoit :
Add some basic helpers to retrieve a DMA controller device_node
and the DMA request line
want to do that if you have something to do
during probe like enabling the clock in order to access the sub modules.
How about the actual panel devices. Above there's the "ti,tfp410"
device. The panel devices are not plain platform devices, so I need to
handle those myself. Can I so
Salut Nico,
On 2/22/2012 11:59 AM, Nicolas Ferre wrote:
On 01/27/2012 06:29 PM, Cousson, Benoit :
Add some basic helpers to retrieve a DMA controller device_node
and the DMA request line number.
For legacy reason another API will export the DMA request number
into a Linux resource of type
On 2/22/2012 3:23 PM, Rob Herring wrote:
On 02/15/2012 10:04 AM, Benoit Cousson wrote:
Adapt the GPIO driver to retrieve information from a DT file.
Allocate the irq_base dynamically and rename bank->virtual_irq_start
to bank->irq_base.
Change irq_base type to int instead of u16 to
these OMAP custom hooks
without pdata.
A basic fix (below) for the moment is to test for valid pdata inside the driver.
I'll repost it properly if you are fine with it.
Regards,
Benoit
---
>From af9f18e15e0ef0e227b3efa42489b7bd8a20c2a9 Mon Sep 17 00:00:00 2001
From: Benoit Cousson
Date:
On 2/17/2012 2:44 PM, Daniel Mack wrote:
> ping? Could anyone care for queueing this please?
There is no OMAP HSMMC dedicated maintainer anymore so I guess you should ping
Chris Ball .
Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
e only relevant name you can use.
As far as OMAP3 is concern, the power rails were named as well vdd1 and
vdd2, but it was so confusing that we changed that on OMAP4 and maybe on
3630 to vdd_mpu, vdd_iva and vdd_core.
So using this terminology for OMAP power rails is strongly recommended.
Hi Aneesh,
On 2/17/2012 2:26 PM, Aneesh V wrote:
On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote:
On 2/4/2012 1:16 PM, Aneesh V wrote:
[...]
+/**
+ * struct emif_data - Per device static data for driver's use
+ * @duplicate: Whether the DDR devices attached to this
that IP.
This is what SmartReflex is using for example.
Regards,
Benoit
sysc_type3:
| 3 2 | 10 |
| STDBYMODE | IDLEMODE |
So introduce new sysc_type3 in omap_hwmod common data.
Signed-off-by: Vaibhav Hiremath
Signed-off-by: Vaibhav Bedia
---
arch/arm/mach-omap2
Hi Tony,
Here is a small cleanup series to prepare for further DT series for 3.4.
Thanks,
Benoit
The following changes since commit d65b4e98d7ea3038b767b70fe8be959b2913f16d:
Linus Torvalds (1):
Linux 3.3-rc3
are available in the git repository at:
git://git.kernel.org/pub/scm
approach will
anyway be hacky and require centralized hard coded global GPIO number
like it is done for the IRQ so far.
Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
(&pdev->dev, "get_device_details() failure!!\n");
That's not a very good error message, isn't?
> + cleanup_emif(emif);
> + return NULL;
> +
> +out:
> + return emif;
> +}
> +
> +static int __init emif_probe(struct platform_device *pdev)
On 2/15/2012 7:13 PM, Tony Lindgren wrote:
> * Cousson, Benoit [120215 04:43]:
>> On 2/14/2012 8:52 PM, Tony Lindgren wrote:
>>> * Benoit Cousson [120213 07:59]:
>>>> Some .atag_offset entries were wrongly added during a merge conflict
>>>> resolution i
On 2/16/2012 9:22 AM, Tomi Valkeinen wrote:
On Wed, 2012-02-15 at 11:59 -0800, Kevin Hilman wrote:
"Cousson, Benoit" writes:
Kevin,
Do we still need to set the dev.parent to omap_device_parent?
Nope.
I guess the default&platform_bus parent is good enough and
poten
On 2/16/2012 6:53 AM, DebBarma, Tarun Kanti wrote:
On Wed, Feb 15, 2012 at 9:34 PM, Benoit Cousson wrote:
The driver does not need anymore any id to identify the GPIO instance.
Remove every occurence of the bank->id inside the driver.
Remove two trailing spaces.
Add a dev variable for bet
On 2/16/2012 7:37 AM, Shubhrajyoti wrote:
On Thursday 16 February 2012 11:11 AM, DebBarma, Tarun Kanti wrote:
Hi Benoit,
On Wed, Feb 15, 2012 at 9:34 PM, Benoit Cousson wrote:
Replace the regular kzalloc and ioremap with the devm_ equivalent
to simplify error handling.
Add the missing
On 2/15/2012 8:34 PM, Rob Herring wrote:
On 02/15/2012 11:37 AM, Benoit Cousson wrote:
Add device tree support to the OMAP2+ McSPI driver.
Add the bindings documentation.
Based on original code from Rajendra.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
Cc: Rajendra Nayak
On 2/15/2012 9:02 PM, Grant Likely wrote:
On Wed, Feb 15, 2012 at 06:37:35PM +0100, Benoit Cousson wrote:
Add the 4 McSPI controller nodes present in an OMAP4 device.
Remove SPI static device initialisation if DT is populated.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
---
arch/arm/boot
Add the 4 McSPI controller nodes present in an OMAP4 device.
Remove SPI static device initialisation if DT is populated.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
---
arch/arm/boot/dts/omap4.dtsi | 32
arch/arm/mach-omap2/devices.c |4 +++-
2 files
Add an ethernet SPI chip in the OMAP4 SDP/Blaze board DTS file.
Add a fixed regulator node controlled by a GPIO line to supply
the ethernet chip.
Based on original code from Rajendra.
Signed-off-by: Benoit Cousson
Signed-off-by: Rajendra Nayak
---
arch/arm/boot/dts/omap4-sdp.dts | 21
Add the 4 McSPI controller nodes present in an OMAP3 device.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
---
arch/arm/boot/dts/omap3.dtsi | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts
Add device tree support to the OMAP2+ McSPI driver.
Add the bindings documentation.
Based on original code from Rajendra.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
Cc: Rajendra Nayak
---
Documentation/devicetree/bindings/spi/omap-spi.txt | 20 +++
drivers/spi/spi-omap2-mcspi.c
nce:
git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.4/dt_spi_eth
Regards,
Benoit
Benoit Cousson (4):
spi/omap: Add DT support to McSPI driver
arm/dts: OMAP4: Add SPI controller nodes
arm/dts: OMAP3: Add SPI controller nodes
arm/dts: omap4-sdp: Add ks885
off-by: Benoit Cousson
Cc: Tarun Kanti DebBarma
---
.../devicetree/bindings/gpio/gpio-omap.txt | 30 +
drivers/gpio/gpio-omap.c | 121 ++--
2 files changed, 142 insertions(+), 9 deletions(-)
create mode 100644 Documentation/devicetree/bi
Add the 6 GPIOs controller nodes present in OMAP4.
Remove gpio static device initialisation if DT is populated.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
---
arch/arm/boot/dts/omap4.dtsi | 54 ++
arch/arm/mach-omap2/gpio.c |8 -
2 files
Add the 6 GPIOs controller nodes present in OMAP3.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
---
arch/arm/boot/dts/omap3.dtsi | 54 ++
1 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts
Replace the regular kzalloc and ioremap with the devm_ equivalent
to simplify error handling.
Add the missing devm_request_mem_region to reserve the region used
by the driver.
Signed-off-by: Benoit Cousson
Cc: Tarun Kanti DebBarma
---
drivers/gpio/gpio-omap.c | 35
The driver does not need anymore any id to identify the GPIO instance.
Remove every occurence of the bank->id inside the driver.
Remove two trailing spaces.
Add a dev variable for better readability in probe.
Remove unused variable bank->pbase.
Signed-off-by: Benoit Cousson
Cc: Tarun
s.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
for_3.4/gpio_cleanup_fixes_v9
This series is available here for reference:
git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.4/dt_gpio
Regards,
Benoit
Benoit Cousson (5):
gpio/omap: Remove ban
On 2/14/2012 9:52 PM, Grant Likely wrote:
On Tue, Feb 14, 2012 at 06:56:10PM +0100, Benoit Cousson wrote:
Add a function to initialize the OMAP2/3 interrupt controller (INTC)
using a device tree node.
This version take advantage of the new irq_domain_add_legacy API.
Replace some printk() with
On 2/14/2012 8:52 PM, Tony Lindgren wrote:
* Benoit Cousson [120213 07:59]:
Some .atag_offset entries were wrongly added during a merge conflict
resolution in 3.3.
Remove them all, since DT boot does not use that attribute anymore.
Replace as well the #if... by #ifdef for consistency.
How
On 2/14/2012 8:48 PM, Rob Herring wrote:
On 02/14/2012 11:56 AM, Benoit Cousson wrote:
Add a function to initialize the OMAP2/3 interrupt controller (INTC)
using a device tree node.
This version take advantage of the new irq_domain_add_legacy API.
Replace some printk() with the proper pr_
+ Kevin
On 2/15/2012 1:51 PM, Tomi Valkeinen wrote:
On Wed, 2012-02-15 at 13:35 +0100, Cousson, Benoit wrote:
I think that changing the device creation to change the dev->parent
should be pretty straightforward.
That's not possible with the current kernel, right?
We are n
On 2/15/2012 1:01 PM, Archit Taneja wrote:
On Tuesday 14 February 2012 09:11 PM, Cousson, Benoit wrote:
On 2/14/2012 2:30 PM, Archit Taneja wrote:
Hi,
On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote:
On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote:
Hi Tomi,
Benoit, do
Use the of_irq_init API introduced in 3.2 to handle
interrupt-controller with DT.
Update the irq_match table to map the proper XXX_of_init
functions for INTC and GIC drivers.
Signed-off-by: Benoit Cousson
Cc: Tony Lindgren
Acked-by: Rob Herring
Acked-by: Grant Likely
---
arch/arm/mach-omap2
Update the DTS with the proper information required by the
INTC bindings.
- Add the number of interrupt lines
- Add the reg and the compatible entries.
Signed-off-by: Benoit Cousson
Acked-by: Rob Herring
Acked-by: Grant Likely
---
arch/arm/boot/dts/omap3.dtsi |6 --
1 files changed
Add a function to initialize the OMAP2/3 interrupt controller (INTC)
using a device tree node.
This version take advantage of the new irq_domain_add_legacy API.
Replace some printk() with the proper pr_ macro.
Signed-off-by: Benoit Cousson
Cc: Tony Lindgren
Cc: Rob Herring
Cc: Grant Likely
The GIC binding was updated in 3.2 and expects 3 interrupt-cells.
- Update the #interrupt-cells
Signed-off-by: Benoit Cousson
Acked-by: Rob Herring
---
arch/arm/boot/dts/omap4.dtsi |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm
linux-2.6 irqdomain/next
The series is available here for reference:
git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.4/dt_irq_domain
Regards,
Benoit
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-January/079467.html
Benoit Cousson (4):
ar
On 2/14/2012 2:45 PM, Archit Taneja wrote:
On Tuesday 14 February 2012 07:03 PM, Tomi Valkeinen wrote:
On Tue, 2012-02-14 at 19:00 +0530, Archit Taneja wrote:
Hi,
On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote:
On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote:
Hi Tomi
On 2/14/2012 2:30 PM, Archit Taneja wrote:
Hi,
On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote:
On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote:
Hi Tomi,
Benoit, do you think we'll get the MODULEMODE mess cleaned up in the
hwmod/clk framework at some point, an
abled as the first display
would have correctly enabled the DSS clockdomain.
I think this looks fine, it's shouldn't have any side effects and is
easy to remove later.
Benoit, do you think we'll get the MODULEMODE mess cleaned up in the
hwmod/clk framework at some point, and the dr
+ Tomi
On 2/14/2012 1:06 PM, Russell King - ARM Linux wrote:
kautobuildv2 discovered this in its omap4430sdp oldconfig build:
drivers/video/omap2/dss/apply.c:350: warning: 'wait_pending_extra_info_updates'
defined but not used
This looks like a valid warning, because wait_pending_extra_info_u
This fix a similar problem as in 72092cc45378176ba700034c91b7af2db524df26
and 481a8199142c050b72bff8a1956a49fd0a75bbe0 ("can:
fix NOHZ local_softirq_pending 08 warning"). This fix replaces netif_rx()
with netif_rx_ni() which has to be used from process/softirq context.
Signed-off-
platforms.
Signed-off-by: Benoit Cousson
Cc: Tony Lindgren
---
arch/arm/plat-omap/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 734009a..e289dd2 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm
In the case of DT, the PMIC and SR initialization will be done using
a completely different mechanism.
Disable this part if a DT blob is available.
Signed-off-by: Benoit Cousson
Acked-by: Kevin Hilman
Acked-by: Rob Herring
Acked-by: Grant Likely
---
arch/arm/mach-omap2/pm.c |8
This warning becomes a little bit too verbose with the increase of
device nodes in some DTS files.
Change it to debug only.
Signed-off-by: Benoit Cousson
Cc: Kevin Hilman
---
arch/arm/plat-omap/omap_device.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm
Some .atag_offset entries were wrongly added during a merge conflict
resolution in 3.3.
Remove them all, since DT boot does not use that attribute anymore.
Replace as well the #if... by #ifdef for consistency.
Signed-off-by: Benoit Cousson
Cc: Tony Lindgren
---
arch/arm/mach-omap2/board
vice and thus we
did not create the hwmod entry for it.
And since we do not use the GPMC on OMAP4 boards, we did not have some
good way to test any change on this driver.
Do not hesitate to update that driver and add the DT support if you want:-)
Regards,
Benoit
--
To unsubscribe from this list:
On 2/9/2012 8:15 PM, Russell King - ARM Linux wrote:
On Thu, Feb 09, 2012 at 08:01:09PM +0100, Cousson, Benoit wrote:
If CONFIG_OF is not defined, the following error will happen.
arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error:
‘INT_34XX_PRCM_MPU_IRQ’ undeclared here (not in a function
#include in prm2xxx_3xxx.c to avoid depending
of that hidden dependency that should probably not exist in theory.
Signed-off-by: Benoit Cousson
---
arch/arm/mach-omap2/prm2xxx_3xxx.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c
b
undeclared here (not in a function)
Patch will follow.
Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2/7/2012 9:41 AM, Russell King - ARM Linux wrote:
On Tue, Feb 07, 2012 at 01:54:57AM +0100, Cousson, Benoit wrote:
Hi Russell,
On 2/7/2012 1:24 AM, Russell King - ARM Linux wrote:
On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote:
In theory that patch should not be even
Hi Mark,
On 2/7/2012 6:28 PM, Mark Brown wrote:
On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote:
The twl changes were done like that because it was assuming that
USE_OF and thus IRQ_DOMAIN will be enabled by default for all OMAP2+
platforms at 3.3 time. The whole point of
s like the OMAP fixes missed -rc2, but Tony sent the pull
request [1].
Regards,
Benoit
[1] http://www.spinics.net/lists/linux-omap/msg63564.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
Mor
On 2/7/2012 5:35 AM, Grant Likely wrote:
On Mon, Feb 6, 2012 at 5:24 PM, Russell King - ARM Linux
wrote:
On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote:
In theory that patch should not be even needed.
In theory that change is needed to fix the obviously broken code which
Hi Russell,
On 2/7/2012 1:24 AM, Russell King - ARM Linux wrote:
On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote:
In theory that patch should not be even needed.
In theory that change is needed to fix the obviously broken code which
is there at the moment.
Well, both
t of doing that was to reduce the ifdefery in every drivers we
have to adapt to DT.
You even pulled the patch to enable that a while back [1], but for some reason
it did not reach mainline in 3.3-rc1.
Since Rob is about to enable IRQ_DOMAIN for every ARM platforms, I'
o we need those funtions ?
These functions are called from the CPUIdle path so outside the scope of
the GPIO driver. These are part of a bunch of nasty PM hacks we are
doing in the CPU idle loop. We are in the process of getting rid of most
of them, but it looks like some are still needed.
mod_usage || !bank->loses_context)
continue;
pm_runtime_get_sync(bank->dev);
}
}
I don't know if there is some reason to not use driver_for_each_device.
Kevin,
Do we have any constraint inside omap_sram_idle to not use the device
iterator?
Regards,
Benoit
--
vices respectively;
and these devices are considered under omap3 family.
Signed-off-by: Vaibhav Hiremath
Cc: Benoit Cousson
Cc: Grant Likely
Cc: Tony Lindgren
Applied, thanks.
Benoit and/or Grant,
Can you also pull-in/merge all other patches which I had submitted recently?
I can pull the
On 2/2/2012 9:45 AM, Russell King - ARM Linux wrote:
> On Wed, Feb 01, 2012 at 11:50:30AM +0100, Cousson, Benoit wrote:
>> Hi Russell,
>>
>> On 2/1/2012 12:09 AM, Russell King - ARM Linux wrote:
>>> On Sat, Jan 28, 2012 at 11:06:02AM -0700, Grant Likely wrote:
>&
specifier that is needed for a simple DMA engine like the SDMA we have
inside OMAP. But the whole idea is to have a flexible enough mechanism
to allow any kind of specifier.
No more global linear number space like for IRQ!
Regards,
Benoit
--
To unsubscribe from this list: send the line &q
Hi Grant,
On 1/28/2012 7:06 PM, Grant Likely wrote:
On Fri, Jan 27, 2012 at 06:29:22PM +0100, Cousson, Benoit wrote:
Add some basic helpers to retrieve a DMA controller device_node
and the DMA request line number.
For legacy reason another API will export the DMA request number
into a Linux
On 1/31/2012 9:14 AM, Paul Walmsley wrote:
Hi
On Tue, 31 Jan 2012, Cousson, Benoit wrote:
Thanks to the L3 log error:
[0.838439] L3 custom error: MASTER:DucatiM3 TARGET:GPMC
I guess that I understand why I was not releasing the hardreset at boot time
before:-)
DSP and CortexM3 cannot be
n this case are trying to access an area that is not
accessible.
We have to let the driver handle the hardreset because it is mainly used
for processors.
Sorry Paul for having mislead you here.
Regards,
Benoit
Kevin
Uncompressing Linux... done, booting the kernel.
Warning: Neithe
On 1/27/2012 7:13 PM, Stephen Warren wrote:
Cousson, Benoit wrote at Friday, January 27, 2012 10:29 AM:
Add some basic helpers to retrieve a DMA controller device_node
and the DMA request line number.
For legacy reason another API will export the DMA request number
into a Linux resource of
Add the DMA controller node.
Add the dma-request attributes for the OMAP4 I2C controllers.
Signed-off-by: Benoit Cousson
Cc: Grant Likely
Cc: Rob Herring
---
arch/arm/boot/dts/omap4.dtsi | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts
Add some basic helpers to retrieve a DMA controller device_node
and the DMA request line number.
For legacy reason another API will export the DMA request number
into a Linux resource of type IORESOURCE_DMA.
This API is usable only on system with an unique DMA controller.
Signed-off-by: Benoit
93ed55441245a39e3935f5cf1af3e22febcce905
Thomas Abraham
DMA: PL330: Add device tree support
That generic DMA support is indeed pretty basic for the moment, but I
think it can still help a couple of platforms.
Comments are welcome.
Thanks,
Benoit
Benoit Cousson (2):
of: Add generic
DPLLs in theory if we want to
be consistent.
Hopefully, the information is available in the data source, so this is
just a matter of printing it in the DPLL node template.
Regards,
Benoit
Also could you please cc linux-arm-ker...@lists.infradead.org?
- Paul
On Fri, Jan 20, 2012 at 11:53 AM
multiplier factor (2 to 4095)
DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)
Acked-by: Benoit Cousson
Signed-off-by: Ameya Palande
Have the scripts been updated?
No not yet. The easy fix I was thinking about is to replace this define
by the hexa value of the mask. I can extract directly from
On 1/25/2012 7:13 PM, Jean Pihet wrote:
Hi Benoit,
On Wed, Jan 25, 2012 at 6:53 PM, Cousson, Benoit wrote:
Salut Jean,
On 1/25/2012 4:16 PM, Jean Pihet wrote:
From: Nishanth Menon
This reverts commit b6be18f0bab68ed304ebbb2d787d1c36237eda62.
That weird, because you revert a patch you
looks like gerrit leftover that should not be there.
I guess that path #3 and #5 should just be removed.
Regards,
Benoit
Signed-off-by: Nishanth Menon
Signed-off-by: Jean Pihet
---
arch/arm/mach-omap2/smartreflex.c | 90 -
1 files changed, 0 insertions(+
+ Mike
On 1/19/2012 12:39 AM, Ameya Palande wrote:
Signed-off-by: Ameya Palande
Assuming that you will re-send with Kevin's comment taken into account,
the fix is indeed very valid.
Acked-by: Benoit Cousson
---
arch/arm/mach-omap2/clock44xx_data.c |4 ++--
1 files chang
t omap_drm_platform_data {
+ struct omap_kms_platform_data *kms_pdata;
+ struct omap_dmm_platform_data *dmm_pdata;
+};
Since the dmm_platform_data should not exist in theory, it should not be
used by this structure either.
Where is the driver that will use these devices?
Regards,
Benoit
-
gned-off-by: Vaibhav Hiremath
Cc: Benoit Cousson
Cc: Grant Likely
Cc: Tony Lindgren
---
arch/arm/boot/dts/omap3-evm.dts | 28
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-evm.dts b/arch/arm/boot/dts/omap3-evm.dts
index 2ee
to sent it during -rc phase.
That being said, this will be valid for OMAP2+ only and will still break
OMAP1 platform :-(
Tony reported that 2 days ago, and I sent the fix for it.
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg61520.html
It is now waiting for Ben's Acked-by.
Rega
701 - 800 of 1974 matches
Mail list logo
