Re: [PATCH 04/30] ARM: omap: add missing __devexit_p() annotations

2011-10-02 Thread Bjarne Steinsbo
is not right with the workflow when bugs are identified, patches are submitted, then ignored, only for someone else to fix the same bug. Enough said. Best regards, Bjarne Steinsbo On Sun, Oct 2, 2011 at 4:45 PM, Arnd Bergmann a...@arndb.de wrote: Drivers that refer to a __devexit function

Re: [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init

2011-09-20 Thread Bjarne Steinsbo
Ref thread starting at http://marc.info/?l=linux-omapm=131316289211258w=2 Bjarne Steinsbo On Tue, Sep 20, 2011 at 10:50 AM, Axel Lin axel@gmail.com wrote: Current code calls omap4430_phy_init() twice in usb_musb_init(). Calling omap4430_phy_init() once is enough. This patch removes

Re: [PATCH] ARM: OMAP: Pointers to __devexit should be __devexit_p

2011-09-14 Thread Bjarne Steinsbo
I can't see this one queued up anywhere. Did it just slip through the cracks, or are there any problems with it? BR, Bjarne Steinsbo On Tue, Aug 16, 2011 at 4:33 PM, Bjarne Steinsbo bstein...@gmail.com wrote: Pointers to functions that are annotated as __devexit should be protected

Re: [PATCH 4/4] usb: musb: OMAP: Delete unused function

2011-09-14 Thread Bjarne Steinsbo
I can't see this one queued up anywhere. Did it just slip through the cracks, or are there any problems with it? BR, Bjarne Steinsbo On Tue, Aug 16, 2011 at 8:54 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Aug 12, 2011 at 05:28:26PM +0200, Bjarne Steinsbo wrote: Not in use anymore. Signed

Re: [PATCHv2 3/4] usb: musb: OMAP4430: Remove incorrect call to omap4430_phy_init()

2011-09-14 Thread Bjarne Steinsbo
I can't see this one queued up anywhere. Did it just slip through the cracks, or are there any problems with it? BR, Bjarne Steinsbo On Tue, Aug 16, 2011 at 8:54 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Aug 12, 2011 at 05:28:07PM +0200, Bjarne Steinsbo wrote: Don't call

Re: [PATCHv2 2/4] OMAP4: Keyboard: Fix section mismatch in the board file

2011-09-14 Thread Bjarne Steinsbo
I can't see this one queued up anywhere. Did it just slip through the cracks, or are there any problems with it? BR, Bjarne Steinsbo On Tue, Aug 16, 2011 at 8:53 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Aug 12, 2011 at 05:27:52PM +0200, Bjarne Steinsbo wrote: `keypad_pads' is referred

[PATCH] ARM: OMAP: Pointers to __devexit should be __devexit_p

2011-08-16 Thread Bjarne Steinsbo
Pointers to functions that are annotated as __devexit should be protected by the __devexit_p() macro. This fixes a build failure for OMAP when defined(CONFIG_SMP_ON_UP) !defined(CONFIG_DEBUG_SPINLOCK) Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- arch/arm/mach-omap2/smartreflex.c

[PATCH] ARM: mach-omap2: Kconfig: select SUSPEND and PM_SLEEP if PM for omap3

2011-08-14 Thread Bjarne Steinsbo
534. Since the code obviously assumes that PM_SLEEP should be defined if PM, change the omap2 Kconfig to reflect this. The existing selection of PM_OPP if PM serves as a precedent for this solution. When selecting PM_SLEEP, also select SUSPEND, which PM_SLEEP depends on. Signed-off-by: Bjarne

Re: [PATCH] ARM: mach-omap2: Kconfig: select SUSPEND and PM_SLEEP if PM for omap3

2011-08-14 Thread Bjarne Steinsbo
Forget this one. I did get this problem compiling a randconfig, but the explanation and the subsequent fix is incorrect. Sorry about the noise. Bjarne On Sun, Aug 14, 2011 at 6:41 PM, Bjarne Steinsbo bstein...@gmail.com wrote: It's conceivable to configure a kernel with CONFIG_PM, but without

[PATCHv2 0/4] Omap-related warnings compiling current mainline 3.1-rc tree

2011-08-12 Thread Bjarne Steinsbo
omap_dss_board_info. I can't see why one should be u32, and the other int. However, I don't know which to fix.. The resulting kernel has been booted on a pandaboard. Bjarne Steinsbo -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

[PATCHv2 1/4] OMAP4: clockdata: Make compiler shut up about possible uninitialized variable

2011-08-12 Thread Bjarne Steinsbo
Stop `warning: 'cpu_clkflg' may be used uninitialized in this function' from compiler. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/clock44xx_data.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach

[PATCHv2 2/4] OMAP4: Keyboard: Fix section mismatch in the board file

2011-08-12 Thread Bjarne Steinsbo
`keypad_pads' is referred to by `keypad_data' which is not __initdata, so `keypad_pads' should not be __initdata either. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/board-4430sdp.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCHv2 3/4] usb: musb: OMAP4430: Remove incorrect call to omap4430_phy_init()

2011-08-12 Thread Bjarne Steinsbo
Don't call omap4430_phy_init(dev) before dev is initialized. The real omap4430_phy_init(dev) call is done at the end of this function. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/usb-musb.c |3 --- 1 files changed, 0 insertions

Re: [PATCH 4/4] usb: musb: OMAP: Delete unused function

2011-08-12 Thread Bjarne Steinsbo
Not in use anymore. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/usb-musb.c | 38 -- 1 files changed, 0 insertions(+), 38 deletions(-) diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach

[PATCH 0/4] Omap-related warnings compiling current mainline 3.1-rc tree

2011-08-04 Thread Bjarne Steinsbo
is sufficient to make it compile, but probably not a complete fix for the problems introduced by the changes to cpu_idle. There is still a boot messages from lockdep pointing to cpu_idle. Bjarne Steinsbo 0001-cpuidle-fix-typos.patch Description: Binary data

[PATCH 1/4] OMAP4: clockdata: Make compiler shut up about possible uninitialized variable

2011-08-04 Thread Bjarne Steinsbo
Stop `warning: 'cpu_clkflg' may be used uninitialized in this function' from compiler. --- arch/arm/mach-omap2/clock44xx_data.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index

[PATCH 2/4] OMAP4: Keyboard: Fix section mismatch in the board file

2011-08-04 Thread Bjarne Steinsbo
`keypad_pads' is referred to by `keypad_data' which is not __initdata, so `keypad_pads' should not be __initdata either. --- arch/arm/mach-omap2/board-4430sdp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-4430sdp.c

[PATCH 3/4] usb: musb: OMAP4430: Remove incorrect call to omap4430_phy_init()

2011-08-04 Thread Bjarne Steinsbo
Don't call omap4430_phy_init(dev) before dev is initialized. The real omap4430_phy_init(dev) call is done at the end of this function. --- arch/arm/mach-omap2/usb-musb.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/usb-musb.c

[PATCH 4/4] usb: musb: OMAP: Delete unused function

2011-08-04 Thread Bjarne Steinsbo
Not in use anymore. --- arch/arm/mach-omap2/usb-musb.c | 38 -- 1 files changed, 0 insertions(+), 38 deletions(-) diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c index 19e4dac..852d6e4 100644 --- a/arch/arm/mach-omap2/usb-musb.c