[PATCH v3] ARM: VExpress: Makefile: add armv7 flags for inline assmembly code compiling

2013-09-22 Thread Chen Gang
make: *** [arch/arm/mach-vexpress] Error 2 Signed-off-by: Chen Gang gang.c...@asianux.com --- arch/arm/mach-vexpress/Makefile |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-vexpress/Makefile b/arch/arm/mach-vexpress/Makefile index 36ea824..f224577 100644

Re: [PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start'

2013-08-23 Thread Chen Gang
On 08/23/2013 01:48 PM, Tony Lindgren wrote: * Chen Gang F T chen.gang.flying.transfor...@gmail.com [130822 02:08]: Hmm... I guess: for our case, what your meaning is fixes-none-urgent, not fixes-none-critical, is it correct ? :-) Right, that naming might be actually better :) Tony

Re: [PATCH] ARM: VExpress: Kconfig: avoid arm6 compatible for ARCH_VEXPRESS

2013-08-23 Thread Chen Gang
On 08/23/2013 01:51 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130822 20:20]: The related error: /tmp/ccOMIprI.s: Assembler messages: /tmp/ccOMIprI.s:507: Error: selected processor does not support ARM mode `isb ' /tmp/ccOMIprI.s:513: Error: selected processor does

Re: [PATCH] ARM: VExpress: Kconfig: avoid arm6 compatible for ARCH_VEXPRESS

2013-08-23 Thread Chen Gang
On 08/23/2013 03:02 PM, Chen Gang wrote: On 08/23/2013 01:51 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130822 20:20]: The related error: /tmp/ccOMIprI.s: Assembler messages: /tmp/ccOMIprI.s:507: Error: selected processor does not support ARM mode `isb ' /tmp

Re: [PATCH v2] ARM: VExpress: Makefile: add armv7 flags for inline assmembly code compiling

2013-08-23 Thread Chen Gang
On 08/23/2013 04:02 PM, Chen Gang wrote: When vexpress kernel is compiled for v6, it still can support armv7 instructions (hardware still support), so need let compiler know about it for related inline assembly code, or compiling will fail. Hmm... need change compiled for v6, it still can

[PATCH v2] ARM: VExpress: Makefile: add armv7 flags for inline assmembly code compiling

2013-08-23 Thread Chen Gang
: *** [arch/arm/mach-vexpress] Error 2 Signed-off-by: Chen Gang gang.c...@asianux.com --- arch/arm/mach-vexpress/Makefile |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-vexpress/Makefile b/arch/arm/mach-vexpress/Makefile index 36ea824..f224577 100644 --- a/arch

Re: [PATCH] ARM: OMAP2: remove useless variable 'ret'

2013-08-22 Thread Chen Gang
On 08/22/2013 03:17 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130821 01:39]: Remove useless variable 'ret', the related warning: arch/arm/mach-omap2/board-am3517crane.c:113:6: warning: unused variable ‘ret’ [-Wunused-variable] Thanks applying into omap-for-v3.12/fixes

Re: [PATCH] ARM: OMAP2: add type cast from 'unsigned' to 'signed'

2013-08-22 Thread Chen Gang
On 08/22/2013 03:14 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130821 01:34]: Need add type cast, or can not notice the failure. The related warning (allmodconfig, EXTRA_CFLAGS=-W): arch/arm/mach-omap2/gpmc.c:728:2: warning: comparison of unsigned expression 0 is always

Re: [PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start'

2013-08-22 Thread Chen Gang
On 08/22/2013 03:57 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130822 00:55]: 'gpmc_irq_start' is mostly used as 'int', and for a variable, do not suggest to only use 'unsigned' as its type, so use 'int' instead of 'unsigned' for variable 'gpmc_irq_start'. Also it will fix

[PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start'

2013-08-22 Thread Chen Gang
: comparison of unsigned expression 0 is always false [-Wtype-limits] Signed-off-by: Chen Gang gang.c...@asianux.com --- arch/arm/mach-omap2/gpmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index f3fdd6a..9f4795a

Re: [PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start'

2013-08-22 Thread Chen Gang F T
On 08/22/2013 04:32 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130822 01:10]: On 08/22/2013 03:57 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130822 00:55]: 'gpmc_irq_start' is mostly used as 'int', and for a variable, do not suggest to only use 'unsigned

Re: [Suggestion] ARM: allmodconfig: about cross compiling failure under i386 ubuntu.

2013-08-22 Thread Chen Gang
On 08/22/2013 03:45 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130821 01:53]: Hello Maintainers: When build arm with allmodconfig under ubuntu i386 with arm-linux- gnueabi-gcc 4.7, as 2.22, it report the errors. Please help check, thanks (the related config file

Re: [Suggestion] ARM: allmodconfig: about cross compiling failure under i386 ubuntu.

2013-08-22 Thread Chen Gang
On 08/22/2013 05:19 PM, Chen Gang wrote: On 08/22/2013 03:45 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130821 01:53]: Hello Maintainers: When build arm with allmodconfig under ubuntu i386 with arm-linux- gnueabi-gcc 4.7, as 2.22, it report the errors. Please help check

Re: [Suggestion] ARM: allmodconfig: about cross compiling failure under i386 ubuntu.

2013-08-22 Thread Chen Gang
On 08/22/2013 06:22 PM, Russell King - ARM Linux wrote: On Thu, Aug 22, 2013 at 12:45:24AM -0700, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130821 01:53]: Hello Maintainers: When build arm with allmodconfig under ubuntu i386 with arm-linux- gnueabi-gcc 4.7, as 2.22, it report

Re: [Suggestion] ARM: allmodconfig: about cross compiling failure under i386 ubuntu.

2013-08-22 Thread Chen Gang
On 08/23/2013 09:47 AM, Chen Gang wrote: On 08/22/2013 06:22 PM, Russell King - ARM Linux wrote: On Thu, Aug 22, 2013 at 12:45:24AM -0700, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130821 01:53]: Hello Maintainers: When build arm with allmodconfig under ubuntu i386 with arm

[PATCH] ARM: VExpress: Kconfig: avoid arm6 compatible for ARCH_VEXPRESS

2013-08-22 Thread Chen Gang
/ccOMIprI.s:590: Error: selected processor does not support ARM mode `isb ' /tmp/ccOMIprI.s:591: Error: selected processor does not support ARM mode `dsb ' make[1]: *** [arch/arm/mach-vexpress/dcscb.o] Error 1 make: *** [arch/arm/mach-vexpress] Error 2 Signed-off-by: Chen Gang gang.c

Re: [PATCH] ARM: VExpress: Kconfig: avoid arm6 compatible for ARCH_VEXPRESS

2013-08-22 Thread Chen Gang
On 08/23/2013 11:04 AM, Chen Gang wrote: ARCH_VEXPRESS isn't compatible with arm6 (not support -march=armv6k), so add dependency for it, or allmodconfig can not pass compiling. The related command: arm-linux-gnueabi-gcc -Wp,-MD,arch/arm/mach-vexpress/.dcscb.o.d -nostdinc -isystem /usr

[PATCH] ARM: OMAP2: add type cast from 'unsigned' to 'signed'

2013-08-21 Thread Chen Gang
Need add type cast, or can not notice the failure. The related warning (allmodconfig, EXTRA_CFLAGS=-W): arch/arm/mach-omap2/gpmc.c:728:2: warning: comparison of unsigned expression 0 is always false [-Wtype-limits] Signed-off-by: Chen Gang gang.c...@asianux.com --- arch/arm/mach-omap2

[PATCH] ARM: OMAP2: remove useless variable 'ret'

2013-08-21 Thread Chen Gang
Remove useless variable 'ret', the related warning: arch/arm/mach-omap2/board-am3517crane.c:113:6: warning: unused variable ‘ret’ [-Wunused-variable] Signed-off-by: Chen Gang gang.c...@asianux.com --- arch/arm/mach-omap2/board-am3517crane.c |2 -- 1 files changed, 0 insertions(+), 2

Re: [PATCH] ARM:OMAP2: an issue about curr_pwrst, u8 is never 0

2013-04-01 Thread Chen Gang
On 2013年04月01日 18:25, Paul Walmsley wrote: Hi, On Thu, 14 Mar 2013, Chen Gang wrote: if pwrdm_read_pwrst returns negative number, curr_pwrst can not notice it. since really need check curr_pwrst whether is negative, need let the check valid in _pwrdm_save_clkdm_state_and_activate

[PATCH] ARM:OMAP2: an issue about curr_pwrst, u8 is never 0

2013-03-13 Thread Chen Gang
-by: Chen Gang gang.c...@asianux.com --- arch/arm/mach-omap2/powerdomain.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c index 43ac20c..876d067 100644 --- a/arch/arm/mach-omap2/powerdomain.c +++ b

[PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static'

2013-02-06 Thread Chen Gang
of declaration drivers/gpio/gpio-omap.c:1491: warning: 'static' is not at beginning of declaration Signed-off-by: Chen Gang gang.c...@asianux.com --- drivers/gpio/gpio-omap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio

Re: [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static'

2013-02-06 Thread Chen Gang
于 2013年02月06日 17:36, Santosh Shilimkar 写道: On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote: 'const static ' is not a common order, better to use 'const static' instead. You mean use static const instead , right ? oh, yes. it is my miswritten. if necessary to send

[PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'

2013-02-06 Thread Chen Gang
of declaration drivers/gpio/gpio-omap.c:1491: warning: 'static' is not at beginning of declaration Signed-off-by: Chen Gang gang.c...@asianux.com Cc: Santosh Shilimkar santosh.shilim...@ti.com --- drivers/gpio/gpio-omap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy

2013-02-05 Thread Chen Gang
于 2013年02月06日 02:56, Tony Lindgren 写道: * Chen Gang gang.c...@asianux.com [130204 18:22]: Does it mean: we need not sync MAINTAINERS file for twl-*, recently ? :-) No we should still do it. Tony ok, thanks. if necessary (no other members do it), I should perform. if really

Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy

2013-02-04 Thread Chen Gang
linux-omap (the file is under arch/arm/mach-omap2 anyways) OK thanks I'll apply with your ack to omap-for-v3.9/fixes-noncritical. Tony Does it mean: we need not sync MAINTAINERS file for twl-*, recently ? :-) thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from

Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy

2013-02-03 Thread Chen Gang
another suitable members to sync it), I should sync it (since I found it) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy

2013-02-01 Thread Chen Gang
于 2013年02月02日 06:45, Tony Lindgren 写道: Added Peter to cc on this one too, it's best that he queues all the twl changes. is it suitable to sync the MAINTAINER file for it ? if suitable, can you help to change it ? thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from

[PATCH] ARM:omap2: using strlcpy instead of strncpy

2013-01-30 Thread Chen Gang
the fields must be null-terminated: the caller may use it as null-terminted string, next. Signed-off-by: Chen Gang gang.c...@asianux.com --- arch/arm/mach-omap2/twl-common.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-11 Thread Chen Gang
于 2013年01月11日 15:26, Santosh Shilimkar 写道: On Friday 11 January 2013 10:33 AM, Chen Gang wrote: �� 2013��01��10�� 18:48, Santosh Shilimkar д��: 'omap_dma_reserve_channels' when used is suppose to be from command line. Hence the proposed fix in the review is the right one. ok, thank you

[PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Chen Gang
. in the future maybe omap_dma_reserve_channels can be set by outside (such as from /proc) dma_lch_count is a static global variable which has effect to all devices. maybe the original author do not hope the newer is larger than the older Signed-off-by: Chen Gang gang.c...@asianux.com --- arch

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Chen Gang
于 2013年01月10日 18:48, Santosh Shilimkar 写道: 'omap_dma_reserve_channels' when used is suppose to be from command line. Hence the proposed fix in the review is the right one. ok, thank you for your suggestion. I will send patch v2, also mark you as Signed-of-by. :-) -- Chen Gang Asianux

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Chen Gang
于 2013年01月10日 18:51, Santosh Shilimkar 写道: Another thing. please fix the subject line. It should be something like below. ARM: OMAP: Fix the use of uninitialized dma_lch_count ok, thank you for your suggestion I will use it as subject for patch v2. :-) -- Chen Gang Asianux

[PATCH] ARM: OMAP: Fix the use of uninitialized dma_lch_count

2013-01-10 Thread Chen Gang
it will be failed for omap_dma_reserve_channels, when 1st call. so, need use 'd-lch_count' instead of 'dma_lch_count' for judging. Signed-off-by: Chen Gang gang.c...@asianux.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/plat-omap/dma.c |2 +- 1 file changed, 1