On 02/05/2013 01:29 PM, Linus Walleij wrote:
On Tue, Feb 5, 2013 at 5:47 PM, Mark Brown
wrote:
On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote:
For IRQ mode, use the completion callback to push each cookie
to NAPI, and thus let the IRQ drive the traffic.
The whole purpose of N
On 02/05/2013 07:41 AM, Russell King - ARM Linux wrote:
On Mon, Feb 04, 2013 at 04:54:45PM -0500, Cyril Chemparathy wrote:
You're assuming that cookies complete in order. That is not necessarily
true.
Under what circumstances is that not true?
Notably when hardware can prioritize ce
On 02/05/2013 07:38 AM, Russell King - ARM Linux wrote:
On Mon, Feb 04, 2013 at 09:47:38PM +, Arnd Bergmann wrote:
On Monday 04 February 2013, Linus Walleij wrote:
So I think the above concerns are moot. The callback we can
set on cookies is entirely optional, and it's even implemented by
e
On 02/04/2013 03:29 PM, Linus Walleij wrote:
On Mon, Feb 4, 2013 at 8:22 PM, Cyril Chemparathy wrote:
Based on our experience with fitting multiple subsystems on top of this
DMA-Engine driver, I must say that the DMA-Engine interface has proven
to be a less than ideal fit for the network
On 02/04/2013 04:11 PM, Linus Walleij wrote:
On Mon, Feb 4, 2013 at 9:33 PM, Mark Brown
wrote:
On Mon, Feb 04, 2013 at 09:29:46PM +0100, Linus Walleij wrote:
On Mon, Feb 4, 2013 at 8:22 PM, Cyril Chemparathy wrote:
Based on our experience with fitting multiple subsystems on top of this
On 02/04/2013 12:02 PM, Felipe Balbi wrote:
Hi,
On Mon, Feb 04, 2013 at 08:54:17PM +0300, Sergei Shtylyov wrote:
On Mon, Feb 04, 2013 at 08:36:38PM +0300, Sergei Shtylyov wrote:
opted out of it. From the top of my head we have CPPI 3.x, CPPI 4.1,
Inventra DMA, OMAP sDMA and ux500 DMA engines s
On 01/28/2013 03:12 PM, Mugunthan V N wrote:
Add helper functions for VLAN ALE implementations for Add, Delete
Dump VLAN related ALE entries
Signed-off-by: Mugunthan V N
---
drivers/net/ethernet/ti/cpsw_ale.c | 172 ++--
drivers/net/ethernet/ti/cpsw_ale.h |
On 9/12/2012 1:50 AM, R Sricharan wrote:
Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig,
the feature is not getting selected.
Adding a string description in the Kconfig resolves this.
But not sure if this is the right way to fix this.
Shouldn't you be selecting this in your 64-bi
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
In addition, the earlier phy_mask definitions have been replaced with
corresponding phy_id definitions.
Signed-off-by: Cyril Chemparathy
Tested-by: Michael
and EMAC regions.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
arch/arm/mach-davinci/devices-da8xx.c | 29 +-
arch/arm/mach-davinci/dm365.c | 22 +++-
arch/arm
then be reused across
EMAC and CPSW drivers.
Signed-off-by: Cyril Chemparathy
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile|1 +
drivers/net/davinci_cpdma.c | 965 +++
dr
Having switched over to the newly introduced cpdma layer, this patch now
removes a whole bunch of code that is now unused. This patch has been
maintained separate strictly for reasons of readability.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Acked-by: Tony Lindgren
---
arch/arm/mach-omap2/board-am3517evm.c |4
1 files changed, 0
was cleared - a possible security issue. This has been
fixed to use skb_padto().
Signed-off-by: Cyril Chemparathy
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/davinci_emac.c | 249 +---
1 files changed, 164 insertions(+), 85
and EMAC regions.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Acked-by: Tony Lindgren
---
arch/arm/mach-omap2/board-am3517evm.c | 27 ++-
1 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-am3517evm.c
b/arch/arm
This patch removes code that has been rendered useless by the previous patches
in this series.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/davinci_emac.c | 107
mask. This largely serves to eliminate the "phy search" code in emac
init.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/Kconfig |1 +
drivers/net/davinci_emac.
to be reused on such platforms.
Signed-off-by: Cyril Chemparathy
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile |1 +
drivers/net/davinci_mdio.c | 475 ++
include/
dma descriptors when EOQ at submit
4. use calculated mdio bus access times instead of hardcoded delays
5. work around emac soft-reset impact on mdio controller state
6. extend register dumps to include cpdma registers
7. updated sign offs and acks
Cyril Chemparathy (10):
net: davinci_emac:
Having switched over to the newly introduced cpdma layer, this patch now
removes a whole bunch of code that is now unused. This patch has been
maintained separate strictly for reasons of readability.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
and EMAC regions.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
arch/arm/mach-omap2/board-am3517evm.c | 27 ++-
1 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2
then be reused across
EMAC and CPSW drivers.
Signed-off-by: Cyril Chemparathy
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile|1 +
drivers/net/davinci_cpdma.c | 965 +++
dr
to be reused on such platforms.
Signed-off-by: Cyril Chemparathy
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile |1 +
drivers/net/davinci_mdio.c | 475 ++
include/
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
In addition, the earlier phy_mask definitions have been replaced with
corresponding phy_id definitions.
Signed-off-by: Cyril Chemparathy
Tested-by: Michael
This patch removes code that has been rendered useless by the previous patches
in this series.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/davinci_emac.c | 107
mask. This largely serves to eliminate the "phy search" code in emac
init.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/Kconfig |1 +
drivers/net/davinci_emac.
dma descriptors when EOQ at submit
4. use calculated mdio bus access times instead of hardcoded delays
5. work around emac soft-reset impact on mdio controller state
6. extend register dumps to include cpdma registers
Cyril Chemparathy (10):
net: davinci_emac: separate out davinci mdio
was cleared - a possible security issue. This has been
fixed to use skb_padto().
Signed-off-by: Cyril Chemparathy
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
drivers/net/davinci_emac.c | 249 +---
1 files changed, 164 insertions(+), 85
and EMAC regions.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
arch/arm/mach-davinci/devices-da8xx.c | 29 +-
arch/arm/mach-davinci/dm365.c | 22 +++-
arch/arm
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
Tested-by: Michael Williamson
Tested-by: Caglar Akyuz
---
arch/arm/mach-omap2/board-am3517evm.c
This patch replaces the hardcoded scan delay with a calculated delay that
adjusts to clock rates. This delay is calculated on the basis of a worst case
bus transaction time, with generous built-in margins of error.
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off
This patch separates out the controller reset logic, and makes this available
via mii_bus->reset.
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
drivers/net/davinci_mdio.c | 90 +--
1 files chan
This patch hooks up the emac_dump_regs() function to use cpdma dump routines.
Further, we dump registers on transmit timeout, to make such timeouts
debuggable.
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
drivers/net/davinci_emac.c |4
failed
transaction.
In addition, defensive timeouts have been added to prevent an indefinite
lockup in case of an unexpected hardware error.
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
drivers/net/davinci_mdio.c | 92
through these
issues, I've taken the liberty of adding their sign offs.
Cyril Chemparathy (9):
net: davinci_emac: allow forced 100/full via phy_id
davinci: specify phy_id rather than auto-detect
net: davinci_cpdma: requeue on early end-of-queue
net: davinci_emac: fix rx error handling
condition is detected on descriptor
submission as well. This is necessary on davinci style emac controllers, and
prevents transmit timeouts when sending out a burst of packets.
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
drivers/net
This patch adds register dump routines at both controller and channel levels.
These are intended to be used in higher level driver debug dumps, e.g.
emac_dump_regs().
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
drivers/net/davinci_cpdma.c
orms (e.g. da830 evm),
where an on-board switch may be connected on the emac mii.
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
drivers/net/davinci_emac.c |2 +-
include/linux/davinci_emac.h |7 +++
2 files changed, 8 insertions(+),
, normal phy auto-detection does not work
on this platform.
Rather than risk breaking other boards, this patch reverts to using hard-coded
phy ids on platforms that did so earlier.
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
arch/arm/mach
. Update rx_error stats on dma receive error
3. Rate limit error messages on buffer allocation failures
Signed-off-by: Cyril Chemparathy
Signed-off-by: Michael Williamson
Signed-off-by: Caglar Akyuz
---
drivers/net/davinci_emac.c | 25 +++--
1 files changed, 19 insertions
Hi Caglar,
[...]
> Assuming that the DMA got stuck at some point leading up to the transmit
> timeout, any ideas as to why a host error was not thrown? To help
> debug, I'll post out a set of patches that dump out the MAC (and DMA)
> registers on timeout. That should give us some visibility into
Hi Caglar,
[...]
> Unfortunately emac driver is not stable after this series. I face lock-ups
> time to time, followed by attached kernel trace.
Could you elaborate on your test scenario so that I can try and
reproduce the problem at my end? Also, did you have the contents of my
commit stack in
Hi Mike,
I have merged your latest two emails and responded to both here.
[...]
> Your patch doesn't work with my board. It does attempt to reset the bus on
> the read call,
> but following wait_for_user_access() calls are timing out and the _read() and
> _write() calls punt.
> I bumped up
Hi Mike,
[...]
> An EMAC soft-reset clobbering the MDIO controller state is a
> possibility. I will poll TI designers to see if this could be the case.
To test this theory out, I hacked up a crude
beat-it-to-death-and-see-if-it-breaks kinda patch (attached). This
tests 1 mdio read cycles wh
Hi Mike,
[...]
> The hang is in wait_for_user_access() in the davinci_mdio_read() call. Looks
> like
> the state machine got put back into IDLE somewhere between the MDIO probe and
> the
> EMAC probe. Seems like there should be some sort of time-out and error
> message
> in the wait_for_user
Hi Mike,
[...]
> So I just pulled this to test it out on a da850 based board
> (mitydspl138), and I'm having some problems. I'm hoping it's just
> operator error.
Probably not, considering that this series had not been tested on da8xx
platforms. Thanks for jumping in!
> I have a TI TLK100PHP P
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-da830-evm.c |5 -
arch/arm/mach-davinci/board-da850-evm.c |6 --
arch
to be reused on such platforms.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile |1 +
drivers/net/davinci_mdio.c | 386 ++
include/linux/davinci_emac.h |4 +
4
mask. This largely serves to eliminate the "phy search" code in emac
init.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
drivers/net/Kconfig |1 +
drivers/net/davinci_emac.c | 88 ++---
include/linux/davinci_emac.h |
This patch removes code that has been rendered useless by the previous patches
in this series.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
drivers/net/davinci_emac.c | 107 --
include/linux/davinci_emac.h |3 -
2 files changed
then be reused across
EMAC and CPSW drivers.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile|1 +
drivers/net/davinci_cpdma.c | 837 +++
drivers/net/davinci_cpdma.h |
Having switched over to the newly introduced cpdma layer, this patch now
removes a whole bunch of code that is now unused. This patch has been
maintained separate strictly for reasons of readability.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
drivers/net/davinci_emac.c
was cleared - a possible security issue. This has been
fixed to use skb_padto().
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
drivers/net/davinci_emac.c | 232
1 files changed, 147 insertions(+), 85 deletions(-)
diff --git a
and EMAC regions.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
arch/arm/mach-davinci/devices-da8xx.c | 29 +-
arch/arm/mach-davinci/dm365.c | 22 +++-
arch/arm/mach-davinci/dm644x.c | 22
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
arch/arm/mach-omap2/board-am3517evm.c |4
1 files changed, 0 insertions(+), 4 deletions
and EMAC regions.
Signed-off-by: Cyril Chemparathy
Acked-by: David S. Miller
---
arch/arm/mach-omap2/board-am3517evm.c | 27 ++-
1 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-am3517evm.c
b/arch/arm/mach-omap2/board-am3517evm.c
1. Updated series to include mityomapl138 board
2. Minor white-space fixes
Cyril Chemparathy (10):
net: davinci_emac: separate out davinci mdio
davinci: add mdio platform devices
omap: add mdio platform devices
net: davinci_emac: switch to new mdio
davinci: cleanup unused davinci mdio
Hi Kevin,
[...]
>> Although am3517 (omap) board support code has been updated as needed,
>> emac does not work on this platform.
>
> Just to clarify... did EMAC work on AM3517 before this series?
No. It didn't work before this series. To get AM3517 EMAC working, the
driver needs another patch
and EMAC regions.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-omap2/board-am3517evm.c | 27 ++-
1 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-am3517evm.c
b/arch/arm/mach-omap2/board-am3517evm.c
index 4d0f585..5dd1b73
This patch removes code that has been rendered useless by the previous patches
in this series.
Signed-off-by: Cyril Chemparathy
---
drivers/net/davinci_emac.c | 107 --
include/linux/davinci_emac.h |3 -
2 files changed, 0 insertions(+), 110
and EMAC regions.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/devices-da8xx.c | 29 +-
arch/arm/mach-davinci/dm365.c | 22 +++-
arch/arm/mach-davinci/dm644x.c | 22 +++-
arch/arm/mach
mask. This largely serves to eliminate the "phy search" code in emac
init.
Signed-off-by: Cyril Chemparathy
---
drivers/net/Kconfig |1 +
drivers/net/davinci_emac.c | 88 ++---
include/linux/davinci_emac.h |1 +
3 files changed, 32
Having switched over to the newly introduced cpdma layer, this patch now
removes a whole bunch of code that is now unused. This patch has been
maintained separate strictly for reasons of readability.
Signed-off-by: Cyril Chemparathy
---
drivers/net/davinci_emac.c | 930
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-omap2/board-am3517evm.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/arm
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-da830-evm.c |5 -
arch/arm/mach-davinci/board-da850-evm.c |6 --
arch
then be reused across
EMAC and CPSW drivers.
Signed-off-by: Cyril Chemparathy
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile|1 +
drivers/net/davinci_cpdma.c | 837 +++
drivers/net/davinci_cpdma.h | 105 ++
4 files changed
was cleared - a possible security issue. This has been
fixed to use skb_padto().
Signed-off-by: Cyril Chemparathy
---
drivers/net/davinci_emac.c | 232
1 files changed, 147 insertions(+), 85 deletions(-)
diff --git a/drivers/net/davinci_emac.c b
ional cpsw
patches) hardware. Although am3517 (omap) board support code has been updated
as needed, emac does not work on this platform.
Changes from v1:
1. Fixed memory leak in cpdma_chan_create() failure case
2. Included new omap patches for am3517, avoids build breakage
Cyril Chemparathy (8)
to be reused on such platforms.
Signed-off-by: Cyril Chemparathy
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile |1 +
drivers/net/davinci_mdio.c | 386 ++
include/linux/davinci_emac.h |4 +
4 files changed, 401 insertions(
Hi Omar,
[...]
>> +if (ctlr->channels[chan_num])
>> +goto err_chan_busy;
>
> Mem leaking 'chan'
>
Thanks. Will modify for v2.
Regards
Cyril.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majo
Hi Omar,
[...]
>> +while ((reg = __raw_readl(®s->user[0].access)) & USERACCESS_GO)
>> +;
>
> potential infinite loop? I saw another place in your series using time_after,
> might fit in here too.
[...]
>> +while ((__raw_readl(®s->control) & CONTROL_IDLE) == 0)
>> +
Hi Igor,
> Shouldn't arch/arm/mach-omap2/board-am3517evm.c be on your list?
> I think it should, or else it will be broken by:
> [PATCH 5/8] netdev: cleanup unused davinci mdio emac code
Correct. As stated in the series summary:
> Additional omap tree patches will be required for am35xx as well
to be reused on such platforms.
Signed-off-by: Cyril Chemparathy
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile |1 +
drivers/net/davinci_mdio.c | 386 ++
include/linux/davinci_emac.h |4 +
4 files changed, 401 insertions(
mask. This largely serves to eliminate the "phy search" code in emac
init.
Signed-off-by: Cyril Chemparathy
---
drivers/net/Kconfig |1 +
drivers/net/davinci_emac.c | 89 ++---
include/linux/davinci_emac.h |1 +
3 files changed, 33
and EMAC regions.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/devices-da8xx.c | 29 +-
arch/arm/mach-davinci/dm365.c | 22 +++-
arch/arm/mach-davinci/dm644x.c | 22 +++-
arch/arm/mach
This patch removes davinci architecture code that has now been rendered
useless by the previous patches in the MDIO separation series.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-da830-evm.c |5 -
arch/arm/mach-davinci/board-da850-evm.c |6 --
arch
was cleared - a possible security issue. This has been
fixed to use skb_padto().
Signed-off-by: Cyril Chemparathy
---
drivers/net/davinci_emac.c | 238
1 files changed, 150 insertions(+), 88 deletions(-)
diff --git a/drivers/net/davinci_emac.c b
then be reused across
EMAC and CPSW drivers.
Signed-off-by: Cyril Chemparathy
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile|1 +
drivers/net/davinci_cpdma.c | 836 +++
drivers/net/davinci_cpdma.h | 105 ++
4 files changed
Having switched over to the newly introduced cpdma layer, this patch now
removes a whole bunch of code that is now unused. This patch has been
maintained separate strictly for reasons of readability.
Signed-off-by: Cyril Chemparathy
---
drivers/net/davinci_emac.c | 929
This patch removes code that has been rendered useless by the previous patches
in this series.
Signed-off-by: Cyril Chemparathy
---
drivers/net/davinci_emac.c | 107 --
include/linux/davinci_emac.h |3 -
2 files changed, 0 insertions(+), 110
well (not included here).
Cyril Chemparathy (8):
netdev: separate out davinci mdio controller code
davinci: add mdio platform devices
netdev: switch davinci emac to new mdio driver
davinci: cleanup unused davinci mdio arch code
netdev: cleanup unused davinci mdio emac code
netdev: se
Hi,
[...]
> To fix both problems, maybe we should just use a fixed memory location
> to pass this temporary data from uncompress to the kernel. We've had a
> similar problem on DaVinci recently and a proposal has been made (and
> tested) to use memory just below the page tables[3].)
Essentially
82 matches
Mail list logo
