Re: [net-next PATCH 1/2] drivers: net: ethernet: cpsw: use netif_wake_queue() while restarting tx queue

2013-03-27 Thread Eric Dumazet
(netif_queue_stopped(ndev))) - netif_start_queue(ndev); + netif_wake_queue(ndev); cpts_tx_timestamp(priv-cpts, skb); priv-stats.tx_packets++; priv-stats.tx_bytes += len; Its a bug fix, suitable for net tree Acked-by: Eric Dumazet eduma...@google.com

Re: [net-next PATCH 2/2] drivers: net: ethernet: davinci_emac: use netif_wake_queue() while restarting tx queue

2013-03-27 Thread Eric Dumazet
desc for tx */ if (unlikely(netif_queue_stopped(ndev))) - netif_start_queue(ndev); + netif_wake_queue(ndev); ndev-stats.tx_packets++; ndev-stats.tx_bytes += len; dev_kfree_skb_any(skb); same remark here, its a bug fix Acked-by: Eric

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

2012-12-11 Thread Eric Dumazet
On Tue, 2012-12-11 at 13:34 -0500, David Miller wrote: You can't signal out of descriptors and stop the queue after the fact. NETDEV_TX_BUSY is for handling exceptional and extraordinary conditions, not for the normal queue full handling. This reminds me an idea I had about MQ/MQPRIO qdisc

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

2012-12-11 Thread Eric Dumazet
On Tue, 2012-12-11 at 13:57 -0500, David Miller wrote: From: Eric Dumazet erdnet...@gmail.com Date: Tue, 11 Dec 2012 10:54:56 -0800 Suggested fix : add a TCQ_F_MQSLAVE flag to allow dequeue_skb() to test the netif_xmit_frozen_or_stopped() status _before_ dequeing packet from qdisc

Re: [PATCH] net: Add back alignment for size for __alloc_skb

2011-11-02 Thread Eric Dumazet
] from [c04b2224] Function entered at [c04b2224] from [c001056c] Code: e1a5 e3a01028 ebfa7cb0 e35a (e5858028) Here PC is at __alloc_skb and shinfo-dataref is unaligned because skb-end can be unaligned without this patch. Cc: Eric Dumazet eric.duma...@gmail.com Signed-off-by: Tony

Re: [PATCH] net: Add back alignment for size for __alloc_skb

2011-11-02 Thread Eric Dumazet
On 03/11/2011 00:09, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 02 Nov 2011 23:55:11 +0100 There is a problem with your kmalloc() or alignments on your architecture. What is the SMP_CACHE_BYTES value ? kmalloc() behavior doesn't have anything to do

Re: [PATCH] net: Add back alignment for size for __alloc_skb

2011-11-02 Thread Eric Dumazet
On 03/11/2011 00:19, Tony Lindgren wrote: * David Miller da...@davemloft.net [02 15:42]: c The issue is calculation of skb-end, which is based upon calculated 'size' variable. skb-end determines alignment of skb_shared_info, which is where the alignment problem is occuring for Tony.

Re: [PATCH] net: Add back alignment for size for __alloc_skb

2011-11-02 Thread Eric Dumazet
)-88011c777230 ksize=656 - nsize=272 [ 60.325701] malloc(size=656)-880114011008 ksize=656 - nsize=272 [ 60.346716] malloc(size=385)-880114142008 ksize=386 - nsize=2 [ 60.346900] malloc(size=385)-88011c777690 ksize=386 - nsize=2 Acked-by: Eric Dumazet eric.duma...@gmail.com Thanks

Re: [PATCH] Fix CPU spinlock lockups on secondary CPU bringup

2011-06-22 Thread Eric Dumazet
Le mercredi 22 juin 2011 à 11:55 +0100, Russell King - ARM Linux a écrit : From: Russell King rmk+ker...@arm.linux.org.uk Secondary CPU bringup typically calls calibrate_delay() during its initialization. However, calibrate_delay() modifies a global variable (loops_per_jiffy) used for

RE: NULL Pointer Deference: NFS Telnet

2010-05-26 Thread Eric Dumazet
Le mercredi 26 mai 2010 à 15:19 -0500, Arce, Abraham a écrit : By increasing the allocation length of our rx skbuff the corruption issue is fixed... I have increased it by 2... Were we writing outside our boundaries of skb data? Please let me know about this approach... diff --git

RE: NULL Pointer Deference: NFS Telnet

2010-05-25 Thread Eric Dumazet
Le mardi 25 mai 2010 à 21:02 -0500, Arce, Abraham a écrit : Thanks David, diff --git a/net/core/skbuff.c b/net/core/skbuff.c index f8abf68..eb81f76 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -334,7 +334,7 @@ static void skb_release_data(struct sk_buff *skb) if