Re: [PATCH 2/3] drivers: usb: dwc3: Add adjust_frame_length_quirk

2015-07-27 Thread Felipe Balbi
On Mon, Jul 27, 2015 at 06:56:48AM +, Badola Nikhil wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, July 23, 2015 8:39 PM To: Felipe Balbi Cc: Badola Nikhil-B46172; linux-ker...@vger.kernel.org; linux- u...@vger.kernel.org; linux-omap

Re: [PATCH 2/3] drivers: usb: dwc3: Add adjust_frame_length_quirk

2015-07-23 Thread Felipe Balbi
Hi, On Thu, Jul 23, 2015 at 03:41:35PM +0530, Nikhil Badola wrote: Add adjust_frame_length_quirk for writing to fladj register which adjusts (micro)frame length to value provided by snps,configure-fladj property thus avoiding USB 2.0 devices to time-out over a longer run Signed-off-by:

Re: [PATCH 2/3] drivers: usb: dwc3: Add adjust_frame_length_quirk

2015-07-23 Thread Felipe Balbi
Hi again, On Thu, Jul 23, 2015 at 09:55:32AM -0500, Felipe Balbi wrote: diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 0447788..b7a5119 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -124,6 +124,7 @@ #define DWC3_GEVNTCOUNT(n) (0xc40c + (n

Re: [PATCH v3 07/46] usb: dwc3: gadget: add ep capabilities support

2015-07-21 Thread Felipe Balbi
Hi, On Wed, Jul 15, 2015 at 08:31:54AM +0200, Robert Baldyga wrote: Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/dwc3/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

2015-07-21 Thread Felipe Balbi
On Tue, Jul 14, 2015 at 02:29:46PM -0500, Franklin S Cooper Jr wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without this patch boards that do not enable regulator config options will fail to boot with a kernel panic. Signed-off-by: Roger Quadros

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

2015-07-21 Thread Felipe Balbi
On Tue, Jul 21, 2015 at 03:11:21PM -0500, Franklin S Cooper Jr. wrote: On 07/21/2015 02:57 PM, Felipe Balbi wrote: On Tue, Jul 14, 2015 at 02:29:46PM -0500, Franklin S Cooper Jr wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without

Re: [PATCH] irqchip: omap-intc: improve IRQ handler

2015-07-20 Thread Felipe Balbi
On Wed, Jul 15, 2015 at 02:36:54PM +0200, Thomas Gleixner wrote: On Wed, 15 Jul 2015, Tony Lindgren wrote: Felipe, * Tony Lindgren t...@atomide.com [150119 13:41]: * Felipe Balbi ba...@ti.com [150102 10:50]: as it turns out the current IRQ number will *always* be available from

[PATCH RESEND] irqchip: omap-intc: improve IRQ handler

2015-07-20 Thread Felipe Balbi
report it. With this patch average running time of omap_intc_handle_irq() reduced from about 28.5us to 19.8us as measured by the kernel function profiler. Tested with BeagleBoneBlack Rev A5C. Tested-by: Tony Lindgren t...@atomide.com Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/irqchip/irq

Re: [PATCH RESEND] irqchip: omap-intc: improve IRQ handler

2015-07-20 Thread Felipe Balbi
On Mon, Jul 20, 2015 at 10:44:08PM +0200, Thomas Gleixner wrote: On Mon, 20 Jul 2015, Felipe Balbi wrote: + irqnr = intc_readl(INTC_SIR); + irqnr = ACTIVEIRQ_MASK; + WARN(!irqnr, Spurious IRQ ?\n); Shouldn't that be WARN_ONCE? Sure, why not ? 8

[PATCH 2/3] i2c: omap: abolish variable name confusion

2015-07-13 Thread Felipe Balbi
struct device pointers are usually called dev. Calling our struct omap_i2c_dev pointers also dev has caused enough confusion. This is the result of a few simple sed rules to convert all struct omap_i2c_dev pointers to be called omap instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers

[PATCH 1/3] i2c: omap: switch to dev_get_drvdata()

2015-07-13 Thread Felipe Balbi
there's no need to fetch the platform_device in order to dereference it back to the dev pointer to access drvdata, we can use dev_get_drvdata() instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 3/3] i2c: omap: on -remove() call pm_runtime_put_sync()

2015-07-13 Thread Felipe Balbi
we're about to remove the module, so we can't really schedule a PM transition in the future, we must wait for it to finish. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c

Re: musb-hdrc: Vbus off, timeout 1100 msec message does not belong in sysfs

2015-07-13 Thread Felipe Balbi
On Fri, Jul 10, 2015 at 09:17:39AM +0200, Sebastian Andrzej Siewior wrote: On 07/09/2015 11:46 PM, Pavel Machek wrote: On Thu 2015-07-09 23:39:22, Pavel Machek wrote: Hi! Hi, sysfs should contain one value per file. This one has at least two, with nice english sentence as a bonus.

[PATCH] arm: dts: dra7: arch timer sits in always-on power domain

2015-07-13 Thread Felipe Balbi
goes out of standby. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 8f1e25bcecbd..c1e6fd82485f 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts

Re: [PATCH v3] i2c: omap: improve duty cycle on SCL

2015-07-10 Thread Felipe Balbi
On Thu, Jul 09, 2015 at 09:42:41PM +0200, Wolfram Sang wrote: On Thu, Jun 18, 2015 at 12:25:58PM -0500, Felipe Balbi wrote: On Thu, Jun 18, 2015 at 10:09:59AM +0200, Alexander Sverdlin wrote: Hello Felipe, On 17/06/15 21:31, ext Felipe Balbi wrote: With this patch we try

Re: [PATCH 2/3] i2c: omap: abolish variable name confusion

2015-07-10 Thread Felipe Balbi
Hi, On Thu, Jul 09, 2015 at 09:49:41PM +0200, Wolfram Sang wrote: On Thu, Jun 25, 2015 at 02:34:49PM -0500, Felipe Balbi wrote: struct device pointers are usually called dev. Calling our struct omap_i2c_dev pointers also dev has caused enough confusion. This is the result of a few

Re: [PATCH] base: power: wakeirq: don't leak dev-power.wakeirq

2015-07-07 Thread Felipe Balbi
On Tue, Jul 07, 2015 at 12:40:53AM -0700, Tony Lindgren wrote: * Rafael J. Wysocki r...@rjwysocki.net [150706 15:49]: On Monday, July 06, 2015 01:01:18 PM Felipe Balbi wrote: on a first call to dev_pm_attach_wake_irq(), if it fails, it will leave dev-power.wakeirq set to a dangling

Re: [PATCH] base: power: wakeirq: don't leak dev-power.wakeirq

2015-07-06 Thread Felipe Balbi
On Mon, Jul 06, 2015 at 08:06:17PM +0200, Michael Trimarchi wrote: Hi On Jul 6, 2015 8:01 PM, Felipe Balbi ba...@ti.com wrote: on a first call to dev_pm_attach_wake_irq(), if it fails, it will leave dev-power.wakeirq set to a dangling pointer. Instead, let's clear it to make sure

[PATCH] base: power: wakeirq: don't leak dev-power.wakeirq

2015-07-06 Thread Felipe Balbi
on a first call to dev_pm_attach_wake_irq(), if it fails, it will leave dev-power.wakeirq set to a dangling pointer. Instead, let's clear it to make sure a subsequent call to dev_pm_attach_wake_irq() has chance to succeed. Cc: Tony Lindgren tml...@atomide.com Signed-off-by: Felipe Balbi ba

Re: [PATCH 1/5] usb: dwc3: ep0: use _roundup_ to calculate the transfer size

2015-07-06 Thread Felipe Balbi
On Wed, Jun 10, 2015 at 02:48:48PM +0530, Kishon Vijay Abraham I wrote: No functional change. Used _roundup_ macro to calculate the transfer size aligned to maxpacket in dwc3_ep0_complete_data. It also makes it similar to how transfer size is calculated in __dwc3_ep0_do_control_data.

Re: [PATCH 03/10] crypto: aead: Add aead_request_cast() api

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:33AM +0530, Lokesh Vutla wrote: Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/linux/crypto.h |6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:32AM +0530, Lokesh Vutla wrote: AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before configuring any AES mode. Signed-off-by: Lokesh Vutla

Re: [PATCH 04/10] crypto: omap-aes: Use BIT() macro

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:34AM +0530, Lokesh Vutla wrote: Use BIT()/GENMASK() macros for all register definitions instead of hand-writing bit masks. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 36 ++-- 1 file

Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote: OMAP AES driver returns an error if the data is not aligned with AES_BLOCK_SIZE bytes. But OMAP AES hw allows data input upto 1 byte aligned, but still zeros are to be appended and complete AES_BLOCK_SIZE has to be written. And

Re: [PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:39AM +0530, Lokesh Vutla wrote: Add support for PIO mode for GCM mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com why do you require PIO ? Is there any situation where DMA can't be used? What would that case be ? -- balbi signature.asc Description:

Re: [PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:36AM +0530, Lokesh Vutla wrote: Its not necessary that assoc data and plain text is passed always. Add these checks before processing the input. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com why can't this be combined with patch which added GCM in the first

Re: [PATCH 07/10] crypto: omap-aes: gcm: Add support for unaligned lengths

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:37AM +0530, Lokesh Vutla wrote: Check if the inputs are not aligned, if not process the input before starting the hw acceleration. Similarly after completition of hw acceleration. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com and this ? -- balbi

Re: [PATCH 05/10] crypto: omap-aes: Add support for GCM mode

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:35AM +0530, Lokesh Vutla wrote: OMAP AES hw supports aes gcm mode. here you refer to it as 'gcm' Adding support for GCM mode in omap-aes driver. while here and in subject as 'GCM'. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/Makefile

Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote: The sound support consist only Headset output on the board and can be handled by simple-audio-card Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Still works fine: Tested-by: Felipe Balbi ba...@ti.com one question though

Re: [PATCH 1/2] ARM: DTS: am437x-sk-evm: Add sleep pin settings for mcasp1

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 02:58:05PM +0300, Peter Ujfalusi wrote: When McASP is not in use the pins can be put to sleep mode to conserve power. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Tested-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 03:52:49PM +0300, Peter Ujfalusi wrote: On 07/02/2015 03:23 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote: The sound support consist only Headset output on the board and can be handled by simple-audio-card Signed-off

Re: [PATCH 0/2] ARM: DTS: am437x-sk-evm: Use simple-card for audio support

2015-07-02 Thread Felipe Balbi
Hi, On Thu, Jul 02, 2015 at 02:58:04PM +0300, Peter Ujfalusi wrote: Hi, There is no reason to use the davinci-evm machine driver's compatible for audio support since the setup is simple and the common simple-audio-card can handle it just fine. Also add McASP1 sleep pin configuration.

Re: [PATCH v2 01/20] ARM: omap2plus_defconfig: Enable audio related config options

2015-07-02 Thread Felipe Balbi
by the CONFIG_SND_AM33XX_SOC_EVM option, but the aim is to convert all boards to use simple card. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Acked-by: Felipe Balbi ba...@ti.com --- arch/arm/configs/omap2plus_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm

[PATCH] watchdog: omap: fix build error

2015-06-29 Thread Felipe Balbi
Fix reference to unexistent variable in omap_wdt_probe() caused by commit 387ee4d26e5f (watchdog: omap_wdt: early_enable module parameter) Reported-by: Mark Brown broo...@kernel.org Fixes: 387ee4d26e5f (watchdog: omap_wdt: early_enable module parameter) Signed-off-by: Felipe Balbi ba...@ti.com

Regression with today's next

2015-06-29 Thread Felipe Balbi
Hi, commit 736e60ddc215b85e73bbf7da26e1cde84cc9500f (OMAPDSS: componentize omapdss) caused a regression at least on AM437x SK board where Display doesn't work anymore. Below you can find bisection log and a git show of commit. I have tested that reverting said commit makes it work again. Please

[PATCH 1/3] i2c: omap: switch to dev_get_drvdata()

2015-06-25 Thread Felipe Balbi
there's no need to fetch the platform_device in order to dereference it back to the dev pointer to access drvdata, we can use dev_get_drvdata() instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 2/3] i2c: omap: abolish variable name confusion

2015-06-25 Thread Felipe Balbi
struct device pointers are usually called dev. Calling our struct omap_i2c_dev pointers also dev has caused enough confusion. This is the result of a few simple sed rules to convert all struct omap_i2c_dev pointers to be called omap instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers

[PATCH 3/3] i2c: omap: on -remove() call pm_runtime_put_sync()

2015-06-25 Thread Felipe Balbi
we're about to remove the module, so we can't really schedule a PM transition in the future, we must wait for it to finish. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c

Re: [PATCH V2 0/5] drivers/rtc/rtc-ds1307.c: Basic cleanups and support for wakeupirq

2015-06-24 Thread Felipe Balbi
, and will be reposted along with other wakeup sources to be enabled once the driver changes are accepted. Felipe Balbi (1): drivers/rtc/rtc-ds1307.c: Convert to threaded IRQ Nishanth Menon (4): drivers/rtc/rtc-ds1307.c: Switch to managed irq allocation drivers/rtc/rtc-ds1307.c: Sort

Re: [PATCH] i2c: omap: improve duty cycle on SCL

2015-06-19 Thread Felipe Balbi
On Fri, Jun 19, 2015 at 07:41:49AM +0200, Michael Lawnick wrote: Am 18.06.2015 um 19:24 schrieb Felipe Balbi: On Thu, Jun 18, 2015 at 08:39:11AM +0200, Michael Lawnick wrote: Am 17.06.2015 um 17:38 schrieb Felipe Balbi: Hi, On Wed, Jun 17, 2015 at 01:09:53PM +0200, Michael Lawnick wrote

Re: [PATCH] i2c: omap: improve duty cycle on SCL

2015-06-18 Thread Felipe Balbi
On Thu, Jun 18, 2015 at 08:39:11AM +0200, Michael Lawnick wrote: Am 17.06.2015 um 17:38 schrieb Felipe Balbi: Hi, On Wed, Jun 17, 2015 at 01:09:53PM +0200, Michael Lawnick wrote: Am 16.06.2015 um 21:17 schrieb Felipe Balbi: With this patch we try to be as close to 50% duty cycle

Re: [PATCH v3] i2c: omap: improve duty cycle on SCL

2015-06-18 Thread Felipe Balbi
On Thu, Jun 18, 2015 at 10:09:59AM +0200, Alexander Sverdlin wrote: Hello Felipe, On 17/06/15 21:31, ext Felipe Balbi wrote: With this patch we try to be as close to 50% duty cycle as possible. The reason for this is that some devices present an erratic behavior with certain duty

Re: [PATCH RESEND] i2c: omap: improve duty cycle on SCL

2015-06-17 Thread Felipe Balbi
tHigh and to make sure that we end up within I2C specifications. Kudos to Nishanth Menon and Dave Gerlach for helping debugging the TPS65218 problem found on AM437x SK. Signed-off-by: Felipe Balbi ba...@ti.com NAK. This is a direct violation of PHILIPS I2C-bus Specification v.2.1

[PATCH v3] i2c: omap: improve duty cycle on SCL

2015-06-17 Thread Felipe Balbi
for helping debugging the TPS65218 problem found on AM437x SK. Signed-off-by: Felipe Balbi ba...@ti.com --- Changes since v2: - use NSEC_PER_SEC from time.h - Fix 19.2MHz (it was missing one 0) Changes since v1: - Fix for dev-speed which is in kHz, rather than Hz ps

Re: [PATCH RESEND] i2c: omap: improve duty cycle on SCL

2015-06-17 Thread Felipe Balbi
Hi, On Wed, Jun 17, 2015 at 08:38:42PM +0200, Alexander Sverdlin wrote: Hello Felipe, On 17/06/15 20:00, Felipe Balbi wrote: With this patch we try to be as close to 50% duty cycle as possible. The reason for this is that some devices present an erratic behavior with certain

Re: [PATCH v2] i2c: omap: improve duty cycle on SCL

2015-06-17 Thread Felipe Balbi
On Wed, Jun 17, 2015 at 09:00:53PM +0200, Alexander Sverdlin wrote: Hi! On 17/06/15 20:29, Felipe Balbi wrote: - if (dev-speed 400 || - dev-flags OMAP_I2C_FLAG_FORCE_19200_INT_CLK) - internal_clk = 19200; Let's compare, what

Re: [PATCH RESEND] i2c: omap: improve duty cycle on SCL

2015-06-17 Thread Felipe Balbi
On Wed, Jun 17, 2015 at 01:00:52PM -0500, Felipe Balbi wrote: Hi, On Wed, Jun 17, 2015 at 11:19:28AM +0200, Alexander Sverdlin wrote: With this patch we try to be as close to 50% duty cycle as possible. The reason for this is that some devices present an erratic behavior

[PATCH v2] i2c: omap: improve duty cycle on SCL

2015-06-17 Thread Felipe Balbi
for helping debugging the TPS65218 problem found on AM437x SK. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 88 --- 1 file changed, 57 insertions(+), 31 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c

Re: [PATCH] i2c: omap: improve duty cycle on SCL

2015-06-17 Thread Felipe Balbi
Hi, On Wed, Jun 17, 2015 at 01:09:53PM +0200, Michael Lawnick wrote: Am 16.06.2015 um 21:17 schrieb Felipe Balbi: With this patch we try to be as close to 50% duty cycle as possible. The reason for this is that some devices present an erratic behavior with certain duty cycles. One

Re: [PATCH 2/2] cpufreq: dt: allow driver to boot automatically

2015-06-16 Thread Felipe Balbi
On Wed, Jun 17, 2015 at 12:04:07AM +0200, Rafael J. Wysocki wrote: On Tue, Jun 16, 2015 at 11:40 PM, Felipe Balbi ba...@ti.com wrote: On Fri, May 08, 2015 at 02:57:30PM -0500, Felipe Balbi wrote: by adding the missing MODULE_ALIAS(), cpufreq-dt can be autoloaded by udev/systemd. Signed

Re: [PATCH 2/2] cpufreq: dt: allow driver to boot automatically

2015-06-16 Thread Felipe Balbi
On Fri, May 08, 2015 at 02:57:30PM -0500, Felipe Balbi wrote: by adding the missing MODULE_ALIAS(), cpufreq-dt can be autoloaded by udev/systemd. Signed-off-by: Felipe Balbi ba...@ti.com looks like this wasn't applied anywhere. Viresh, can you apply this patch please ? --- drivers

Re: [PATCH] i2c: omap: improve duty cycle on SCL

2015-06-16 Thread Felipe Balbi
On Tue, Jun 16, 2015 at 02:17:56PM -0500, Felipe Balbi wrote: With this patch we try to be as close to 50% duty cycle as possible. The reason for this is that some devices present an erratic behavior with certain duty cycles. One such example is TPS65218 PMIC which fails to change voltages

[PATCH] i2c: omap: improve duty cycle on SCL

2015-06-16 Thread Felipe Balbi
for helping debugging the TPS65218 problem found on AM437x SK. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 86 --- 1 file changed, 56 insertions(+), 30 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c

[PATCH RESEND] i2c: omap: improve duty cycle on SCL

2015-06-16 Thread Felipe Balbi
for helping debugging the TPS65218 problem found on AM437x SK. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 86 --- 1 file changed, 56 insertions(+), 30 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c

Re: [PATCH RESEND] i2c: omap: improve duty cycle on SCL

2015-06-16 Thread Felipe Balbi
On Tue, Jun 16, 2015 at 02:20:45PM -0500, Felipe Balbi wrote: With this patch we try to be as close to 50% duty cycle as possible. The reason for this is that some devices present an erratic behavior with certain duty cycles. One such example is TPS65218 PMIC which fails to change voltages

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

2015-06-09 Thread Felipe Balbi
On Tue, Jun 09, 2015 at 10:59:50AM -0400, Alan Stern wrote: On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: Hi, On Tuesday 09 June 2015 08:09 PM, Michael Trimarchi wrote: Hi On Jun 9, 2015 4:36 PM, Kishon Vijay Abraham I kis...@ti.com mailto:kis...@ti.com wrote:

Re: [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin.

2015-06-07 Thread Felipe Balbi
On Sat, Jun 06, 2015 at 03:10:09PM +0200, Pavel Machek wrote: On Tue 2015-06-02 07:37:31, NeilBrown wrote: On Mon, 1 Jun 2015 19:06:52 +0530 Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Thursday 16 April 2015 01:33 PM, NeilBrown wrote: From: NeilBrown ne...@suse.de

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-05 Thread Felipe Balbi
On Thu, Jun 04, 2015 at 03:20:57PM -0700, Stephen Boyd wrote: On 06/04, Felipe Balbi wrote: On Thu, Jun 04, 2015 at 03:18:25PM -0500, Felipe Balbi wrote: On Thu, Jun 04, 2015 at 03:08:50PM -0500, Felipe Balbi wrote: Hi, On Thu, Jun 04, 2015 at 11:46:59AM +0200, Mason wrote

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-04 Thread Felipe Balbi
On Thu, Jun 04, 2015 at 10:32:40PM +0200, Mason wrote: On 04/06/2015 22:08, Felipe Balbi wrote: On Thu, Jun 04, 2015 at 11:46:59AM +0200, Mason wrote: Also, check /proc/timer_list for a Broadcast device. If you don't define one, the TWD timers are set to periodic mode, with hrtimers

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-04 Thread Felipe Balbi
On Thu, Jun 04, 2015 at 03:18:25PM -0500, Felipe Balbi wrote: On Thu, Jun 04, 2015 at 03:08:50PM -0500, Felipe Balbi wrote: Hi, On Thu, Jun 04, 2015 at 11:46:59AM +0200, Mason wrote: Also, check /proc/timer_list for a Broadcast device. If you don't define one, the TWD timers are set

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-04 Thread Felipe Balbi
On Thu, Jun 04, 2015 at 11:46:59AM +0200, Mason wrote: On 03/06/2015 23:54, Felipe Balbi wrote: On Wed, Jun 03, 2015 at 02:41:39PM -0700, Stephen Boyd wrote: AM43xx, even though it's a single processor A9, it still has TWD and global timer. I was doing some profiling with RT v4.0

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-04 Thread Felipe Balbi
Hi, On Thu, Jun 04, 2015 at 11:46:59AM +0200, Mason wrote: Also, check /proc/timer_list for a Broadcast device. If you don't define one, the TWD timers are set to periodic mode, with hrtimers disabled. Did you manage to turn global timer into Broadcast device ? -- balbi signature.asc

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-04 Thread Felipe Balbi
On Thu, Jun 04, 2015 at 03:08:50PM -0500, Felipe Balbi wrote: Hi, On Thu, Jun 04, 2015 at 11:46:59AM +0200, Mason wrote: Also, check /proc/timer_list for a Broadcast device. If you don't define one, the TWD timers are set to periodic mode, with hrtimers disabled. Did you manage

[RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-03 Thread Felipe Balbi
Signed-off-by: Felipe Balbi ba...@ti.com --- Hi Tony and Russell, AM43xx, even though it's a single processor A9, it still has TWD and global timer. I was doing some profiling with RT v4.0 and latency is 3.5x lower just by switching from gptimer to twd/global. The only problem is that currently

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-03 Thread Felipe Balbi
On Wed, Jun 03, 2015 at 10:55:27PM +0200, Arnd Bergmann wrote: On Wednesday 03 June 2015 15:32:45 Felipe Balbi wrote: Hi Tony and Russell, AM43xx, even though it's a single processor A9, it still has TWD and global timer. I was doing some profiling with RT v4.0 and latency is 3.5x

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-03 Thread Felipe Balbi
Hi, On Wed, Jun 03, 2015 at 02:41:39PM -0700, Stephen Boyd wrote: AM43xx, even though it's a single processor A9, it still has TWD and global timer. I was doing some profiling with RT v4.0 and latency is 3.5x lower just by switching from gptimer to twd/global. The only problem is that

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-03 Thread Felipe Balbi
On Wed, Jun 03, 2015 at 04:04:55PM -0500, Felipe Balbi wrote: On Wed, Jun 03, 2015 at 10:55:27PM +0200, Arnd Bergmann wrote: On Wednesday 03 June 2015 15:32:45 Felipe Balbi wrote: Hi Tony and Russell, AM43xx, even though it's a single processor A9, it still has TWD and global

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

2015-06-03 Thread Felipe Balbi
Hi, On Wed, Jun 03, 2015 at 03:26:20PM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [150603 13:36]: --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2/timer.c @@ -655,20 +655,18 @@ static OMAP_SYS_32K_TIMER_INIT(4, 1, timer_32k_ck, ti,timer-alwon, static

Re: Regression with AM43xx devices

2015-06-02 Thread Felipe Balbi
On Tue, Jun 02, 2015 at 02:17:52PM -0500, Felipe Balbi wrote: Hi Dave, You commit fabbe6df130a46d5b5e7484b2273d69c4be3012a (ARM: OMAP: AM43xx hwmod: Add data for am43xx emif hwmod) listed below added a new WARNING during boot to all AM43xx-based boards. Full boot logs can be found at [1

Re: [PATCH 2/2] ARM: dts: am4372: Add emif node

2015-06-02 Thread Felipe Balbi
On Wed, May 06, 2015 at 12:25:33PM -0500, Dave Gerlach wrote: Add node for TI AM4372 EMIF. Signed-off-by: Dave Gerlach d-gerl...@ti.com Tony, this patch fixes the regression I just reported at [1], care to pick this one up ? Tested-by: Felipe Balbi ba...@ti.com Acked-by: Felipe Balbi ba

Regression with AM43xx devices

2015-06-02 Thread Felipe Balbi
Hi Dave, You commit fabbe6df130a46d5b5e7484b2273d69c4be3012a (ARM: OMAP: AM43xx hwmod: Add data for am43xx emif hwmod) listed below added a new WARNING during boot to all AM43xx-based boards. Full boot logs can be found at [1], but it seems like we should, at least for the merge window, revert

Re: [RFC PATCH 2/2] usb: dwc3: Add chained TRB support for ep0

2015-06-01 Thread Felipe Balbi
Hi, On Mon, Jun 01, 2015 at 03:23:48PM +0530, Kishon Vijay Abraham I wrote: + transferred = transfer_size - length; + buf = (u8 *)buf + transferred; + ur-actual += transferred; this is dangerous. The extra size is because you *must* align OUT to

Re: [PATCH] ARM: dts: Fix dm816x to use right compatible flag for MUSB

2015-05-29 Thread Felipe Balbi
Cc: George Cherian george.cher...@ti.com Cc: Felipe Balbi ba...@ti.com Fixes: 3e457371f436 (usb: musb: Fix fifo reads for dm816x with musb_dsps) Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Tony Lindgren t...@atomide.com --- arch/arm/boot/dts/dm816x.dtsi | 4 ++-- 1 file changed, 2

Re: [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq

2015-05-29 Thread Felipe Balbi
and CONFIG_MMC_OMAP_HS are selected. Cc: Stephen Rothwell s...@canb.auug.org.au Cc: Ulf Hansson ulf.hans...@linaro.org Reported-by: Jim Davis jim.ep...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com cool: Reviewed-by: Felipe Balbi ba...@ti.com --- include/linux/pm_wakeirq.h

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Felipe Balbi
a38cfebb56898633687ab337fd53710e63a0aedd v3.15-rc5-72-ga38cfebb5689 So, because this has been wrongly documented for so long, we should support both bindings. Sure, deprecate touchscreen-max-[xy], but they must still be supported, IMO. In any case, for this patch: Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Felipe Balbi
On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel

Re: [PATCH] ARM: omap2plus_defconfig: Add dm816x USB PHY as a loadable module

2015-05-29 Thread Felipe Balbi
On Fri, May 29, 2015 at 10:12:12AM -0700, Tony Lindgren wrote: This is needed for USB on dm816x-evm. Cc: Bin Liu binml...@gmail.com Cc: Brian Hutchinson b.hutch...@gmail.com Cc: George Cherian george.cher...@ti.com Cc: Felipe Balbi ba...@ti.com Signed-off-by: Tony Lindgren t...@atomide.com

Re: [PATCHv3 00/27] ARM: OMAP2+: clock code move under clk driver

2015-05-26 Thread Felipe Balbi
On Tue, May 26, 2015 at 09:32:16AM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [150526 09:08]: * Tero Kristo t-kri...@ti.com [150525 08:01]: Hi, As requested, posting v3 with somewhat changed diff parameters and diffstat attached. Just some minor Makefile changes

Re: AM3517 usb host issue

2015-05-22 Thread Felipe Balbi
Hi, On Fri, May 22, 2015 at 11:13:22PM +0300, Ben Dooks wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 22/05/15 16:50, Felipe Balbi wrote: Hi, On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote: I am trying to get the full-speed USB host working on an custom

Re: AM3517 usb host issue

2015-05-22 Thread Felipe Balbi
Hi, On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote: I am trying to get the full-speed USB host working on an custom AM3517 device with the 3.18.12 kernel. The hardware works (a 2.6.37 kernel has been used for testing). Does anyone have any experience of 3.18 (or similarly recent

Re: races in omap_wdt

2015-05-22 Thread Felipe Balbi
On Fri, May 22, 2015 at 08:16:47PM +0200, Uwe Kleine-König wrote: On Fri, Apr 24, 2015 at 11:18:40AM +0200, Uwe Kleine-König wrote: [dropped Varadarajan Charulatha and Shubhrajyoti D from the addressees because the ti mailserver doesn't know them :-(, added Felipe instead] On Thu, Apr

Re: [PATCH] tty: serial: omap: use mctrl_gpio helpers

2015-05-22 Thread Felipe Balbi
On Fri, May 22, 2015 at 09:52:13AM -0700, Tony Lindgren wrote: * Nishanth Menon n...@ti.com [150522 08:36]: On 05/22/2015 07:16 AM, yegorsli...@googlemail.com wrote: From: Yegor Yefremov yegorsli...@googlemail.com This patch permits to use GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI

Re: [PATCH 2/5] PM / Wakeirq: Add automated device wake IRQ handling

2015-05-20 Thread Felipe Balbi
. OK I added a new pm-wakeirq branch to linux-pm.git with these two patches and one other commit related to runtime PM (all based on 4.1-rc4). This branch will not be rebased going forward. Hopefully it's not too late to get my Reviewed-by: Felipe Balbi ba...@ti.com in the patch

Re: [PATCH 1/2] arm: boot: dts: am4372: add operating points

2015-05-11 Thread Felipe Balbi
HI, On Mon, May 11, 2015 at 11:46:13AM -0500, Nishanth Menon wrote: On Mon, May 11, 2015 at 10:19 AM, Felipe Balbi ba...@ti.com wrote: in my opinion, doing a temporary hack in upstream kernel is not an elegant approach. I suggest helping review and approving Viresh's new however

Re: [PATCH 1/3] watchdog: omap: use watchdog_init_timeout

2015-04-24 Thread Felipe Balbi
Hi, On Fri, Apr 24, 2015 at 11:48:31AM +0200, Uwe Kleine-König wrote: Instead of (partly) open coding it use the core function. As a side effect the timeout-sec devicetree property is used now. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de ---

Re: [PATCH 3/3] watchdog: omap: simplify assignment of bootstatus

2015-04-24 Thread Felipe Balbi
variable into a more local scope. There is no functional change. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de looks good to me Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/watchdog/omap_wdt.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff

Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation

2015-04-24 Thread Felipe Balbi
-koe...@pengutronix.de looks great to me, thanks Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Felipe Balbi ba...@ti.com --- Hello Felipe, what about this patch before the previously sent patch 1? Best regards Uwe Documentation/devicetree/bindings/watchdog/omap-wdt.txt | 6 ++ 1

Re: [PATCH] gpio: omap: Allow building as a loadable module

2015-04-24 Thread Felipe Balbi
, we can make the Kconfig entry just a tristate option that's selected for omaps. Cc: Felipe Balbi ba...@ti.com Cc: Javier Martinez Canillas jav...@dowhile0.org Cc: Grygorii Strashko grygorii.stras...@linaro.org Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Nishanth Menon n...@ti.com Cc

Re: [PATCH] gpio: omap: Fix regression for MPUIO interrupts

2015-04-24 Thread Felipe Balbi
just remove all old code trying to do the same. Cc: Aaro Koskinen aaro.koski...@iki.fi Cc: Felipe Balbi ba...@ti.com Cc: Javier Martinez Canillas jav...@dowhile0.org Cc: Grygorii Strashko grygorii.stras...@linaro.org Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Nishanth Menon n...@ti.com

Re: [PATCH 2/3] watchdog: omap: put struct watchdog_device into driver data

2015-04-24 Thread Felipe Balbi
On Fri, Apr 24, 2015 at 11:48:32AM +0200, Uwe Kleine-König wrote: This way only a single allocation is needed (per device). Also this stops making use of watchdog_{set,get}_drvdata. And this is better because ... ? Nothing against it, just feels like this commit log needs a little more

Re: [PATCH 1/1] gpio: omap: Fix PM runtime issue and remove most BANK_USED macros

2015-04-22 Thread Felipe Balbi
. In the long run we want to move to using PM runtime counts for each GPIO line to determine if a GPIO bank is used. Once we have a solution for omap_enable_gpio_module and omap_disable_gpio_module, we can remove the remaining BANK_USED macros. Cc: Felipe Balbi ba...@ti.com Cc: Grygorii

Re: OMAP: 4.0-rc7: dma_async_device_register issue

2015-04-09 Thread Felipe Balbi
Hi, On Thu, Apr 09, 2015 at 10:42:15AM +0200, Yegor Yefremov wrote: I see this during the boot: platform musb-hdrc.1.auto: Driver musb-hdrc requests probe deferral [ cut here ] WARNING: CPU: 0 PID: 1 at drivers/dma/dmaengine.c:863

[PATCH 1/2] arm: boot: dts: am437x-sk: fix for new newhaven display module revision

2015-04-09 Thread Felipe Balbi
is available on AM437x SK Beta and all new revisions while the older revision is only available on AM437x SK Alpha which, unfortunately, can't be supported anymore in mainline without a revert of this patch. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- 1 file

[PATCH 2/2] arm: boot: dts: am437x-sk: reduce col-scan-delay-us

2015-04-09 Thread Felipe Balbi
The new AM437x SK Beta boards have removed the large capacitors on the gpio-matrix column lines which means we can reduce col-scan-delay-us to 5us without loosing functionality. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- 1 file changed, 1 insertion

Re: OMAP: 4.0-rc7: dma_async_device_register issue

2015-04-09 Thread Felipe Balbi
On Thu, Apr 09, 2015 at 04:17:26PM +0200, Yegor Yefremov wrote: On Thu, Apr 9, 2015 at 3:37 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Apr 09, 2015 at 10:42:15AM +0200, Yegor Yefremov wrote: I see this during the boot: platform musb-hdrc.1.auto: Driver musb-hdrc requests probe

Re: LDP: next-20150402: twl4030 regression?

2015-04-08 Thread Felipe Balbi
On Mon, Apr 06, 2015 at 01:45:22PM -0500, Nishanth Menon wrote: On 04/06/2015 10:27 AM, Felipe Balbi wrote: Hi, On Mon, Apr 06, 2015 at 10:17:37AM -0500, Nishanth Menon wrote: On 04/06/2015 10:01 AM, Mark Brown wrote: On Mon, Apr 06, 2015 at 02:58:29PM +0100, Russell King - ARM Linux

Re: LDP: next-20150402: twl4030 regression?

2015-04-06 Thread Felipe Balbi
Hi, On Mon, Apr 06, 2015 at 10:17:37AM -0500, Nishanth Menon wrote: On 04/06/2015 10:01 AM, Mark Brown wrote: On Mon, Apr 06, 2015 at 02:58:29PM +0100, Russell King - ARM Linux wrote: On Mon, Apr 06, 2015 at 08:53:36AM -0500, Nishanth Menon wrote: at least a description of the problem

Re: [PATCH 1/1] usb: musb: dsps: fix build on i386 when COMPILE_TEST is set

2015-04-03 Thread Felipe Balbi
? It fixes a build error on i386. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/musb/musb_dsps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 2c0750e..8e089c1 100644 --- a/drivers/usb/musb

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-03-30 Thread Felipe Balbi
On Mon, Mar 30, 2015 at 04:15:45PM +0300, Roger Quadros wrote: Without this system suspend is broken on systems that have drivers calling enable/disable_irq_wake() for interrupts based off the dummy irq hook. (e.g. drivers/gpio/gpio-pcf857x.c)

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-03-30 Thread Felipe Balbi
On Mon, Mar 30, 2015 at 01:06:24PM -0500, Felipe Balbi wrote: On Mon, Mar 30, 2015 at 04:15:45PM +0300, Roger Quadros wrote: Without this system suspend is broken on systems that have drivers calling enable/disable_irq_wake() for interrupts based off the dummy irq hook. (e.g. drivers/gpio

<    1   2   3   4   5   6   7   8   9   10   >