Re: [PATCH 2/2] i2c: omap: fix "Too much work in one IRQ" irq handling

2014-11-14 Thread Felipe Balbi
Hi, (please, never top-post) On Sat, Nov 15, 2014 at 05:37:41AM +0300, Alexander Kochetkov wrote: > Hi Felipe, > > Initially you made the change (66b9298878742f08cb6e79b7c7d5632d782fd1e1): > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/i2c/busses/i2c-omap.c?id=6

Re: [PATCH 2/2] i2c: omap: fix "Too much work in one IRQ" irq handling

2014-11-14 Thread Felipe Balbi
Hi, On Sat, Nov 15, 2014 at 05:20:52AM +0400, Alexander Kochetkov wrote: > commit 66b9298878742f08cb6e79b7c7d5632d782fd1e1 (i2c: omap: switch over > to do {} while loop) changed the interrupt handler to abort transfers > in case interrupt serviced 100 times but commit's comment states that > "No f

Re: [PATCH 1/2] i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-14 Thread Felipe Balbi
On Sat, Nov 15, 2014 at 05:20:51AM +0400, Alexander Kochetkov wrote: > commit 1d7afc95946487945cc7f5019b41255b72224b70 (i2c: omap: ack IRQ in parts) > changed the interrupt handler to complete transfers without clearing > XRDY (AL case) and ARDY (NACK case) flags. XRDY or ARDY interrupt will be > f

Re: [PATCH 2/2] ARM: dts: Add devicetree for NovaTech OrionLXm

2014-11-14 Thread Felipe Balbi
Hi, On Fri, Nov 14, 2014 at 04:47:02PM -0600, George McCollister wrote: > Felipe, > > Thank you for your reply. no problem > >> + vbat: fixedregulator@0 { > >> + compatible = "regulator-fixed"; > >> + regulator-name = "vbat"; > >> + regulator-min-microvol

Re: [RFC PATCH 2/3] mmc: omap_hsmmc: add tuning support

2014-11-14 Thread Felipe Balbi
Hi, On Thu, Nov 13, 2014 at 06:26:18PM +0530, Kishon Vijay Abraham I wrote: > @@ -233,6 +263,48 @@ struct omap_mmc_of_data { > u8 controller_flags; > }; > > +static const u32 ref_tuning_4bits[] = { > + 0x00FF0FFF, 0xCCC3CCFF, 0xFFCC3CC3, 0xEFFEFFFE, > + 0xDDFFDFFF, 0xFBFFFBFF, 0xF

Re: [PATCH V3 3/3] mfd: palmas: Add support for optional wakeup

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 09:08:17AM -0800, Tony Lindgren wrote: > * Felipe Balbi [141114 08:20]: > > On Thu, Nov 13, 2014 at 09:40:31AM -0800, Tony Lindgren wrote: > > > +/** > > > + * handle_wakeirq_thread - call device runtime pm calls on wake-up > > >

Re: [PATCH V3 3/3] mfd: palmas: Add support for optional wakeup

2014-11-14 Thread Felipe Balbi
Hi, On Thu, Nov 13, 2014 at 09:40:31AM -0800, Tony Lindgren wrote: [snip] > From: Tony Lindgren > Date: Tue, 11 Nov 2014 07:53:55 -0800 > Subject: [PATCH] genirq: Add support for wake-up interrupts to fix irq > reentry issues in drivers > > As pointed out by Thomas Gleixner, at least omap wak

Re: [PATCH 2/2] ARM: dts: Add devicetree for NovaTech OrionLXm

2014-11-12 Thread Felipe Balbi
Hi, On Wed, Nov 12, 2014 at 04:41:33PM -0600, George McCollister wrote: > diff --git a/arch/arm/boot/dts/am335x-lxm.dts > b/arch/arm/boot/dts/am335x-lxm.dts > new file mode 100644 > index 000..0f7cbae > --- /dev/null > +++ b/arch/arm/boot/dts/am335x-lxm.dts > @@ -0,0 +1,354 @@ > +/* > + * Cop

Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled

2014-11-12 Thread Felipe Balbi
On Wed, Nov 12, 2014 at 01:20:27PM -0800, Tony Lindgren wrote: > * Dr. H. Nikolaus Schaller [141112 12:28]: > > Am 12.11.2014 um 16:45 schrieb Grazvydas Ignotas : > > > On Tue, Nov 4, 2014 at 5:42 PM, Tony Lindgren wrote: > > > > > > Pandora does, as well as GTA04 AFAIK, > > > > Yes. The trick

Re: [PATCH] usb: dwc3: gadget: Fix broken gadget on system suspend/resume

2014-11-12 Thread Felipe Balbi
On Wed, Nov 12, 2014 at 05:40:59PM +0200, Roger Quadros wrote: > On 11/12/2014 05:36 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Nov 12, 2014 at 05:32:00PM +0200, Roger Quadros wrote: > >> On 11/12/2014 05:08 PM, Felipe Balbi wrote: > >>> On We

Re: [PATCH] usb: dwc3: gadget: Fix broken gadget on system suspend/resume

2014-11-12 Thread Felipe Balbi
Hi, On Wed, Nov 12, 2014 at 05:32:00PM +0200, Roger Quadros wrote: > On 11/12/2014 05:08 PM, Felipe Balbi wrote: > > On Wed, Nov 12, 2014 at 04:58:16PM +0200, Roger Quadros wrote: > >> On TI SoCs (e.g. DRA7) we don't support the DWC3 hibernation feature. > >> We ne

Re: [PATCH] usb: dwc3: gadget: Fix broken gadget on system suspend/resume

2014-11-12 Thread Felipe Balbi
On Wed, Nov 12, 2014 at 04:58:16PM +0200, Roger Quadros wrote: > On TI SoCs (e.g. DRA7) we don't support the DWC3 hibernation feature. > We need to stop the gadget controller while system suspend > else it results in L3 Bus errors on resume with broken > USB gadget on J6-evm. > > [ 55.718226] WA

Re: [PATCH] usb: phy: fix twl4030 build regression

2014-11-11 Thread Felipe Balbi
to the OTG > structure") on my testing/next already: commit 7e1bbeb4292783dcc079156b8fa08d66d17219e0 Author: Felipe Balbi Date: Fri Nov 7 19:43:45 2014 -0600 usb: host: ohci: omap: fix build breakage commit e47d925 (usb: move the OTG state from the USB PHY to the OTG s

Re: [PATCH] usb: phy: fix twl4030 build regression

2014-11-11 Thread Felipe Balbi
On Tue, Nov 11, 2014 at 08:52:17AM -0600, Felipe Balbi wrote: > On Tue, Nov 11, 2014 at 10:36:09AM +0100, Arnd Bergmann wrote: > > Recent changes to the common OTG handling broke building the twl4030 > > OTG driver as found during an allmodconfig build of linux-next: > >

Re: [PATCH] arm: boot: dts: dra7: add labels to DWC3 nodes

2014-11-10 Thread Felipe Balbi
On Mon, Nov 10, 2014 at 03:27:09PM -0800, Tony Lindgren wrote: > * Felipe Balbi [141103 08:30]: > > by adding labels to DWC3 nodes, it's far easier > > for boards to reference them. > > > > Signed-off-by: Felipe Balbi > > Applying into omap-for-v3.19/dt, h

[PATCH 2/2] arm: boot: dts: am4372: enable dwc3 suspend PHY quirk

2014-11-06 Thread Felipe Balbi
initialization. Synopsys Databook requires that we enable Suspend PHY bit after initialization but that, unfortunately, breaks AM437x. Signed-off-by: Felipe Balbi --- arch/arm/boot/dts/am4372.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372

[PATCH 1/2] usb: dwc3: core: enable phy suspend quirk on non-FPGA

2014-11-06 Thread Felipe Balbi
as it turns out, at least AM437x silicon (non-FPGA) needs to enable PHY suspend quirk. So let's allow for PHY suspend quirk to be used with non-FPGA builds too. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [PATCH] ARM: dts: Add am57xx-beagle-x15

2014-11-06 Thread Felipe Balbi
ed: > i) Ethernet - depends on SoC dts fixes > ii) USB Client (USB2) - depends on GPIO extcon > ii) HDMI - additional driver fixes pending > iii) Audio - additional driver fixes pending > > Signed-off-by: Felipe Balbi > Signed-off-by: Nishanth Menon > --- >

Re: [PATCH] arm: omap: hwmod: drop unnecessary list initialization

2014-11-06 Thread Felipe Balbi
On Mon, Nov 03, 2014 at 11:39:52PM -0600, Felipe Balbi wrote: > Hi, > > On Mon, Jul 28, 2014 at 05:24:34AM +, Paul Walmsley wrote: > > On Tue, 15 Jul 2014, Felipe Balbi wrote: > > > > > ml->node and sl->node are currently initialized > > > by

[PATCH v2] MAINTAINERS: add more files under OMAP SUPPORT

2014-11-06 Thread Felipe Balbi
These files are very important to the healt of the OMAP architecture, specially when it comes to PM support which currently we have working for at least OMAP3 and we'd like to know about any changes being made to our PMICs and IRQ controllers. Signed-off-by: Felipe Balbi --- MAINTAINERS

Re: [RESEND PATCH 1/2] extcon: gpio: Add dt support for the driver

2014-11-05 Thread Felipe Balbi
On Wed, Nov 05, 2014 at 08:59:47PM +0530, George Cherian wrote: > Add device tree support to extcon-gpio driver. > Add devicetree binding documentation > > While at that > - Cleanup the pdata as there are no users for the same. should be a patch of its own. > - Convert the driver to

Re: [PATCH 0/4] extcon: gpio: add DT support

2014-11-05 Thread Felipe Balbi
On Wed, Nov 05, 2014 at 08:55:17PM +0530, George Cherian wrote: > > On 11/04/2014 08:11 PM, Felipe Balbi wrote: > >On Tue, Nov 04, 2014 at 11:42:04AM +0530, George Cherian wrote: > >>Hi Felipe et al. > >> > >>Another series was posted by removing the plat

Re: [PATCH 0/4] extcon: gpio: add DT support

2014-11-04 Thread Felipe Balbi
On Tue, Nov 04, 2014 at 11:42:04AM +0530, George Cherian wrote: > Hi Felipe et al. > > Another series was posted by removing the platform support. > https://lkml.org/lkml/2014/10/14/244 > > I guess I forgot to copy linux-omap. you do too many things in patch one. I wonder why you decided to comb

Re: [PATCH] arm: omap: hwmod: drop unnecessary list initialization

2014-11-03 Thread Felipe Balbi
Hi, On Mon, Jul 28, 2014 at 05:24:34AM +, Paul Walmsley wrote: > On Tue, 15 Jul 2014, Felipe Balbi wrote: > > > ml->node and sl->node are currently initialized > > by means of INIT_LIST_HEAD(). That initialiation > > is followed by a list_add() call. >

Re: [PATCH] MAINTAINERS: add more files under OMAP SUPPORT

2014-11-03 Thread Felipe Balbi
On Mon, Nov 03, 2014 at 06:32:53PM -0600, Felipe Balbi wrote: > These files are very important to the healt > of the OMAP architecture, specially when it > comes to PM support which currently we have > working for at least OMAP3 and we'd like > to know about any changes being

[PATCH] MAINTAINERS: add more files under OMAP SUPPORT

2014-11-03 Thread Felipe Balbi
These files are very important to the healt of the OMAP architecture, specially when it comes to PM support which currently we have working for at least OMAP3 and we'd like to know about any changes being made to our PMICs and IRQ controllers. Signed-off-by: Felipe Balbi --- MAINTAINERS

Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's

2014-11-03 Thread Felipe Balbi
Hi, On Mon, Nov 03, 2014 at 10:51:08AM -0800, Guenter Roeck wrote: > On Mon, Nov 03, 2014 at 12:06:02PM -0600, Felipe Balbi wrote: > > On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote: > > > On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: > >

Re: [PATCH v3 09/47] mfd: palmas: Register with kernel power-off handler

2014-11-03 Thread Felipe Balbi
On Mon, Nov 03, 2014 at 10:36:53AM -0800, Guenter Roeck wrote: > On Mon, Nov 03, 2014 at 11:59:54AM -0600, Felipe Balbi wrote: > > On Mon, Nov 03, 2014 at 05:56:45PM +, Lee Jones wrote: > > > On Mon, 27 Oct 2014, Guenter Roeck wrote: > > > > > > >

Re: [PATCH v3 00/47] kernel: Add support for power-off handler call chain

2014-11-03 Thread Felipe Balbi
Hi, On Mon, Nov 03, 2014 at 10:22:13AM -0800, Guenter Roeck wrote: > On Mon, Nov 03, 2014 at 11:59:35AM -0600, Felipe Balbi wrote: > > Hi, > > > > On Mon, Oct 27, 2014 at 08:55:07AM -0700, Guenter Roeck wrote: > > > Various drivers implement architecture a

Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's

2014-11-03 Thread Felipe Balbi
On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote: > On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: > > From: George Cherian > > > > Convert the driver to use gpiod_* API's. > > > > Reviewed-by: Roger Quadros > > Sign

Re: [PATCH v3 17/47] mfd: tps65910: Register with kernel power-off handler

2014-11-03 Thread Felipe Balbi
On Mon, Oct 27, 2014 at 08:55:24AM -0700, Guenter Roeck wrote: > Register with kernel power-off handler instead of setting pm_power_off > directly. Register with low priority to reflect that the original code > only sets pm_power_off if it was not already set. > > Cc: Samuel Ortiz > Cc: Lee Jones

Re: [PATCH v3 09/47] mfd: palmas: Register with kernel power-off handler

2014-11-03 Thread Felipe Balbi
On Mon, Nov 03, 2014 at 05:56:45PM +, Lee Jones wrote: > On Mon, 27 Oct 2014, Guenter Roeck wrote: > > > Register with kernel power-off handler instead of setting pm_power_off > > directly. Register with low priority to reflect that the original code > > only sets pm_power_off if it was not al

Re: [PATCH v3 00/47] kernel: Add support for power-off handler call chain

2014-11-03 Thread Felipe Balbi
Hi, On Mon, Oct 27, 2014 at 08:55:07AM -0700, Guenter Roeck wrote: > Various drivers implement architecture and/or device specific means to > remove power from the system. For the most part, those drivers set the > global variable pm_power_off to point to a function within the driver. > > This m

Re: [PATCH v3 16/47] mfd: tps6586x: Register with kernel power-off handler

2014-11-03 Thread Felipe Balbi
On Mon, Oct 27, 2014 at 08:55:23AM -0700, Guenter Roeck wrote: > Register with kernel power-off handler instead of setting pm_power_off > directly. Register with low priority to reflect that the original code > only sets pm_power_off if it was not already set. > > Cc: Samuel Ortiz > Cc: Lee Jones

[PATCH] ARM: dts: dra7-evm: Add extcon nodes for USB

2014-11-03 Thread Felipe Balbi
ge Cherian Signed-off-by: Sekhar Nori Signed-off-by: Felipe Balbi --- ** ** ** ** UNTESTED** **

Re: [PATCH 4/4] extcon: gpio: Add support for using cable names

2014-11-03 Thread Felipe Balbi
On Mon, Nov 03, 2014 at 10:32:30AM -0600, Felipe Balbi wrote: > From: George Cherian > > Add support for using cable names. Enables other drivers to register interest > and get notified using extcon provided notifier call backs. > > Signed-off-by: George Cherian > Signe

[PATCH 2/4] extcon: gpio: Add dt support for the driver.

2014-11-03 Thread Felipe Balbi
From: George Cherian Add device tree support to extcon-gpio driver. Add devicetree binding documentation Cc: devicet...@vger.kernel.org Signed-off-by: George Cherian Signed-off-by: Sekhar Nori Signed-off-by: Felipe Balbi --- .../devicetree/bindings/extcon/extcon-gpio.txt | 21

[PATCH 4/4] extcon: gpio: Add support for using cable names

2014-11-03 Thread Felipe Balbi
From: George Cherian Add support for using cable names. Enables other drivers to register interest and get notified using extcon provided notifier call backs. Signed-off-by: George Cherian Signed-off-by: Sekhar Nori --- Documentation/devicetree/bindings/extcon/extcon-gpio.txt | 2 ++ drivers/

[PATCH 3/4] extcon: gpio: Always use gpio_get_value_cansleep

2014-11-03 Thread Felipe Balbi
From: George Cherian Some gpio's can sleep while reading, so always use gpio_get_value_cansleep to get data. This fixes warning from gpiolib due to wrong API usage. Reviewed-by: Roger Quadros Signed-off-by: George Cherian Signed-off-by: Sekhar Nori Signed-off-by: Felipe Balbi --- dr

[PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's

2014-11-03 Thread Felipe Balbi
From: George Cherian Convert the driver to use gpiod_* API's. Reviewed-by: Roger Quadros Signed-off-by: George Cherian Signed-off-by: Sekhar Nori Signed-off-by: Felipe Balbi --- drivers/extcon/extcon-gpio.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff

[PATCH 0/4] extcon: gpio: add DT support

2014-11-03 Thread Felipe Balbi
Hi, this series has been tested with v3.18-rc2 with a yet-to-be-released board (called X15). That board is DT-only and we use extcon-gpio to decide which USB mode should be used (host or peripheral). George Cherian (4): extcon: gpio: Convert the driver to use gpio desc API's extcon: gpio: Add

[PATCH] arm: boot: dts: dra7: add labels to DWC3 nodes

2014-11-03 Thread Felipe Balbi
by adding labels to DWC3 nodes, it's far easier for boards to reference them. Signed-off-by: Felipe Balbi --- soon we will need to reference these nodes in order to add extcon binding, so USB can be enabled out-of-the-box. arch/arm/boot/dts/dra7.dtsi | 8 1 file changed, 4 inser

Re: [PATCH v3 0/2] Add DRA7xx CPSW Ethernet support in Device Tree

2014-11-03 Thread Felipe Balbi
only so that people can use dra7-evm on linux-next. > > Quickly tested as well: > http://slexy.org/raw/s2vISJxYrR > > Please feel free to add: > Tested-by: Nishanth Menon > Acked-by: Nishanth Menon I've used these patches with X15 (DRA7xx-based yet-to-be-released board) with v3.18-rc2. Tested-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH V4 3/3] rtc: omap: Support regulator supply for RTC

2014-10-28 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 03:28:52PM +0530, Lokesh Vutla wrote: > Certain SoCs such as DRA7, RTC is an independent voltage domain of it's own > and on platforms such as DRA7-evm, this may be supplied by individual > regulator on it's own. > So make the OMAP RTC driver support a power regulator. > >

Re: [PATCH v3] rtc: omap: add support for pmic_power_en

2014-10-27 Thread Felipe Balbi
On Mon, Oct 27, 2014 at 05:56:54PM +0100, Johan Hovold wrote: > On Mon, Oct 27, 2014 at 11:45:44AM -0500, Felipe Balbi wrote: > > On Mon, Oct 27, 2014 at 09:09:28AM +0100, Johan Hovold wrote: > > > Add new property "ti,system-power-controller" to register the RTC

Re: [PATCH v3] rtc: omap: add support for pmic_power_en

2014-10-27 Thread Felipe Balbi
ansition to OFF on ALARM2 events and > back to ON on subsequent ALARM (wakealarm) events. > > This is based on earlier work by Colin Foe-Parker and AnilKumar Ch. [1] > > [1] https://www.mail-archive.com/linux-omap@vger.kernel.org/msg82127.html > > Tested-by: Felipe Balbi >

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Felipe Balbi
On Fri, Oct 24, 2014 at 09:55:32PM +0200, Johan Hovold wrote: > On Fri, Oct 24, 2014 at 02:44:42PM -0500, Felipe Balbi wrote: > > On Fri, Oct 24, 2014 at 09:36:55PM +0200, Johan Hovold wrote: > > > On Fri, Oct 24, 2014 at 02:29:48PM -0500, Felipe Balbi wrote: > > > &g

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Felipe Balbi
On Fri, Oct 24, 2014 at 09:36:55PM +0200, Johan Hovold wrote: > On Fri, Oct 24, 2014 at 02:29:48PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Fri, Oct 24, 2014 at 02:25:40PM -0500, Felipe Balbi wrote: > > > On Fri, Oct 24, 2014 at 09:02:51PM +0200, Johan Hovold

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Felipe Balbi
Hi, On Fri, Oct 24, 2014 at 02:25:40PM -0500, Felipe Balbi wrote: > On Fri, Oct 24, 2014 at 09:02:51PM +0200, Johan Hovold wrote: > > [ +CC: Russell ] > > > > On Fri, Oct 24, 2014 at 11:08:45AM -0500, Felipe Balbi wrote: > > > > > I tested this entire series

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Felipe Balbi
On Fri, Oct 24, 2014 at 09:02:51PM +0200, Johan Hovold wrote: > [ +CC: Russell ] > > On Fri, Oct 24, 2014 at 11:08:45AM -0500, Felipe Balbi wrote: > > > I tested this entire series with my BBB and it still works fine. However > > I still get below panic. This tim

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Felipe Balbi
0x9d0) [ 63.135900] [] (do_exit) from [] (SyS_reboot+0x14c/0x1e8) [ 63.143361] [] (SyS_reboot) from [] (ret_fast_syscall+0x0/0x48) [ 63.151596] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x Then again, this also happens by simply calling poweroff without enabling wakealarm. In any case, for the whole series: Tested-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH V3 3/3] rtc: omap: Support regulator supply for RTC

2014-10-24 Thread Felipe Balbi
On Fri, Oct 24, 2014 at 08:26:43AM -0500, Nishanth Menon wrote: > On 10/23/2014 11:53 PM, Lokesh Vutla wrote: > > On some Soc's RTC is powered by an external power regulator. > SoC ? -> could you rephrase this to indicate "certain SoCs such as > DRA7, RTC is an independent voltage domain of it's ow

Re: [PATCH V4 3/3] rtc: omap: Support regulator supply for RTC

2014-10-24 Thread Felipe Balbi
ry, there was already a new version: Reviewed-by: Felipe Balbi > --- > Changes since v3: > - Removed extra Optional properties header. > - Moved regulator get before platform_set_drvdatai() as suggested by Johan > > Documentation/devicetree/bindings/rtc/rtc-o

Re: [PATCH V3 3/3] rtc: omap: Support regulator supply for RTC

2014-10-24 Thread Felipe Balbi
t; > pm_runtime_put_sync(&pdev->dev); > > pm_runtime_disable(&pdev->dev); > > > > + if (rtc->supply) > > + regulator_disable(rtc->supply); > > + > > return ret; > > } > > > > @@ -649,6 +670,9 @@ static int __exit omap_rtc_remove(struct > > platform_device *pdev) > > pm_runtime_put_sync(&pdev->dev); > > pm_runtime_disable(&pdev->dev); > > > > + if (rtc->supply) > > + regulator_disable(rtc->supply); > > + > > return 0; > > } > > Looks good otherwise. Feel free to add > > Reviewed-by: Johan Hovold Conditional on Johan's comments: Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH V3 1/3] rtc: omap: use module_platform_driver

2014-10-24 Thread Felipe Balbi
; Signed-off-by: Lokesh Vutla Reviewed-by: Felipe Balbi > --- > drivers/rtc/rtc-omap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c > index e74750f..d9bb5e7 100644 > --- a/drivers/rtc/rtc-o

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-23 Thread Felipe Balbi
On Wed, Oct 22, 2014 at 12:23:05PM +0200, Johan Hovold wrote: > On Wed, Oct 15, 2014 at 12:08:32PM -0500, Felipe Balbi wrote: > > On Wed, Oct 15, 2014 at 07:06:28PM +0200, Johan Hovold wrote: > > > On Wed, Oct 15, 2014 at 11:55:02AM -0500, Felipe Balbi wrote: > > > &g

Re: [PATCH 09/12] rtc: omap: add support for pmic_power_en

2014-10-23 Thread Felipe Balbi
On Wed, Oct 22, 2014 at 12:18:49PM +0200, Johan Hovold wrote: > On Fri, Oct 10, 2014 at 01:07:27PM -0500, Felipe Balbi wrote: > > On Thu, Oct 09, 2014 at 09:06:31PM +0200, Johan Hovold wrote: > > > > - /* clear pending irqs, and set 1/second periodic, > > > - * whi

Re: [PATCH 08/12] rtc: omap: restore irq state after reading TC registers

2014-10-23 Thread Felipe Balbi
On Wed, Oct 22, 2014 at 12:50:11PM +0200, Johan Hovold wrote: > On Sat, Oct 11, 2014 at 07:47:58PM -0500, Felipe Balbi wrote: > > On Sat, Oct 11, 2014 at 12:12:01PM +0200, Johan Hovold wrote: > > > On Fri, Oct 10, 2014 at 01:02:31PM -0500, Felipe Balbi wrote: > > > &g

Re: RCU bug with v3.17-rc3 ?

2014-10-19 Thread Felipe Balbi
Hi, On Sun, Oct 19, 2014 at 10:54:16AM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 15, 2014 at 10:25:13PM +0100, Russell King - ARM Linux wrote: > > On Wed, Oct 15, 2014 at 10:23:10PM +0100, Russell King - ARM Linux wrote: > > > As I said, I have a patch in progress, but it seems that the

Re: USB Ethernet gadget on Nokia n900

2014-10-19 Thread Felipe Balbi
Hi, On Sun, Oct 19, 2014 at 12:07:39PM +0200, Pavel Machek wrote: > On Sun 2014-10-19 11:01:07, Pavel Machek wrote: > > Hi! > > > > From 3.6 to 3.10, USB networking works on Nokia N900. With 3.11, it > > fails with messages on the host. I also tried to get it to work on > > 3.14 and 3.17, with no

Re: [PATCH 2/5] OMAPFB: remove wrong __exit and __exit_p()

2014-10-16 Thread Felipe Balbi
On Thu, Oct 16, 2014 at 12:39:44PM +0300, Tomi Valkeinen wrote: > omapfb device can be unbound, so using __exit_p() for the driver's > remove callback is wrong. > > Remove __exit_p() and __exit from the driver's remove. > > Signed-off-by: Tomi Valkeinen and why was my version dropped ? http://

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-15 Thread Felipe Balbi
On Wed, Oct 15, 2014 at 07:06:28PM +0200, Johan Hovold wrote: > On Wed, Oct 15, 2014 at 11:55:02AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Oct 09, 2014 at 09:06:22PM +0200, Johan Hovold wrote: > > > This series fixes a few issues with the omap rtc-dri

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-15 Thread Felipe Balbi
Hi, On Thu, Oct 09, 2014 at 09:06:22PM +0200, Johan Hovold wrote: > This series fixes a few issues with the omap rtc-driver, cleans up a bit > and finally adds support for the PMIC control feature found in some > revisions of this RTC IP block. > > Ultimately, this allows for powering off the Bea

Re: [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-15 Thread Felipe Balbi
Hi, On Wed, Oct 15, 2014 at 06:43:40PM +0300, Tomi Valkeinen wrote: > >> Somehow omapfb device is still unbound from the driver, as I can then > >> bind it again, causing probe to be called. Which breaks everything. > >> > >> I would've thought that unbinding is not possible if remove is missing,

Re: [PATCH v2 1/4] dwc3: exynos: Add support for SCLK present on Exynos7

2014-10-15 Thread Felipe Balbi
Hi, On Tue, Oct 14, 2014 at 10:25:00AM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Tue, Oct 14, 2014 at 4:14 AM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Oct 13, 2014 at 01:54:59PM +0900, Anton Tikhomirov wrote: > >> Hi Vivek, > >> >

Re: [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-15 Thread Felipe Balbi
Hi, On Wed, Oct 15, 2014 at 03:13:34PM +0300, Tomi Valkeinen wrote: > Hi, > > On 14/10/14 21:28, Felipe Balbi wrote: > > if we leave __exit annotation, driver can't be unbound > > through sysfs. > > > > Signed-off-by: Felipe Balbi > > --- > >

Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit

2014-10-15 Thread Felipe Balbi
On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote: > This allows testing the watchdog easily with distros just by > doing pkill -9 watchdog. > > Reported-by: Thomas Dziedzic > Signed-off-by: Tony Lindgren Reviewed-by: Felipe Balbi > > --- a/drivers/watchd

Re: [PATCH 2/3] video: fbdev: omap2: omapfb: add missing MODULE_ALIAS()

2014-10-15 Thread Felipe Balbi
On Wed, Oct 15, 2014 at 03:20:19PM +0300, Tomi Valkeinen wrote: > On 14/10/14 21:28, Felipe Balbi wrote: > > without MODULE_ALIAS(), omapfb won't get loaded > > automatically. > > > > Signed-off-by: Felipe Balbi > > --- > > drivers/video/fbdev/

Re: [PATCH 2/3] video: fbdev: omap2: omapfb: add missing MODULE_ALIAS()

2014-10-15 Thread Felipe Balbi
HI, On Wed, Oct 15, 2014 at 03:46:10PM +0300, Tomi Valkeinen wrote: > On 14/10/14 21:34, Felipe Balbi wrote: > > On Tue, Oct 14, 2014 at 01:28:54PM -0500, Felipe Balbi wrote: > >> without MODULE_ALIAS(), omapfb won't get loaded > >> automatically. >

Re: [PATCH 2/3] video: fbdev: omap2: omapfb: add missing MODULE_ALIAS()

2014-10-14 Thread Felipe Balbi
On Tue, Oct 14, 2014 at 01:28:54PM -0500, Felipe Balbi wrote: > without MODULE_ALIAS(), omapfb won't get loaded > automatically. > > Signed-off-by: Felipe Balbi little note here. This makes omapfb load automatically, but display still doesn't work with DSS as modules. Ba

[PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-14 Thread Felipe Balbi
if we leave __exit annotation, driver can't be unbound through sysfs. Signed-off-by: Felipe Balbi --- drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/

[PATCH 3/3] arm: boot: dts: am437x-sk: fix lcd enable pin mux data

2014-10-14 Thread Felipe Balbi
Caused by a copy & paste error. Note that even with this bug AM437x SK display still works because GPIO mux mode is always enabled. It's still wrong to mux somebody else's pin. Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x isn't used for anything. Signed-off-by: Felipe B

[PATCH 2/3] video: fbdev: omap2: omapfb: add missing MODULE_ALIAS()

2014-10-14 Thread Felipe Balbi
without MODULE_ALIAS(), omapfb won't get loaded automatically. Signed-off-by: Felipe Balbi --- drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/fbdev/omap2/omapfb/omapfb-m

Re: [PATCH v2 1/4] dwc3: exynos: Add support for SCLK present on Exynos7

2014-10-13 Thread Felipe Balbi
Hi, On Mon, Oct 13, 2014 at 01:54:59PM +0900, Anton Tikhomirov wrote: > Hi Vivek, > > > Exynos7 also has a separate special gate clock going to the IP > > apart from the usual AHB clock. So add support for the same. > > As we discussed before, Exynos7 SoCs have 7 clocks to be controlled > by the

Re: [PATCH 03/12] rtc: omap: fix class-device registration

2014-10-13 Thread Felipe Balbi
Hi, On Sat, Oct 11, 2014 at 11:59:47AM +0200, Johan Hovold wrote: > > > @@ -450,14 +441,14 @@ static int __init omap_rtc_probe(struct > > > platform_device *pdev) > > > > > > /* handle periodic and alarm irqs */ > > > if (devm_request_irq(&pdev->dev, omap_rtc_timer, rtc_irq, 0, > > > -

Re: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-13 Thread Felipe Balbi
Hi, On Sun, Oct 12, 2014 at 08:42:40PM +0200, Johan Hovold wrote: > On Sat, Oct 11, 2014 at 07:50:07PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Sat, Oct 11, 2014 at 12:20:04PM +0200, Johan Hovold wrote: > > > On Fri, Oct 10, 2014 at 01:02:56PM -0500, Felipe Ba

Re: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-11 Thread Felipe Balbi
Hi, On Sat, Oct 11, 2014 at 12:20:04PM +0200, Johan Hovold wrote: > On Fri, Oct 10, 2014 at 01:02:56PM -0500, Felipe Balbi wrote: > > On Fri, Oct 10, 2014 at 01:00:54PM -0500, Felipe Balbi wrote: > > > On Thu, Oct 09, 2014 at 09:06:29PM +0200, Johan Hovold wrote: > >

Re: [PATCH 08/12] rtc: omap: restore irq state after reading TC registers

2014-10-11 Thread Felipe Balbi
On Sat, Oct 11, 2014 at 12:12:01PM +0200, Johan Hovold wrote: > On Fri, Oct 10, 2014 at 01:02:31PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Oct 09, 2014 at 09:06:30PM +0200, Johan Hovold wrote: > > > Make sure to restore local irq state when readin

Re: [PATCH 11/12] ARM: dts: am33xx: update rtc node compatible property

2014-10-10 Thread Felipe Balbi
On Thu, Oct 09, 2014 at 09:06:33PM +0200, Johan Hovold wrote: > Enable am33xx specific RTC features (e.g. PMIC control) by adding > "ti,am3352-rtc" to the compatible property of the rtc node. > > Signed-off-by: Johan Hovold Reviewed-by: Felipe Balbi > --- > arch/

Re: [PATCH 12/12] ARM: dts: am335x-bone-common: enable power off and rtc wake up

2014-10-10 Thread Felipe Balbi
ne white uses that. Perhaps move this from bone-common to boneblack.dts ? other than that Reviewed-by: Felipe Balbi > Signed-off-by: Johan Hovold > --- > arch/arm/boot/dts/am335x-bone-common.dtsi | 4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/a

Re: [PATCH 10/12] rtc: omap: enable wake-up from power off

2014-10-10 Thread Felipe Balbi
On Thu, Oct 09, 2014 at 09:06:32PM +0200, Johan Hovold wrote: > The ALARM interrupt must not be disabled during shutdown in order to be > able to power up the system using an RTC alarm. > > Signed-off-by: Johan Hovold nicely done! Reviewed-by: Felipe Balbi > --- > driv

Re: [PATCH 09/12] rtc: omap: add support for pmic_power_en

2014-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 09, 2014 at 09:06:31PM +0200, Johan Hovold wrote: > @@ -124,11 +138,18 @@ > */ > #define OMAP_RTC_HAS_POWER_UP_RESET BIT(3) > > +/* > + * Some RTC IP revisions can control an external PMIC via the pmic_power_en > + * pin. > + */ > +#define OMAP_RTC_HAS_PMIC_MODE

Re: [PATCH 08/12] rtc: omap: restore irq state after reading TC registers

2014-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 09, 2014 at 09:06:30PM +0200, Johan Hovold wrote: > Make sure to restore local irq state when reading the timer/calendar > (TC) registers, so that omap_rtc_read_time() can be called with > interrupts disabled. > > Signed-off-by: Johan Hovold > --- > drivers/rtc/rtc-omap.c | 6 ++

Re: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-10 Thread Felipe Balbi
On Fri, Oct 10, 2014 at 01:00:54PM -0500, Felipe Balbi wrote: > On Thu, Oct 09, 2014 at 09:06:29PM +0200, Johan Hovold wrote: > > Some legacy RTC IP revisions has a power-up reset flag in the status > > register that later revisions lack. > > > > As this flag is alway

Re: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-10 Thread Felipe Balbi
ke sure to only clear the flag and > print the info message on legacy platforms. > > Signed-off-by: Johan Hovold Reviewed-by: Felipe Balbi > --- > drivers/rtc/rtc-omap.c | 23 +-- > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/d

Re: [PATCH 06/12] rtc: omap: use dev_info and dev_dbg

2014-10-10 Thread Felipe Balbi
On Thu, Oct 09, 2014 at 09:06:28PM +0200, Johan Hovold wrote: > Use dev_info and dev_dbg rather than pr_info and pr_debug. > > Signed-off-by: Johan Hovold thanks! Reviewed-by: Felipe Balbi > --- > drivers/rtc/rtc-omap.c | 19 +-- > 1 file changed, 9

Re: [PATCH 04/12] rtc: omap: remove unused register-base define

2014-10-10 Thread Felipe Balbi
On Thu, Oct 09, 2014 at 09:06:26PM +0200, Johan Hovold wrote: > Remove register-base define, which is no longer used. > > Signed-off-by: Johan Hovold Reviewed-by: Felipe Balbi > --- > drivers/rtc/rtc-omap.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/

Re: [PATCH 05/12] rtc: omap: remove redundant debug message

2014-10-10 Thread Felipe Balbi
On Thu, Oct 09, 2014 at 09:06:27PM +0200, Johan Hovold wrote: > Remove redundant debug message. > > The corresponding error has already been logged by rtc core. > > Signed-off-by: Johan Hovold Reviewed-by: Felipe Balbi > --- > drivers/rtc/rtc-omap.c | 6 ++

Re: [PATCH 03/12] rtc: omap: fix class-device registration

2014-10-10 Thread Felipe Balbi
On Thu, Oct 09, 2014 at 09:06:25PM +0200, Johan Hovold wrote: > Make sure not to register the class device until after it has been > configured and interrupt handlers registered at probe. > > Currently, the device is not fully configured (e.g. 24-hour mode) when > the class device is registered, s

Re: [PATCH 02/12] rtc: omap: fix missing wakealarm attribute

2014-10-10 Thread Felipe Balbi
ors. > > Fixes: 1d2e2b65d098 ("rtc: omap: restore back (hard-code) wakeup support") > Cc: stable > Signed-off-by: Johan Hovold > --- Reviewed-by: Felipe Balbi > drivers/rtc/rtc-omap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH 01/12] rtc: omap: fix clock-source configuration

2014-10-10 Thread Felipe Balbi
g. clock-source selection). > > Fixes: cd914bba03d8 ("drivers/rtc/rtc-omap.c: add support for enabling > 32khz clock") > Cc: stable > > Signed-off-by: Johan Hovold Reviewed-by: Felipe Balbi > --- > drivers/rtc/rtc-omap.c | 6 -- > 1 file changed, 4 ins

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-10 Thread Felipe Balbi
HI, On Thu, Oct 09, 2014 at 09:06:22PM +0200, Johan Hovold wrote: > This series fixes a few issues with the omap rtc-driver, cleans up a bit > and finally adds support for the PMIC control feature found in some > revisions of this RTC IP block. > > Ultimately, this allows for powering off the Bea

Re: RCU bug with v3.17-rc3 ?

2014-10-10 Thread Felipe Balbi
On Thu, Oct 09, 2014 at 04:07:15PM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Oct 09, 2014 at 03:46:37PM -0500, Felipe Balbi wrote: > > On Thu, Oct 09, 2014 at 10:41:01PM +0200, Rabin Vincent wrote: > > > On Thu, Oct 09, 2014 at 11:26:56AM -0500, Felipe Balbi wrote: >

Re: RCU bug with v3.17-rc3 ?

2014-10-09 Thread Felipe Balbi
Hi, On Thu, Oct 09, 2014 at 03:46:37PM -0500, Felipe Balbi wrote: > On Thu, Oct 09, 2014 at 10:41:01PM +0200, Rabin Vincent wrote: > > On Thu, Oct 09, 2014 at 11:26:56AM -0500, Felipe Balbi wrote: > > > alright, it's pretty deterministic however. Always on the same test, no

Re: RCU bug with v3.17-rc3 ?

2014-10-09 Thread Felipe Balbi
Hi, On Thu, Oct 09, 2014 at 10:41:01PM +0200, Rabin Vincent wrote: > On Thu, Oct 09, 2014 at 11:26:56AM -0500, Felipe Balbi wrote: > > alright, it's pretty deterministic however. Always on the same test, no > > matter which USB controller, no matter if backing store is RAM or

Re: RCU bug with v3.17-rc3 ?

2014-10-09 Thread Felipe Balbi
Hi, On Thu, Oct 09, 2014 at 11:26:56AM -0500, Felipe Balbi wrote: > > I'm thinking it's not the slot pointer itself that's bad, because > > __radix_tree_lookup() dereferences that to test if it's populated > > before returning it, and slot life-time is guara

Re: RCU bug with v3.17-rc3 ?

2014-10-09 Thread Felipe Balbi
Hi Johannes, On Thu, Oct 09, 2014 at 12:01:38PM -0400, Johannes Weiner wrote: > On Wed, Oct 08, 2014 at 04:29:38PM -0500, Felipe Balbi wrote: > > Finally bisected it down to commit 139e561660fe11e0fc35e142a800df3dd7d03e9d > > (lib: radix_tree: tree node interface). Here&#x

Re: RCU bug with v3.17-rc3 ?

2014-10-08 Thread Felipe Balbi
Hi, On Wed, Oct 08, 2014 at 12:57:07PM -0500, Felipe Balbi wrote: [ snip ] > > > > It seems to be a difficult-to-reproduce race though. On a second boot it > > > > didn't die during boot, but died with my USB test case. Unfortunately, > > > > the platf

Re: RCU bug with v3.17-rc3 ?

2014-10-08 Thread Felipe Balbi
Hi, On Wed, Oct 08, 2014 at 12:13:22PM -0500, Felipe Balbi wrote: > On Fri, Sep 05, 2014 at 02:32:16PM -0700, Paul E. McKenney wrote: > > On Thu, Sep 04, 2014 at 03:04:03PM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Sep 04, 2014 at 02:25:35PM -

Re: RCU bug with v3.17-rc3 ?

2014-10-08 Thread Felipe Balbi
Hi, On Fri, Sep 05, 2014 at 02:32:16PM -0700, Paul E. McKenney wrote: > On Thu, Sep 04, 2014 at 03:04:03PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Sep 04, 2014 at 02:25:35PM -0500, Felipe Balbi wrote: > > > On Thu, Sep 04, 2014 at 12:16:42PM -0700, Paul

<    2   3   4   5   6   7   8   9   10   11   >