Re: [PATCHv12 07/49] clk: divider: add support for low level ops

2014-01-04 Thread Gerhard Sittig
On Fri, Jan 03, 2014 at 11:17 +0200, Tero Kristo wrote: > > On 12/22/2013 07:52 PM, Gerhard Sittig wrote: > >[ dropped devicetree, we're clock specific here ] > > > >On Fri, Dec 20, 2013 at 18:34 +0200, Tero Kristo wrote: > >> > >>Divider clock

Re: [PATCHv12 07/49] clk: divider: add support for low level ops

2013-12-22 Thread Gerhard Sittig
the clock item, or is "global" for a platform, yet can get re-registered at runtime (see the comment on 06/49)? And why are you referencing clk_readl() instead of clk_readl_default() which you specifically have introduced in the previous patch? Adding a copy of the routine and using

Re: [PATCHv12 06/49] clk: add support for low level register ops

2013-12-22 Thread Gerhard Sittig
but does not remove the then obsolete static inlines from the header. Tero, can you please verify whether the clk_readl() and clk_writel() routines from become obsolete with your patch, or whether any unchanged users remain? Are other parts of v12 still stuck? I only saw 15 of 49 patches. virtuall

Re: [PATCHv9 01/43] clk: Add support for regmap register read/write

2013-11-05 Thread Gerhard Sittig
hile patches are pending (currently under review and receiving further improvement) which introduce several alternative implementations of clk_readl() depending on the platform. Making all of them duplicate the "regmap vs direct register access" branch would be as bad. Keeping one set of clk_r