rted-by: Sebastian Reichel
> Signed-off-by: Aaro Koskinen
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
rted-by: Sebastian Reichel
> Signed-off-by: Aaro Koskinen
Thanks for the patch. Can you please remove timer.h and include
workqueue.h instead?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsub
s. Also tmp
must not be reused by a subsequent call to scatterwalk_ffwd.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body
cking.
The reqeust context on the other hand is specific to a request
so it can be used to store information.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "un
On Wed, Jul 08, 2015 at 03:48:05PM +0800, Herbert Xu wrote:
> On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote:
> >
> > >> +if (req->assoclen + req->cryptlen == 0) {
> > >> +scatterwalk_map_and_copy(ctx-
> where Y0 = IV||(0^31)1
> I have E(K, Y0) calculated in previous step. And copying it
> to destination if assoclen and cryptlen is 0.
>
> Correct me if I am wrong.
It should be E(K, Y0) ^ GHASH(0). So unless GHASH(0) == 0, your
code doesn't work.
Cheers,
--
Email:
On Tue, Jul 07, 2015 at 09:01:42PM +0530, Lokesh Vutla wrote:
> This series does some basic cleanup and adds support for
> AES GCM mode for omap aes driver.
>
> Changes since v1:
> - Switched GCM to new AEAD interface
Patches 1-4 and 7 applied.
Cheers,
--
Email: Herbert Xu
ite to it as multiple
requests can be called on the same tfm. Use rctx instead.
> + memcpy(req->iv + 12, &counter, 4);
The IV is only 12 bytes long so you're corrupting memory here.
You should use rctx here too.
> + if (req->assoclen + req->cryptlen == 0) {
>
ase);
> +}
Please drop this and use the aead_queue interface I just posted.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap"
On Mon, Jul 06, 2015 at 02:15:06PM +0530, Lokesh Vutla wrote:
>
> The existing AEAD test case does not do a wait_for_completion(), when
> the return value is EINPROGRESS or EBUSY like it is done for acipher_speed
> tests.
Please fix them to do the wait.
Thanks,
--
Email: Herbert X
4.321235] [] (__do_softirq) from []
> (irq_exit+0x98/0xec)
> [4.328500] [] (irq_exit) from []
> (handle_IRQ+0x50/0xb0)
> [4.335589] [] (handle_IRQ) from []
> (gic_handle_irq+0x28/0x5c)
>
> Removing the duplicate call to dma_unmap_sg().
>
> Reported-by: T
On Thu, Jul 02, 2015 at 10:48:40AM +0530, Lokesh Vutla wrote:
> Adding simple speed tests for a range of block sizes for Async AEAD crypto
> algorithms.
>
> Signed-off-by: Lokesh Vutla
What's wrong with the existing AEAD speed tests?
--
Email: Herbert Xu
Home Page: http://go
GENMASK(4, 3)
> > +#define AES_REG_CTRL_DIRECTION BIT(2)
> > +#define AES_REG_CTRL_INPUT_READY BIT(1)
> > +#define AES_REG_CTRL_OUTPUT_READY BIT(0)
> > +#define AES_REG_CTRL_MASK GENMASK(24, 2)
>
> this was defined a couple patches ago, why didn&
tfm = crypto_aead_tfm(crypto_aead_crt(tfm)->base);
> }
>
> +static inline struct aead_request *aead_request_cast(
> + struct crypto_async_request *req)
> +{
> + return container_of(req, struct aead_request, base);
> +}
> +
This should go int
r GCM support
then you should state that explicitly. Because partial blocks make
no sense otherwise.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubs
accepting any new implementations
using the old interface.
Please convert your driver over to the new interface.
Also please merge your GCM patches into a single patch. Splitting
out bug fixes makes no sense.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbe
08] alg: hash: Chunking test 1 failed for omap-sha256
>
> So adding the scatterlist offset to vaddr.
>
> Signed-off-by: Lokesh Vutla
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To
o: omap-aes - Add support for cases of unaligned
> lengths")
> Signed-off-by: Lokesh Vutla
Applied.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsu
am_handle_queue(), because of which the following appears:
> " [ 116.169969] BUG: scheduling while atomic: kworker/0:2/2676/0x0100"
>
> Add pm_runtime_irq_safe() to avoid this.
>
> Signed-off-by: Lokesh Vutla
Applied.
--
Email: Herbert Xu
Home Page: http://gon
else
> + vaddr = sg_virt(ctx->sg);
This is completely bogus. kmap_atomic should be identical to
sg_virt(sg_page()) for the lowmem case.
So either your architecture is broken (because the same problem
would obviously affect the core crypto code which does exactly
the same t
gt;
> Signed-off-by: Andre Wolokita
Your patch is white-space damaged. Please fix and resubmit.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscri
gt; >>
> >> Fixes the runtime warning from omap_l3_noc when omap-des is built-in
> >> on my VAR-SOM-OM44 (OMAP4460) board.
> >>
> >> Tested-by: Joachim Eastwood
> >
> > Thanks Joachim. Looks like in my hurry, I missed proper
> > acknowledgement
anks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
x4b/0x60) from []
> (omap_sham_update+0x1f/0xa4)
> [ 220.081214] [] (omap_sham_update+0x1f/0xa4) from []
> (cryptodev_hash_update+0x26/0x80 [cryptodev])
>
>
> Could you suggest, what other place is update() called in softirq context?
> I may be missing something.
IPse
On Wed, Mar 05, 2014 at 04:18:12AM +, Fernandes, Joel wrote:
>
>
> > On Mar 4, 2014, at 8:00 PM, "Herbert Xu"
> > wrote:
> >
> >> On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote:
> >> HIGHMEM pages may not be mapped so we
On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote:
> HIGHMEM pages may not be mapped so we must kmap them before accessing.
> This resolves a random OOPs error that was showing up during OpenSSL SHA
> tests.
>
> Signed-off-by: Joel Fernandes
> Cc: Herbert Xu
ap-des: Add config and build options
Both patches applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the
This is because polling_mode is not enabled for ctx without FLAGS_FINUP.
>
> For polling mode the bufcnt is made 0 unconditionally. But it should be made 0
> only if it is a final update or a total is not zero(This condition is similar
> to what is done in DMA case). Because of this wr
> place. https://bugzilla.kernel.org/show_bug.cgi?id=66441
>
> Reported-by: Tobias Jakobi
> Signed-off-by: Nishanth Menon
Patch applied.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list:
ter here:
>
> http://www.spinics.net/lists/devicetree/msg11023.html
>
> Add code to only release 'dd->dma_lch' when its not NULL
> (that is, when it was successfully requested).
>
> Reported-by: Dan Carpenter
> CC: Joel Fernandes
> Signed-off-by: Mark
On Mon, Nov 18, 2013 at 10:51:30PM +0100, Pali Rohár wrote:
> On Wednesday 16 October 2013 14:57:34 Herbert Xu wrote:
> > On Tue, Oct 08, 2013 at 12:04:09PM -0700, Tony Lindgren wrote:
> > > * Pali Rohár [130920 06:33]:
> > > > This driver provides kern
rnandes
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
Mor
d was tested on Nokia RX-51.
> > It is platform device because it needs board specific function for smc
> > calls.
>
> This one is should be merged via the hw_random patches seprately:
>
> Acked-by: Tony Lindgren
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page:
ifdef CONFIG_OF, where it needs
> > to be.
> >
> Missed testing this. Thanks for the patch.
> Reviewed-by: Lokesh Vutla
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To uns
to give good
> performance
> for small blocks as shown below.
>
> Tests have been performed on AM335x, OMAP4 and AM437x SoCs.
>
> Below is a sample run on AM335x SoC (beaglebone board), showing
> performance improvement (20% for 8K blocks):
All applied. Thanks!
--
Email:
ls
> crypto: omap-sham: correct dma burst size
Both patches applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap&quo
used.
> hwrng: OMAP: Add OMAP4 TRNG support
All applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body
ake cleanup paths simpler.
All applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.ker
; can be used for that.
>
> Tested on a Beaglebone (AM335x SoC) board.
>
> v3 changes:
> Refreshed patch on kernel v3.10-rc3
>
> Signed-off-by: Joel A Fernandes
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gon
can be used for that.
>
> Tested on a Beaglebone (AM335x SoC) board.
>
> Signed-off-by: Joel A Fernandes
I like your patch but it doesn't apply against the current cryptodev
tree.
Please rebase and repost.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org
ev() to omap_sham_get_res_of()
> and creating an empty version of omap_sham_of_match[].
>
> Signed-off-by: Mark A. Greer
Also applied.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from
aengine patches submitted by Matt Porter
>"[RFC PATCH v3 00/16] DMA Engine support for AM33XX]"
>(https://lkml.org/lkml/2012/10/18/256)
> - some misc patches required by the EDMA patches
> - a hack to fix the compilation error that the current k.o. kernel has
All appli
rter
>"[RFC PATCH v3 00/16] DMA Engine support for AM33XX]"
>(https://lkml.org/lkml/2012/10/18/256)
> - some misc patches required by the EDMA patches
> - a hack to fix the compilation error that the current k.o. kernel has
All applied. Thaks a lot!
--
Emai
> here.
>
> Yes Matt & Herbert, care to ack the drivers/char/hw_random related changes?
Acked-by: Herbert Xu
> This series will conflict with the planned ARM common zImage changes
> that we have planned so I'd like to merge them via the ARM soc tree.
Thanks,
--
Email:
for multi core as well.
All applied to cryptodev. Thanks Dmitry!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the
On Wed, Apr 20, 2011 at 01:34:54PM +0300, Dmitry Kasatkin wrote:
> Hi,
>
> Here is few patches with couple of important fixes...
All applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To un
ed requests.
> It does not happen in implementation similar to crypto test manager,
> but it will happen in implementation similar to dm-crypt.
> Backlog needs to be checked before dequeuing next request.
>
> Signed-off-by: Dmitry Kasatkin
Patch applied. Thanks Dmitry.
-
cient and right way to do it
> - checkpatch fixes in separate patch
All applied. Thanks Dmitry!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-
On Fri, Nov 19, 2010 at 04:04:21PM +0200, Dmitry Kasatkin wrote:
> Hi,
>
> Here is a set of patches which provides fixes and improvements.
>
> Based on Herbert feedback it also includes fixes so that calling final()
> is not mandatory.
All applied. Thanks Dmitry!
--
Email
ble omap aes") from the omap tree and commit
> b744c679f62b368cb94c21c1dcd4618e42d88d63 ("crypto: updates to enable omap
> aes") from the crypto tree.
>
> Two versions of the same patch. The version in the omap tree has been
> updated, so I used that.
Thanks fo
SHA processing speed up to 30 percent depending on the
> bus / memory load.
>
> Signed-off-by: Samu Onkalo
> Signed-off-by: Dmitry Kasatkin
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.t
On Fri, Aug 20, 2010 at 04:44:45PM +0300, Dmitry Kasatkin wrote:
> This set of patches provides implementation of the driver for
> OMAP2/3 AES hw accelerator.
>
Both patches applied.
Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP
On Tue, Aug 31, 2010 at 11:52:27AM +0300, Dmitry Kasatkin wrote:
> Hi,
>
> Does anyone want to comment on this?
Please be patient. Your patches are still in my queue. Resending
them is only going to slow them down.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au
penswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kerne
odev, is this going to cause any
problems for you?
Thbanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsub
sha1 & md5 driver
Both patches applied. Thanks for all your hard work Dmitry!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this l
shash object. ahash by itself
is enough.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscri
ble
>
> Signed-off-by: Dmitry Kasatkin
You have not addressed my objections raised earlier.
Also, why are you exporting a shash object? You cannot sleep during
shash operations (except for setkey).
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV&
On Tue, Mar 23, 2010 at 07:32:39PM +0800, Herbert Xu wrote:
>
> My only question is what's your plan with respect to HMAC? If
> you're going to do it in hardware then it's fine as it is.
>
> Otherwise you need to implement export/import and we also need
> to add
's your plan with respect to HMAC? If
you're going to do it in hardware then it's fine as it is.
Otherwise you need to implement export/import and we also need
to add ahash support to hmac.c.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
On Wed, Apr 16, 2008 at 10:04:49AM -0700, David Brownell wrote:
>
> Is that where the RNG stuff is now getting maintained?
For hardware RNG stuff yes. For the software RNG you should
send them to Matt Mackall as usual.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herb
On Fri, Apr 11, 2008 at 04:32:03AM +, David Brownell wrote:
> Minor cleanups to the OMAP RNG:
Thanks. I've picked this up in cryptodev-2.6.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/
62 matches
Mail list logo
