Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

2015-09-22 Thread Jacek Anaszewski
ses as he finds it clearer. I think it applies to patches 29-36. I am not sure about patches 26-28,37. Dropped 30/38 and 31/38 from LED tree then. -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a messag

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
Hi Pavel, On 11/20/2014 01:12 PM, Pavel Machek wrote: Hi! I would also swap the segments of a property name to follow the convention as in case of "regulator-max-microamp". Updated version: == Optional properties for child nodes: - max

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
On 11/19/2014 10:45 AM, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same, but white LED block should be updated with different value. I think

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
Hi Pavel, Sakari, On 11/19/2014 06:53 PM, Sakari Ailus wrote: Hi Jacek and Pavel, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same, but

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-19 Thread Jacek Anaszewski
Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same, but white LED block should be updated with different value. I think that you are talking about sub nodes. Indeed I am

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
Hi Pavel, On 11/18/2014 02:21 PM, Pavel Machek wrote: Hi! @@ -19,5 +30,10 @@ Examples: system-status { label = "Status"; linux,default-trigger = "heartbeat"; + iout-torch = <500 500>; + iout-flash = <1000 1000>; + iout-indi

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
On 11/18/2014 12:32 PM, Pavel Machek wrote: I've already submitted a patch [1] that updates leds common bindings. I hasn't been merged yet, as the related LED Flash class patch [2] still needs some indicator leds related discussion [3]. I think this is a good moment to discuss the flash relate

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
On 11/18/2014 09:46 AM, Pavel Machek wrote: On Tue 2014-11-18 09:09:09, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/17/2014 03:58 PM, Sakari Ailus wrote: Hi Pavel, On Sun, Nov 16, 2014 at 08:59:28AM +0100, Pavel Machek wrote: For device tree people: Yes, I know I'll have to create

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
code a bit more, remove the printks. Anything else obviously wrong? Jacek Anaszewski is working on flash support for LED devices. I think it'd be good to sync the DT bindings for the two, as the types of devices supported by the LED API and the V4L2 flash API are quite similar. Cc Jacek.