Re: [PATCH v6 0/7] irqchip: Move OMAP{4,5}/DRA7 to use stacked domains

2015-03-14 Thread Jason Cooper
Marc, On Wed, Mar 11, 2015 at 03:43:42PM +, Marc Zyngier wrote: > This series is extracted from [4], which is trying to remove all > traces of gic_arch_extn from the tree. As some maintainers are more > responsive than others (understatement of the year...), I've decided > to split it per sub-

Re: [PATCH v6 0/7] irqchip: Move OMAP{4,5}/DRA7 to use stacked domains

2015-03-13 Thread Jason Cooper
Hey Tony, On Fri, Mar 13, 2015 at 08:40:39AM -0700, Tony Lindgren wrote: > * Marc Zyngier [150311 08:44]: > > This series is extracted from [4], which is trying to remove all > > traces of gic_arch_extn from the tree. As some maintainers are more > > responsive than others (understatement of the

Re: [PATCH 0/5] irqchip: kill the GIC routable domain

2015-01-07 Thread Jason Cooper
On Tue, Dec 09, 2014 at 06:40:35PM +, Marc Zyngier wrote: > On 09/12/14 18:17, Nishanth Menon wrote: > > On 09:53-20141209, Marc Zyngier wrote: > >> On 08/12/14 22:41, Nishanth Menon wrote: > >> > >>> Anyways.. The following diff[1] on top of your branch makes DRA7 work - I > >>> assume you wil

Re: [PATCH v2] irqchip: omap-intc: fix legacy DMA regression

2015-01-06 Thread Jason Cooper
On Tue, Jan 06, 2015 at 02:38:08PM -0600, Felipe Balbi wrote: > commit 55601c9f2467 (arm: omap: intc: switch over > to linear irq domain) introduced a regression with > SDMA legacy driver because that driver strictly depends > on INTC's IRQs starting at NR_IRQs. Aparently > irq_domain_add_linear()

Re: [PATCH 00/35] arm: omap: move intc to drivers/irqchip/

2014-09-13 Thread Jason Cooper
| 5 + > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-omap-intc.c| 408 > + > include/linux/irqchip/irq-omap-intc.h | 32 +++ > 30 files changed, 468 insertions(+), 439 deletions(-) > delete mode 10064

Re: [PATCH v2 00/26] genirq: fix use of irq_find_mapping outside of legal RCU context

2014-09-03 Thread Jason Cooper
On Tue, Aug 26, 2014 at 11:03:15AM +0100, Marc Zyngier wrote: > A number of irqchip drivers are directly calling irq_find_mapping, > which may use a rcu_read_lock call when walking the radix tree. > > Turns out that if you hit that point with CONFIG_PROVE_RCU enabled, > the kernel will shout at yo

Re: [PATCH v2 00/26] genirq: fix use of irq_find_mapping outside of legal RCU context

2014-09-03 Thread Jason Cooper
On Wed, Sep 03, 2014 at 02:25:09PM +0200, Thomas Gleixner wrote: > On Wed, 3 Sep 2014, Marc Zyngier wrote: > > [Dropping li...@openrisc.net from the CC list] > > > > On 03/09/14 13:09, Thomas Gleixner wrote: > > > On Wed, 3 Sep 2014, Jason Cooper wrote: > > >

Re: [PATCH v2 00/26] genirq: fix use of irq_find_mapping outside of legal RCU context

2014-09-03 Thread Jason Cooper
On Wed, Aug 27, 2014 at 10:33:44AM +0100, Marc Zyngier wrote: > Hi Thomas, > > On Tue, Aug 26 2014 at 10:34:51 pm BST, Thomas Gleixner > wrote: > > On Tue, 26 Aug 2014, Marc Zyngier wrote: > > > >> A number of irqchip drivers are directly calling irq_find_mapping, > >> which may use a rcu_read_l

Re: [PATCH V4 00/16] irqchip: crossbar: Driver fixes

2014-07-01 Thread Jason Cooper
On Tue, Jul 01, 2014 at 03:06:36PM +0530, Sricharan R wrote: > Hi Tony, > > On Tuesday 01 July 2014 01:29 PM, Tony Lindgren wrote: > > * Jason Cooper [140630 12:30]: > >> > >> Whole series applied to irqchip/crossbar, I'll give it a day or two in > >&

Re: [PATCH V4 13/16] irqchip: crossbar: Introduce ti,max-crossbar-sources to identify valid crossbar mapping

2014-06-30 Thread Jason Cooper
On Fri, Jun 27, 2014 at 08:00:35AM -0400, Jason Cooper wrote: > On Thu, Jun 26, 2014 at 12:40:31PM +0530, Sricharan R wrote: > > From: Nishanth Menon > > > > Currently we attempt to map any crossbar value to an IRQ, however, > > this is not correct from hardware

Re: [PATCH V4 00/16] irqchip: crossbar: Driver fixes

2014-06-30 Thread Jason Cooper
On Thu, Jun 26, 2014 at 12:40:18PM +0530, Sricharan R wrote: > This series does some cleanups, fixes for handling two interrupts > getting mapped twice to same crossbar and provides support for > hardwired IRQ and crossbar definitions. > > On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6,

Re: [PATCH V4 00/16] irqchip: crossbar: Driver fixes

2014-06-27 Thread Jason Cooper
On Thu, Jun 26, 2014 at 12:42:09AM -0700, Tony Lindgren wrote: > * Sricharan R [140626 00:14]: > > This series does some cleanups, fixes for handling two interrupts > > getting mapped twice to same crossbar and provides support for > > hardwired IRQ and crossbar definitions. > > > > On certain pl

Re: [PATCH V4 13/16] irqchip: crossbar: Introduce ti,max-crossbar-sources to identify valid crossbar mapping

2014-06-27 Thread Jason Cooper
On Thu, Jun 26, 2014 at 12:40:31PM +0530, Sricharan R wrote: > From: Nishanth Menon > > Currently we attempt to map any crossbar value to an IRQ, however, > this is not correct from hardware perspective. There is a max crossbar > event number upto which hardware supports. So describe the same in

Re: [PATCH V4 15/16] documentation: dt: omap: crossbar: Add description for interrupt consumer

2014-06-27 Thread Jason Cooper
On Thu, Jun 26, 2014 at 12:40:33PM +0530, Sricharan R wrote: > From: Nishanth Menon > > The current crossbar description does not include the description > required for the consumer of the crossbar, a.k.a devices whoes events > pass through the crossbar into the GIC interrupt controller. > > So,

Re: [PATCH V3 16/16] irqchip: crossbar: allow for quirky hardware with direct hardwiring of GIC

2014-06-20 Thread Jason Cooper
On Mon, Jun 16, 2014 at 04:53:16PM +0530, Sricharan R wrote: > From: Nishanth Menon > > On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10, 131, > 132, 133 are direct wired to hardware blocks bypassing crossbar. > This quirky implementation is *NOT* supposed to be the expectation > of c

Re: [PATCH V3 03/16] irqchip: crossbar: introduce ti,irqs-skip to skip

2014-06-20 Thread Jason Cooper
Sricharan, Your subject line seems truncated: "irqchip: crossbar: introduce ti,irqs-skip to skip" maybe "... Introduce DT property to skip hardwired irqs" ? Also note that you need to correct the subject line for *every* patch in the series wrt capitalization. I don't mind correcting it when

Re: [PATCH 00/14] arm-soc fixes for 3.16 review

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 06:01:02PM +0200, Arnd Bergmann wrote: > here are the fixes I've picked up so far as the last pull request > for the merge window. I'm sure there will be a lot more in the > future, but let us know if I missed something Please see my pull request that I replied to today.

Re: [PATCH V2 00/19] irqchip: crossbar: driver fixes

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 09:48:24AM -0700, Joe Perches wrote: > On Fri, 2014-06-13 at 12:37 -0400, Jason Cooper wrote: > > On Fri, Jun 13, 2014 at 09:14:34AM -0700, Joe Perches wrote: > > > On Fri, 2014-06-13 at 11:01 -0400, Jason Cooper wrote: > > > > Please fo

Re: [PATCH V2 00/19] irqchip: crossbar: driver fixes

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 09:14:34AM -0700, Joe Perches wrote: > On Fri, 2014-06-13 at 11:01 -0400, Jason Cooper wrote: > > Please format the subject lines like so: > > > > irqchip: cro

Re: [PATCH V2 00/19] irqchip: crossbar: driver fixes

2014-06-13 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:08PM +0530, Sricharan R wrote: > This series does some cleanups, fixes for handling two interrupts > getting mapped twice to same crossbar and provides support for > hardwired IRQ and crossbar definitions. > > On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6,

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 09:35:20AM -0400, Santosh Shilimkar wrote: > On Friday 13 June 2014 09:10 AM, Jason Cooper wrote: ... > > Have you tried booting all the different scenarios? eg: > > > > old dtb, new driver > > new dtb, old driver > > old dtb, old

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 12:07:49PM +0530, Sricharan R wrote: > Hi Jason, > > On Thursday 12 June 2014 07:37 PM, Jason Cooper wrote: > > On Thu, Jun 12, 2014 at 06:49:17PM +0530, Sricharan R wrote: > >> Hi Jason, > >> > >> On Thursday 12 June 2014 06:21 PM

Re: [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 04:24:52PM +0530, Sricharan R wrote: > On Thursday 12 June 2014 07:24 PM, Jason Cooper wrote: > > On Thu, Jun 12, 2014 at 05:23:24PM +0530, Sricharan R wrote: ... > >> + of_property_read_u32(node, "ti,max-crossbar-sources", >

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 12:00:31PM +0530, Sricharan R wrote: > Ok, if this is not qualifying as a separate patch then i will merge > this with other patches in the series which touch them. A good general rule of thumb is to just run checkpatch on the patches, not the source files. This way, w

Re: [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 11:39:39AM +0530, Sricharan R wrote: > Hi Jason, > > On Thursday 12 June 2014 06:26 PM, Jason Cooper wrote: > > On Thu, Jun 12, 2014 at 05:23:13PM +0530, Sricharan R wrote: > >> From: Nishanth Menon > >> > >> Reverse the search al

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 12:26:10PM +0530, Sricharan R wrote: > On Thursday 12 June 2014 07:35 PM, Jason Cooper wrote: ... > > Do you have other changes outside of irqchip depending on this series? > > If so, I can set up a topic branch for you guys to base off of. > > Other

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Jason Cooper
Hey Joe, On Thu, Jun 12, 2014 at 07:18:31AM -0700, Joe Perches wrote: > On Thu, 2014-06-12 at 19:05 +0530, Sricharan R wrote: > > On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote: > > > On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote: > > >> di

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 06:49:17PM +0530, Sricharan R wrote: > Hi Jason, > > On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote: > > On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote: > >> From: Nishanth Menon > >> > >> When, in the system

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 06:57:15AM -0700, Tony Lindgren wrote: > * Jason Cooper [140612 05:52]: > > On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote: > > > From: Nishanth Menon > > > > > > When, in the system due to varied reasons, interrupts mig

Re: [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:24PM +0530, Sricharan R wrote: > From: Nishanth Menon > > Currently we attempt to map any crossbar value to an IRQ, however, > this is not correct from hardware perspective. There is a max crossbar > event number upto which hardware supports. So describe the same in

Re: [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:23PM +0530, Sricharan R wrote: > The crossbar_domain_map/unmap callbacks need not be called same number > of times for a particular irq. But still use counting is not needed > here, because unmap(irq) gets called when irq_desc(irq) is disposed. > After this the irq is

Re: [PATCH V2 13/19] irqchip: crossbar: change the goto naming

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:21PM +0530, Sricharan R wrote: > From: Nishanth Menon > > Using err1,2,3,4 etc makes it hard to ensure a new exit path in the > middle will not result in spurious changes, so rename the error paths > as per the function it does. > > Signed-off-by: Nishanth Menon >

Re: [PATCH V2 12/19] irqchip: crossbar: return proper error value

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:20PM +0530, Sricharan R wrote: > From: Nishanth Menon > > crossbar_of_init always returns -ENOMEM in case of errors, return proper > error results in case of failures. Please describe what the other possible failures are and how the changes are more correct. > > S

Re: [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:19PM +0530, Sricharan R wrote: > From: Nishanth Menon > > When the provided unused skip list entry is greater than max irqs > possible, we go to err3, but we fail to free register_offsets, > should have returned to err4 instead which ensures that allocated s/returne

Re: [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:18PM +0530, Sricharan R wrote: > From: Rajendra Nayak > > On DRA7 compatible IRQ crossbar, IRQ 10 default mapped to L3_APP_IRQ, > IRQ133 is default mapped to NMI pin, 139 and 140 crossbars are > unused(not routed). Mark these as unused crossbar IRQs. > > Technical R

Re: [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:17PM +0530, Sricharan R wrote: > From: Nishanth Menon > > kernel doc style is wrong in code. fix it to squelch > kerneldoc warnings: I would re-word the above to mention that we need to add missing properties for kerneldoc (@write, @safemap), and we're doing some cl

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote: > From: Nishanth Menon > > remove un-necessary space in function pointer. > > Fixes checkpatch warning: > WARNING: Unnecessary space before function pointer arguments > #37: FILE: drivers/irqchip/irq-crossbar.c:37: > +void (*writ

Re: [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:13PM +0530, Sricharan R wrote: > From: Nishanth Menon > > Reverse the search algorithm to ensure that address mapping and IRQ > allocation logics are proper. This can open up new bugs which are > easily fixable rather than wait till allocation logic approaches > the

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote: > From: Nishanth Menon > > When, in the system due to varied reasons, interrupts might be unusable > due to hardware behavior, but register maps do exist, then those interrupts > should be skipped while mapping irq to crossbars. > > Si

Re: [PATCH 3/3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line

2013-06-04 Thread Jason Cooper
On Tue, Jun 04, 2013 at 10:58:46AM -0700, Kevin Hilman wrote: > Jason Cooper writes: > > > On Mon, Jun 03, 2013 at 03:19:25PM -0700, Kevin Hilman wrote: > >> Florian Vaussard writes: > >> > >> > Hello Kevin, > >> > > >> >

Re: [PATCH 3/3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line

2013-06-03 Thread Jason Cooper
On Mon, Jun 03, 2013 at 03:19:25PM -0700, Kevin Hilman wrote: > Florian Vaussard writes: > > > Hello Kevin, > > > > On 06/01/2013 12:45 AM, Kevin Hilman wrote: > >> On most OMAP3 platforms, the twl4030 IRQ line is connected to the > >> SYS_NIRQ line on OMAP. Therefore, configure the defaults for

Re: [RFC PATCH 0/3] ARM: omap3: add Seagate Wireless Plus board

2013-05-08 Thread Jason Cooper
On Wed, May 08, 2013 at 12:45:04PM -0700, Tony Lindgren wrote: > * Jason Cooper [130508 12:29]: > > > > Tony has been helping me out offline with this, and he suggested trying the > > gpmc against Linus' ToT. Which locks up before it even has a chance to get >

Re: [RFC PATCH 0/3] ARM: omap3: add Seagate Wireless Plus board

2013-05-08 Thread Jason Cooper
On Wed, May 08, 2013 at 12:51:53PM -0700, Tony Lindgren wrote: > * Jason Cooper [130508 12:29]: > > > > Current Problem: > > > > There are several gaps in my understanding of how far along TI's conversion > > to > > DT is. Should I be doing a sep

[RFC PATCH 0/3] ARM: omap3: add Seagate Wireless Plus board

2013-05-08 Thread Jason Cooper
t I can read/write, mount a rootfs and do better testing. thx, Jason. [1] http://www.seagate.com/support/downloads/item/satellite-gpl-fw-master-dl/ Jason Cooper (3): ARM: omap3: Seagate Wireless Plus board ARM: omap3: Seagate Wireless Plus DT entry ARM: omap3: wireless plus gpmc wip arc

[RFC PATCH 2/3] ARM: omap3: Seagate Wireless Plus DT entry

2013-05-08 Thread Jason Cooper
Signed-off-by: Jason Cooper --- NOTE: please see coverletter for details. arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/omap3-wireless_plus.dts | 314 ++ 2 files changed, 315 insertions(+) create mode 100644 arch/arm/boot/dts/omap3

[RFC PATCH 3/3] ARM: omap3: wireless plus gpmc wip

2013-05-08 Thread Jason Cooper
Need this in order to add the nand node and then the partitions. in it's current state, crashes the system. :( --- arch/arm/boot/dts/omap3-wireless_plus.dts | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3-wireless_plus.dts b/arch/ar

[RFC PATCH 1/3] ARM: omap3: Seagate Wireless Plus board

2013-05-08 Thread Jason Cooper
Hynix include file copied from vendor supplied source code. Signed-off-by: Jason Cooper --- arch/arm/mach-omap2/board-generic.c| 26 +++ arch/arm/mach-omap2/sdram-hynix-h8kds0un0mer-4em.h | 30 ++ 2 files changed, 56 insertions(+) create mode

Re: Build error: OMAP randconfig / mvebu

2013-02-14 Thread Jason Cooper
/twl6030-usb.ko] undefined! > > Yes, I guess that is an unrelated error. However, my patch also wasn't > correct because it is not allowed to have an empty list of objects. > > There is an updated patch below, I could add that straight to the branch > that caused t