Re: [jenny...@intel.com: [RFC] power_supply: Introduce generic psy charging driver]

2014-05-07 Thread Jenny Tc
+static struct charger_cable cable_list[] = { + { +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_SDP, +}, + { +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_CDP, +}, + { +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_DCP, +}, + { +

Re: [RFC] power_supply: Introduce generic psy charging driver

2014-04-28 Thread Jenny Tc
On Mon, Apr 28, 2014 at 07:56:06PM +0200, Pavel Machek wrote: On Mon 2014-04-28 22:24:36, Jenny Tc wrote: Dmitry/Pavel, Request your feedback on this. Fixed the comments from Pavel and waiting for your feedback on the changes IIRC, my latest comments were this is completely

Re: [PATCHv8 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-03-09 Thread Jenny Tc
On Fri, Mar 07, 2014 at 09:12:40PM +0100, Pavel Machek wrote: On Fri 2014-03-07 10:59:31, Jenny TC wrote: Add new power supply properties for input current, charge termination current, min and max temperature POWER_SUPPLY_PROP_TEMP_MIN - minimum operatable temperature

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-09 Thread Jenny Tc
On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote: Hi, The Power Supply charging driver connects multiple subsystems to do charging in a generic way. The subsystems involves power_supply, thermal and battery communication subsystems (1wire).With this the charging is handled

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-03-06 Thread Jenny Tc
On Fri, Mar 07, 2014 at 11:34:14AM +0800, Linus Walleij wrote: On Fri, Feb 28, 2014 at 11:07 AM, Jenny Tc jenny...@intel.com wrote: On Thu, Feb 27, 2014 at 09:18:57PM +0100, Linus Walleij wrote: On Tue, Feb 4, 2014 at 6:12 AM, Jenny TC jenny...@intel.com wrote: +static inline bool

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-03-06 Thread Jenny Tc
On Fri, Mar 07, 2014 at 11:03:02AM +0800, Linus Walleij wrote: On Fri, Feb 28, 2014 at 12:27 PM, Jenny Tc jenny...@intel.com wrote: On Thu, Feb 27, 2014 at 09:08:01PM +0100, Linus Walleij wrote: On Thu, Feb 20, 2014 at 6:53 AM, Jenny TC jenny...@intel.com wrote: +++ b/include/linux/power

[PATCHv8 0/4] power_supply: Introduce power supply charging driver

2014-03-06 Thread Jenny TC
be implemented by exposing get_property and set property callbacks. Jenny TC (4): power_supply: Add inlmt,iterm, min/max temp props power_supply: Introduce generic psy charging driver power_supply: Introduce PSE compliant algorithm power_supply: bq24261 charger driver Documentation/power

[PATCHv8 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-03-06 Thread Jenny TC
. Indicates the input current for a charging source. POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect the end of charge condition Signed-off-by: Jenny TC jenny...@intel.com --- Documentation/power/power_supply_class.txt |6 ++ drivers/power/power_supply_sysfs.c

[PATCHv8 3/4] power_supply: Introduce PSE compliant algorithm

2014-03-06 Thread Jenny TC
by the power supply charging driver based on the type of the battery charging profile. Signed-off-by: Jenny TC jenny...@intel.com --- drivers/power/Kconfig | 15 ++ drivers/power/Makefile |1 + drivers/power/charging_algo_pse.c | 204

[PATCHv8 4/4] power_supply: bq24261 charger driver

2014-03-06 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC jenny

Re: power_supply mailing list

2014-03-06 Thread Jenny Tc
On Sat, Feb 01, 2014 at 09:06:48AM -0700, Dmitry Eremin-Solenikov wrote: Hello, On Thu, Jan 30, 2014 at 10:46 PM, Jenny Tc jenny...@intel.com wrote: Do we have any mailing list for power_supply subsystem? If not what about having one - linux-power-sup...@vger.kernel.org? I'm

[PATCHv7 0/4] power_supply: Introduce power supply charging driver

2014-03-03 Thread Jenny TC
logic out of the charger chip driver and the charger chip driver can just listen to the request from the power supply charging driver to set the charger properties. This can be implemented by exposing get_property and set property callbacks. Jenny TC (4): power_supply: Add inlmt,iterm, min/max

[PATCHv7 4/4] power_supply: bq24261 charger driver

2014-03-03 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC jenny

[PATCH v7 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-03-03 Thread Jenny TC
. Indicates the input current for a charging source. POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect the end of charge condition Signed-off-by: Jenny TC jenny...@intel.com --- Documentation/power/power_supply_class.txt |6 ++ drivers/power/power_supply_sysfs.c

[PATCHv7 3/4] power_supply: Introduce PSE compliant algorithm

2014-03-03 Thread Jenny TC
by the power supply charging driver based on the type of the battery charging profile. Signed-off-by: Jenny TC jenny...@intel.com --- drivers/power/Kconfig | 13 ++ drivers/power/Makefile |1 + drivers/power/charging_algo_pse.c | 204

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-03-02 Thread Jenny Tc
On Fri, Feb 28, 2014 at 11:08:16AM +0100, Pavel Machek wrote: On Fri 2014-02-28 08:37:27, Jenny Tc wrote: On Thu, Feb 27, 2014 at 09:18:57PM +0100, Linus Walleij wrote: On Tue, Feb 4, 2014 at 6:12 AM, Jenny TC jenny...@intel.com wrote: +static inline bool __is_battery_full

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-27 Thread Jenny Tc
On Thu, Feb 27, 2014 at 08:47:07PM +0100, Linus Walleij wrote: On Wed, Feb 26, 2014 at 3:54 AM, Jenny Tc jenny...@intel.com wrote: The idea is to allow pluggable charging algorithms. Currently we have only one charging algorithm proposed, but can have other charging algorithms (like

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-27 Thread Jenny Tc
On Thu, Feb 27, 2014 at 09:18:57PM +0100, Linus Walleij wrote: On Tue, Feb 4, 2014 at 6:12 AM, Jenny TC jenny...@intel.com wrote: +static inline bool __is_battery_full + (long volt, long cur, long iterm, unsigned long cv) Overall I wonder if you've run checkpatch on these patches

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-02-27 Thread Jenny Tc
On Thu, Feb 27, 2014 at 09:08:01PM +0100, Linus Walleij wrote: On Thu, Feb 20, 2014 at 6:53 AM, Jenny TC jenny...@intel.com wrote: +++ b/include/linux/power/power_supply_charger.h +#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ) Why are things defined

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-25 Thread Jenny Tc
On Fri, Feb 21, 2014 at 03:44:00PM +0100, Pavel Machek wrote: Hi! +static inline int bq24261_set_cv(struct bq24261_charger *chip, int cv) +{ + int bat_volt; + int ret; + u8 reg_val; + u8 vindpm_val = 0x0; + + /* + * Setting

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-25 Thread Jenny Tc
On Fri, Feb 21, 2014 at 03:45:29PM +0100, Pavel Machek wrote: On Thu 2014-02-20 10:46:55, Jenny Tc wrote: On Tue, Feb 04, 2014 at 12:36:40PM +0100, Pavel Machek wrote: --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -22,6 +22,19 @@ config POWER_SUPPLY_CHARGER

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-19 Thread Jenny Tc
On Tue, Feb 04, 2014 at 12:36:21PM +0100, Pavel Machek wrote: +#define BQ24261_MIN_CV 3500 +#define BQ24261_MAX_CV 4440 Other defines use uV as an unit :-(. uV is used if the value is read from psy class. For register configurations uses mV. Will change the name to reflect mV + /* If

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-19 Thread Jenny Tc
On Tue, Feb 04, 2014 at 12:36:40PM +0100, Pavel Machek wrote: --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -22,6 +22,19 @@ config POWER_SUPPLY_CHARGER drivers to keep the charging logic outside and the charger driver just need to abstract the charger hardware.

[PATCH v6 0/4] power_supply: Introduce power supply charging driver

2014-02-19 Thread Jenny TC
and the charger chip driver can just listen to the request from the power supply charging driver to set the charger properties. This can be implemented by exposing get_property and set property callbacks. Jenny TC (4): power_supply: Add inlmt,iterm, min/max temp props power_supply: Introduce generic psy

[PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-02-19 Thread Jenny TC
. Indicates the input current for a charging source. POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect the end of charge condition Signed-off-by: Jenny TC jenny...@intel.com --- Documentation/power/power_supply_class.txt |6 ++ drivers/power/power_supply_sysfs.c

[PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-19 Thread Jenny TC
by the power supply charging driver based on the type of the battery charging profile. Signed-off-by: Jenny TC jenny...@intel.com --- drivers/power/Kconfig | 13 ++ drivers/power/Makefile |1 + drivers/power/charging_algo_pse.c | 204

[PATCH 4/4] power_supply: bq24261 charger driver

2014-02-19 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC jenny

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-02-05 Thread Jenny Tc
On Tue, Feb 04, 2014 at 12:36:30PM +0100, Pavel Machek wrote: +struct psy_charger_context { + bool is_usb_cable_evt_reg; + int psyc_cnt; + int batt_status; + /*cache battery and charger properties */ Comment coding style. Please run you patches through checkpatch. checkpatch

[PATCH v5 0/4] power_supply: Introduce power supply charging driver

2014-02-03 Thread Jenny TC
to the request from the power supply charging driver to set the charger properties. This can be implemented by exposing get_property and set property callbacks. Jenny TC (4): power_supply: Add inlmt,iterm, min/max temp props power_supply: Introduce generic psy charging driver power_supply: Introduce

[PATCH 4/4] power_supply: bq24261 charger driver

2014-02-03 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC jenny

[PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-02-03 Thread Jenny TC
. Indicates the input current for a charging source. POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect the end of charge condition Signed-off-by: Jenny TC jenny...@intel.com --- Documentation/power/power_supply_class.txt |6 ++ drivers/power/power_supply_sysfs.c

[PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-03 Thread Jenny TC
by the power supply charging driver based on the type of the battery charging profile. Signed-off-by: Jenny TC jenny...@intel.com --- drivers/power/Kconfig | 13 ++ drivers/power/Makefile |1 + drivers/power/charging_algo_pse.c | 198

[PATCH v4 0/4] power_supply: Introduce power supply charging driver

2014-01-30 Thread Jenny TC
properties. This can be implemented by exposing get_property and set property callbacks. Jenny TC (4): power_supply: Add inlmt,iterm, min/max temp props power_supply: Introduce generic psy charging driver power_supply: Introduce PSE compliant algorithm power_supply: bq24261 charger driver

[PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-01-30 Thread Jenny TC
. Indicates the input current for a charging source. POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect the end of charge condition Signed-off-by: Jenny TC jenny...@intel.com --- Documentation/power/power_supply_class.txt |6 ++ drivers/power/power_supply_sysfs.c

[PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC jenny

[PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-01-30 Thread Jenny TC
by the power supply charging driver based on the type of the battery charging profile. Signed-off-by: Jenny TC jenny...@intel.com --- drivers/power/Kconfig | 13 ++ drivers/power/Makefile |1 + drivers/power/charging_algo_pse.c | 198

power_supply mailing list

2014-01-30 Thread Jenny Tc
Hi, Do we have any mailing list for power_supply subsystem? If not what about having one - linux-power-sup...@vger.kernel.org? Thanks Jenny -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Jenny Tc
On Thu, Jan 30, 2014 at 06:01:54PM +0100, Pavel Machek wrote: Hi! diff --git a/drivers/power/Makefile b/drivers/power/Makefile index 77535fd..6d184c8 100644 --- a/drivers/power/Makefile +++ b/drivers/power/Makefile @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) +=

Re: [PATCH 2/4] power_supply: Introduce Generic Power Supply charging driver

2014-01-29 Thread Jenny Tc
On Sat, Jan 25, 2014 at 10:04:03AM -0700, Pavel Machek wrote: + * Write access using set_property + * Set Maximum charging current + * Action: Configure safety charging registers if any. If not no + actions expected for this. Having property

Re: [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-01-28 Thread Jenny Tc
On Fri, Jan 24, 2014 at 08:25:19AM -0700, Dmitry Eremin-Solenikov wrote: On 22/01/14 21:19, Jenny TC wrote: Add new power supply properties for input current, charge termination current, min and max temperature POWER_SUPPLY_PROP_TEMP_MIN - minimum operatable temperature

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Jenny Tc
On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: +#define BQ24261_ICHRG_MASK (0x1F 3) +#define BQ24261_ICHRG_100ma(0x01 3) +#define BQ24261_ICHRG_200ma(0x01 4) +#define BQ24261_ICHRG_400ma(0x01 5) +#define

[PATCH v3 0/4] power_supply: Introduce power supply charging driver

2014-01-22 Thread Jenny TC
of the charger chip driver and the charger chip driver can just listen to the request from the power supply charging driver to set the charger properties. This can be implemented by exposing get_property and set property callbacks. Jenny TC (4): power_supply: Add inlmt,iterm, min/max temp props

[PATCH 4/4] power_supply: bq24261 charger driver

2014-01-22 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC jenny

[PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-01-22 Thread Jenny TC
by the power supply charging driver based on the type of the battery charging profile. Signed-off-by: Jenny TC jenny...@intel.com --- drivers/power/Kconfig | 12 ++ drivers/power/Makefile |1 + drivers/power/charging_algo_pse.c | 198

[PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-01-22 Thread Jenny TC
. Indicates the input current for a charging source. POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect the end of charge condition Change-Id: Ifb40662bbfa24387ac7493ffa7ce01c6fae7e800 Signed-off-by: Jenny TC jenny...@intel.com --- Documentation/power/power_supply_class.txt