[PATCH] OMAP3: am3517crane: remove NULL board_mux from board file

2011-08-09 Thread Johan Hovold
Since 7203f8a48bb63015ebe58a6f2a38aec1cb208b9d (arm: mach-omap2: remove NULL board_mux from board files) NULL board_mux is defined in mux.h. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/board-am3517crane.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm

[PATCH 1/3] OMAP2+: pm: fix typos

2011-08-09 Thread Johan Hovold
Fix typos in comment and error message. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/pm.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index 3feb359..fd77cf4 100644 --- a/arch/arm/mach-omap2/pm.c +++ b

[PATCH 2/3] OMAP2+: pm: clean up error messages

2011-08-09 Thread Johan Hovold
Replace all printks with pr_err. Clean up error messages by adding missing whitespace, fixing capitalisations, removing double newlines, and reducing verbosity. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/pm.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions

[PATCH 3/3] OMAP2+: voltage: clean up error messages

2011-08-09 Thread Johan Hovold
Clean up error messages by adding missing whitespace, reducing excessive verbosity, and fixing a few language issues. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/voltage.c | 51 ++-- 1 files changed, 23 insertions(+), 28 deletions(-) diff --git a

[PATCH 1/2 RESEND] OMAP2+: pm: fix typos

2011-08-30 Thread Johan Hovold
Fix typos in comment and error message. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/pm.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index 3feb359..fd77cf4 100644 --- a/arch/arm/mach-omap2/pm.c +++ b

[PATCH 2/2 RESEND] OMAP2+: pm: clean up error messages

2011-08-30 Thread Johan Hovold
Replace all printks with pr_err. Clean up error messages by adding missing whitespace, fixing capitalisations, removing double newlines, and reducing verbosity. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/pm.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions

Re: [PATCH 3/3] OMAP2+: voltage: clean up error messages

2011-08-30 Thread Johan Hovold
On Mon, Aug 29, 2011 at 02:15:49PM -0700, Kevin Hilman wrote: > Hi Johan, > > Johan Hovold writes: > > > Clean up error messages by adding missing whitespace, reducing excessive > > verbosity, and fixing a few language issues. > > > > Signed-off-by: Johan H

Re: [PATCH v2 1/4] rtc: omap: Introduce rtc_omap_dev structure to include per device data

2014-10-08 Thread Johan Hovold
On Thu, Sep 25, 2014 at 03:02:06PM +0530, Lokesh Vutla wrote: > Currently all the device data is declared globally which will be a > problem if more than one instance of device is present. So consolidate > all the data into rtc_omap_dev struct and adopt the driver to use this. > > Suggested-by: Fe

Re: [PATCH v2 2/4] rtc: omap: Adopt driver to support probe deferral

2014-10-08 Thread Johan Hovold
On Thu, Sep 25, 2014 at 03:02:07PM +0530, Lokesh Vutla wrote: Perhaps the subject should simply be "use module_platform_driver", then you can explain your motive for the change in the body as you already do. > module_platform_driver_probe() prevents driver from requesting probe deferral. > So usi

Re: [PATCH v2 4/4] rtc: omap: Support regulator supply for RTC

2014-10-08 Thread Johan Hovold
On Thu, Sep 25, 2014 at 03:02:09PM +0530, Lokesh Vutla wrote: > On some Soc's RTC is powered by an external power regulator. > e.g. RTC on DRA7 SoC. Make the OMAP RTC driver support a > power regulator. > > Signed-off-by: Lokesh Vutla > --- > Changes since v1: > - Separated probe deferral s

[PATCH 05/12] rtc: omap: remove redundant debug message

2014-10-09 Thread Johan Hovold
Remove redundant debug message. The corresponding error has already been logged by rtc core. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index d1b5562a148b

[PATCH 02/12] rtc: omap: fix missing wakealarm attribute

2014-10-09 Thread Johan Hovold
Cc: stable Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index f842c216f2dd..828cb9983cc2 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c @@ -416,6 +416,8

[PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-09 Thread Johan Hovold
call chain will have stabilised by then. Johan [1] http://www.spinics.net/lists/devicetree/msg50869.html [2] https://lkml.org/lkml/2014/10/7/30 Johan Hovold (12): rtc: omap: fix clock-source configuration rtc: omap: fix missing wakealarm attribute rtc: omap: fix class-device registration

[PATCH 03/12] rtc: omap: fix class-device registration

2014-10-09 Thread Johan Hovold
current time. This reordering also prevents user space from enabling an alarm before an interrupt handler has been registered. Note that the interrupts are now registered using the platform-device rather than class-device name. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 32

[PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-09 Thread Johan Hovold
-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 1c58920b0c88..0ef016553a97 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c @@ -118,6

[PATCH 04/12] rtc: omap: remove unused register-base define

2014-10-09 Thread Johan Hovold
Remove register-base define, which is no longer used. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 2eca141e784e..d1b5562a148b 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers

[PATCH 01/12] rtc: omap: fix clock-source configuration

2014-10-09 Thread Johan Hovold
t for enabling 32khz clock") Cc: stable Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 21142e6574a9..f842c216f2dd 100644 --- a/drivers/rtc/rtc-omap.c +++

[PATCH 10/12] rtc: omap: enable wake-up from power off

2014-10-09 Thread Johan Hovold
The ALARM interrupt must not be disabled during shutdown in order to be able to power up the system using an RTC alarm. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc

[PATCH 12/12] ARM: dts: am335x-bone-common: enable power off and rtc wake up

2014-10-09 Thread Johan Hovold
property must be left unset in order to be able to wake up on RTC alarms. Tested on BeagleBone Black (rev A5). Signed-off-by: Johan Hovold --- arch/arm/boot/dts/am335x-bone-common.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm

[PATCH 09/12] rtc: omap: add support for pmic_power_en

2014-10-09 Thread Johan Hovold
. This is based on earlier work by Colin Foe-Parker and AnilKumar Ch. [1] [1] https://www.mail-archive.com/linux-omap@vger.kernel.org/msg82127.html Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/rtc/rtc-omap.txt | 9 +- drivers/rtc/rtc-omap.c

[PATCH 11/12] ARM: dts: am33xx: update rtc node compatible property

2014-10-09 Thread Johan Hovold
Enable am33xx specific RTC features (e.g. PMIC control) by adding "ti,am3352-rtc" to the compatible property of the rtc node. Signed-off-by: Johan Hovold --- arch/arm/boot/dts/am33xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am33xx.d

[PATCH 08/12] rtc: omap: restore irq state after reading TC registers

2014-10-09 Thread Johan Hovold
Make sure to restore local irq state when reading the timer/calendar (TC) registers, so that omap_rtc_read_time() can be called with interrupts disabled. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc

[PATCH 06/12] rtc: omap: use dev_info and dev_dbg

2014-10-09 Thread Johan Hovold
Use dev_info and dev_dbg rather than pr_info and pr_debug. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index e50ffd7063f5..1c58920b0c88 100644

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-11 Thread Johan Hovold
On Fri, Oct 10, 2014 at 12:54:22PM -0500, Felipe Balbi wrote: > HI, > > On Thu, Oct 09, 2014 at 09:06:22PM +0200, Johan Hovold wrote: > > This series fixes a few issues with the omap rtc-driver, cleans up a bit > > and finally adds support for the PMIC control feature found

Re: [PATCH 03/12] rtc: omap: fix class-device registration

2014-10-11 Thread Johan Hovold
On Fri, Oct 10, 2014 at 12:59:30PM -0500, Felipe Balbi wrote: > On Thu, Oct 09, 2014 at 09:06:25PM +0200, Johan Hovold wrote: > > Make sure not to register the class device until after it has been > > configured and interrupt handlers registered at probe. > > > > C

Re: [PATCH 08/12] rtc: omap: restore irq state after reading TC registers

2014-10-11 Thread Johan Hovold
On Fri, Oct 10, 2014 at 01:02:31PM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Oct 09, 2014 at 09:06:30PM +0200, Johan Hovold wrote: > > Make sure to restore local irq state when reading the timer/calendar > > (TC) registers, so that omap_rtc_read_time() can be calle

Re: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-11 Thread Johan Hovold
On Fri, Oct 10, 2014 at 01:02:56PM -0500, Felipe Balbi wrote: > On Fri, Oct 10, 2014 at 01:00:54PM -0500, Felipe Balbi wrote: > > On Thu, Oct 09, 2014 at 09:06:29PM +0200, Johan Hovold wrote: > > > Some legacy RTC IP revisions has a power-up reset flag in the status > &g

Re: [PATCH 09/12] rtc: omap: add support for pmic_power_en

2014-10-11 Thread Johan Hovold
On Fri, Oct 10, 2014 at 01:07:27PM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Oct 09, 2014 at 09:06:31PM +0200, Johan Hovold wrote: > > @@ -124,11 +138,18 @@ > > */ > > #define OMAP_RTC_HAS_POWER_UP_RESETBIT(3) > > > > +/* > > + * Some

Re: [PATCH 12/12] ARM: dts: am335x-bone-common: enable power off and rtc wake up

2014-10-11 Thread Johan Hovold
On Fri, Oct 10, 2014 at 01:09:49PM -0500, Felipe Balbi wrote: > On Thu, Oct 09, 2014 at 09:06:34PM +0200, Johan Hovold wrote: > > Configure the RTC as system-power controller, which allows the system to > > be powered off as well as woken up again on subsequent RTC alarms. > &g

Re: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-12 Thread Johan Hovold
On Sat, Oct 11, 2014 at 07:50:07PM -0500, Felipe Balbi wrote: > Hi, > > On Sat, Oct 11, 2014 at 12:20:04PM +0200, Johan Hovold wrote: > > On Fri, Oct 10, 2014 at 01:02:56PM -0500, Felipe Balbi wrote: > > > On Fri, Oct 10, 2014 at 01:00:54PM -0500, Felipe Balbi wrote: >

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-15 Thread Johan Hovold
On Wed, Oct 15, 2014 at 11:55:02AM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Oct 09, 2014 at 09:06:22PM +0200, Johan Hovold wrote: > > This series fixes a few issues with the omap rtc-driver, cleans up a bit > > and finally adds support for the PMIC control feature found

[PATCH v2 11/20] rtc: omap: add structured device-type info

2014-10-21 Thread Johan Hovold
Add structured device-type info to encode IP-block revision differences. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 103 - 1 file changed, 51 insertions(+), 52 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc

[PATCH v2 07/20] rtc: omap: use dev_info

2014-10-21 Thread Johan Hovold
Use dev_info rather than pr_info. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index c750678de652..dbb88e46c25d 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers

[PATCH v2 04/20] rtc: omap: clean up probe error handling

2014-10-21 Thread Johan Hovold
Remove some debug messages and return errors from subsystems rather than always fail with -EIO. Note that the class-registration error has already been logged by rtc core. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 41 ++--- 1 file changed, 18

[PATCH v2 20/20] ARM: dts: am335x-boneblack: enable power off and rtc wake up

2014-10-21 Thread Johan Hovold
property must be left unset in order to be able to wake up on RTC alarms. Tested on BeagleBone Black (rev A5). Reviewed-by: Felipe Balbi Signed-off-by: Johan Hovold --- arch/arm/boot/dts/am335x-boneblack.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/am335x

[PATCH v2 09/20] rtc: omap: add device abstraction

2014-10-21 Thread Johan Hovold
Add struct omap_rtc to hold previously global data as well as the IP-block feature flags. Also convert the register-access macros to proper inline helper functions. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 239 +++-- 1 file changed

[PATCH v2 19/20] ARM: dts: am33xx: update rtc-node compatible property

2014-10-21 Thread Johan Hovold
Enable am33xx specific RTC features (e.g. PMIC control) by adding "ti,am3352-rtc" to the compatible property of the rtc node. Reviewed-by: Felipe Balbi Signed-off-by: Johan Hovold --- arch/arm/boot/dts/am33xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 15/20] rtc: omap: add support for pmic_power_en

2014-10-21 Thread Johan Hovold
. This is based on earlier work by Colin Foe-Parker and AnilKumar Ch. [1] [1] https://www.mail-archive.com/linux-omap@vger.kernel.org/msg82127.html Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/rtc/rtc-omap.txt | 9 ++- drivers/rtc/rtc-omap.c

[PATCH v2 08/20] rtc: omap: make platform-device id table const

2014-10-21 Thread Johan Hovold
Make platform-device id table const. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index dbb88e46c25d..bdee29674589 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc

[PATCH v2 14/20] rtc: omap: add helper to read 32-bit registers

2014-10-21 Thread Johan Hovold
Add helper to read full register width. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index bcdf3c596214..c508e45ca3ce 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc

[PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-21 Thread Johan Hovold
pdates to use these new interfaces once the infrastructure is in place. Johan [1] https://lkml.org/lkml/2014/10/9/427 [2] https://lkml.org/lkml/2014/10/7/30 [3] https://lkml.org/lkml/2014/10/7/654 Johan Hovold (20): rtc: omap: fix clock-source configuration rtc: omap: fix missing wakealarm att

[PATCH v2 18/20] rtc: omap: add copyright entry

2014-10-21 Thread Johan Hovold
Add myself to the list of copyright holders. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 4278421183e5..e74750f00b18 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc

[PATCH v2 03/20] rtc: omap: fix interrupt disable at probe

2014-10-21 Thread Johan Hovold
Use writel instead of writeb when disabling interrupts at probe as ALARM2 is not cleared otherwise on some IP-block revisions (e.g. AM3352). Note that the driver currently never enables the ALARM2 interrupt. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 8 +--- 1 file changed, 5

[PATCH v2 17/20] rtc: omap: fix minor coding style issues

2014-10-21 Thread Johan Hovold
Fix minor coding style issues like comment style, indentation and remove a few unnecessary casts. Also drop the 1 from OMAP1 in the driver description. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 46 +++--- 1 file changed, 27 insertions

[PATCH v2 05/20] rtc: omap: fix class-device registration

2014-10-21 Thread Johan Hovold
Make sure not to register the class device until after the device has been configured. Currently, the device is not fully configured (e.g. 24-hour mode) when the class device is registered, something which involves driver callbacks for example to read the current time. Signed-off-by: Johan

[PATCH v2 16/20] rtc: omap: enable wake-up from power off

2014-10-21 Thread Johan Hovold
The ALARM interrupt must not be disabled during shutdown in order to be able to power up the system using an RTC alarm. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc

[PATCH v2 12/20] rtc: omap: silence bogus power-up reset message at probe

2014-10-21 Thread Johan Hovold
-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 1abd88e24c22..ee20f2d36065 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c @@ -106,6 +106,7

[PATCH v2 02/20] rtc: omap: fix missing wakealarm attribute

2014-10-21 Thread Johan Hovold
Cc: stable Reviewed-by: Felipe Balbi Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index f842c216f2dd..828cb9983cc2 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/

[PATCH v2 01/20] rtc: omap: fix clock-source configuration

2014-10-21 Thread Johan Hovold
t for enabling 32khz clock") Cc: stable Reviewed-by: Felipe Balbi Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 21142e6574a9..f842c216f2dd 100644 --- a/d

[PATCH v2 06/20] rtc: omap: remove unused register-base define

2014-10-21 Thread Johan Hovold
Remove register-base define, which is no longer used. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 813bed270867..c750678de652 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers

[PATCH v2 13/20] rtc: omap: add helper to read raw bcd time

2014-10-21 Thread Johan Hovold
Add helper to read raw BCD time that can be used in interrupt context. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index ee20f2d36065..bcdf3c596214

[PATCH v2 10/20] rtc: omap: remove DRIVER_NAME macro

2014-10-21 Thread Johan Hovold
Remove DRIVER_NAME macro which was used for unrelated strings (e.g. id-table entry and module name), but not for related ones (e.g. module name and alias). Also move the module alias to the other module-info entries. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 8 +++- 1 file

Re: [PATCH 09/12] rtc: omap: add support for pmic_power_en

2014-10-22 Thread Johan Hovold
On Fri, Oct 10, 2014 at 01:07:27PM -0500, Felipe Balbi wrote: > On Thu, Oct 09, 2014 at 09:06:31PM +0200, Johan Hovold wrote: > > - /* clear pending irqs, and set 1/second periodic, > > -* which we'll use instead of update irqs > > + /* >

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-22 Thread Johan Hovold
On Wed, Oct 15, 2014 at 12:08:32PM -0500, Felipe Balbi wrote: > On Wed, Oct 15, 2014 at 07:06:28PM +0200, Johan Hovold wrote: > > On Wed, Oct 15, 2014 at 11:55:02AM -0500, Felipe Balbi wrote: > > > BTW, how do you test this series ? > > > > Set a 30 second wakealar

Re: [PATCH 08/12] rtc: omap: restore irq state after reading TC registers

2014-10-22 Thread Johan Hovold
On Sat, Oct 11, 2014 at 07:47:58PM -0500, Felipe Balbi wrote: > On Sat, Oct 11, 2014 at 12:12:01PM +0200, Johan Hovold wrote: > > On Fri, Oct 10, 2014 at 01:02:31PM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Oct 09, 2014 at 09:06:30PM +0200, Joha

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-22 Thread Johan Hovold
On Sat, Oct 11, 2014 at 12:08:18PM -0700, Tony Lindgren wrote: > * Johan Hovold [141011 02:42]: > > On Fri, Oct 10, 2014 at 12:54:22PM -0500, Felipe Balbi wrote: > > > > > > is this power-off feature "RTC-only mode" ? > > > > Yes, I believe so,

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-22 Thread Johan Hovold
On Wed, Oct 22, 2014 at 08:29:56AM -0700, Tony Lindgren wrote: > * Johan Hovold [141022 04:12]: > > On Sat, Oct 11, 2014 at 12:08:18PM -0700, Tony Lindgren wrote: > > > * Johan Hovold [141011 02:42]: > > > > On Fri, Oct 10, 2014 at 12:54:22PM -0500, Felipe Balbi

Re: [PATCH V3 1/3] rtc: omap: use module_platform_driver

2014-10-24 Thread Johan Hovold
; Signed-off-by: Lokesh Vutla Reviewed-by: Johan Hovold > --- > drivers/rtc/rtc-omap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c > index e74750f..d9bb5e7 100644 > --- a/drivers/rtc/rtc-o

Re: [PATCH V3 3/3] rtc: omap: Support regulator supply for RTC

2014-10-24 Thread Johan Hovold
regulator_disable(rtc->supply); > + > return ret; > } > > @@ -649,6 +670,9 @@ static int __exit omap_rtc_remove(struct platform_device > *pdev) > pm_runtime_put_sync(&pdev->dev); > pm_runtime_disable(&pdev->dev); > > + if (rtc->supply) > + regulator_disable(rtc->supply); > + > return 0; > } Looks good otherwise. Feel free to add Reviewed-by: Johan Hovold Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-24 Thread Johan Hovold
On Thu, Oct 23, 2014 at 01:55:13PM -0500, Felipe Balbi wrote: > On Wed, Oct 22, 2014 at 12:23:05PM +0200, Johan Hovold wrote: > > On Wed, Oct 15, 2014 at 12:08:32PM -0500, Felipe Balbi wrote: > > > On Wed, Oct 15, 2014 at 07:06:28PM +0200, Johan Hovold wrote: > > > >

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Johan Hovold
Thanks for testing! Johan >From aaa1d1d6171c895b6966ba5b738ac7946ada97c7 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 24 Oct 2014 18:53:09 +0200 Subject: [PATCH] ARM: fix failed power-off handling Make sure to handle failed power off by printing an error message and halting (analog

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Johan Hovold
On Fri, Oct 24, 2014 at 02:29:48PM -0500, Felipe Balbi wrote: > Hi, > > On Fri, Oct 24, 2014 at 02:25:40PM -0500, Felipe Balbi wrote: > > On Fri, Oct 24, 2014 at 09:02:51PM +0200, Johan Hovold wrote: > > > [ +CC: Russell ] > > > > > > On Fri, Oct 24, 20

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-24 Thread Johan Hovold
On Fri, Oct 24, 2014 at 02:44:42PM -0500, Felipe Balbi wrote: > On Fri, Oct 24, 2014 at 09:36:55PM +0200, Johan Hovold wrote: > > On Fri, Oct 24, 2014 at 02:29:48PM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Fri, Oct 24, 2014 at 02:25:40PM -0500, Feli

[PATCH v3] rtc: omap: add support for pmic_power_en

2014-10-27 Thread Johan Hovold
. This is based on earlier work by Colin Foe-Parker and AnilKumar Ch. [1] [1] https://www.mail-archive.com/linux-omap@vger.kernel.org/msg82127.html Tested-by: Felipe Balbi Signed-off-by: Johan Hovold --- Changes since v2: - add two-second delay to allow alarm to trigger before returning Andre

Re: [PATCH v3] rtc: omap: add support for pmic_power_en

2014-10-27 Thread Johan Hovold
On Mon, Oct 27, 2014 at 11:45:44AM -0500, Felipe Balbi wrote: > On Mon, Oct 27, 2014 at 09:09:28AM +0100, Johan Hovold wrote: > > Add new property "ti,system-power-controller" to register the RTC as a > > power-off handler. > > > > Some RTC IP revisions

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-28 Thread Johan Hovold
On Tue, Oct 28, 2014 at 12:25:52AM +, Russell King - ARM Linux wrote: > On Mon, Oct 27, 2014 at 04:22:51PM -0700, Andrew Morton wrote: > > On Fri, 24 Oct 2014 21:55:32 +0200 Johan Hovold wrote: > > > I will. :) Just wanted to see whether Andrew preferred I resend the >

Re: [PATCH v3] rtc: omap: add support for pmic_power_en

2014-10-28 Thread Johan Hovold
On Mon, Oct 27, 2014 at 03:40:31PM -0700, Andrew Morton wrote: > On Mon, 27 Oct 2014 09:09:28 +0100 Johan Hovold wrote: > > > Add new property "ti,system-power-controller" to register the RTC as a > > power-off handler. > > > > Some RTC IP revisi

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-28 Thread Johan Hovold
On Tue, Oct 28, 2014 at 08:47:46AM +, Russell King - ARM Linux wrote: > On Tue, Oct 28, 2014 at 09:16:16AM +0100, Johan Hovold wrote: > > It looks like we're soon to be having power-off call chains, with > > configurable priorities, to shut of various parts of the hardwar

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Johan Hovold
On Tue, Oct 28, 2014 at 03:16:10PM +, Russell King - ARM Linux wrote: > On Tue, Oct 28, 2014 at 02:12:57PM +0100, Johan Hovold wrote: > > That's not what I was trying to refer to. But the patch set explicitly > > allows for multiple, prioritised power-off handlers, which

Re: [PATCH v3] rtc: omap: add support for pmic_power_en

2014-10-29 Thread Johan Hovold
On Tue, Oct 28, 2014 at 02:18:05PM -0700, Andrew Morton wrote: > On Tue, 28 Oct 2014 09:36:33 +0100 Johan Hovold wrote: > > > > But it doesn't explain *why* we want the alarm to trigger before > > > returning. > > > > Should we really require

Re: [PATCH v3] rtc: omap: add support for pmic_power_en

2014-10-29 Thread Johan Hovold
On Tue, Oct 28, 2014 at 09:36:33AM +0100, Johan Hovold wrote: > On Mon, Oct 27, 2014 at 03:40:31PM -0700, Andrew Morton wrote: > > On Mon, 27 Oct 2014 09:09:28 +0100 Johan Hovold wrote: > But in general, how do you want to handle updates to a single patch in a > series you alrea

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Johan Hovold
[ Please do not top-post. ] On Wed, Oct 29, 2014 at 01:55:49PM +0100, Romain Perier wrote: > Johan:. do you really plan to use this "poweroff-source" property ? As > you proposed a renaming few days ago... > I don't really want to waste time to propose patches to fix things > incrementally and ren

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Johan Hovold
On Wed, Oct 29, 2014 at 01:10:20PM +, Russell King - ARM Linux wrote: > On Wed, Oct 29, 2014 at 01:34:18PM +0100, Johan Hovold wrote: > > On Tue, Oct 28, 2014 at 03:16:10PM +, Russell King - ARM Linux wrote: > > > And how is that different from having a set of power

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Johan Hovold
On Wed, Oct 29, 2014 at 06:20:40AM -0700, Guenter Roeck wrote: > On 10/29/2014 05:34 AM, Johan Hovold wrote: > > On Tue, Oct 28, 2014 at 03:16:10PM +, Russell King - ARM Linux wrote: > >> On Tue, Oct 28, 2014 at 02:12:57PM +0100, Johan Hovold wrote: > >>> That&#x

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Johan Hovold
[ Again, please stop with the top-posting. A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? ] On Wed, Oct 29, 2014 at 02:11:02PM +0100

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Johan Hovold
On Wed, Oct 29, 2014 at 08:25:02AM -0700, Guenter Roeck wrote: > On Wed, Oct 29, 2014 at 02:22:44PM +0100, Johan Hovold wrote: > > On Wed, Oct 29, 2014 at 01:10:20PM +, Russell King - ARM Linux wrote: > > > On Wed, Oct 29, 2014 at 01:34:18PM +0100, Johan Hovold wrote: >

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Johan Hovold
On Wed, Oct 29, 2014 at 08:36:41AM -0700, Guenter Roeck wrote: > On Wed, Oct 29, 2014 at 02:35:26PM +0100, Johan Hovold wrote: > > On Wed, Oct 29, 2014 at 06:20:40AM -0700, Guenter Roeck wrote: > > > On 10/29/2014 05:34 AM, Johan Hovold wrote: > > > > And what

[PATCH v4] rtc: omap: add support for pmic_power_en

2014-10-30 Thread Johan Hovold
. This is based on earlier work by Colin Foe-Parker and AnilKumar Ch. [1] [1] https://www.mail-archive.com/linux-omap@vger.kernel.org/msg82127.html Tested-by: Felipe Balbi Signed-off-by: Johan Hovold --- Here's an updated patch, which adds a comment on why there is a delay after activating t

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-30 Thread Johan Hovold
On Wed, Oct 29, 2014 at 04:51:09PM +0100, Johan Hovold wrote: > On Wed, Oct 29, 2014 at 08:25:02AM -0700, Guenter Roeck wrote: > > On Wed, Oct 29, 2014 at 02:22:44PM +0100, Johan Hovold wrote: > > > On Wed, Oct 29, 2014 at 01:10:20PM +, Russell King - ARM Linux wrote: >

[PATCH] ARM: OMAP2+: clock: remove unused function prototype

2014-11-11 Thread Johan Hovold
Remove unused function prototype that was left by commit 149c09d3a61d ("ARM: AM33xx: remove old clock data and link in new clock init code") which removed the definition. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/clock.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] Revert "ARM: dts: am335x-boneblack: disable RTC-only sleep"

2015-06-11 Thread Johan Hovold
avoid hardware damage"). Unfortunately, an incorrect fix had already been applied, which instead of just disabling RTC-only mode, prevents the Beaglebone from powering down at all. Revert this patch to fix the power-off regression. Signed-off-by: Johan Hovold --- The offending patch was i

Re: [PATCH 2/2] rtc: omap: Add external clock enabling support

2015-08-14 Thread Johan Hovold
On Thu, Aug 13, 2015 at 12:37:48PM +0530, Keerthy wrote: > Configure the clock source to either internal clock > or external clock based on the availability of the clocks. > External clock is preferred as it can be ticking during suspend. > > Signed-off-by: Keerthy > @@ -627,6 +642,17 @@ static

Re: [PATCH v2 2/2] rtc: omap: Add external clock enabling support

2015-08-17 Thread Johan Hovold
On Mon, Aug 17, 2015 at 10:25:38AM +0530, Keerthy wrote: > Configure the clock source to either internal clock > or external clock based on the availability of the clocks. > External clock is preferred as it can be ticking during suspend. > > Signed-off-by: Keerthy > --- > > Changes in V2: > >

Re: [PATCH v2 2/2] rtc: omap: Add external clock enabling support

2015-08-17 Thread Johan Hovold
On Mon, Aug 17, 2015 at 05:08:55PM +0530, Keerthy wrote: > > > On Monday 17 August 2015 05:00 PM, Johan Hovold wrote: > > On Mon, Aug 17, 2015 at 10:25:38AM +0530, Keerthy wrote: > >> Configure the clock source to either internal clock > >> or external clock

Re: [PATCH v3 3/3] rtc: omap: Add external clock enabling support

2015-08-18 Thread Johan Hovold
On Tue, Aug 18, 2015 at 11:48:44AM +0530, Keerthy wrote: > Configure the clock source to external clock if available. > External clock is preferred as it can be ticking during suspend. > > Signed-off-by: Keerthy > --- > drivers/rtc/rtc-omap.c | 33 ++--- > 1 file chan

Re: [PATCH v4 0/2] ARM: AM437X: Add rtc clock handling

2015-08-18 Thread Johan Hovold
On Tue, Aug 18, 2015 at 02:13:28PM +0530, Keerthy wrote: > The series is applicable for all am437x series of processors. > It adds clock handling support. Boot tested on am437x-gp-evm. > > Keerthy (2): > ARM: dts: AM437x: Add the internal and external clock nodes for rtc > rtc: omap: Add exter

[PATCH] usb: musb: omap2430: fix build failure

2011-04-05 Thread Johan Hovold
/musb/omap2430.c:262: error: ‘struct musb’ has no member named ‘gadget_driver’ Signed-off-by: Johan Hovold --- drivers/usb/musb/omap2430.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 25cb8b0..57a27fa

Re: [PATCH] usb: musb: omap2430: fix build failure

2011-04-13 Thread Johan Hovold
Hi Filipe, On Tue, Apr 05, 2011 at 07:50:34PM +0200, Johan Hovold wrote: > Fix build failure introduced by commit > 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026 (usb: musb: Idle path retention > and offmode support for OMAP3) when building without gadget > support. > > CC

[PATCH] rtc: omap: drop vendor-prefix from power-controller dt property

2014-11-26 Thread Johan Hovold
stem-power-controller" in a released kernel will need to support both versions. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/rtc/rtc-omap.txt | 4 ++-- arch/arm/boot/dts/am335x-boneblack.dts | 2 +- drivers/rtc/rtc-omap.c | 2 +-

[PATCH] ARM: dts: OMAP2+: remove uses of obsolete gpmc,device-nand

2014-04-08 Thread Johan Hovold
Remove all remaining uses of gpmc,device-nand that have been added since the property was removed by commit f40739faba8e ("ARM: dts: OMAP2+: Simplify NAND support"). Signed-off-by: Johan Hovold --- arch/arm/boot/dts/am335x-igep0033.dtsi | 1 - arch/arm/boot/dts/omap3-devkit800

[PATCH] ARM: dts: am335x-boneblack: remove use of ti,vcc-aux-disable-is-sleep

2014-04-25 Thread Johan Hovold
Remove use of property ti,vcc-aux-disable-is-sleep, which does not exist. Signed-off-by: Johan Hovold --- arch/arm/boot/dts/am335x-boneblack.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts index 6b71ad95a5cf

Re: [PATCH 3.14 012/158] ARM: dts: am33xx: correcting dt node unit address for usb

2014-05-05 Thread Johan Hovold
On Sun, May 04, 2014 at 11:38:41AM -0400, Greg Kroah-Hartman wrote: > 3.14-stable review patch. If anyone has any objections, please let me know. This one should not be backported without commit a2f8d6b30321 ("ARM: dts: am335x: update USB DT references") which is in Linus' tree but is n

[PATCH] ARM: dts: AM33XX: fix ethernet and mdio default state

2014-05-08 Thread Johan Hovold
Make sure ethernet and mdio nodes are disabled by default and enable them explicitly only on boards that actually use them. Signed-off-by: Johan Hovold --- arch/arm/boot/dts/am335x-bone-common.dtsi | 3 ++- arch/arm/boot/dts/am335x-evm.dts | 2 ++ arch/arm/boot/dts/am335x-evmsk.dts

Re: [GIT PULL] ARM: OMAP: IRQ domain support for INTC

2012-03-05 Thread Johan Hovold
On Wed, Feb 29, 2012 at 05:15:25PM +0100, Cousson, Benoit wrote: > On 2/29/2012 12:48 AM, Tony Lindgren wrote: > > * Cousson, Benoit [120227 08:04]: > >> Hi Tony > >> > >> This series is based on the lo/dt + the irqdomain/next branch merged on > >> top of it. > >> > >> Grant confirmed that the ir

Re: [GIT PULL] ARM: OMAP: IRQ domain support for INTC

2012-03-05 Thread Johan Hovold
On Mon, Mar 05, 2012 at 03:25:01PM +0100, Cousson, Benoit wrote: > On 3/5/2012 2:58 PM, Johan Hovold wrote: > > On Wed, Feb 29, 2012 at 05:15:25PM +0100, Cousson, Benoit wrote: > >> On 2/29/2012 12:48 AM, Tony Lindgren wrote: > >>> * Cousson, Benoit [120227 08:04]: