Re: [PATCH RFC v2 0/2] Disable planes on blanked CRTC and enable on unblank

2015-11-17 Thread Jyri Sarha
On 11/17/15 12:28, Daniel Vetter wrote: On Fri, Nov 13, 2015 at 05:53:13PM +0200, Jyri Sarha wrote: Since first RFC version: - Added "drm/atomic: Track drm_plane's active state"-patch We would need something like this to get rid off OMAPDSS somewhat messy runtime_resume code

[PATCH] clk: gpio: Get parent clk names already in of_gpio_clk_setup()

2015-11-17 Thread Jyri Sarha
to recursively lock of_clk_mutex. Signed-off-by: Jyri Sarha <jsa...@ti.com> Cc: Sergej Sawazki <c...@gmx.de> --- Something has changed in Linux mainline so that getting the clk parent names in struct of_clk_provider's get() callback does not work anymore. This patch should fix the problem. dri

[PATCH] clk: gpio: Get parent clk names already in of_gpio_clk_setup()

2015-11-17 Thread Jyri Sarha
to recursively lock of_clk_mutex. Signed-off-by: Jyri Sarha <jsa...@ti.com> Cc: Sergej Sawazki <c...@gmx.de> --- Something has changed in Linux mainline so that getting the clk parent names in struct of_clk_provider's get() callback does not work anymore. This patch should fix the problem. dri

[PATCH RFC v2 0/2] Disable planes on blanked CRTC and enable on unblank

2015-11-13 Thread Jyri Sarha
rt looking a local solution to omapdrm? Jyri Sarha (2): drm/atomic: Track drm_plane's active state drm/atomic: Disable planes on blanked CRTC and enable on unblank drivers/gpu/drm/drm_atomic_helper.c | 82 + drivers/gpu/drm/drm_plane_helper.c | 10 + i

[PATCH RFC v2 1/2] drm/atomic: Track drm_plane's active state

2015-11-13 Thread Jyri Sarha
and calls atomic_update() or atomic_disable() from the plane's helper funcs as needed. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- drivers/gpu/drm/drm_atomic_helper.c | 63 - drivers/gpu/drm/drm_plane_helper.c | 10 +- include/drm/drm_atomic_helper.h

[PATCH RFC v2 2/2] drm/atomic: Disable planes on blanked CRTC and enable on unblank

2015-11-13 Thread Jyri Sarha
callback. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- drivers/gpu/drm/drm_atomic_helper.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index d03e2ac..5cd8016 100644 --- a/d

Re: [PATCH] ASoC: davinci-mcasp: Fix TDM slot rx/tx mask associations

2015-11-09 Thread Jyri Sarha
Reviewed-by: Jyri Sarha <jsa...@ti.com> For what little there is to review. I only had HW that worked with symmetric masks, so I did not hit this myself. Should have hacked something to codec end to be able to test asymetric masks at McASP end. Thanks, Jyri On 11/09/15 20:19, A

Re: [PATCH RFC] ASoC: simple-card: Update clocks binding for simple-card DAI subnodes

2015-09-28 Thread Jyri Sarha
On 09/19/15 21:42, Mark Brown wrote: On Fri, Sep 11, 2015 at 04:18:02PM +0300, Jyri Sarha wrote: The updated binding provides a way to set clock-ID and direction parameters for DAI drivers set_sysclk() call back. I proposed something similar about a year ago, but Mark rejected

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-28 Thread Jyri Sarha
On 09/28/15 12:01, Arnaud Pouliquen wrote: few questions/remarks BR, Arnaud +static void hdmi_codec_abort(struct device *dev) +{ +struct hdmi_codec_priv *hcp = dev_get_drvdata(dev); + +dev_dbg(dev, "%s()\n", __func__); + +mutex_lock(>current_stream_lock); +if

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-21 Thread Jyri Sarha
On 09/21/15 12:31, Russell King - ARM Linux wrote: On Sat, Sep 19, 2015 at 10:54:51AM -0700, Mark Brown wrote: On Fri, Sep 18, 2015 at 02:06:40PM +0300, Jyri Sarha wrote: +#define SPDIF_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE

Re: [alsa-devel] [PATCH RFC v4 2/8] ALSA: pcm: add IEC958 channel status helper for hw_params

2015-09-21 Thread Jyri Sarha
On 09/21/15 18:08, Clemens Ladisch wrote: >But there is no downside in using prepare callback. The prepare callback also can be called multiple times. This certainly happens when the stream is stopped/restarted multiple times. If something does not need to be done again when a stream is

Re: [PATCH RFC v4 2/8] ALSA: pcm: add IEC958 channel status helper for hw_params

2015-09-21 Thread Jyri Sarha
On 09/21/15 12:37, Russell King - ARM Linux wrote: On Fri, Sep 18, 2015 at 02:06:39PM +0300, Jyri Sarha wrote: Add IEC958 channel status helper that gets the audio properties from snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to produce the channel status bits already in audio

[PATCH RFC v4 7/8] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality

2015-09-18 Thread Jyri Sarha
for available sample-rates. Implementation of audio_startup for hdmi_codec_ops would enable tda998x driver to abort ongoing playback if the HDMI cable is unplugged or re-plugged to a device without audio capability. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- drivers/gpu/drm/i2c/Kconfig

[PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-18 Thread Jyri Sarha
of similar structures in ASoC headers. This is on purpose to avoid direct dependencies to ASoC structures in video side driver. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- include/sound/hdmi-codec.h| 104 +++ sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile

[PATCH RFC v4 0/8] Implement generic ASoC HDMI codec and use it in tda998x

2015-09-18 Thread Jyri Sarha
Jyri Jean-Francois Moine (1): drm/i2c: tda998x: Add support of a DT graph of ports Jyri Sarha (7): ASoC: hdmi: Remove obsolete dummy HDMI codec ALSA: pcm: add IEC958 channel status helper for hw_params ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders drm/i2c: tda998x: Remove in

[PATCH RFC v4 1/8] ASoC: hdmi: Remove obsolete dummy HDMI codec

2015-09-18 Thread Jyri Sarha
The hdmi stub codec has not been used since refactoring of OMAP HDMI audio support. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- sound/soc/codecs/Kconfig | 4 -- sound/soc/codecs/Makefile | 2 - sound/soc/codecs/hdmi.c | 109 -- 3 files c

[PATCH RFC v4 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2015-09-18 Thread Jyri Sarha
slave encoder. The new file include/sound/tda998x.h prepares to the definition of a tda998x CODEC. Signed-off-by: Jean-Francois Moine <moin...@free.fr> Signed-off-by: Jyri Sarha <jsa...@ti.com> --- .../devicetree/bindings/drm/i2c/tda998x.txt| 51 drivers/gpu/drm

[PATCH RFC v4 2/8] ALSA: pcm: add IEC958 channel status helper for hw_params

2015-09-18 Thread Jyri Sarha
Add IEC958 channel status helper that gets the audio properties from snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to produce the channel status bits already in audio stream configuration phase. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- include/sound/pcm_iec958.

[PATCH RFC v4 5/8] drm/i2c: tda998x: Remove include/sound/tda998x.h and fix graph parsing

2015-09-18 Thread Jyri Sarha
Move struct tda998x_audio definition to tda998x_drv.c and remove include/sound/tda998x.h. There is no external use for struct tda998x_audio. Fix graph parsing to allow ports to be inside a separate "ports"-node as specified in Documentation/devicetree/bindings/graph.txt. Signed-of

[PATCH RFC v4 6/8] drm/i2c: tda998x: Improve tda998x_configure_audio() audio related pdata

2015-09-18 Thread Jyri Sarha
Declare struct tda998x_audio_params in include/drm/i2c/tda998x.h and use it in pdata and for tda998x_configure_audio() parameters. Also updates tda998x_write_aif() to use hdmi_audio_infoframe_pack() and friends. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- drivers/gpu/drm/armada/armada

[PATCH RFC v4 8/8] ARM: dts: am335x-boneblack: Add HDMI audio support

2015-09-18 Thread Jyri Sarha
Add HDMI audio support. Adds mcasp0_pins, clk_mcasp0_fixed, clk_mcasp0, mcasp0, sound node, and updates the tda19988 node to follow the new binding. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- arch/arm/boot/dts/am335x-boneblack.dts | 90 -- 1 file chang

[PATCH v2] ASoC: davinci-mcasp: Get rid of bclk_lrclk_ratio in private data

2015-09-17 Thread Jyri Sarha
The slot_width is for essentially same thing. Instead of storing bclk_lrclk_ratio, just store the slot_width. Comments has been updated accordingly and some variable names changed to more descriptive. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- Added the missing __func__ to dev_warn() war

[PATCH] ASoC: soc-core: Fix sparse warning in be32_to_cpup() call

2015-09-17 Thread Jyri Sarha
Signed-off-by: Jyri Sarha <jsa...@ti.com> --- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 1929f0e..614b831 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3301,7 +3301,7 @@ stat

[PATCH v3] ASoC: soc-core: Fix sparse warning in be32_to_cpup() call

2015-09-17 Thread Jyri Sarha
if the value is zero or not, but I wanted to add it to remind in the future that the data has to be converted before use. Compiler should optimize the unnecessary operations away. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- Damn, I wrote description ready but forgot to produce the patch aga

Re: [PATCH] ASoC: soc-core: Fix sparse warning in be32_to_cpup() call

2015-09-17 Thread Jyri Sarha
On 09/17/15 12:22, Mark Brown wrote: On Thu, Sep 17, 2015 at 11:02:57AM +0300, Jyri Sarha wrote: val /= sizeof(u32); for (i = 0; i < val; i++) - if (be32_to_cpup(_slot_mask[i])) + if (be32_to_cpup((__be32 *)_slot_mas

[PATCH v2] ASoC: soc-core: Fix sparse warning in be32_to_cpup() call

2015-09-17 Thread Jyri Sarha
Signed-off-by: Jyri Sarha <jsa...@ti.com> --- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 1929f0e..af4999c 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3294,7 +3294,7 @@ stat

[PATCH RFC] ASoC: simple-card: Update clocks binding for simple-card DAI subnodes

2015-09-11 Thread Jyri Sarha
The updated binding provides a way to set clock-ID and direction parameters for DAI drivers set_sysclk() call back. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- I proposed something similar about a year ago, but Mark rejected that at the time. This RFC is to start that discussion

Re: [PATCH RFC 4/5] ASoC: davinci-mcasp: Get rid of bclk_lrclk_ratio in private data

2015-09-10 Thread Jyri Sarha
On 09/09/15 21:27, Jyri Sarha wrote: The slot_width is for essentially same thing. Instead of storing bclk_lrclk_ratio, just store the slot_width. Comments has been updated accordingly and some variable names changed to more descriptive. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- sou

[PATCH RFC 3/5] ASoC: davinci-mcasp: Add set_tdm_slots() support

2015-09-09 Thread Jyri Sarha
-by: Jyri Sarha <jsa...@ti.com> --- sound/soc/davinci/davinci-mcasp.c | 255 ++ 1 file changed, 174 insertions(+), 81 deletions(-) diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c index bbd1987..de1e3a8 100644 --- a/sou

[PATCH RFC 2/5] ASoC: simple-card: Add tdm slot mask support to simple-card

2015-09-09 Thread Jyri Sarha
Adds DT binding for explicitly choosing a tdm mask for DAI and uses it in simple-card. The API for snd_soc_of_parse_tdm_slot() has also been changed. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- .../devicetree/bindings/sound/tdm-slot.txt | 11 +- include/sound/simple_

[PATCH RFC 1/5] ASoC: davinci-mcasp: Set .symmetric_rates = 1 in snd_soc_dai_driver

2015-09-09 Thread Jyri Sarha
The TX and RX direction share the same bit clock and frame sync, so the samplerate must be the same to both directions. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- sound/soc/davinci/davinci-mcasp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/davinci/davinci-mcasp.c b

[PATCH RFC 4/5] ASoC: davinci-mcasp: Get rid of bclk_lrclk_ratio in private data

2015-09-09 Thread Jyri Sarha
The slot_width is for essentially same thing. Instead of storing bclk_lrclk_ratio, just store the slot_width. Comments has been updated accordingly and some variable names changed to more descriptive. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- sound/soc/davinci/davinci-mcasp.

[PATCH RFC 5/5] ASoC: tlv320aic3x: Improve tdm support

2015-09-09 Thread Jyri Sarha
in the capture direction, but the other end of the i2s bus should be able to ignore them. Signed-off-by: Jyri Sarha <jsa...@ti.com> --- sound/soc/codecs/tlv320aic3x.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/tlv320a

[PATCH RFC 0/5] ASoC: TDM stuff for simple-card, mcasp, and tlv320aic3x

2015-09-09 Thread Jyri Sarha
The first patch is an independent fix. The symmetric_samplebits constraint could probably be removed too (with some changes to mcasp code too), but as tlv320aic3x family codecs won't support it, I could not test it. Jyri Sarha (5): ASoC: davinci-mcasp: Set .symmetric_rates = 1

Re: [PATCH 1/2] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled

2015-08-28 Thread Jyri Sarha
On 08/28/15 13:37, Tomi Valkeinen wrote: On 26/08/15 16:11, Jyri Sarha wrote: diff --git a/drivers/video/fbdev/omap2/dss/hdmi5.c b/drivers/video/fbdev/omap2/dss/hdmi5.c index 7f87578..f352c4b 100644 --- a/drivers/video/fbdev/omap2/dss/hdmi5.c +++ b/drivers/video/fbdev/omap2/dss/hdmi5.c

Re: [PATCH v2] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled

2015-08-28 Thread Jyri Sarha
On 08/28/15 16:04, Tomi Valkeinen wrote: ... The question is (which was my point in the earlier mail), we already have mutex, so why a new spinlock? I think the answer is that audio start/stop (anything else?) are called in atomic context, so mutex cannot be used. Yes, that is correct.

[PATCH v3] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled

2015-08-28 Thread Jyri Sarha
-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/hdmi.h | 9 - drivers/video/fbdev/omap2/dss/hdmi4.c | 66 +- drivers/video/fbdev/omap2/dss/hdmi5.c | 76 --- 3 files changed, 124 insertions(+), 27 deletions(-) diff

[PATCH v2] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled

2015-08-28 Thread Jyri Sarha
to hdmi.audio_playing state and set hdmi.display_enabled to true. After releasing the lock hdmi.display_enabled is true and all audio_start and audio_stop commands write their stuff directly to HW. Signed-off-by: Jyri Sarha jsa...@ti.com --- I dropped the ASoC maintainers from the recipient list

Re: [PATCH v2] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled

2015-08-28 Thread Jyri Sarha
On 08/28/15 15:24, Jyri Sarha wrote: @@ -565,9 +594,14 @@ out: static int hdmi_audio_shutdown(struct device *dev) { struct omap_hdmi *hd = dev_get_drvdata(dev); + unsigned long flags; mutex_lock(hd-lock); hd-audio_abort_cb = NULL; + hd-audio_configured

[PATCH v4] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled

2015-08-28 Thread Jyri Sarha
-by: Jyri Sarha jsa...@ti.com --- Fixed one bad sentece in the description. drivers/video/fbdev/omap2/dss/hdmi.h | 9 - drivers/video/fbdev/omap2/dss/hdmi4.c | 66 +- drivers/video/fbdev/omap2/dss/hdmi5.c | 76 --- 3 files changed, 124

[PATCH 1/2] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled

2015-08-26 Thread Jyri Sarha
be needed for proper synchronization. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/hdmi.h | 10 +++- drivers/video/fbdev/omap2/dss/hdmi4.c | 65 - drivers/video/fbdev/omap2/dss/hdmi5.c | 89 +-- 3 files changed

[PATCH 0/2] OMAPDSS: Couple of HDMI audio fixes

2015-08-26 Thread Jyri Sarha
separately trough their own trees. Jyri Sarha (2): OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled ASoC: omap-hdmi-audio: Set buffer bytes step constraint to 128 drivers/video/fbdev/omap2/dss/hdmi.h | 10 +++- drivers/video/fbdev/omap2/dss/hdmi4.c | 65

[PATCH 2/2] ASoC: omap-hdmi-audio: Set buffer bytes step constraint to 128

2015-08-26 Thread Jyri Sarha
Set buffer bytes step constraint to 128. A matching constraint has already been set to period size. This helps PCM setup to tolerate ALSA clients that set the PCM hw params in unusual order. Signed-off-by: Jyri Sarha jsa...@ti.com --- sound/soc/omap/omap-hdmi-audio.c | 10 +- 1 file

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-17 Thread Jyri Sarha
On 08/17/15 10:57, Jyri Sarha wrote: Missed one commet first time around... On 08/14/15 19:18, Mark Brown wrote: On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: ... +/* HDMI codec initalization data */ +struct hdmi_codec_pdata { +struct device *dev; /* The HDMI encoder

Re: [PATCH RFC v3 6/7] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality

2015-08-17 Thread Jyri Sarha
On 08/14/15 13:06, Russell King - ARM Linux wrote: On Fri, Aug 14, 2015 at 12:30:44PM +0300, Jyri Sarha wrote: +static int tda998x_write_aif(struct tda998x_priv *priv, +struct hdmi_audio_infoframe *cea) +{ + uint8_t buf[HDMI_INFOFRAME_SIZE(AUDIO)]; + int

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-17 Thread Jyri Sarha
Missed one commet first time around... On 08/14/15 19:18, Mark Brown wrote: On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: ... +/* HDMI codec initalization data */ +struct hdmi_codec_pdata { + struct device *dev; /* The HDMI encoder registering the codec */ Shouldn't

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-17 Thread Jyri Sarha
On 08/17/15 21:41, Mark Brown wrote: On Mon, Aug 17, 2015 at 10:07:55AM +0300, Jyri Sarha wrote: On 08/14/15 19:18, Mark Brown wrote: On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: + /* Called when ASoC starts an audio stream setup. The call +* provides an audio

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-17 Thread Jyri Sarha
On 08/14/15 12:57, Russell King - ARM Linux wrote: On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: +static int hdmi_codec_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct

Re: [PATCH RFC v3 2/7] ASoC: hdmi: Remove obsolete dummy HDMI codec

2015-08-17 Thread Jyri Sarha
On 08/14/15 19:10, Mark Brown wrote: On Fri, Aug 14, 2015 at 12:30:40PM +0300, Jyri Sarha wrote: The hdmi stub codec has not been used since refactoring of OMAP HDMI audio support. grep tells me that the OMAP HDMI4 and HDMI5 drivers are still registering this device in -next... Really? My

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-17 Thread Jyri Sarha
On 08/14/15 19:18, Mark Brown wrote: On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: +struct hdmi_codec_ops { + /* For runtime clock configuration from ASoC machine driver. +* A direct forward from set_sysclk in struct snd_soc_dai_ops. +* Optional

Re: [PATCH RFC v2 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-17 Thread Jyri Sarha
On 08/14/15 22:25, Mark Brown wrote: On Tue, May 26, 2015 at 09:59:07PM +0300, Jyri Sarha wrote: + + mutex_lock(hcp-current_stream_lock); + if (hcp-current_stream hcp-current_stream-runtime + snd_pcm_running(hcp-current_stream)) { + dev_info(dev, HDMI

[PATCH RFC v3 7/7] ARM: dts: am335x-boneblack: Add HDMI audio support

2015-08-14 Thread Jyri Sarha
Add HDMI audio support. Adds mcasp0_pins, clk_mcasp0_fixed, clk_mcasp0, mcasp0, sound node, and updates the tda19988 node to follow the new binding. Signed-off-by: Jyri Sarha jsa...@ti.com --- arch/arm/boot/dts/am335x-boneblack.dts | 90 -- 1 file changed, 86

[PATCH RFC v3 4/7] drm/i2c: tda998x: Add support of a DT graph of ports

2015-08-14 Thread Jyri Sarha
encoder. The new file include/sound/tda998x.h prepares to the definition of a tda998x CODEC. Signed-off-by: Jean-Francois Moine moin...@free.fr Signed-off-by: Jyri Sarha jsa...@ti.com --- .../devicetree/bindings/drm/i2c/tda998x.txt| 51 drivers/gpu/drm/i2c/tda998x_drv.c

[PATCH RFC v3 0/7] Implement generic ASoC HDMI codec and use it in tda998x

2015-08-14 Thread Jyri Sarha
Moine (1): drm/i2c: tda998x: Add support of a DT graph of ports Jyri Sarha (5): ASoC: hdmi: Remove obsolete dummy HDMI codec ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders drm/i2c: tda998x: Remove include/sound/tda998x.h and fix graph parsing drm/i2c: tda998x: Register ASoC

[PATCH RFC v3 6/7] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality

2015-08-14 Thread Jyri Sarha
for available sample-rates. Implementation of audio_startup for hdmi_codec_ops would enable tda998x driver to abort ongoing playback if the HDMI cable is unplugged or re-plugged to a device without audio capability. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/i2c/Kconfig | 1

[PATCH RFC v3 5/7] drm/i2c: tda998x: Remove include/sound/tda998x.h and fix graph parsing

2015-08-14 Thread Jyri Sarha
Move struct tda998x_audio definition to tda998x_drv.c and remove include/sound/tda998x.h. There is no external use for struct tda998x_audio. Fix graph parsing to allow ports to be inside a separate ports-node as specified in Documentation/devicetree/bindings/graph.txt. Signed-off-by: Jyri Sarha

[PATCH RFC v3 2/7] ASoC: hdmi: Remove obsolete dummy HDMI codec

2015-08-14 Thread Jyri Sarha
The hdmi stub codec has not been used since refactoring of OMAP HDMI audio support. Signed-off-by: Jyri Sarha jsa...@ti.com --- sound/soc/codecs/Kconfig | 4 -- sound/soc/codecs/Makefile | 2 - sound/soc/codecs/hdmi.c | 109 -- 3 files changed

[PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-14 Thread Jyri Sarha
of similar structures in ASoC headers. This is on purpose to avoid direct dependencies to ASoC structures in video side driver. Signed-off-by: Jyri Sarha jsa...@ti.com --- include/sound/hdmi-codec.h| 99 + sound/soc/codecs/Kconfig | 5 + sound/soc/codecs/Makefile | 2

[PATCH RFC v3 1/7] drm/edid: add function to help find SADs, DO NOT MERGE

2015-08-14 Thread Jyri Sarha
From: Russell King - ARM Linux li...@arm.linux.org.uk Add a function to find the start of the SADs in the ELD. This complements the helper to retrieve the SAD count. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk This should already be coming in from drm-next. Signed-off-by: Jyri

[PATCH v2 2/2] OMAPDSS: Fix omap_dss_find_output_by_port_node() port refcount decrement

2015-08-07 Thread Jyri Sarha
Fix omap_dss_find_output_by_port_node() port parameter refcount decrementation. The only user of dss_of_port_get_parent_device() function is omap_dss_find_output_by_port_node() and it assumes the refcount of the port parameter is not decremented by the call. Signed-off-by: Jyri Sarha jsa

[PATCH v2 1/2] OMAPDSS: Fix node refcount leak in omapdss_of_get_next_port()

2015-08-07 Thread Jyri Sarha
Fix node refcount leak in omapdss_of_get_next_port(). Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/dss-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/dss/dss-of.c b/drivers/video/fbdev/omap2/dss/dss-of.c index 928ee63..ab6ef16

[PATCH v2 0/2] OMAPDSS: Fix of-node refcount issues

2015-08-07 Thread Jyri Sarha
sense start using of_graph_*() functions in OMAP DSS too. However the semantics of of_graph_*() functions are quite different from omapdss_of_*() counterparts. So it better to just fix these bugs first. Jyri Sarha (2): OMAPDSS: Fix node refcount leak in omapdss_of_get_next_port() OMAPDSS: Fix

[PATCH 1/2] OMAPDSS: dss-of: Fix node refcount leak in omapdss_of_get_next_port()

2015-08-06 Thread Jyri Sarha
Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/dss-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/dss/dss-of.c b/drivers/video/fbdev/omap2/dss/dss-of.c index 928ee63..ab6ef16 100644 --- a/drivers/video/fbdev/omap2/dss/dss-of.c +++ b

[PATCH 0/2] OMAPDSS: Fix of-node refcount issues

2015-08-06 Thread Jyri Sarha
*() functions are quite different from omapdss_of_*() counterparts. So it better to just fix these bugs first. Jyri Sarha (2): OMAPDSS: dss-of: Fix node refcount leak in omapdss_of_get_next_port() OMAPDSS: of-dss: omap_dss_find_output_by_port_node() keep port refcount drivers/video/fbdev/omap2/dss

[PATCH 2/2] OMAPDSS: of-dss: omap_dss_find_output_by_port_node() keep port refcount

2015-08-06 Thread Jyri Sarha
The only user of dss_of_port_get_parent_device() function is omap_dss_find_output_by_port_node() and it assumes the refcount of the port parameter is not decremented by the call. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/dss-of.c | 2 +- 1 file changed, 1

[PATCH] drm/tilcdc: Allocate register storage based on the actual number registers

2015-07-03 Thread Jyri Sarha
Allocate suspend/resume register storage based on the actual number registers the driver is aware of. The static allocation for register storage had falen behind badly. Reported-by: Michael Bode mich...@bumbleb.de Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/tilcdc/tilcdc_drv.c

[PATCH] drm/tilcdc: Implement dma-buf support for tilcdc

2015-06-30 Thread Jyri Sarha
There is nothing special about tilcdc HW when the video memory is concerned. Just using the standard drm helpers for implementation is enough. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff

[PATCH] drm/tilcdc: Fix bad if statement in tilcdc_get_external_components()

2015-06-12 Thread Jyri Sarha
The if statement condition should have been !node || !of_device_is_available(node) ( changed to ||), but let's rewrite the whole inside of the loop for better readability. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/tilcdc

[PATCH] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller

2015-06-02 Thread Jyri Sarha
node. Signed-off-by: Jyri Sarha jsa...@ti.com --- sound/soc/davinci/davinci-mcasp.c | 61 --- 1 file changed, 51 insertions(+), 10 deletions(-) diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c index d793494..5bc2712 100644

Re: [PATCH v2] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller

2015-06-02 Thread Jyri Sarha
On 06/02/15 19:16, Misael Lopez Cruz wrote: Jyri, On 06/02/2015 08:49 AM, Jyri Sarha wrote: Find the configured DMA controller by asking for a DMA channel in the probe phase and releasing it right after. The controller device can be found via the dma_chan struct and the controller

[PATCH v3] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller

2015-06-02 Thread Jyri Sarha
node. Signed-off-by: Jyri Sarha jsa...@ti.com --- Changes since v2: - Print only one error message if DMA probing fails and none in case of -EPROBE_DEFER Changes since first patch version: - Change enum names from MCASP_?DMA to PCM_?DMA - Return PCM_EDMA if !mcasp-dev-of_node - Do not ignore

Re: [PATCH] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller

2015-06-02 Thread Jyri Sarha
On 06/02/15 13:31, Peter Ujfalusi wrote: On 06/02/2015 11:58 AM, Jyri Sarha wrote: Find the configured DMA controller by asking for a DMA channel in the probe phase and releasing it right after. The controller device can be found via the dma_chan struct and the controller is recognized from

Re: [PATCH] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller

2015-06-02 Thread Jyri Sarha
I missed two comments first time around... On 06/02/15 13:31, Peter Ujfalusi wrote: On 06/02/2015 11:58 AM, Jyri Sarha wrote: Find the configured DMA controller by asking for a DMA channel in the probe phase and releasing it right after. The controller device can be found via the dma_chan

[PATCH v2] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller

2015-06-02 Thread Jyri Sarha
node. Signed-off-by: Jyri Sarha jsa...@ti.com --- Changes since first patch version: - Change enum names from MCASP_?DMA to PCM_?DMA - Return PCM_EDMA if !mcasp-dev-of_node - Do not ignore possible error code returned by davinci_mcasp_get_dma_type() sound/soc/davinci/davinci-mcasp.c | 68

[PATCH v6 3/7] drm/tilcdc: Add support for external tda998x encoder

2015-05-27 Thread Jyri Sarha
helper functions before it is unbound from the external device. I got the idea and some lines of code from Jean-Francois Moine's drm/tilcdc: Change the interface with the tda998x driver-patch. Signed-off-by: Jyri Sarha jsa...@ti.com --- .../devicetree/bindings/drm/tilcdc/tilcdc.txt | 27

[PATCH v6 7/7] ARM: dts: am335x-boneblack: Use new binding for HDMI

2015-05-27 Thread Jyri Sarha
Use new binding for the external tda19988 HDMI encoder. Signed-off-by: Jyri Sarha jsa...@ti.com --- arch/arm/boot/dts/am335x-boneblack.dts | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x

[PATCH v6 4/7] drm/tilcdc: use pm_runtime_irq_safe()

2015-05-27 Thread Jyri Sarha
From: Tomi Valkeinen tomi.valkei...@ti.com tilcdc calls runtime PM get/put functions everywhere. Some of those places will be called in irq context, crashing the driver. As a quick fix, use pm_runtime_irq_safe() for tilcdc. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com Signed-off-by: Jyri

[PATCH v6 5/7] drm/tilcdc: Add DRM_TILCDC_SLAVE_COMPAT for ti,tilcdc,slave binding support

2015-05-27 Thread Jyri Sarha
based slave encoder. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/tilcdc/Kconfig | 12 ++ drivers/gpu/drm/tilcdc/Makefile| 3 + drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 270 + drivers/gpu/drm/tilcdc

[PATCH v6 2/7] drm/tilcdc: Remove tilcdc slave support for tda998x driver

2015-05-27 Thread Jyri Sarha
Remove tilcdc slave support for tda998x driver. The tilcdc slave support would conflicts with componentized use of tda998x. Signed-off-by: Jyri Sarha jsa...@ti.com --- .../devicetree/bindings/drm/tilcdc/slave.txt | 18 - drivers/gpu/drm/tilcdc/Makefile| 1 - drivers

[PATCH v6 6/7] drm/tilcdc: Force building of DRM_TILCDC_SLAVE_COMPAT

2015-05-27 Thread Jyri Sarha
If I read Documentation/kbuild/makefiles.txt section 3.6 right, this patch should not be needed. However, without this patch the objects needed for DRM_TILCDC_SLAVE_COMPAT are not linked, if DRM_TILCDC is built as module. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/Makefile | 2

[PATCH v6 0/7] Use DRM component API in tilcdc to connect to tda998x

2015-05-27 Thread Jyri Sarha
patches are already in. The DRM_TILCDC_SLAVE_COMPAT should keep the bbb HDMI operational until then. The first patch is just a bugfix and can be applied or dropped independently. Jyri Sarha (6): drm/tilcdc: Fix module unloading drm/tilcdc: Remove tilcdc slave support for tda998x driver drm

[PATCH v6 1/7] drm/tilcdc: Fix module unloading

2015-05-27 Thread Jyri Sarha
Force crtc dpms off before destroying the crtc instead of just checking the dpms state. This fixes warning message and frozen picture after tilcdc module unloading. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH RFC v2 4/7] ASoC: hdmi-codec: Add ELD based audio pcm rules DO NOT MERGE

2015-05-26 Thread Jyri Sarha
This patch is mostly just a copy paste from Russel King's generic patchs[1] for the same thing. The patche is included only for testing purposes. Do not merge! [1] http://lists.freedesktop.org/archives/dri-devel/2015-April/080525.html Signed-off-by: Jyri Sarha jsa...@ti.com --- sound/soc/codecs

[PATCH RFC v2 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-05-26 Thread Jyri Sarha
of similar structures in ASoC headers. This is on purpose to avoid direct dependencies to ASoC structures in video side driver. Signed-off-by: Jyri Sarha jsa...@ti.com --- include/sound/hdmi-codec.h| 99 + sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound

[PATCH RFC v2 6/7] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality DO NOT MERGE

2015-05-26 Thread Jyri Sarha
-Francois Moine's ASoC: tda998x: add a codec to the HDMI transmitter patch series. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/i2c/Kconfig | 1 + drivers/gpu/drm/i2c/tda998x_drv.c | 238 ++ 2 files changed, 239 insertions(+) diff --git

[PATCH RFC v2 0/7] Implement generic ASoC HDMI codec

2015-05-26 Thread Jyri Sarha
linux-master-bbb-hdmi-20150512 [1] http://lists.freedesktop.org/archives/dri-devel/2015-May/082537.html [2] http://mailman.alsa-project.org/pipermail/alsa-devel/2015-April/090974.html Jean-Francois Moine (1): drm/i2c: tda998x: Add support of a DT graph of ports DO NOT MERGE Jyri Sarha (6): ASoC

[PATCH RFC v2 1/7] ASoC: core: If component doesn't have of_node use parent's node instead

2015-05-26 Thread Jyri Sarha
If an ASoC component device does not have a device tree node, use its parent's node instead, when looking for a matching DAI based on a device tree reference. This allows video device drivers to register a separate child device for their ASoC side audio functionality. Signed-off-by: Jyri Sarha

[PATCH RFC v2 2/7] ASoC: hdmi: Remove obsolete dummy HDMI codec

2015-05-26 Thread Jyri Sarha
The hdmi stub codec has not been used since refactoring of OMAP HDMI audio support. Signed-off-by: Jyri Sarha jsa...@ti.com --- sound/soc/codecs/Kconfig | 4 -- sound/soc/codecs/Makefile | 2 - sound/soc/codecs/hdmi.c | 109 -- 3 files changed

[PATCH RFC v2 5/7] drm/i2c: tda998x: Add support of a DT graph of ports DO NOT MERGE

2015-05-26 Thread Jyri Sarha
encoder. The new file include/sound/tda998x.h prepares to the definition of a tda998x CODEC. Signed-off-by: Jean-Francois Moine moin...@free.fr Signed-off-by: Jyri Sarha jsa...@ti.com --- .../devicetree/bindings/drm/i2c/tda998x.txt| 51 drivers/gpu/drm/i2c/tda998x_drv.c

[PATCH RFC v2 7/7] ARM: dts: am335x-boneblack: Add HDMI audio support DO NOT MERGE

2015-05-26 Thread Jyri Sarha
This patch is here only to demonstrate HDMI codec functionality on Beaglebone-Black. Adds mcasp0_pins, clk_mcasp0_fixed, clk_mcasp0, mcasp0, sound node, and changes the tda19988 node to follow the new binding. Signed-off-by: Jyri Sarha jsa...@ti.com --- arch/arm/boot/dts/am335x-boneblack.dts

[PATCH early RFC 2/2] drm/i2c: tda998x: HACK Implement primitive HDMI audio with ASoC hdmi-code-lib

2015-05-13 Thread Jyri Sarha
to work on Beaglebone-Black. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/i2c/Kconfig | 1 + drivers/gpu/drm/i2c/tda998x_drv.c | 238 ++ 2 files changed, 239 insertions(+) diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gpu/drm/i2c

[PATCH early RFC 0/2] Implement ASoC HDMI codec library

2015-05-13 Thread Jyri Sarha
] http://mailman.alsa-project.org/pipermail/alsa-devel/2015-April/090974.html Jyri Sarha (2): ASoC: hdmi-codec-lib: Add hdmi-codec-lib for external HDMI-encoders drm/i2c: tda998x: HACK Implement primitive HDMI audio with ASoC hdmi-code-lib drivers/gpu/drm/i2c/Kconfig | 1

[PATCH v5 5/6] drm/tilcdc: Force building of DRM_TILCDC_SLAVE_COMPAT

2015-05-08 Thread Jyri Sarha
If I read Documentation/kbuild/makefiles.txt section 3.6 right, this patch should not be needed. However, without this patch the objects needed for DRM_TILCDC_SLAVE_COMPAT are not linked, if DRM_TILCDC is built as module. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/Makefile | 2

Re: [PATCH v4 0/7] Use DRM component API in tilcdc to connect to tda998x

2015-05-07 Thread Jyri Sarha
On 05/07/15 12:44, Tomi Valkeinen wrote: On 01/04/15 11:49, Jyri Sarha wrote: Ok, let's do one more full review round. The mode filtering issue was the main reason for this new patch series version. However, I found couple other things to fix too after scrutinizing the patches once more

[PATCH 2/5] OMAPDSS: HDMI5: Set valid sample order

2015-04-22 Thread Jyri Sarha
From: Misael Lopez Cruz misael.lo...@ti.com As per TRM, HDMI_WP_AUDIO_CFG[2] LEFT_BEFORE = 0 is reserved, so it must always be set to 1 (the first sample is the left). Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss

[PATCH 1/5] OMAPDSS: HDMI4: Set correct CC for 8-channels layout

2015-04-22 Thread Jyri Sarha
Audio InfoFrame, CC = 7 is required for 8-channels CA masks (0x13 and 0x1F). Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/hdmi4_core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video

[PATCH 5/5] ASoC: omap-hdmi-audio: Fix invalid combination of DM_INH and CA

2015-04-22 Thread Jyri Sarha
From: Misael Lopez Cruz misael.lo...@ti.com DM_INH = 1 (stereo downmix prohibited) and CA = 0x00 (Channel Allocation: FR, FL) is an invalid combination according to the HDMI Compliance Test 7.31 Audio InfoFrame. Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com Signed-off-by: Jyri Sarha jsa

[PATCH 0/5] OMAPDSS: HDMI audio compliance fixes

2015-04-22 Thread Jyri Sarha
I have rebased these patches from ti-linux-3.14.y on top of Linux 4.0.0. I tested them briefly on OMAP4 and OMAP5 in my environment, but I could not test any channel count beyond stereo. However, there were no conflicts in the rebase and each fix makes sense when looking at the chip TRM and the

[PATCH 3/5] OMAPDSS: HDMI5: Fix AUDICONF3 bitfield offsets

2015-04-22 Thread Jyri Sarha
From: Misael Lopez Cruz misael.lo...@ti.com Downmix inhibit in HDMI_CORE_FC_AUDICONF3 register is in bit 4 while CEA861_AUDIO_INFOFRAME_DB5_DM_INH sets bit 7. Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss

[PATCH 4/5] ASoC: omap-hdmi-audio: Force channel allocation only for OMAP4

2015-04-22 Thread Jyri Sarha
for OMAP4 later in the hdmi4 core. Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/hdmi4_core.c | 7 +++ sound/soc/omap/omap-hdmi-audio.c | 6 ++ 2 files changed, 9 insertions(+), 4 deletions(-) diff

  1   2   3   4   5   6   >