Re: [PATCH 37/57] mmc: irq: Remove IRQF_DISABLED

2011-09-22 Thread Kadiyala, Kishore
On Wed, Sep 21, 2011 at 2:58 PM, Yong Zhang yong.zha...@gmail.com wrote: Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see

Re: [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-28 Thread Kadiyala, Kishore
Hi Tony, On Sat, Feb 26, 2011 at 4:59 PM, Kadiyala, Kishore kishore.kadiy...@ti.com wrote: Hi Tony, On Sat, Feb 26, 2011 at 2:27 AM, Tony Lindgren t...@atomide.com wrote: * Tony Lindgren t...@atomide.com [110225 12:42]: * Kishore Kadiyala kishore.kadiy...@ti.com [110225 09:00]: +static int

Re: [PATCH v5 2/8] OMAP2430: hwmod data: Add HSMMC

2011-02-26 Thread Kadiyala, Kishore
Hi Paul, On Sat, Feb 26, 2011 at 3:07 AM, Paul Walmsley p...@pwsan.com wrote: Hello Kishore, There are several problems with this data that generate warning messages on boot on 2430SDP. Did you actually test this on 2430SDP?  The warning messages would have been obvious in the boot log.

Re: [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-26 Thread Kadiyala, Kishore
Hi Tony, On Sat, Feb 26, 2011 at 2:27 AM, Tony Lindgren t...@atomide.com wrote: * Tony Lindgren t...@atomide.com [110225 12:42]: * Kishore Kadiyala kishore.kadiy...@ti.com [110225 09:00]: +static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo) ... +   static int mmc_num; + +

Re: [PATCH v4 0/6] OMAP: HSMMC: hwmod adaptation

2011-02-25 Thread Kadiyala, Kishore
Hi Benoit, On Fri, Feb 25, 2011 at 6:24 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Kishore, On 2/24/2011 8:26 PM, Kadiyala, Kishore wrote: Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4. Adapting the omap_hsmmc driver to hwmod framework. The patch series is based on omap

Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Kadiyala, Kishore
On Fri, Feb 25, 2011 at 6:20 PM, Krishnamoorthy, Balaji T balaj...@ti.com wrote: snip -               if (cpu_is_omap44xx()) -                       mmc-reg_offset = OMAP4_MMC_REG_OFFSET; -               else -                       mmc-reg_offset = 0; +static struct omap_mmc_platform_data

Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Kadiyala, Kishore
On Fri, Feb 25, 2011 at 5:02 AM, Tony Lindgren t...@atomide.com wrote: * Kishore Kadiyala kishore.kadiy...@ti.com [110224 11:17]: Changes involves: 1) Remove controller reset in devices.c which is taken care of    by hwmod framework. 2) Omap2420 platform consists of mmc block as in omap1 and

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Kadiyala, Kishore
On Thu, Feb 24, 2011 at 5:19 PM, Cousson, Benoit b-cous...@ti.com wrote: On 2/23/2011 6:47 PM, Kadiyala, Kishore wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care of    by hwmod framework. 2) Removing all base address macro defines except keeping one

Re: [PATCH v3 4/5] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-24 Thread Kadiyala, Kishore
On Thu, Feb 24, 2011 at 4:29 PM, Cousson, Benoit b-cous...@ti.com wrote: On 2/23/2011 6:47 PM, Kadiyala, Kishore wrote: Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding dual volt MMC card support by the controller

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Kadiyala, Kishore
On Thu, Feb 24, 2011 at 11:58 AM, Varadarajan, Charulatha ch...@ti.com wrote: Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala kishore.kadiy...@ti.com wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care of   by hwmod framework. 2) Removing all base

Re: [PATCH v3 4/5] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-24 Thread Kadiyala, Kishore
On Thu, Feb 24, 2011 at 11:30 AM, Varadarajan, Charulatha ch...@ti.com wrote: Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala kishore.kadiy...@ti.com wrote: Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding

Re: [PATCH v3 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-24 Thread Kadiyala, Kishore
Hi Benoit, On Thu, Feb 24, 2011 at 3:49 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Kishore, On 2/23/2011 6:47 PM, Kadiyala, Kishore wrote: Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4. Adapting the omap_hsmmc driver to hwmod framework. The patch series is based on -rc6

Re: [PATCH 1/6] omap: mmc: split out init for 2420

2011-02-23 Thread Kadiyala, Kishore
On Wed, Feb 23, 2011 at 10:44 PM, Kishore Kadiyala kishore.kadiy...@ti.com wrote: From: Anand Gadiyar gadi...@ti.com The MMC controller on the OMAP2420 is different from those on the OMAP2430, OMAP3 and OMAP4 families - all of the latter are identical. The one on the OMAP2420 is closer to

Re: [PATCH 3/5] OMAP3: hwmod data: Add HSMMC

2011-02-10 Thread Kadiyala, Kishore
Hi Kevin, On Wed, Feb 9, 2011 at 4:00 AM, Kevin Hilman khil...@ti.com wrote: Kishore Kadiyala kishore.kadiy...@ti.com writes: From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman

Re: [PATCH 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-10 Thread Kadiyala, Kishore
On Wed, Feb 9, 2011 at 4:06 AM, Kevin Hilman khil...@ti.com wrote: Kishore Kadiyala kishore.kadiy...@ti.com writes: Update the omap2420 hwmod data with the HSMMC info. Add a device attribute structure which will be used by the host driver to find whether the HSMMC controller supports DUAL

Re: [PATCH 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-10 Thread Kadiyala, Kishore
Hi Paul, On Wed, Feb 9, 2011 at 4:59 AM, Paul Walmsley p...@pwsan.com wrote: On Wed, 2 Feb 2011, Kishore Kadiyala wrote: Update the omap2420 hwmod data with the HSMMC info. Umm, this doesn't look right.  OMAP2420 doesn't have an HSMMC block as far as I know.  It also uses a different driver

Re: [PATCH 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-10 Thread Kadiyala, Kishore
On Wed, Feb 9, 2011 at 4:35 AM, Kevin Hilman khil...@ti.com wrote: Kishore Kadiyala kishore.kadiy...@ti.com writes: Changes involves: 1) Remove controller reset in devices.c which is taken care    by hwmod framework. 2) Removing all base address macro defines. 3) Using omap-device layer to

Re: [PATCH 0/4] omap4: hsmmc: Adding ADMA support

2011-02-02 Thread Kadiyala, Kishore
Tony, On Thu, Jan 20, 2011 at 11:12 PM, Tony Lindgren t...@atomide.com wrote: * Kishore Kadiyala kishore.kadiy...@ti.com [110118 09:19]: This patch series adds support for ADMA on MMC1 MMC2 controllers on OMAP4. There is no performance improvement observed using ADMA over SDMA. Advantage