Re: OMAP baseline test results for v3.7-rc2

2012-10-22 Thread Kevin Hilman
+Igor Paul Walmsley p...@pwsan.com writes: Here are some basic OMAP test results for Linux v3.7-rc2. Logs and other details at: http://www.pwsan.com/omap/testlogs/test_v3.7-rc2/20121020134755/ [...] * 37xx EVM: CORE not entering dynamic off-idle - Cause unknown; dynamic

[PATCH v2] ARM: OMAP2: UART: fix console UART mismatched runtime PM status

2012-10-19 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com The runtime PM framework assumes that the hardware state of devices when initialized is disabled. For all omap_devices, we idle/disable device by default. However, the console uart uses a no idle option during omap_device init in order to allow earlyprintk

Re: RT throttling and suspend/resume (was Re: [PATCH] i2c: omap: revert i2c: omap: switch to threaded IRQ support)

2012-10-19 Thread Kevin Hilman
Peter Zijlstra pet...@infradead.org writes: On Thu, 2012-10-18 at 08:51 +0300, Felipe Balbi wrote: So the primary question remains: is RT runtime supposed to include the time spent suspended? I suspect not. you might be right there, though we need Thomas or Peter to answer :-s re,

Re: RT throttling and suspend/resume (was Re: [PATCH] i2c: omap: revert i2c: omap: switch to threaded IRQ support)

2012-10-19 Thread Kevin Hilman
Peter Zijlstra pet...@infradead.org writes: On Thu, 2012-10-18 at 08:51 +0300, Felipe Balbi wrote: So the primary question remains: is RT runtime supposed to include the time spent suspended? I suspect not. you might be right there, though we need Thomas or Peter to answer :-s re,

Re: [RFC/NOT FOR MERGING 1/5] arm: omap: fix up _od_suspend_noirq and _od_resume_noirq

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: current implementation doesn't take care about drivers which don't provide *_noirq methods The generic ops handle this. See below. and we could fall into a situation where we would suspend/resume devices even though they haven't asked for it. The

Re: [RFC/NOT FOR MERGING 2/5] arm: omap: don't forcefully runtime suspend a device

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: device drivers should be smart enough to provide -suspend/-resume callbacks when needed and they should take care of doing whatever needs to be done in order to allow a device to be suspended. Calling pm_runtime_* from system suspend isn't the right way to

Re: [RFC/NOT FOR MERGING 3/5] arm: omap: introduce other PM methods

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: current omap_device PM implementation defines omap-specific *_noirq methods but uses the generic versions for all other PM methods. As it turns out, if a device decides to implement non-runtime PM callbacks, we might fall into a situation where the hwmod

Re: [RFC/NOT FOR MERGING 4/5] i2c: omap: don't re-enable IRQs after masking them

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: OMAP I2C driver will re-enable IRQs right after masking them during suspend. That's not what we want. We want to keep IRQs masked until our resume method is called. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 10

Re: [RFC/NOT FOR MERGING 1/5] arm: omap: fix up _od_suspend_noirq and _od_resume_noirq

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Thu, Oct 18, 2012 at 09:34:15AM -0700, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: current implementation doesn't take care about drivers which don't provide *_noirq methods The generic ops handle this. See below. and we could

Re: [RFC/NOT FOR MERGING 1/5] arm: omap: fix up _od_suspend_noirq and _od_resume_noirq

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Thu, Oct 18, 2012 at 10:42:37AM -0700, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Hi, On Thu, Oct 18, 2012 at 09:34:15AM -0700, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: current implementation doesn't take care

Re: [RFC/NOT FOR MERGING 1/5] arm: omap: fix up _od_suspend_noirq and _od_resume_noirq

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: [...] if the device implements none of the suspend methods, then you shouldn't suspend it at all, because you'd be masking a bug in the driver, IMHO. OK, let's start over here, because here's the fundamental difference. I don't think missing suspend methods

Re: [RFC/NOT FOR MERGING 1/5] arm: omap: fix up _od_suspend_noirq and _od_resume_noirq

2012-10-18 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: [...] ps: I'll continue reading the code and further test my series to see if I can understand what you say here. OK. And please get it working in cases where drivers are using I2C in their suspend/resume (and even late/early) paths, and also where device

Re: RT throttling and suspend/resume (was Re: [PATCH] i2c: omap: revert i2c: omap: switch to threaded IRQ support)

2012-10-17 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: On Wed, Oct 17, 2012 at 05:00:02PM +0300, Felipe Balbi wrote: On Tue, Oct 16, 2012 at 02:39:50PM -0700, Kevin Hilman wrote: + peterz, tglx Felipe Balbi ba...@ti.com writes: [...] The problem I see is that even though we properly return

Re: [RFC][PATCH v4? 0/7] Adaptive Body-Bias for OMAP

2012-10-16 Thread Kevin Hilman
Mike Turquette mturque...@ti.com writes: Quoting Tony Lindgren (2012-10-16 09:32:25) * Mike Turquette mturque...@ti.com [121011 15:27]: Quoting Nishanth Menon (2012-10-11 06:33:04) On 18:26-20121003, Mike Turquette wrote: From: Mike Turquette mturque...@linaro.org [...]

[PATCH] genirq: provide means to retrigger parent

2012-10-16 Thread Kevin Hilman
, but check_irq_resend() returning early on subsequent resends because the replay flag is still set. Problem discovered on ARM/OMAP platforms where a nested IRQ that's also a wakeup IRQ happens late in suspend and needed to be retriggered during the resume process. Reported-by: Kevin Hilman khil...@ti.com Tested

Re: [PATCH 1/1] twl4030: Fix chained irq handling on resume from suspend

2012-10-16 Thread Kevin Hilman
interrupt, and SIHs have not been enabled yet, a flood of interrupts hangs the device. Fixed the issue by setting the SIH irqs with IRQF_EARLY_RESUME flags, so they get enabled before the PIH. Signed-off-by: Kalle Jokiniemi kalle.jokini...@jollamobile.com Acked-by: Kevin Hilman khil...@ti.com

Re: [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle

2012-10-16 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Kevin, Here's an updated version of this one, with the erratum coverage expanded to include OMAP34xx/35xx. I think this one can replace Tero's [PATCHv6 06/11] ARM: OMAP: clockdomain: add support for preventing autodep delete and [PATCHv6 07/11]

Re: [PATCH] ARM: OMAP2: UART: fix console UART mismatched runtime PM status

2012-10-16 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Felipe Balbi ba...@ti.com [121016 03:32]: Hi, On Mon, Oct 15, 2012 at 04:49:58PM -0700, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com The runtime PM framework assumes that the hardware state of devices when initialized is disabled

Re: [PATCH] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2012-10-15 Thread Kevin Hilman
Kalle Jokiniemi kalle.jokini...@jollamobile.com writes: Hi, la, 2012-10-13 kello 01:00 +0530, Shubhrajyoti Datta kirjoitti: On Sat, Oct 13, 2012 at 12:10 AM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com Currently, runtime PM is used to keep

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-10-15 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [121012 13:34]: I'm not conviced (yet) that a mismatch is the root cause. Yes, that's what the author of $SUBJECT patch assumed and stated, but I'm not pursuaded. If it's an improperly configured mux

[PATCH] ARM: OMAP2: UART: fix console UART mismatched runtime PM status

2012-10-15 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com The runtime PM framework assumes that the hardware state of devices when initialized is disabled. For all omap_devices, we idle/disable device by default. However, the console uart uses a no idle option during omap_device init in order to allow earlyprintk

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-12 Thread Kevin Hilman
Strashko, Grygorii grygorii.stras...@ti.com writes: Hi All, Sorry, for the late reply. + CC Huzefa Kankroliwala - who is I2C driver owner on Android Kernel 3.4. Hi Grygorii, thanks for reviewing. I was hoping you would have some ideas here as this was sounding familiar to something you had

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-12 Thread Kevin Hilman
Strashko, Grygorii grygorii.stras...@ti.com writes: Hi All, Sorry, for the late reply. + CC Huzefa Kankroliwala - who is I2C driver owner on Android Kernel 3.4. Hi Grygorii, thanks for reviewing. I was hoping you would have some ideas here as this was sounding familiar to something you had

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-10-12 Thread Kevin Hilman
Sourav sourav.pod...@ti.com writes: Hi Paul, There are On Thursday 11 October 2012 11:58 PM, Paul Walmsley wrote: Hi Sourav, Felipe, any progress on fixing the N800 problem? Would be good to keep it booting since we use it as our primary 2420 test platform. - Paul The patch sent

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-12 Thread Kevin Hilman
, omap_i2c_runtime_resume, NULL) }; - Grygorii From: Kevin Hilman [khil...@deeprootsystems.com] Sent: Friday, October 12, 2012 5:34 PM To: Strashko, Grygorii Cc: Kalle Jokiniemi; linux-...@vger.kernel.org; w.s...@pengutronix.de; ben-li...@fluff.org; t

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-10-12 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Fri, Oct 12, 2012 at 09:35:54AM -0700, Kevin Hilman wrote: Sourav sourav.pod...@ti.com writes: diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 6ede6fd..3fbc7f7 100644 --- a/drivers/tty

[PATCH] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2012-10-12 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com Currently, runtime PM is used to keep the device enabled only during active transfers and for a configurable runtime PM autosuspend timout after an xfer. In addition to idling the device, driver's -runtime_suspend() method currently disables device interrupts

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-12 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Russell King - ARM Linux li...@arm.linux.org.uk [121012 08:56]: For those who don't bother looking at my kautobuild boot tests on the OMAP boards I have, here's the errors which get spat out at boot time. Note that some of these I've reported in the

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-12 Thread Kevin Hilman
Shubhrajyoti Datta omaplinuxker...@gmail.com writes: On Fri, Oct 12, 2012 at 10:13 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Strashko, Grygorii grygorii.stras...@ti.com writes: Hi Kevin, yep, [1] is the same fix - thanks. Hi Kalle, i've applied these changes and PM runtime

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-10-12 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Fri, Oct 12, 2012 at 10:59:22AM -0700, Kevin Hilman wrote: Russell King - ARM Linux li...@arm.linux.org.uk writes: On Fri, Oct 12, 2012 at 09:35:54AM -0700, Kevin Hilman wrote: Sourav sourav.pod...@ti.com writes: diff --git

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

2012-10-11 Thread Kevin Hilman
on N9. Patch tested on N9. Signed-off-by: Kalle Jokiniemi kalle.jokini...@jollamobile.com This version looks good, thanks for the extra comments. Reviewed-by: Kevin Hilman khil...@ti.com Tested-by: Kevin Hilman khil...@ti.com Wolfram, This should also probably be Cc'd to stable since

Re: [PATCHv2 1/3] OMAP: VRFB: convert vrfb to platform device

2012-10-10 Thread Kevin Hilman
Tomi Valkeinen tomi.valkei...@ti.com writes: On Tue, 2012-10-09 at 13:37 -0700, Kevin Hilman wrote: Hi Tomi, Tomi Valkeinen tomi.valkei...@ti.com writes: This patch converts vrfb library into a platform device, in an effort to remove omap dependencies. The platform device

Re: [RFC 00/24] OMAP serial driver flow control fixes, and preparation for DMA engine conversion

2012-10-10 Thread Kevin Hilman
Hi Sourav, Sourav sourav.pod...@ti.com writes: [...] Boot Tested this patch series against v3.6 tag(applied cleanly) on panda board and PM tested(hitting off in Idle and suspend) on omap3630 based beagle board. Note, I also tested the patches against the current master but only after

Re: [PATCHv2 1/3] OMAP: VRFB: convert vrfb to platform device

2012-10-09 Thread Kevin Hilman
Hi Tomi, Tomi Valkeinen tomi.valkei...@ti.com writes: This patch converts vrfb library into a platform device, in an effort to remove omap dependencies. The platform device is registered in arch/arm/plat-omap/fb.c and assigned resources depending on whether running on omap2 or omap3. The

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

2012-10-09 Thread Kevin Hilman
Hi Sakari, Sakari Ailus sakari.ai...@iki.fi writes: The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to the actual CSI-2 receivers outside the ISP itself. Allow changing this configuration from the ISP driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi These

[PATCH] rtc: kconfig: fix RTC_INTF defaults connected to RTC_CLASS

2012-10-09 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com commit 6b8029fab64164b5895d58d23229b75c82e3a6fc (rtc: kconfig: remove unnecessary dependencies) removed various 'depends on RTC_CLASS' dependencies but also removed a few 'default RTC_CLASS' statements, which actually changed default behavior. This resulted

Re: [PATCH 0/4] cpufreq: OMAP: fixes for v3.7-rc2

2012-10-08 Thread Kevin Hilman
Rafael J. Wysocki r...@sisk.pl writes: On Wednesday 03 of October 2012 16:00:25 Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com Here's a series with a couple bug fixes and a couple fixes that make this driver support newer OMAP-based SoCs. The 'get_cpu_device' patch is needed due

[GIT PULL] ARM: OMAP: CPUfreq fixes for v3.7-rc

2012-10-08 Thread Kevin Hilman
. Kevin Hilman (4): cpufreq: OMAP: ensure valid clock rate before scaling cpufreq: OMAP: remove unused plat/omap-pm.h cpufreq: OMAP: use get_cpu_device() instead of omap_device API ARM: OMAP2+: PM: MPU DVFS: use generic CPU device for MPU-SS Paul Walmsley

[GIT PULL] ARM: OMAP: PM fixes for v3.7-rc

2012-10-08 Thread Kevin Hilman
Tony, Please pull the following OMAP PM fixes for v3.7-rc. Thanks, Kevin The following changes since commit a0d271cbfed1dd50278c6b06bead3d00ba0a88f9: Linux 3.6 (2012-09-30 16:47:46 -0700) are available in the git repository at:

Re: [PATCH] gpio/gpio-omap: Use existing pointer to struct device

2012-10-05 Thread Kevin Hilman
Tobias Klauser tklau...@distanz.ch writes: A pointer to pdev-dev is already stored in dev, so use it in devm_kzalloc. Signed-off-by: Tobias Klauser tklau...@distanz.ch Acked-by: Kevin Hilman khil...@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH] i2c: i2c-omap: fix interrupt flood during resume

2012-10-05 Thread Kevin Hilman
+Grygorii (who's been working on various I2C related suspend/resume issues also) Hi Kalle, Kalle Jokiniemi kalle.jokini...@jollamobile.com writes: The resume_noirq enables interrupts one-by-one starting from first one. Now if the wake up event for suspend came from i2c device, the

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-04 Thread Kevin Hilman
Hi Thomas, Thomas Petazzoni thomas.petazz...@free-electrons.com writes: Kevin, Reviving an old thread. On Fri, 04 May 2012 16:46:32 -0700, Kevin Hilman wrote: Thomas Petazzoni thomas.petazz...@free-electrons.com writes: I have an IGEPv2 revision 6 board, which uses the DM3730 OMAP3

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-04 Thread Kevin Hilman
Thomas Petazzoni thomas.petazz...@free-electrons.com writes: Kevin, On Thu, 04 Oct 2012 10:18:04 -0700, Kevin Hilman wrote: Can you dump the UART mux registers on a working kernel and compare them to the broken one? (Table 7-4 in the 34xx public TRM[1] will list all the mux registers

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-04 Thread Kevin Hilman
Thomas Petazzoni thomas.petazz...@free-electrons.com writes: On Thu, 4 Oct 2012 22:30:58 +0200, Enric Balletbò i Serra wrote: I recently tested kernel 3.6-rc5 and worked for me. Let me check tomorrow kernel 3.6. Which u-boot version are you using? 2011.12 + a few patches to make the NAND of

Re: [PATCH 0/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-04 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the

Re: OMAP4460/PandaES: hang during resume

2012-10-03 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: On Wed, Oct 3, 2012 at 5:05 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Santosh, Tero, I just added my 4460/PandaES to my board farm for automated PM testing and see that basic suspend/resume tests don't work in mainline

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the

[PATCH] ARM: OMAP2+: PM: MPU DVFS: use generic CPU device for MPU-SS

2012-10-03 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com Currently, a dummy omap_device is created for the MPU sub-system so that a device node exists for MPU DVFS. Specifically, for the association of MPU OPPs to a device node, and so that a voltage regulator can be mapped to a device node. For drivers to get

[PATCH 0/4] cpufreq: OMAP: fixes for v3.7-rc2

2012-10-03 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com Here's a series with a couple bug fixes and a couple fixes that make this driver support newer OMAP-based SoCs. The 'get_cpu_device' patch is needed due to a change in the OMAP OMAP PM core code which enforces use of get_cpu_device() instead of a deprecated OMAP

[PATCH 4/4] cpufreq: OMAP: use get_cpu_device() instead of omap_device API

2012-10-03 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com OMAP PM core code has moved to using the existing, generic CPU devices for attaching OPPs, so the CPUfreq driver can now use the generic get_cpu_device() API instead of the OMAP-specific omap_device API. This allows us to remove the last plat/* include from

[PATCH 2/4] cpufreq: OMAP: remove unused plat/omap-pm.h

2012-10-03 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com The plat/*.h headers are going away, and this one is not used. remove it. Signed-off-by: Kevin Hilman khil...@ti.com --- drivers/cpufreq/omap-cpufreq.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap

[PATCH 1/4] cpufreq: OMAP: ensure valid clock rate before scaling

2012-10-03 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com Ensure the clock rate that will be used is a valid one before attempting to scale the voltage. Currently the driver assumes it has a valid frequency from the OPP table, but boards using different system oscillators might not have exact matches with the OPP table

[PATCH 3/4] cpufreq: OMAP: fix clock usage to be SoC independent, remove plat/ includes

2012-10-03 Thread Kevin Hilman
-subarch ARM kernels. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Rafael J. Wysocki r...@sisk.pl [t...@atomide.com: updated already changed clock aliases] Signed-off-by: Tony Lindgren t...@atomide.com [khil...@ti.com: minor shortlog/changelog updates] Signed-off-by: Kevin Hilman khil...@ti.com

Re: [PATCH 1/2] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-10-03 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * jean.pi...@newoldbits.com jean.pi...@newoldbits.com [121003 08:48]: @@ -1036,8 +1036,8 @@ static struct omap_clk am33xx_clks[] = { CLK(davinci-mcasp.1, NULL, mcasp1_fck,CK_AM33XX), CLK(NULL, mmc2_fck, mmc2_fck,

Re: [PATCH] ARM: OMAP: fix return value check in beagle_opp_init()

2012-10-02 Thread Kevin Hilman
Wei Yongjun weiyj...@gmail.com writes: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function omap_device_get_by_hwmod_name() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto

Re: [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()

2012-10-02 Thread Kevin Hilman
Wei Yongjun weiyj...@gmail.com writes: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function omap_device_alloc() returns ERR_PTR() and never returns NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to

Re: [PATCH] ARM: OMAP2+: SmartReflex: fix return value check in sr_dev_init()

2012-10-02 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Hello, On Thu, Sep 27, 2012 at 7:54 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function voltdm_lookup() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check

Re: [PATCH] ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()

2012-10-02 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: On Thu, Sep 27, 2012 at 7:54 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function voltdm_lookup() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should

Re: [PATCH] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-10-02 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Rename the smartreflex fck names for consistency and better readability; rename the clock aliases for use by the SmartReflex driver, with the smartreflex.%d format. hmm, do we even need the clkdev nodes anymore? The driver isn't directly accessing

Re: [PATCH] ARM: OMAP: SmartReflex: select CONFIG_POWER_SUPPLY in Kconfig

2012-10-02 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Select POWER_SUPPLY from POWER_AVS_OMAP entry in Kconfig. This avoids the following build problems using a randconfig that has CONFIG_POWER_SUPPLY not set: LD init/built-in.o arch/arm/mach-omap2/built-in.o: In

Re: [PATCH 1/2] ARM: OMAP: SmartReflex: fix error path in init function

2012-10-02 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Fix the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. Signed-off-by: Jean Pihet j-pi...@ti.com Thanks, queuing this one as a fix for v3.7-rc Kevin -- To unsubscribe from this list: send the line

Re: [PATCH] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-10-02 Thread Kevin Hilman
On 10/02/2012 02:49 PM, Kevin Hilman wrote: Jean Pihet jean.pi...@newoldbits.com writes: Rename the smartreflex fck names for consistency and better readability; rename the clock aliases for use by the SmartReflex driver, with the smartreflex.%d format. hmm, do we even need the clkdev nodes

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-02 Thread Kevin Hilman
Hi Jean, Jean Pihet jean.pi...@newoldbits.com writes: Remove the device dependent settings (cpu_is_xxx(), IP fck etc.) from the driver code and pass them instead via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-10-02 Thread Kevin Hilman
Poddar, Sourav sourav.pod...@ti.com writes: Hi, On Tue, Sep 25, 2012 at 2:51 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Sep 25, 2012 at 12:11:14PM +0300, Felipe Balbi wrote: On Tue, Sep 25, 2012 at 10:12:28AM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25,

Re: [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()

2012-10-01 Thread Kevin Hilman
to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap/omap_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/plat-omap

Re: [PATCH] ARM: OMAP: fix return value check in beagle_opp_init()

2012-10-01 Thread Kevin Hilman
generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Kevin Hilman khil...@ti.com --- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/board

Re: Beagleboard xM crashes when being set to 800MHz with smartreflex on linux-omap-3.6-rc6

2012-10-01 Thread Kevin Hilman
Maximilian Schwerin maximilian.schwe...@tigris.de writes: Hi, I've just built a linux-omap kernel at 3.6-rc6 using omap2plus_defconfig as basis for the kernel config. When I enable smartreflex and switch to 800MHz via echo 1 /sys/kernel/debug/smartreflex/smartreflex_core/autocomp echo 1

Re: [PATCH V2] ARM: OMAP: counter: add locking to read_persistent_clock

2012-09-24 Thread Kevin Hilman
-by: R Sricharan r.sricha...@ti.com Acked-by: Kevin Hilman khil...@ti.com Tony, this should probably be queued up for v3.7-rc and flagged for stable. Thanks, Kevin --- [V2] Added signed-off-by and looped in linux-arm-kernel list arch/arm/plat-omap/counter_32k.c | 21

Re: [PATCH] ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-09-24 Thread Kevin Hilman
to decide the next power state of the MPU subsystem. The I2C device latency timing is derived from the FIFO size and the clock speed and so is applicable to all OMAP SoCs. Signed-off-by: Jean Pihet j-pi...@ti.com Acked-by: Kevin Hilman khil...@ti.com -- To unsubscribe from this list: send the line

Re: [PATCH] serial: omap: fix the overrun case

2012-09-21 Thread Kevin Hilman
-off-by: Shubhrajyoti D shubhrajy...@ti.com --- - functional testing on omap4sdp - Verified idle and suspend path hits off on beagle. Tested-by: Kevin Hilman khil...@ti.com This fixes the console hang I was seeing on 3530/Overo. Thanks, Kevin drivers/tty/serial/omap-serial.c |7

Re: [PATCH RESEND] PM / Runtime: let rpm_resume() succeed if RPM_ACTIVE, even when disabled

2012-09-21 Thread Kevin Hilman
Alan Stern st...@rowland.harvard.edu writes: On Fri, 21 Sep 2012, Rafael J. Wysocki wrote: Kevin makes a good case that pm_runtime_resume() and related functions should succeed even when runtime PM is disabled, if the device is already in the desired state. The same may be true for

Re: [PATCH v2] serial: omap: fix the reciever line error case

2012-09-21 Thread Kevin Hilman
-by: Shubhrajyoti D shubhrajy...@ti.com --- - Tested on omap4sdp. - pm tested hitting off in idle and suspend. - v2 changes update the changelogs. - Also remove the dummy check as FE , PE , BI and OE are the only receiver errors. Tested-by: Kevin Hilman khil...@ti.com This one also makes

Re: serial-omap regression?

2012-09-21 Thread Kevin Hilman
Not sure if it's related to the cleanup series, but I've also been seeing a bunch of 'callbacks suppressed messages lately. Is anyone else seeing this? Here's an example from a debian nfsfroot boot: [ 20.044006] tty_init_dev: 59 callbacks suppressed [ 25.063934] tty_init_dev: 57 callbacks

[PATCH v2] PM / Runtime: let rpm_resume() succeed if RPM_ACTIVE, even when disabled

2012-09-21 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com There are several drivers where the return value of pm_runtime_get_sync() is used to decide whether or not it is safe to access hardware and that don't provide .suspend() callbacks for system suspend (but may use late/noirq callbacks.) If such a driver happens

arm-soc/for-next: fixup compile after platform_data move

2012-09-20 Thread Kevin Hilman
is a simple fix. Kevin From cae062932d1d28e499b03d31da815fc2696badfd Mon Sep 17 00:00:00 2001 From: Kevin Hilman khil...@ti.com Date: Thu, 20 Sep 2012 09:28:43 -0700 Subject: [PATCH] ARM: OMAP: AM33xx hwmod: fixup SPI after platform_data move AM33xx hwmod data includes mcspi.h which has now been

[PATCH RESEND] PM / Runtime: let rpm_resume() succeed if RPM_ACTIVE, even when disabled

2012-09-20 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com When runtime PM is disabled, what we want is for callbacks not to be called from then on. However, currently, when runtime PM is disabled, operations such as 'get' will also fail even if the device is currently active. Since calling 'get' on a device

serial-omap regression?

2012-09-20 Thread Kevin Hilman
Hi Felipe, I just noticed today that one of my boards (3530/Overo) was not making it to the console when using an Debian rootfs (nfsroot) but works fine with my basic busybox initramfs. Basically, it hangs somewhere between finishing the userspace init and launching the login shell. git bisect

Re: serial-omap regression?

2012-09-20 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Hi Felipe, I just noticed today that one of my boards (3530/Overo) was not making it to the console when using an Debian rootfs (nfsroot) but works fine with my basic busybox initramfs. Basically, it hangs somewhere between finishing

Re: [PATCH] cpufreq: OMAP: Check IS_ERR() instead of NULL for omap_device_get_by_hwmod_name

2012-09-19 Thread Kevin Hilman
Rafael J. Wysocki r...@sisk.pl writes: On Tuesday, September 18, 2012, Axel Lin wrote: omap_device_get_by_hwmod_name() returns ERR_PTR on error. Signed-off-by: Axel Lin axel@gmail.com Kevin, should I take this? Yes, please. Acked-by: Kevin Hilman khil...@ti.com Thanks, Kevin

Re: [PATCH] serial: omap: Remove unnecessary checks from suspend/resume

2012-09-19 Thread Kevin Hilman
Poddar, Sourav sourav.pod...@ti.com writes: Hi Felipe, On Tue, Sep 18, 2012 at 5:04 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Sep 18, 2012 at 05:05:54PM +0530, Sourav Poddar wrote: Drop the check for up being valid on suspend/resume callbacks. It should be valid always. Get rid of the

Re: [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle

2012-09-19 Thread Kevin Hilman
Hilman khil...@ti.com Acked-by: Kevin Hilman khil...@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] PM / Runtime: let rpm_resume() succeed if RPM_ACTIVE, even when disabled

2012-09-19 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com When runtime PM is disabled, what we want is for callbacks not to be called from then on. However, currently, when runtime PM is disabled, operations such as 'get' will also fail even if the device is currently active. Since calling 'get' on a device

Re: [PATCH] RTC: TWL: ensure all interrupts are disabled during probe

2012-09-14 Thread Kevin Hilman
Shubhrajyoti Datta omaplinuxker...@gmail.com writes: Hi Kevin, On Fri, Sep 14, 2012 at 2:15 AM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com On some platforms, bootloaders are known to do some interesting RTC programming. Without going

Re: [PATCH] can: c_can: Move pm_runtime_enable/disable calls to common code

2012-09-13 Thread Kevin Hilman
AnilKumar Ch anilku...@ti.com writes: Move pm_runtime_enable/disable calls to c_can.c driver. Current implementation is such that platform driver is doing pm_runtime enable/disable and core driver is doing put_sync/get_sync. PM runtime calls should be invoked if there is a valid device

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: [...] I just ran same tests on pandaboard and i2c is suspended actually, though no power domain transitions to RET. Do we not have retention while idle on pandaboard ? Not for CORE. Only CPUx and MPU domains will be transitioning on OMAP4, and then, only

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Kevin Hilman khil...@deeprootsystems.com writes: [...] Sorry to be late to the party (again), but still catching up after some time off. Unfortunately, this series causes PM regressions on several OMAP platforms. I hope we can hold off

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Thu, Sep 13, 2012 at 11:04:42AM -0700, Kevin Hilman wrote: Kevin Hilman khil...@deeprootsystems.com writes: Kevin Hilman khil...@deeprootsystems.com writes: [...] Sorry to be late to the party (again), but still catching up after some time

Re: [PATCH] can: c_can: Move pm_runtime_enable/disable calls to common code

2012-09-13 Thread Kevin Hilman
Marc Kleine-Budde m...@pengutronix.de writes: On 09/13/2012 04:14 PM, Kevin Hilman wrote: AnilKumar Ch anilku...@ti.com writes: Move pm_runtime_enable/disable calls to c_can.c driver. Current implementation is such that platform driver is doing pm_runtime enable/disable and core driver

Re: [PATCH] CPUFreq: OMAP: remove unnecessary plat/ includes

2012-09-12 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: On Wed, Sep 12, 2012 at 6:02 AM, Paul Walmsley p...@pwsan.com wrote: Remove some unnecessary plat/ includes that are interfering with multi-subarch ARM kernels. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com

[GIT PULL] ARM: OMAP: omap_device updates for v3.7

2012-09-12 Thread Kevin Hilman
) Updates for omap_device layer for v3.7. Allows omap_device layer to keep track of driver bound status in order to make more intelligent decisions about idling unused devices. Kevin Hilman (3): ARM

Re: [PATCHv7 06/12] ARM: OMAP4: suspend: Program all domains to retention

2012-09-12 Thread Kevin Hilman
: ported on top of the functional power states] Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Kevin Hilman khil...@ti.com Paul, go ahead and queue this one with the others. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Kevin Hilman
Shubhrajyoti D shubhrajy...@ti.com writes: [...] This is the cleanup only series. Tested on omap4sdp and 3430sdp. It would be extremely helpful if you would describe how this was tested. And for me, it would be a source of extreme joy if you described any PM testing. I gave this some

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Kevin Hilman
Wolfram Sang w.s...@pengutronix.de writes: On Wed, Sep 12, 2012 at 04:27:54PM +0530, Shubhrajyoti D wrote: [...] This is the cleanup only series. Tested on omap4sdp and 3430sdp. The following changes since commit 55d512e245bc7699a8800e23df1a24195dd08217: Linux 3.6-rc5 (2012-09-08

Re: [PATCHv8 21/22] i2c: omap: switch over to autosuspend API

2012-09-12 Thread Kevin Hilman
Shubhrajyoti D shubhrajy...@ti.com writes: From: Felipe Balbi ba...@ti.com this helps us reduce unnecessary pm transitions in case we have another i2c message starting soon. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com I tracked the PM

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Wolfram Sang w.s...@pengutronix.de writes: On Wed, Sep 12, 2012 at 04:27:54PM +0530, Shubhrajyoti D wrote: [...] This is the cleanup only series. Tested on omap4sdp and 3430sdp. The following changes since commit

Re: [PATCHv7 07/12] ARM: OMAP4: PM: put all domains to OSWR during suspend

2012-09-12 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: [...] It kind of looks to me like there are two or three separate sets within the series. My feeling is that Kevin should take the first two, then I should take the rest other than 6 and 7. Then once those are queued, we can pull in 6 and 7. Does

Re: [PATCH 5/7] ARM: OMAP2+: PM debug: trace the functional power domains states

2012-09-12 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Trace the power domain transitions using the functional power states, which include the power and logic states. Just to be clear, this means that a trace will only contain functional power state changes, not logical ones, correct? While at it, fix

Re: [PATCH 7/7] ARM: OMAP2+: PM: reorganize the powerdomain API in public and private parts

2012-09-12 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: The newly added code for functional power states re-defines the API to query and control the power domains settings. The API is now split in the following parts in powerdomain.h: - the public or external API, to be used by external PM components:

Re: [PATCH 4/7] ARM: OMAP2+: PM: use power domain functional state in stats counters

2012-09-12 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: The PM code uses some counters to keep track of the power domains transitions, in order to provide the information to drivers (in pwrdm_get_context_loss_count) and to expose the information to sysfs for debug purpose. nit: this is part of debugfs,

Re: [PATCH v6 0/7] ARM: OMAP2+: PM: introduce the power domains functional states

2012-09-12 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Here is a re-spin after some comments and suggestions after review and discussions. Implement the functional states for the power domains: - unify the API to use the functional states. The new API consists of the pwrdm_set*_fpwrst and

<    1   2   3   4   5   6   7   8   9   10   >