Re: [PATCH] OMAP: config : disable the usb host configuration in omap2plus_defconfig

2012-07-06 Thread Kevin Hilman
Keshava Munegowda writes: > The usb host is disabled in the omap2 build; This is because > usb host is causing the retention to break in cpu idle. ... and causes warnings during boot, and hangs in suspend, can't suspend using NFSroot, etc. etc. Thank you for disabling this by default, But I don

[GIT PULL] OMAP: PM: one more fix for 3.5-rc

2012-07-05 Thread Kevin Hilman
Tony, Hopefully this is the last one. This one fixes a problem where the CORE power domain does not hit retention during suspend. This has been known since v3.5 came out, but there has been some discussion about the proper fix. The solution has now been agreed upon, so I'd like to see this make

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-05 Thread Kevin Hilman
Paul Walmsley writes: > Hi Benoît > > On Wed, 4 Jul 2012, Benoit Cousson wrote: > >> > @@ -1141,8 +1144,16 @@ static void _enable_sysc(struct omap_hwmod *oh) >> >sf = oh->class->sysc->sysc_flags; >> > >> >if (sf & SYSC_HAS_SIDLEMODE) { >> > - idlemode = (oh->flags & HWMOD_SWSUP

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Kevin Hilman
er possible fix would have been to modify the pm34xx.c code to > force the IP block idle before entering WFI. But this would not have > been an acceptable approach: we are trying to remove this type of > centralized IP block idle control from the PM code. > > This patch is a collaboration betwee

Re: 3.5-rc3: PM/DSS broken (was vdd_mpu_iva warnings)

2012-07-04 Thread Kevin Hilman
"Joe Woodward" writes: > ...snip... > >> > # >> >> Thanks for testing this out. >> >> I was going through Tomi's queue for the 3.6 merge window: >> >> git://gitorious.org/linux-omap-dss2/linux.git master >> >> There is a commit called: >> >> 2b8501d777346ce1d4fe99167e9b3c0e42aae7a8 >> >> OM

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-04 Thread Kevin Hilman
"Munegowda, Keshava" writes: > On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava > wrote: >> On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman wrote: >>> Felipe, Keshava, >>> >>> Kevin Hilman writes: >>> >>>> Felipe Balbi

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Kevin Hilman
Kevin Hilman writes: > Felipe, Keshava, > > Kevin Hilman writes: > >> Felipe Balbi writes: >> >> [...] >> >>> Keshava is reverting a fix for a HW errata. I can't accept it as it will >>> cause regressions. Granted, regression by regr

Re: [PATCH] gpio/omap: fix invalid context restore of gpio bank-0

2012-07-02 Thread Kevin Hilman
NeilBrown writes: > On Mon, 2 Jul 2012 13:26:38 -0500 Jon Hunter wrote: > >> >> On 07/02/2012 01:07 PM, Kevin Hilman wrote: >> > + Neil Brown >> > >> > Hi Jon, >> > >> > Jon Hunter writes: >> > &g

Re: 3.5-rc3: vdd_mpu_iva warnings

2012-07-02 Thread Kevin Hilman
"Joe Woodward" writes: > I have a GUMSTIX Overo AirSTORM module (AM3703-based). > > When booting the kernel the following features are listed: > OMAP3630 ES1.2 (l2cache neon isp 192mhz_clk ) > > After booting I get the following (repeating every few seconds): > > [ 81.122558] voltdm_scale: No v

Re: 3.5-rc3: vdd_mpu_iva warnings

2012-07-02 Thread Kevin Hilman
"Joe Woodward" writes: > I have a GUMSTIX Overo AirSTORM module (AM3703-based). > > When booting the kernel the following features are listed: > OMAP3630 ES1.2 (l2cache neon isp 192mhz_clk ) > > After booting I get the following (repeating every few seconds): > > [ 81.122558] voltdm_scale: No v

Re: [PATCH] gpio/omap: fix invalid context restore of gpio bank-0

2012-07-02 Thread Kevin Hilman
ontext_loss_count() function pointer after the initial call to >pm_runtime_get() has occurred. This will ensure that the first >pm_runtime_put() initialised the loss count correctly. > > This patch addresses issues 2 and 3 above. > [1] http://marc.info/?l=linux-omap&m=1

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Kevin Hilman
Russ Dill writes: > On Mon, Jul 2, 2012 at 9:54 AM, Kevin Hilman wrote: >> Felipe, Keshava, >> >> Kevin Hilman writes: >> >>> Felipe Balbi writes: >>> >>> [...] >>> >>>> Keshava is reverting a fix for a HW errata.

Re: [PATCH RESEND] ARM: OMAP2+: Fix Wake-up power domain power status

2012-07-02 Thread Kevin Hilman
inux-omap master branch. > > Testing: > - Boot tested on OMAP4460 panda. > - Boot tested on OMAP3430 beagle and validated CORE RET still working (using > Paul's 32k timer patch [1]). > > [1] http://marc.info/?l=linux-omap&m=13453229888&w=2 > > Signed-off

Re: [GIT PULL] gpio/omap: cleanups for v3.5

2012-07-02 Thread Kevin Hilman
On 07/02/2012 10:37 AM, Kevin Hilman wrote: "DebBarma, Tarun Kanti" writes: On Mon, Jun 25, 2012 at 11:48 AM, NeilBrown wrote: On Thu, 21 Jun 2012 12:04:26 +0530 "DebBarma, Tarun Kanti" wrote: On Thu, Jun 21, 2012 at 8:46 AM, NeilBrown wrote: On Thu, 14 Jun

Re: [GIT PULL] gpio/omap: cleanups for v3.5

2012-07-02 Thread Kevin Hilman
4 Jun 2012 23:24:10 +0530 "DebBarma, Tarun Kanti" >>> > wrote: >>> > >>> >> On Thu, Jun 14, 2012 at 5:45 AM, NeilBrown wrote: >>> >> > On Fri, 11 May 2012 17:30:48 -0700 Kevin Hilman wrote: >>> >> > >>&g

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Kevin Hilman
Felipe, Keshava, Kevin Hilman writes: > Felipe Balbi writes: > > [...] > >> Keshava is reverting a fix for a HW errata. I can't accept it as it will >> cause regressions. Granted, regression by regression, there's no change, >> but I simply can't kn

Re: [PATCH 1/1] ARM: OMAP3: PM: don't explicitly enable the IO-chain interrupt

2012-06-29 Thread Kevin Hilman
Javier Martinez Canillas writes: > On Fri, Jun 29, 2012 at 2:55 PM, Kevin Hilman wrote: >> +Paul >> >> Javier Martinez Canillas writes: >> >>> commit 99b59df0 ARM: OMAP3: PM: fix shared PRCM interrupt leave disabled at >>> boot >>> >

[PATCH] ARM: OMAP2+: PM: fix IRQ_NOAUTOEN removal by mis-merge

2012-06-29 Thread Kevin Hilman
l Walmsley Signed-off-by: Kevin Hilman --- Tony, this applies on top of your current devel-pm branch. arch/arm/mach-omap2/prm2xxx_3xxx.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c ind

Re: [PATCH] I2C: OMAP: fix runtime PM get/put balance on error

2012-06-29 Thread Kevin Hilman
Shubhrajyoti writes: > On Friday 29 June 2012 05:32 PM, Kevin Hilman wrote: >> Shubhrajyoti D writes: >> >>> ensure pm_runtime_put() is called, on pm_runtime_get_sync() >>> failure. >>> >>> Without this, after a failed call, the run

Re: [PATCH 1/1] ARM: OMAP3: PM: don't explicitly enable the IO-chain interrupt

2012-06-29 Thread Kevin Hilman
+Paul Javier Martinez Canillas writes: > commit 99b59df0 ARM: OMAP3: PM: fix shared PRCM interrupt leave disabled at > boot > > set the IRQ_NOAUTOEN flag to the PCRM IO-chain irq to avoid this > interrupt until the PM core code is ready to handle the interrupts. > > It seems that this is not ne

Re: [PATCH] I2C: OMAP: fix runtime PM get/put balance on error

2012-06-29 Thread Kevin Hilman
ch. As this changes the error/failure path, please be specific about how the failure modes were tested, and on which platforms. > Cc: Kevin Hilman > Signed-off-by: Shubhrajyoti D > --- > drivers/i2c/busses/i2c-omap.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-06-28 Thread Kevin Hilman
Hi Shubhrajyoti, Shubhrajyoti Datta writes: > Hi Kevin, > Thanks for the patch , > a doubt below Thanks for the review. > On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman wrote: >> In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on >> failure. > So

Re: [PATCH 3/3] ARM: OMAP3: PM: cpuidle: optimize the clkdm idle latency in C1 state

2012-06-28 Thread Kevin Hilman
Jean Pihet writes: > Hi Rajendra, > > On Wed, Jun 20, 2012 at 10:57 AM, Rajendra Nayak wrote: >> Jean, >> >> >> On Wednesday 20 June 2012 02:22 PM, Rajendra Nayak wrote: >>> >>> Hi Jean, >>> >>> On Wednesday 20 June 2012 02:16 PM, Rajendra Nayak wrote: On Wednesday 20 June 2012 02:01 P

Re: Problems in the DaVinci EMAC driver & AM35xx?

2012-06-28 Thread Kevin Hilman
CF Adad writes: [...] > I bring these questions here, as the crash's call stack shares so many > similarities to the "SLAB crash" discussed > "http://thread.gmane.org/gmane.linux.ports.arm.omap/78039/";, that I > think they're related.  At the very least, the EMAC to EMAC > performance issues we

[PATCH] MAINTAINERS: add OMAP CPUfreq driver to OMAP Power Management section

2012-06-28 Thread Kevin Hilman
Add the OMAP CPUFreq driver to the list of files in the OMAP Power Management section. I've already been maintaining this driver, this just makes it official. Signed-off-by: Kevin Hilman --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 2/2] ARM: OMAP4: TWL6030: ensure sys_nirq1 is mux'd and wakeup enabled

2012-06-28 Thread Kevin Hilman
The SYS_NIRQ1 pin is the interupt line for the PMIC part of the TWL6030 and interrupts from the PMIC are needed as wakeup sources. Ensure this pin is mux'd as input and has wakeup enabled so PMIC interupts (e.g. RTC) can be used as wakeup sources. Tested on OMAP4430/Panda. Signed-off-by:

[PATCH 0/2] ARM: OMAP: few more PM fixes for v3.5-rc

2012-06-28 Thread Kevin Hilman
Tony, here are hopefully the last couple PM-related fixes for v3.5-rc. Both of these fix suspend/resume/wakeup problems on OMAP3 or OMAP4. Thanks, Kevin Kevin Hilman (2): ARM: OMAP2: Overo: init I2C before MMC to fix MMC suspend/resume failure ARM: OMAP4: TWL6030: ensure sys_nirq1 is

[PATCH 1/2] ARM: OMAP2: Overo: init I2C before MMC to fix MMC suspend/resume failure

2012-06-28 Thread Kevin Hilman
on 3730/OveroSTORM platform. Signed-off-by: Kevin Hilman --- arch/arm/mach-omap2/board-overo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index 8fa2fc3..779734d 100644 --- a/arch/arm/mach-omap2

[PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module

2012-06-28 Thread Kevin Hilman
tion `sr_class3_init': /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class' Reported-by: Tony Lindgren Signed-off-by: Jean Pihet Signed-off-by: Kevin Hilman --- Tony, this one fixes the SR related build errors you saw with

[PATCH] ARM: OMAP2+: fix CONFIG_CPU_IDLE dependency on CONFIG_PM

2012-06-28 Thread Kevin Hilman
FIG_PM_RUNTIME (which in turn will enable CONFIG_PM.) Reported-by: Tony Lindgren Cc: Daniel Lezcano Signed-off-by: Kevin Hilman --- Tony, this fixes the randconfig problems you mentioned. It applies on top of your testing-board branch, where the commit that introduced this problem is applie

Re: Bringing back gptimer_wakeup

2012-06-28 Thread Kevin Hilman
Kevin Hilman writes: > Tasslehoff Kjappfot writes: > >> The support for using a timer to wake from suspend was removed in: >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=98e182a26bbbf5575457622337684ef61493e864 >> >> I found

Re: v3.5-rc4 doesn't wake from dynamic idle on 3530ES3 Beagle

2012-06-27 Thread Kevin Hilman
Paul Walmsley writes: > Looks like something broke between v3.5-rc3 and v3.5-rc4 with dynamic > idle on 3530ES3 Beagle. 37xx EVM doesn't seem to be affected. > > Taking a closer look now. I don't currently have access to a 3530 Beagle so I couldn't test there, but just confirmed that vanilla v

Re: Panda ES board hang when using GPIO as interrupt

2012-06-26 Thread Kevin Hilman
Hello, "Franky Lin" writes: > Hi Kevin, Tarun, > > We are using the expansion connector A on Panda board to mount a SDIO > WiFi dongle on MMC2 with a level triggered interrupt signal connected > to GPIO 138. It's been working fine until 3.5 rc1. The board hang > randomly within 5 mins during a n

Re: DM3730 without PMIC oops on idle

2012-06-26 Thread Kevin Hilman
jean-philippe francois writes: > Hi, > > My board does not have any Power Management IC. > Without the following patch, the bood ends with an oops. > How can I further debug this, ie trace through the assembly > in arch/arm/mach-omap2/sleep34xx.S ? The assembly code that is faulting has nothing

Re: [PATCH] gpio/omap: fix irq loss while in idle with debounce on

2012-06-26 Thread Kevin Hilman
are disabling debounce clocks (for PM or other reasons), > be sure the module's debounce feature is disabled too. > > Cc: Kevin Hilman > Signed-off-by: Grazvydas Ignotas This looks right, thanks for the patch. I will queue it up for v3.6 and get it some broader testing before se

[PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-06-26 Thread Kevin Hilman
the enclosing power domain active, and prevents full-chip retention/off from happening during idle. Cc: Shubhrajyoti D Signed-off-by: Kevin Hilman --- This patch applies to current i2c-embedded/for-next branch drivers/i2c/busses/i2c-omap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 07/11] I2C: OMAP: Handle error check for pm runtime

2012-06-26 Thread Kevin Hilman
Shubhrajyoti D writes: > If PM runtime get_sync fails return with the error > so that no further reads/writes goes through the interface. > This will avoid possible abort. Add a error message in case > of failure with the cause of the failure. > > Reviewed-by: Kevin Hilma

[GIT PULL] OMAP: TWL IRQ dead code removal

2012-06-26 Thread Kevin Hilman
700) ---- Kevin Hilman (2): ARM: OMAP2+: TWL: remove usage of pdata->irq_base/_end mfd: twl: remove pdata->irq_base/_end, no more users arch/arm/mach-omap2/board-2430sdp.c|3 --- arch/arm/mach-omap2/board-omap3logic.c |3 --- arch/arm/mach-

[GIT PULL] OMAP PM: misc. cleanup for v3.6

2012-06-26 Thread Kevin Hilman
Tony, Please pull the following misc. PM cleanups for v3.6. Kevin The following changes since commit f8f5701bdaf9134b1f90e5044a82c66324d2073f: Linux 3.5-rc1 (2012-06-02 18:29:26 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap

[GIT PULL] OMAP3 PM: preformance enhancements

2012-06-26 Thread Kevin Hilman
ARM: OMAP3: PM: cpuidle: optimize the PER latency in C1 state ARM: OMAP3: PM: cpuidle: optimize the clkdm idle latency in C1 state Kevin Hilman (3): ARM: OMAP2+: powerdomain: allow pre/post transtion to be per pwrdm ARM: OMAP3: PM: call pre/post transition per powerdomain

[GIT PULL] OMAP PM: move SmartReflex driver to drivers/avs

2012-06-26 Thread Kevin Hilman
Tony, Please pull this series that move the SmartReflex driver out to drivers/avs. The series includes some minimal cleanups necessary to cleanly do the move. The drivers/* change has been Acked by Rafael and we agreed to merge it through the OMAP tree because of all the arch/arm/mach-omap2 chan

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-25 Thread Kevin Hilman
Felipe Balbi writes: [...] > Keshava is reverting a fix for a HW errata. I can't accept it as it will > cause regressions. Granted, regression by regression, there's no change, > but I simply can't knowingly cause a regression to the driver just to > have PM working. We need a real fix for this

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Kevin Hilman
"Munegowda, Keshava" writes: > On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman wrote: >> "Munegowda, Keshava" writes: >> >> [...] >> >>>>> >>>>> hi kevin >>>>> >>>>> here is pm count log

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Kevin Hilman
Felipe Balbi writes: > Hi, > > On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote: >> On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman wrote: >> > "Munegowda, Keshava" writes: >> > >> >> On Thu, Jun 21, 2012 at 7:12

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Kevin Hilman
"Munegowda, Keshava" writes: [...] >>> >>> hi kevin >>> >>> here is pm count log on beagle XM with the above patch: >> >> What are you meaning to show by this log? >> >> This dump shows that neither PER or CORE are hitting retention in idle. >> Which sounds to me like you have not enabled UART r

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-21 Thread Kevin Hilman
"Munegowda, Keshava" writes: > On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda > wrote: >> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled >> "Fix OMAP EHCI suspend/resume failure (i693)" is causing >> the usb hub and device detection fails in beagle XM >> causeing NFS not functio

Re: MFD USB host: prevents CORE retention in idle

2012-06-21 Thread Kevin Hilman
Grazvydas Ignotas writes: > On Thu, Jun 21, 2012 at 10:12 AM, Munegowda, Keshava > wrote: >> I did the clone of this , But I am not seeing the branch 'tmp/test/usb-host' >> I am seeing only the branch /wip/arm-nohz-cpusets other than master. >> I didn't any usb-host branch here too: >> http://gi

Re: MFD USB host: prevents CORE retention in idle

2012-06-20 Thread Kevin Hilman
"Munegowda, Keshava" writes: > On Wed, Jun 20, 2012 at 11:53 AM, Munegowda, Keshava > wrote: >> On Tue, Jun 19, 2012 at 11:32 PM, Kevin Hilman wrote: >>> "Munegowda, Keshava" writes: >>> >>>> On Fri, Jun 15, 2012 at 7:17 PM, Jean

Re: MFD USB host: prevents CORE retention in idle

2012-06-19 Thread Kevin Hilman
"Munegowda, Keshava" writes: > On Fri, Jun 15, 2012 at 7:17 PM, Jean Pihet wrote: >> Hi Keshava, >> >> On Fri, Jun 15, 2012 at 2:04 PM, Munegowda, Keshava >> wrote: >>> On Tue, Jun 12, 2012 at 6:28 PM, Munegowda, Keshava >>> wrote: hi kevin     now I am using initramfs with kerne

Re: [PATCH/RFT 2/3] ARM: OMAP3: PM: call pre/post transition per powerdomain

2012-06-19 Thread Kevin Hilman
On 04/24/2012 07:23 AM, Kevin Hilman wrote: We only need to call the pre/post transtion methods when we know the power state is changing. First, split up the pre/post transition calls to be per-powerdomain, and then make them conditional on whether the power domain is actually changing states

Re: Bringing back gptimer_wakeup

2012-06-18 Thread Kevin Hilman
Tasslehoff Kjappfot writes: > The support for using a timer to wake from suspend was removed in: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=98e182a26bbbf5575457622337684ef61493e864 > > I found an alternative patch > (http://www.mail-archive.com/linux-omap@vg

Re: [RFC PATCH 0/5] omap: add ocp2scp as a misc driver

2012-06-12 Thread Kevin Hilman
"ABRAHAM, KISHON VIJAY" writes: > Hi Kevin, Benoit, Paul, > > On Fri, Jun 1, 2012 at 2:16 AM, Arnd Bergmann wrote: >> On Thursday 31 May 2012, ABRAHAM, KISHON VIJAY wrote: >>> > I would mark the multiplexed device compatible with "simple-bus", which >>> > results in the child devices automatical

Re: MFD USB host: prevents CORE retention in idle

2012-06-05 Thread Kevin Hilman
Keshava, Felipe, ping. This problem is still preventing CORE retention in mainline. On 05/24/2012 03:13 PM, Kevin Hilman wrote: Kevin Hilman writes: "Munegowda, Keshava" writes: On Thu, May 24, 2012 at 5:55 AM, Kevin Hilman wrote: On 05/23/2012 05:01 PM, Kevin Hilman w

Re: [PATCH V2 4/4] ARM: OMAP3+: PM: VP: ensure VP is idle before disable

2012-06-04 Thread Kevin Hilman
"Menon, Nishanth" writes: > Regards, > Nishanth Menon > > > On Fri, Jun 1, 2012 at 4:03 PM, Kevin Hilman wrote: >> Nishanth Menon writes: >> >>> From: Wenbiao Wang >>> >>> Voltage Processor state machine transition to disabl

Re: [PATCH V2 3/4] ARM: OMAP3+: PM: VP: check to ensure VP is idle before forceupdate

2012-06-01 Thread Kevin Hilman
nt spam > if VP state machine is stuck. > > Cc: Tony Lindgren > Cc: Kevin Hilman > > Signed-off-by: Vinay Amancha > Signed-off-by: Nishanth Menon > --- > arch/arm/mach-omap2/vp.c |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/ma

Re: [PATCH V2 2/4] ARM: OMAP3+: PM: VP: move check of idle to separate function

2012-06-01 Thread Kevin Hilman
cument the information > about idle timeout. Based on the idea from Kevin Hilman. > > Cc: Tony Lindgren > Cc: Kevin Hilman > Cc: Eduardo Valentin > Signed-off-by: Nishanth Menon > --- > arch/arm/mach-omap2/vp.c | 55 > -- &

Re: [PATCH V2 4/4] ARM: OMAP3+: PM: VP: ensure VP is idle before disable

2012-06-01 Thread Kevin Hilman
s part of this change, increase timeout for VP idle check to > improbable 500uSec to be certain that system is indeed unable > to continue before crashing out with error(worst case expectancy > remains the same 3-100uSec depending on when we caught VP). > > Cc: Tony Lindgren >

Re: [PATCH 0/3] ARM: OMAP3: PM: optimize cpuidle C1 state latency

2012-06-01 Thread Kevin Hilman
Hi Jean, Jean Pihet writes: > The C1 state latency can be improved by optimizing the cpuidle low > level code. > > The first patch is a precaution fix for patch 2. > Patches 2 & 3 are optimization changes. > > Rebased on top of the for_3.6/pm/performance branch of > khilman's tree [1]. > > Teste

Re: [PATCH 2/2] ARM: OMAP3: PM: cpuidle: optimize the clkdm idle latency in C1 state

2012-06-01 Thread Kevin Hilman
Jean Pihet writes: > Hi Kevin, > > On Thu, May 31, 2012 at 6:29 PM, Kevin Hilman wrote: >> jean.pi...@newoldbits.com writes: >> >>> From: Jean Pihet >>> >>> It is not needed to iterate through all the clock domains of a >>> power domain

Re: [linux-pm] [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-06-01 Thread Kevin Hilman
Tony Lindgren writes: > * Tony Lindgren [120601 04:43]: >> * Eduardo Valentin [120525 01:31]: >> > +int omap4_usb_phy_power(struct device *dev, int on) >> > +{ >> > + u32 val; >> > + int ret; >> > + >> > + if (on) { >> > + ret = omap_control_readl(dev, CONTROL_DEV_CONF, &val); >> >

Re: [PATCH] ARM: OMAP2+: OPP: Fix to ensure check of right oppdef after bad one

2012-06-01 Thread Kevin Hilman
Igor Grinberg writes: > Hi Kevin, Nishanth, > > On 06/01/12 02:15, Kevin Hilman wrote: >> Nishanth Menon writes: >> >>> Commit 9fa2df6b90786301b175e264f5fa9846aba81a65 >>> (ARM: OMAP2+: OPP: allow OPP enumeration to continue if device is not >>>

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-05-31 Thread Kevin Hilman
Jon Hunter writes: > Hi Kevin, > > On 05/31/2012 05:36 PM, Kevin Hilman wrote: >> Jon Hunter writes: >> >>> Hi Kevin, >>> >>> On 05/31/2012 03:42 PM, Kevin Hilman wrote: >>>> Jon Hunter writes: >>>> >>>>>

Re: [linux-pm] [RFC PATCH 00/11] OMAP System Control Module

2012-05-31 Thread Kevin Hilman
Hi Eduardo, Eduardo Valentin writes: > Hello Paul and Tony, > > This is a series of patches adding a basic support for system control module, > on OMAP4+ context. It is a working in progress, but I wanted to share already > to get your feedback. This is a great start, thanks for working on this

Re: [PATCH 1/3] ARM: OMAP3+: PM: VP: ensure VP is idle before disable

2012-05-31 Thread Kevin Hilman
On 05/31/2012 04:21 PM, Kevin Hilman wrote: diff --git a/arch/arm/mach-omap2/vp.h b/arch/arm/mach-omap2/vp.h > index 7c155d2..0abf895 100644 > --- a/arch/arm/mach-omap2/vp.h > +++ b/arch/arm/mach-omap2/vp.h > @@ -31,7 +31,7 @@ struct voltagedomain; >#define OMAP4_

Re: [PATCH 3/3] ARM: OMAP3+: PM: VP: check only the VPINIDLE status bit

2012-05-31 Thread Kevin Hilman
Nishanth Menon writes: > Currently we check against the entire 32 bits of the status register > Where, bits 1-31 are marked as reserved and mentioned in TRM as read > returns undefined values. ouch > Hence, check against purely the vpinidle status bit. > > Cc: Tony Lin

Re: [PATCH 2/3] ARM: OMAP3+: PM: VP: check to ensure VP is idle before forceupdate

2012-05-31 Thread Kevin Hilman
Nishanth Menon writes: > Ideally in the flow of DVFS programming, VP should be in idle state > (since we disabled it) before entering forceupdate. Ensure that > this is the case. Not doing this could cause VP statemachine > to enter invalid states. > > Cc: Tony Lindgren > C

Re: [PATCH 1/3] ARM: OMAP3+: PM: VP: ensure VP is idle before disable

2012-05-31 Thread Kevin Hilman
s part of this change, increase timeout for VP idle check to > improbable 500uSec to be certain that system is indeed unable > to continue before crashing out with error(worst case expectancy > remains the same 3-100uSec depending on when we caught VP). > > Cc: Tony Lindgren > Cc: K

Re: [PATCH] ARM: OMAP2+: OPP: Fix to ensure check of right oppdef after bad one

2012-05-31 Thread Kevin Hilman
elf > and allow continue to be used in code without much thought so that > we check the next set of OPP definition pointers :) > > Cc: Kevin Hilman > Cc: Steve Sakoman > Cc: Tony Lindgren > Cc: linux-omap@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > >

Re: [PATCHv10 00/11] I2C fixes

2012-05-31 Thread Kevin Hilman
Shubhrajyoti D writes: > The patch series does the following > > - Warn fixes if CONFIG_PM_RUNTIME is not selected. > - In case of i2c remove register access was done without any > get_sync fix the same. > - Folds a patch from Tasslehoff to prevent any merge conflicts. > - Prevents the XDUF flag

Re: [PATCH V3 00/10] PM: Create the AVS(Adaptive Voltage Scaling)

2012-05-31 Thread Kevin Hilman
Kevin Hilman writes: > "J, KEERTHY" writes: > >> On Tue, May 15, 2012 at 11:16 AM, J, KEERTHY wrote: >>> On Tue, May 8, 2012 at 5:21 AM, Kevin Hilman wrote: >>>> Rafael, >>>> >>>> Keerthy writes: >>>> >>

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-05-31 Thread Kevin Hilman
Jon Hunter writes: > Hi Kevin, > > On 05/31/2012 03:42 PM, Kevin Hilman wrote: >> Jon Hunter writes: >> >>> Hi Kevin, Will, >>> >>> On 05/30/2012 08:29 PM, Will Deacon wrote: >>>> Hi Kevin, >>>> >>>> On Wed,

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-05-31 Thread Kevin Hilman
Jon Hunter writes: > Hi Kevin, Will, > > On 05/30/2012 08:29 PM, Will Deacon wrote: >> Hi Kevin, >> >> On Wed, May 30, 2012 at 10:50:01PM +0100, Kevin Hilman wrote: >>> Basically, I don't like the result when we have to hack around missing >>> r

Re: [PATCH v2 2/2] arm: omap3: am35x: Disable hlt when using Davinci EMAC

2012-05-31 Thread Kevin Hilman
tem when the MPU > has executed a 'wfi' instruction (because of pm_idle > or CPUidle). To prevent this, add hooks to the EMAC > pm_runtime suspend/resume calls so that hlt is disabled > whenever the EMAC is in use. > > Signed-off-by: Mark A. Greer Looks good, Acked-

Re: [PATCH v2 0/2] arm: omap3: am35x: Convert emac to hwmod & disable hlt when open

2012-05-31 Thread Kevin Hilman
it was working fine on dm6446 to enable the emac clocks. Kevin >From 7a90e650ad8542b7f85076b58703e94bdc058562 Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Thu, 31 May 2012 09:59:53 -0700 Subject: [PATCH] ARM: davinci: add runtime PM support for clock management Add runtime PM core support to da

Re: [PATCH 2/2] ARM: OMAP3: PM: cpuidle: optimize the clkdm idle latency in C1 state

2012-05-31 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: > From: Jean Pihet > > It is not needed to iterate through all the clock domains of a > power domain in order to allow or deny it to idle. Why? (I know the answer, but would like it answered here.) > This patch allows or denies only the first registered clock

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-05-31 Thread Kevin Hilman
Jon Hunter writes: > Hi Kevin, > > On 05/30/2012 04:50 PM, Kevin Hilman wrote: > > [...] > >> I'm guessing you probably know my thoughts since you've already thought >> through how this should probably look. >> >> Basically, I don't like

[GIT PULL] OMAP: AM3xxx: cpu_is dead code removal

2012-05-30 Thread Kevin Hilman
scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/cleanup/am3xxx-cpu-is-leftovers for you to fetch changes up to 96f3994929c05a21d757a83613d2710b780ea2b4: ARM: OMAP: SoC detection: remove unused cpu_is macros (2012-05-25 15:48:48 -0700) -----

[GIT PULL] OMAP PM fixes for v3.5-rc

2012-05-30 Thread Kevin Hilman
7:19 -0700) -------- Kevin Hilman (1): ARM: OMAP3: PM: fix shared PRCM interrupts: leave disabled at boot Mark A. Greer (1): arm: omap3: am35x: Don't mark missing features as present NeilBrown (1): ARM: OMAP2+: INTC: fix suspend abort, set IRQCHIP_SKIP_SET_WAKE arch/arm/

Re: [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile

2012-05-30 Thread Kevin Hilman
Daniel Lezcano writes: > On 05/30/2012 08:07 PM, Kevin Hilman wrote: >> Daniel Lezcano writes: >> >>> On 05/14/2012 06:42 AM, Rajendra Nayak wrote: >>>> On Thursday 10 May 2012 03:32 PM, Daniel Lezcano wrote: >>>>> The current Makefile

Re: [PATCHv2 04/19] ARM: OMAP4: PM: save/restore all DPLL settings in OFF mode

2012-05-30 Thread Kevin Hilman
"Menon, Nishanth" writes: > On Wed, May 30, 2012 at 12:59 PM, Kevin Hilman wrote: >> "Menon, Nishanth" writes: >> >>> On Thu, May 17, 2012 at 3:52 AM, Shilimkar, Santosh >>> wrote: >>>> On Thu, May 17, 2012 at 12:34 PM, Shil

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-05-30 Thread Kevin Hilman
Jon Hunter writes: > Hi Kevin, > > On 05/29/2012 05:07 PM, Jon Hunter wrote: >> Hi Kevin, >> >> On 05/29/2012 04:17 PM, Kevin Hilman wrote: >>> Jon Hunter writes: >>> >>>> From: Jon Hunter >>>> >>>> This patch

Re: [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile

2012-05-30 Thread Kevin Hilman
Daniel Lezcano writes: > On 05/14/2012 06:42 AM, Rajendra Nayak wrote: >> On Thursday 10 May 2012 03:32 PM, Daniel Lezcano wrote: >>> The current Makefile compiles the cpuidle34xx.c and cpuidle44xx.c files >>> even if the cpuidle option is not set in the kernel. >>> >>> This patch fixes this by c

Re: [PATCHv2 04/19] ARM: OMAP4: PM: save/restore all DPLL settings in OFF mode

2012-05-30 Thread Kevin Hilman
"Menon, Nishanth" writes: > On Thu, May 17, 2012 at 3:52 AM, Shilimkar, Santosh > wrote: >> On Thu, May 17, 2012 at 12:34 PM, Shilimkar, Santosh >> wrote: >>> On Thu, May 17, 2012 at 4:12 AM, Kevin Hilman wrote: >>>> Tero Kristo wri

Re: [PATCH 1/3] ARM: OMAP4: VC: fix I2C timing

2012-05-29 Thread Kevin Hilman
Tero Kristo writes: > Current I2C timing parameters do not work with Panda board at least. > Parameters updated based on TI recommendation. > > Signed-off-by: Tero Kristo Let's fix this correctly by deriving/calculating them from the proper source clocks. Otherwise, this is going to work for P

Re: [PATCH 0/3] ARM: OMAP4: add support for TPS62361 PMIC

2012-05-29 Thread Kevin Hilman
Tero Kristo writes: > Hi, > > This set adds support for TPS62361 PMIC, which is used to power > MPU voltagedomain on OMAP4460 boards. These patches apply on top > of 3.4 + my voltagedomain fixes set to avoid adding redundant code. Hmm... do you have an updated version of your voltagedomain fixes

Re: [PATCH 2/2] ARM: omap: dmtimer: set non-posted mode if iclk less than 4*fck

2012-05-29 Thread Kevin Hilman
Tarun Kanti DebBarma writes: > Timers in PER domain periodically report old time from TCRR in > posted mode if ick < 4*fck. Therefore, set timer to non-posted > whenever ick < 4*fck for all timers. Is there an erratum assocaited with this? Does this problem affect every SoC? Kevin -- To unsubs

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-05-29 Thread Kevin Hilman
> Cc: Ming Lei > Cc: Will Deacon > Cc: Benoit Cousson > Cc: Paul Walmsley > Cc: Kevin Hilman > > Signed-off-by: Jon Hunter > --- > arch/arm/mach-omap2/devices.c | 50 ++-- > 1 files changed, 27 insertions(+), 23 deletions(-

Re: [PATCHv2 17/19] ARM: OMAP4: put cpu1 back to sleep if no wake request

2012-05-29 Thread Kevin Hilman
"Shilimkar, Santosh" writes: > Tero, > > On Mon, May 21, 2012 at 3:51 PM, Tero Kristo wrote: >> On Wed, 2012-05-16 at 17:31 -0700, Kevin Hilman wrote: >>> Tero Kristo writes: >>> >>> > If AUX_CORE_BOOT0 does not indicate wakeup reques

Re: [PATCHv2 14/19] ARM: OMAP4: wakeupgen: enable clocks for save_secure_all

2012-05-29 Thread Kevin Hilman
Tero Kristo writes: > On Wed, 2012-05-16 at 17:06 -0700, Kevin Hilman wrote: >> +Benoit >> >> Tero Kristo writes: >> >> > save_secure_all needs l3_main_3_ick and l4_secure_clkdm enabled, >> > otherwise the secure ROM code will crash. >>

Re: [PATCHv2 10/19] ARM: OMAP4: PM: Work-around for ROM code BUG of IVAHD/TESLA

2012-05-29 Thread Kevin Hilman
Tero Kristo writes: > On Wed, 2012-05-16 at 16:07 -0700, Kevin Hilman wrote: >> On 05/16/2012 04:05 PM, Kevin Hilman wrote: >> > Tero Kristo writes: >> > >> >> From: Santosh Shilimkar >> >> >> >> The ROM BUG is when MPU Doma

Re: [PATCHv2 03/19] ARM: OMAP4: PM: Add device-off support

2012-05-29 Thread Kevin Hilman
Jean Pihet writes: > Hi Tero, Kevin, Santosh, > > On Mon, May 21, 2012 at 10:48 AM, Tero Kristo wrote: >> On Wed, 2012-05-16 at 15:36 -0700, Kevin Hilman wrote: >>> +Jean for functional power states >>> >>> Tero Kristo writes: >>> >>&g

Re: [PATCHv2 03/19] ARM: OMAP4: PM: Add device-off support

2012-05-29 Thread Kevin Hilman
Tero Kristo writes: > On Wed, 2012-05-16 at 15:36 -0700, Kevin Hilman wrote: >> +Jean for functional power states >> >> Tero Kristo writes: >> >> > This patch adds device off support to OMAP4 device type. >> >> Description is rather thin for

Re: [PATCH v2 0/4] OMAP4: CPUidle: Add coupled idle support

2012-05-25 Thread Kevin Hilman
Hi Santosh, Santosh Shilimkar writes: > Kevin, > > Now Colin's v3 [1] is apearing in Len Brown's next branch, I have rebased > OMAP4 support against it. I need to pick up couple of fixes [2] posted on > top of v3 [1] version and arm-soc 'omap/cpuidle-cleanup' branch lined up > for 3.5. Great.

Re: [PATCHv9 00/10] I2C fixes

2012-05-25 Thread Kevin Hilman
to transfer all messages etc. So don't disable interrupts for I2C. Acked-by: Kevin Hilman Tested-by: Kevin Hilman Signed-off-by: NeilBrown --- drivers/i2c/busses/i2c-omap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/b

[PATCH] MAINTAINERS: add OMAP CPUfreq driver to OMAP Power Management section

2012-05-25 Thread Kevin Hilman
Add the OMAP CPUFreq driver to the list of files in the OMAP Power Management section. I've already been maintaining this driver, this just makes it official. Signed-off-by: Kevin Hilman --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCHv9 00/10] I2C fixes

2012-05-25 Thread Kevin Hilman
this version, otherwise feel free add Reviewed-by: Kevin Hilman That being said, before this is merged, I woudl like to see some more non-author Tested-bys. We've been having lots of regressions of late from OMAP drivers that are not being sufficiently tested before merging. We need to ensure

Re: [PATCHv9 09/10] I2C: OMAP: Do not set the XUDF(Transmit underflow) if the underflow is not reached

2012-05-25 Thread Kevin Hilman
Shubhrajyoti D writes: > Currently in the 1.153 errata handling while waiting for transmitter > underflow if NACK is got the XUDF(Transmit underflow) flag is also set. -EOVERFLOW This sentence needs a rewrite and some punctuation. It does not read well. > The flag is set after wait for the co

Re: [PATCHv9 07/10] I2C: OMAP: Handle error check for pm runtime

2012-05-25 Thread Kevin Hilman
Shubhrajyoti D writes: > If PM runtime get_sync fails return with the error > so that no further reads/writes goes through the interface. > This will avoid possible abort. Add a error message in case > of failure with the cause of the failure. > > Signed-off-by: Shubhrajyoti D > --- > drivers/i

Re: [PATCHv9 02/10] I2C: OMAP: Fix the mismatch of pm_runtime enable and disable

2012-05-25 Thread Kevin Hilman
ht. Can you be more specific in the changelog about when the errors/warning happens? e.g. why pm_runtime_enable() is called again? Is this on module unload/reload? Other than that Acked-by: Kevin Hilman > Cc: Kevin Hilman > Cc: Rajendra Nayak > Signed-off-by: Shubhrajyoti D > -

Re: [PATCHv9 06/10] I2C: OMAP: Fix the crash in i2c remove

2012-05-25 Thread Kevin Hilman
Hi Wolfram, Wolfram Sang writes: > On Wed, May 02, 2012 at 08:02:11PM +0530, Shubhrajyoti D wrote: >> In omap_i2c_remove we are accessing the I2C_CON register without >> enabling the clocks. Fix the same by enabling the clocks and disabling >> it. [...] > I'd really like a comment

<    3   4   5   6   7   8   9   10   11   12   >