Re: [PATCH 1/3] ASoC: OMAP: HDMI: Update machine driver name

2012-11-14 Thread Liam Girdwood
On 14/11/12 02:30, Ricardo Neri wrote: Being the name of a machine driver, it aims to describe the connection between the HDMI IP of the processor and the companion chip it uses to connect to the outside world. This name tries to follow the same naming convention as in the OMAP-ABE-TWL6040 machin

[RFC 1/3] ASoC: dmaengine: Don't use runtime private data for dmaengine data

2012-09-03 Thread Liam Girdwood
Use a dedicated member to store dmaengine data so that drivers can use private data for their own purposes. Signed-off-by: Liam Girdwood Signed-off-by: Russell King --- include/sound/pcm.h |2 ++ sound/soc/soc-dmaengine-pcm.c |2 +- 2 files changed, 3 insertions(+), 1

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Liam Girdwood
On Fri, 2012-04-27 at 19:45 +0530, Shilimkar, Santosh wrote: > + Peter and Liam to comment > > On Fri, Apr 27, 2012 at 7:28 PM, Russell King - ARM Linux > wrote: > > Can someone please hint on what audio is supported on these two OMAP > > boards? From what I can tell, the answer is either "nothi

Re: [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.

2012-04-25 Thread Liam Girdwood
On Tue, 2012-04-24 at 19:02 -0700, Oleg Matcovschi wrote: > Change-Id: I4ba9de0de4681332539246ccc5e11a7a8fb32e79 > Signed-off-by: Oleg Matcovschi > --- > v1: > initial revision > v2: > resending patch including maintainers > > sound/soc/omap/omap-pcm.c |4 > 1 files changed, 4 inserti

Re: [PATCH v3 0/3] MFD: twl6040: Conversion to i2c driver

2012-02-21 Thread Liam Girdwood
On Tue, 2012-02-21 at 12:05 +0100, Samuel Ortiz wrote: > Hi Peter, > > On Tue, Feb 21, 2012 at 12:33:07PM +0200, Peter Ujfalusi wrote: > > > I'm not sure hwo we could handle that properly. Either by letting Tony > > > carrying this patchset, or by sending me the panda patch that adds those > > > s

Re: [RFC 04/11] ASoC: core - Add API call to register dai kcontrols.

2012-02-15 Thread Liam Girdwood
On Wed, 2012-02-15 at 17:37 +0200, Peter Ujfalusi wrote: > Allow dai drivers to register kcontrols. > > Signed-off-by: Peter Ujfalusi > --- > include/sound/soc.h |2 ++ > sound/soc/soc-core.c | 31 +++ > 2 files changed, 33 insertions(+), 0 deletions(-) This f

Re: [PATCH v2 4/4] ASoC: OMAP: ams-delta: drop .set_bias_level callback

2012-01-09 Thread Liam Girdwood
On Fri, 2011-12-30 at 04:04 +0100, Janusz Krzysztofik wrote: > This functionality has just been implemented in the cx20442 codec > driver, no need to keep it here duplicated. > > Once done, remove the no longer used AMS_DELTA_LATCH2_MODEM_NRESET > symbol from the board header file and a call to th

Re: [PATCH v2 1/9] include: platform_data: Platform data header for OMAP4 ASoC audio

2011-12-22 Thread Liam Girdwood
On Thu, 2011-12-22 at 13:04 +, Mark Brown wrote: > On Thu, Dec 22, 2011 at 02:42:40PM +0200, Peter Ujfalusi wrote: > > > include/linux/platform_data/omap-abe-twl6040.h | 48 > > > > omap-abe-mcpdm-twl6040 please. Seriously, just drop the abe - it's not > an option

Re: [PATCH 07/10] ASoC: OMAP: ams-delta: Drive modem/codec pins over GPIO API

2011-12-21 Thread Liam Girdwood
On Sun, 2011-12-11 at 21:12 +0100, Janusz Krzysztofik wrote: > Don't use Amstrad Delta custom I/O functions any longer, replace them > with GPIO. Old pin definitions, no longer used by the modem bits either, > can be dropped. > > Depends on patch 2/10 "ARM: OMAP1: Convert Amstrad E3 latches to > b

Re: [PATCH 00/10] OMAP4: ASoC: Support for PandaBoard family

2011-12-21 Thread Liam Girdwood
On Wed, 2011-12-14 at 11:46 +0200, Peter Ujfalusi wrote: > Hello, > > the following series will add ASoC support for PandaBoards. > PandaBoards have different audio routings compared to SDP4430/Blaze boards, > but > the differences not that big to justify a new ASoC machine driver. > > Main chan

Re: [alsa-devel] [PATCH 0/3] ASoC: tpa6130a2: model handling cleanup

2011-09-13 Thread Liam Girdwood
On Tue, 2011-09-13 at 13:27 +0100, Mark Brown wrote: > On Tue, Sep 13, 2011 at 03:11:41PM +0300, Péter Ujfalusi wrote: > > > Would you have time to take a look at this series (it got the Tested-by > > from > > Jarkko)? > > I'm fine with it, I'm wa

Re: [PATCHv4 2/4] regulator: omap smps regulator driver

2011-08-23 Thread Liam Girdwood
On 22/08/11 23:39, Hilman, Kevin wrote: > Liam Girdwood writes: > >> On 05/08/11 20:33, Hilman, Kevin wrote: >>> Mark Brown writes: >>> >>>> On Thu, Jul 28, 2011 at 02:48:57PM +0300, Tero Kristo wrote: >>>>> OMAP SMPS regulator driver p

Re: [alsa-devel] [PATCH 0/4] ASoC: OMAP4: McPDM: Fix legacy support

2011-08-22 Thread Liam Girdwood
On 22/08/11 08:13, Ujfalusi, Peter wrote: > On Friday 19 August 2011 15:04:20 Tony Lindgren wrote: >> It seems OK to me. > > Thanks! > >> But for the -rc cycle it has potential for >> "fixes for features that never worked" flame bait. If you guys >> are OK to deal with that then go ahead. > > Hr

Re: [PATCHv4 2/4] regulator: omap smps regulator driver

2011-08-08 Thread Liam Girdwood
On 05/08/11 20:33, Hilman, Kevin wrote: > Mark Brown writes: > >> On Thu, Jul 28, 2011 at 02:48:57PM +0300, Tero Kristo wrote: >>> OMAP SMPS regulator driver provides access to OMAP voltage processor >>> controlled regulators. These include VDD_MPU and VDD_CORE for OMAP3 and >>> additionally VDD_

Re: [RFC 1/4] twl-regulator: extend for SMPS regulators and external controllers

2011-07-08 Thread Liam Girdwood
On Fri, 2011-07-08 at 17:56 +0200, Kristo, Tero wrote: > This commit adds two things to the TWL regulator driver code : > > * It extends the twl4030_set_voltage() and twl4030_get_voltage() >functions to understand that VDD1 and VDD2 are different regulators >from all the other regulators:

Re: [PATCH 1/3] ASoC: omap-mcpdm: Replace legacy driver

2011-07-07 Thread Liam Girdwood
On 07/07/11 17:53, Mark Brown wrote: > On Thu, Jul 07, 2011 at 05:32:42PM +0100, Liam Girdwood wrote: >> On 07/07/11 16:57, Mark Brown wrote: >>> On Thu, Jul 07, 2011 at 03:27:50PM +0300, Peter Ujfalusi wrote: > >>>> The current McPDM driver design is not suitable

Re: [PATCH 1/3] ASoC: omap-mcpdm: Replace legacy driver

2011-07-07 Thread Liam Girdwood
On 07/07/11 16:57, Mark Brown wrote: > On Thu, Jul 07, 2011 at 03:27:50PM +0300, Peter Ujfalusi wrote: > >> The current McPDM driver design is not suitable to support both >> the ABE and Legacy DMA operating modes. Therefore remove most > > In what way is it not suitable? It cant support both th

Re: [PATCH v4 2/2] USB: TWL6025 allow different regulator name

2011-05-23 Thread Liam Girdwood
On 23/05/11 12:13, Balbi, Felipe wrote: > Hi, > > On Mon, May 23, 2011 at 10:58:27AM +0100, Liam Girdwood wrote: >> On 22/05/11 23:51, Mark Brown wrote: >>> On Sun, May 22, 2011 at 09:21:24PM +0100, Graeme Gregory wrote: >>>> The twl6025 uses a different regul

Re: [PATCH v4 2/2] USB: TWL6025 allow different regulator name

2011-05-23 Thread Liam Girdwood
On 22/05/11 23:51, Mark Brown wrote: > On Sun, May 22, 2011 at 09:21:24PM +0100, Graeme Gregory wrote: >> The twl6025 uses a different regulator for USB than the 6030 so select >> the correct regulator name depending on the subclass of device. > > Acked-by: Mark Brown Ac

Re: [PATCH v4 1/2] REGULATOR: TWL6025: add support to twl-regulator

2011-05-23 Thread Liam Girdwood
On 22/05/11 23:48, Mark Brown wrote: > On Sun, May 22, 2011 at 09:21:23PM +0100, Graeme Gregory wrote: >> Adding support for the twl6025. Major difference in the twl6025 is the >> group functionality has been removed from the chip so this affects how >> regulators are enabled and disabled. > > Ack

Re: [PATCH 1/2] regulator: twl6030: do not write to _GRP for regulator enable

2011-05-22 Thread Liam Girdwood
On Sun, 2011-05-22 at 14:50 +0800, Mark Brown wrote: > On Fri, May 20, 2011 at 07:03:51PM +0530, Balaji T K wrote: > > TWL6030: regulator is enabled via VREG_STATE > > TWL4030: regulator is enabled via VREG_GRP > > Since there is nothing common, split twlreg_enable similar to other > > regulator_o

Re: [PATCH v2 3/4] REGULATOR: TWL6025: add support to twl-regulator

2011-05-18 Thread Liam Girdwood
On Wed, 2011-05-18 at 15:17 +0100, Graeme Gregory wrote: > On 16/05/2011 10:08, T Krishnamoorthy, Balaji wrote: > > On Thu, May 12, 2011 at 6:57 PM, Graeme Gregory > > wrote: > >> Adding support for the twl6025. Major difference in the twl6025 is the > >> group functionality has been removed from

Re: [PATCH] omap: Remove support for omap2evm (Re: Updated mach-types update)

2011-05-16 Thread Liam Girdwood
updated patch. > > Regards, > > Tony > > > From: Tony Lindgren > Date: Fri, 13 May 2011 04:41:32 -0700 > Subject: [PATCH] omap: Remove support for omap2evm > > The board support has never been merged for it as noticed > by Russell King . So let's remove t

Re: [PATCH] ASoC: omap-mcbsp: Remove restrictive checks for cpu type

2011-05-13 Thread Liam Girdwood
> > Signed-off-by: Sanjeev Premi > cc: Mark Brown > cc: Liam Girdwood > cc: Jarkko Nikula > --- > > Changes in v4: >Reposting after validating that patch still applies cleanly on >linux-omap master [46966f1] > >Changed the subject as suggested

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Liam Girdwood
On Mon, 2011-05-09 at 15:16 +0300, Felipe Balbi wrote: > Hi, > > On Mon, May 09, 2011 at 12:43:49PM +0100, Liam Girdwood wrote: > > On Mon, 2011-05-09 at 12:03 +0300, Felipe Balbi wrote: > > > Hi, > > > > > > On Sun, May 08, 2011 at 04:08:37PM +0100, Li

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Liam Girdwood
On Mon, 2011-05-09 at 12:03 +0300, Felipe Balbi wrote: > Hi, > > On Sun, May 08, 2011 at 04:08:37PM +0100, Liam Girdwood wrote: > > On Wed, 2011-04-27 at 13:45 +0300, Felipe Balbi wrote: > > > Hi, > > > > > > On Wed, Apr 27, 2011 at 10:39:51AM +0100,

Re: [PATCH 1/4] MFD: TWL6025: add phoenix lite support to twl6030

2011-05-08 Thread Liam Girdwood
On Wed, 2011-04-27 at 13:40 +0300, Felipe Balbi wrote: > On Wed, Apr 27, 2011 at 10:39:48AM +0100, Graeme Gregory wrote: > > + /* TWL6025 LDO regulators */ > > + struct regulator_init_data *ldo1; > > + struct regulator_init_data *ldo2; > > + struct regulator_ini

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-08 Thread Liam Girdwood
On Wed, 2011-04-27 at 13:45 +0300, Felipe Balbi wrote: > Hi, > > On Wed, Apr 27, 2011 at 10:39:51AM +0100, Graeme Gregory wrote: > > The twl6025 uses a different regulator for USB than the 6030 so select > > the correct regulator name depending on the subclass of device. > > > > Signed-off-by: Gr

Re: [PATCH 0/5] regulator: twl: make 6030 regulators useable

2011-04-05 Thread Liam Girdwood
On Fri, 2011-04-01 at 10:22 +0530, Nishanth Menon wrote: > TWL6030 regulator dynamic operations such as those on vaux2 and vaux3 > were reported to be broken on platforms such as pandaboard(OMAP4). > Digging deeper into the code, found that 6030 regulator support > requires quiet a bit of fixes to

Re: [PATCH] ASoC: AM3517: Update codec name after multi-component update

2011-03-09 Thread Liam Girdwood
On Tue, 2011-03-08 at 21:02 +0530, Abhilash K V wrote: > The i2c client device name (".2-001a" in this case, including > the separator period) for the AIC23 codec on the TI AM3517-EVM > was appended to the codec_name member of am3517evm_dai to > resolve the names mismatch happening in soc_bind_dai_

Re: [alsa-devel] [PATCH v2 00/13] OMAP: McBSP: hwmod adaptation and runtime conversion

2011-02-01 Thread Liam Girdwood
On Tue, 2011-02-01 at 19:53 +0200, Jarkko Nikula wrote: > On Mon, 31 Jan 2011 20:20:24 +0530 > Kishon Vijay Abraham I wrote: > > > Modify OMAP McBSP driver to use omap hwmod framework and pm runtime APIs. > > > > Created on top of linux OMAP master (linux-omap-2.6 :master) > > Did digital loopb

Re: [alsa-devel] [PATCH v2 2/4] ASoC: DMIC codec: Adding a generic DMIC codec

2011-01-11 Thread Liam Girdwood
On Thu, 2011-01-06 at 08:00 -0600, David Lambert wrote: > This codec is to be used by the DMIC driver to > control the DMIC codec. This driver will be used on future > implementations of the DMIC driver to support codec specific > features. > > At this time, the codec driver just registers the co

Re: [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver

2010-12-29 Thread Liam Girdwood
On Wed, 2010-12-29 at 14:04 +0200, Felipe Balbi wrote: > Hi, > > On Wed, Dec 29, 2010 at 11:52:51AM +0000, Liam Girdwood wrote: > >I agree that drivers should be arch independent when possible, but in > >this case the OMAP DMIC DAI driver is coupled to the OMAP platform only

Re: [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver

2010-12-29 Thread Liam Girdwood
On Wed, 2010-12-29 at 12:44 +0200, Felipe Balbi wrote: > Hi, > > On Wed, Dec 29, 2010 at 10:35:31AM +0000, Liam Girdwood wrote: > >> Even though the driver will never work with those other archs, compile > >> testing with several of them isn't bad at all. > >

Re: [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver

2010-12-29 Thread Liam Girdwood
On Wed, 2010-12-29 at 11:47 +0200, Felipe Balbi wrote: > Hi, > > On Tue, Dec 28, 2010 at 07:13:58PM -0600, Lambert, David wrote: > >> one blank line only. BTW, are these used anywwhere outside the dmic.c > >> driver ? If not, it's better to move the definitions there. > >> > > > >They were origina

Re: [PATCH 2/2] ASoC: Fix resource reclaim for osk5912

2010-11-24 Thread Liam Girdwood
On Wed, 2010-11-24 at 14:07 +0530, Varadarajan, Charulatha wrote: > On Wed, Nov 24, 2010 at 12:53, Axel Lin wrote: > > Add Patch description. > > > Signed-off-by: Axel Lin > > --- Please resubmit with a patch description and Jarkko's Ack. Thanks Liam -- Freelance Developer, SlimLogic Ltd A

Re: [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init

2010-11-24 Thread Liam Girdwood
t;Failed to get DAC regulator from %s: %ld\n", > dev_name(&omap3pandora_snd_device->dev), > PTR_ERR(omap3pandora_dac_reg)); > + ret = PTR_ERR(omap3pandora_dac_reg); > goto fail3; > } > Acked-by: Liam G

Re: [alsa-devel] [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem

2010-11-23 Thread Liam Girdwood
On Tue, 2010-11-23 at 09:26 +0200, Jarkko Nikula wrote: > On Mon, 22 Nov 2010 17:48:24 -0700 (MST) > Paul Walmsley wrote: > > > > Signed-off-by: Janusz Krzysztofik > > > > Thanks for fixing this. What do you think about the following patch > > instead? It should avoid any compiler issues. >

Re: [alsa-devel] [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem

2010-11-03 Thread Liam Girdwood
On Wed, 2010-11-03 at 10:20 +0200, Jarkko Nikula wrote: > On Tue, 2 Nov 2010 10:58:59 -0600 (MDT) > Paul Walmsley wrote: > > > On Tue, 2 Nov 2010, Janusz Krzysztofik wrote: > > > > > In the new code introduced with commit > > > cf4c87abe238ec17cd0255b4e21abd949d7f811e, > > > "OMAP: McBSP: imple

Re: [PATCH] regulator: fix build when CONFIG_REGULATOR_DUMMY=n

2010-10-11 Thread Liam Girdwood
> make[1]: *** [drivers/regulator] Error 2 > make: *** [drivers] Error 2 > > Signed-off-by: Anand Gadiyar > Cc: Liam Girdwood > Cc: Mark Brown > --- > The commit referenced above is in linux next as of 20101011 > and breaks builds of the omap2plus_defconfig at leas

Re: [PATCH 00/10] OMAP: SCM/McBSP/clock: branch integration patches for 2.6.37

2010-10-06 Thread Liam Girdwood
me to rebuild those parts of omap-for-linus > > > to add the acks. > > > > If you decide to rebuild, than you can add my (for patch 6-7): > > Acked-by: Peter Ujfalusi > > OK, let's do that then we should still have some time left before the > merge window.

Re: [alsa-devel] [PATCH] omap: devices: Avoid merge conflict between ASoC and OMAP hwmod changes

2010-10-04 Thread Liam Girdwood
On Mon, 2010-10-04 at 08:04 -0700, Mark Brown wrote: > On Mon, Oct 04, 2010 at 03:04:53PM +0300, Jarkko Nikula wrote: > > Upcoming ASoC multi-component and OMAP hwmod changes will conflict > > in arch/arm/mach-omap2/devices.c. Avoid this by moving a little bit > > include statement introduced by AS

RE: [PATCH 2/2] omap: zoom: Move new code introduced by ASoC m-c to board-zoom-peripherals

2010-09-24 Thread Liam Girdwood
On Fri, 2010-09-24 at 11:31 -0500, Lopez Cruz, Misael wrote: > Hi Jarkko, > > > ASoC Multi-Component Support moves some code from sound/soc/omap/zoom2.c > > into > > arch/arm/mach-omap2/board-zoom2.c. However, that code should go to > > board-zoom-peripherals.c instead as there is common code and

Re: [PATCH] OMAP: McBSP: Fix static function warning

2010-09-08 Thread Liam Girdwood
Signed-off-by: G, Manjunath Kondaiah > Cc: alsa-de...@alsa-project.org > Cc: Jarkko Nikula > Cc: Peter Ujfalusi > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Tony Lindgren > Cc: Nishanth Menon > > --- > sound/soc/omap/omap-mcbsp.c |2 +- > 1 files changed, 1 i

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-06 Thread Liam Girdwood
On Mon, 2010-09-06 at 22:59 +0300, Eduardo Valentin wrote: > Hello, > > On Fri, Sep 03, 2010 at 08:20:52PM +0200, Mark Brown wrote: > > On Fri, Sep 03, 2010 at 11:00:31AM -0700, Kevin Hilman wrote: > > > Mark Brown writes: > > > > > > The only thing I can think you might need to do if this is ju

Re: [alsa-devel] [PATCH v5 0/5] OMAP/ASoC: McBSP: FIFO handling related fixes

2010-06-03 Thread Liam Girdwood
On Thu, 2010-06-03 at 07:39 +0300, Peter Ujfalusi wrote: > Hello, > > Tony: Could you take a look at the arch/arm patches in this series? > Thanks! > > Changes since v3/4: > - Fixed commit subjects and messages for OMAP3 related patches > - Added Acked-by from Mark, and Jarkko > > Intro message

Re: [alsa-devel] [PATCH v3 0/5] OMAP/ASoC: McBSP: FIFO handling related fixes

2010-06-02 Thread Liam Girdwood
On Wed, 2010-06-02 at 12:05 +0300, Peter Ujfalusi wrote: > Hi, > > On Tuesday 01 June 2010 14:18:19 Ujfalusi Peter (Nokia-D/Tampere) wrote: > > .. > > Liam if you are going to take the series, could you fix the patch names? > I can also resend them if it is easier for you. > Peter, I think it'

Re: [alsa-devel] [RFC PATCH 5/5] ASoC: omap-mcbsp: Place correct constraints for streams

2010-05-31 Thread Liam Girdwood
On Mon, 2010-05-31 at 11:16 +0300, Peter Ujfalusi wrote: > OMAP McBSP FIFO is word structured: > McBSP2 has 1024 + 256 = 1280 word long buffer, > McBSP1,3,4,5 has 128 word long buffer > > This means, that the size of the FIFO > depends on the McBSP word size configuration. > For example on McBSP3:

Re: [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()

2010-05-19 Thread Liam Girdwood
On Wed, 2010-05-19 at 13:50 +0300, Eduardo Valentin wrote: > On Tue, May 18, 2010 at 10:13:11PM +0200, Liam Girdwood wrote: > > This adds a method to set the MCBSP DMA OP mode. > > OK. good. But again, why do you need set dma op mode other than inside mcbsp > code? > I thi

Re: [alsa-devel] [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API

2010-05-19 Thread Liam Girdwood
On Wed, 2010-05-19 at 13:46 +0300, Eduardo Valentin wrote: > Hello Lian, > > On Tue, May 18, 2010 at 10:13:12PM +0200, Liam Girdwood wrote: > > Add a small API to configure McBSP smart idle modes > > to conserve power. > > I'm sorry but I didn't get the point

Re: [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC

2010-05-19 Thread Liam Girdwood
On Wed, 2010-05-19 at 13:42 +0300, Eduardo Valentin wrote: > On Tue, May 18, 2010 at 10:13:10PM +0200, Liam Girdwood wrote: > > This series expands the OMAP mcbsp driver to support changing it's DMA > > operating > > mode and smart idle mode from client driver

Re: [alsa-devel] [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API

2010-05-19 Thread Liam Girdwood
On Tue, 2010-05-18 at 16:01 -0700, Kevin Hilman wrote: > Liam Girdwood writes: > > > Add a small API to configure McBSP smart idle modes > > to conserve power. > > Would be useful here to explain why client drivers need to change > idle modes. > I think Peter

Re: [alsa-devel] [PATCH 3/4] ASoC: mcbsp - add machine threshold callback

2010-05-19 Thread Liam Girdwood
On Tue, 2010-05-18 at 15:56 -0500, Candelaria Villarreal, Jorge wrote: > > > > +int omap_bcbsp_set_threshold_func(struct snd_soc_dai *cpu_dai, > > + void (*mach_set_threshold)(struct > > snd_pcm_substream *substream)) > > I think you meant omap_mcbsp_set_threshold_func here. I did i

[PATCH 4/4] OMAP: mcbsp - remove sysfs set for DMA op mode.

2010-05-18 Thread Liam Girdwood
The mcbsp DMA op mode is tightly integrated with the mcbsp client driver operation and hence is unsuitable for userspace configuration via sysfs. Signed-off-by: Liam Girdwood --- arch/arm/plat-omap/mcbsp.c | 30 +- 1 files changed, 1 insertions(+), 29 deletions

[PATCH 3/4] ASoC: mcbsp - add machine threshold callback

2010-05-18 Thread Liam Girdwood
Add a mechanism to register a machine specific callback to calculate and set the McBSP Tx/Rx threshold. Signed-off-by: Liam Girdwood --- sound/soc/omap/omap-mcbsp.c | 22 +- sound/soc/omap/omap-mcbsp.h |2 ++ 2 files changed, 23 insertions(+), 1 deletions(-) diff

[PATCH 2/4] OMAP: mcbsp - add smart idle configuration API

2010-05-18 Thread Liam Girdwood
Add a small API to configure McBSP smart idle modes to conserve power. Signed-off-by: Liam Girdwood --- arch/arm/plat-omap/include/plat/mcbsp.h | 15 arch/arm/plat-omap/mcbsp.c | 122 +++ 2 files changed, 137 insertions(+), 0 deletions(-) diff

[PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()

2010-05-18 Thread Liam Girdwood
This adds a method to set the MCBSP DMA OP mode. Signed-off-by: Liam Girdwood --- arch/arm/plat-omap/include/plat/mcbsp.h |2 ++ arch/arm/plat-omap/mcbsp.c | 31 +++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap

[PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC

2010-05-18 Thread Liam Girdwood
This series expands the OMAP mcbsp driver to support changing it's DMA operating mode and smart idle mode from client drivers. It's primarily aimed at lowering the power consumption for OMAP ASoC drivers by providing methods to gate clocks on the mcbsp interface at runtime. I've also added a patch

Re: [PATCH v3 0/2] McBSP changes for OMAP4 platform

2010-05-14 Thread Liam Girdwood
#1. > - Sending to alsa-devel list also, as suggested by Peter Ujfalusi > and Liam Girdwood > > Jorge Eduardo Candelaria (2): > ARM: McBSP: Fix request for irq in OMAP4 > ARM: OMAP4: Add support for omap4 in McBSP driver > > arch/arm/mach-omap2/mcbsp.c | 12

Re: [PATCH] OMAP: McBSP: Add 32-bit mode support

2010-05-14 Thread Liam Girdwood
On Thu, 2010-05-13 at 19:48 +0400, Sergey Lapin wrote: > This patchs should allow to use 32-bit samples on e.g. TLV320AIC3x codec, > or others. > > Signed-off-by: Sergey Lapin > --- Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.sl

RE: [PATCH] twl6030: regulator: Remove vsel tables and use formula for calculation

2010-05-14 Thread Liam Girdwood
On Fri, 2010-05-14 at 11:57 +0530, Nayak, Rajendra wrote: > > -Original Message- > > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > > Sent: Friday, April 23, 2010 4:49 PM > > To: Nayak, Rajendra > > Cc: linux-omap@vger.kernel.org; Liam Gird

Re: [PATCH v3 0/2] McBSP changes for OMAP4 platform

2010-05-13 Thread Liam Girdwood
On Thu, 2010-05-13 at 09:19 +0100, Mark Brown wrote: > On Wed, May 12, 2010 at 12:18:38PM -0500, Jorge Eduardo Candelaria wrote: > > The following patches enable McBSP driver to be used along with the > > audio driver in SDP4430 and other OMAP4 based boards. > > Both > > Acked-by: Mark Brown To

Re: [PATCH v2 0/0] McBSP changes for OMAP4 platform

2010-05-12 Thread Liam Girdwood
On Wed, 2010-05-12 at 11:39 +0300, Peter Ujfalusi wrote: > Hi, > > On Thursday 06 May 2010 04:15:44 ext Jorge Eduardo Candelaria wrote: > > The following patches enable McBSP driver to be used along with the > > audio driver in SDP4430 and other OMAP4 based boards. > > > > Changes from v1: > > -

Re: [alsa-devel] [PATCHv6 2/2] ASoC: TWL6040: Add twl6040 codec driver

2010-03-18 Thread Liam Girdwood
ath > (headset DAC and driver) is active. > > For the particular case of headset path, PLL being used defines the > headset power mode: low-power, high-performance. > > Signed-off-by: Misael Lopez Cruz > Signed-off-by: Jorge Eduardo Candelaria > Signed-off-by: Margarita Ol

Re: [alsa-devel] [PATCHv2 1/2] OMAP4: PMIC: Rename twl6030_codec as twl6040_codec

2010-03-18 Thread Liam Girdwood
On Wed, 2010-03-17 at 17:42 -0500, Olaya, Margarita wrote: > Correction for chips: > twl6030 is Phoenix Power chip > twl6040 is Phoenix Audio chip > > Signed-off-by: Margarita Olaya Cabrera Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regul

Re: [alsa-devel] [PATCHv2 5/5] ASoC: OMAP3: Report delay caused by the internal FIFO

2010-03-03 Thread Liam Girdwood
On Wed, 2010-03-03 at 15:08 +0200, Peter Ujfalusi wrote: > Use the new delay calback function to report the delay through > ALSA for application caused by the internal FIFO. > > Signed-off-by: Peter Ujfalusi > --- Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd A

Re: [alsa-devel] [PATCHv2 3/5] ASoC: core: Add delay operation to snd_soc_dai_ops

2010-03-03 Thread Liam Girdwood
delay on the chain. > If none of the dai has FIFO, than the delay will be kept as > zero. > > Signed-off-by: Peter Ujfalusi Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from

Re: [alsa-devel] [PATCHv2 2/5] ASoC: core: soc level wrapper for pcm_pointer callback

2010-03-03 Thread Liam Girdwood
On Wed, 2010-03-03 at 15:08 +0200, Peter Ujfalusi wrote: > Create a soc level wrapper for pcm_pointer callback. > This will facilitate the soc level handling of different > HW buffers in the audio path. > > Signed-off-by: Peter Ujfalusi Acked-by: Liam Girdwood -- Free

Re: [alsa-devel] [PATCHv2 1/5] ASoC: core: fix tailing whitespace in soc_pcm_apply_symmetry

2010-03-03 Thread Liam Girdwood
On Wed, 2010-03-03 at 15:08 +0200, Peter Ujfalusi wrote: > My editor removes the tailing spaces, which causes problems when > changing the soc-core.c > Removing the space. > > Signed-off-by: Peter Ujfalusi Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd A

Re: [alsa-devel] [PATCHv4 0/7] TWL6030 audio codec initial support

2010-02-25 Thread Liam Girdwood
On Wed, 2010-02-24 at 18:17 -0600, Olaya, Margarita wrote: > > > -Original Message- > > From: Liam Girdwood [mailto:l...@slimlogic.co.uk] > > Sent: Wednesday, February 24, 2010 5:40 AM > > To: Olaya, Margarita > > Cc: alsa-de...@alsa-project.org; linu

Re: [alsa-devel] [PATCHv4 2/7] ASoC: TWL6030: Add twl6030 codec driver

2010-02-25 Thread Liam Girdwood
On Wed, 2010-02-24 at 17:37 -0600, Olaya, Margarita wrote: > > > -Original Message- > > From: Liam Girdwood [mailto:l...@slimlogic.co.uk] > > Sent: Wednesday, February 24, 2010 4:38 AM > > To: Olaya, Margarita > > Cc: alsa-de...@alsa-project.org; linu

Re: [PATCHv4 0/7] TWL6030 audio codec initial support

2010-02-24 Thread Liam Girdwood
On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote: > Following patch series add initial support for TWL6030 codec driver. > The patch set is based on the series sent from Misael Lopez in October 2009. > > Changes from v3: > - Remove snd_soc_init_card function > - Adapt to latest twl core c

Re: [PATCHv4 3/7] ASoC: TWL6030: Manual power-up/down sequences

2010-02-24 Thread Liam Girdwood
On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote: > From: Misael Lopez Cruz > > TWL6030 codec device can be powered-up/down through a specific register > writes sequence. These sequences can be used when no gpio line is > provided for AUDPWRON. > > When the codec is powered-up in this w

Re: [PATCHv4 2/7] ASoC: TWL6030: Add twl6030 codec driver

2010-02-24 Thread Liam Girdwood
On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote: > From: Misael Lopez Cruz > > Initial version of TWL6030 codec driver. > > The TWL6030 codec uses a propietary PDM-based digital audio interface. > Audio paths supported are: > > - Input: Main Mic, Sub Mic, Headset Mic, Auxiliary-FM Lef

Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-24 Thread Liam Girdwood
On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote: > From: Misael Lopez Cruz > > In order to have TWL6030 CODEC driver as a platform driver, codec data > should be passed through twl_platform_data structure. > > For twl6030 audio codec, the following data may be passed: > - audpwron_

Re: [alsa-devel] [PATCHv5 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-22 Thread Liam Girdwood
++- sound/soc/omap/omap-mcbsp.c | > > 138 +++ > > sound/soc/omap/omap-mcbsp.h |2 + > > 5 files changed, 603 insertions(+), 1 deletions(-) > > Both looks OK for me: > > Acked-by: Peter Ujfalusi Ack

Re: [PATCH 2/2] twl6030: regulator: Configure STATE register instead of REMAP

2010-02-18 Thread Liam Girdwood
|RES |State1 |State0 > > State can be specified as below > 00: OFF > 01: ON > 10: OFF > 11: SLEEP > > Signed-off-by: Rajendra Nayak > Cc: Liam Girdwood > Cc: Samuel Ortiz > Cc: Mark Brown > --- Applied. Thanks Liam -- Freelance Developer, SlimLogic Lt

Re: [RESEND][PATCHv2 3/4] Add ASoC support for Devkit8000

2010-02-11 Thread Liam Girdwood
On Thu, 2010-02-11 at 16:13 +0100, Thomas Weber wrote: > This patch expands the omap3beagle sound soc for the > beagle board clone DevKit8000. > > Signed-off-by: Thomas Weber Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Main

Re: [alsa-devel] [PATCHv3 3/4] Add ASoC support for DevKit8000

2010-02-11 Thread Liam Girdwood
On Thu, 2010-02-11 at 12:40 +0200, Jarkko Nikula wrote: > On Thu, 11 Feb 2010 09:55:12 + > Liam Girdwood wrote: > > > Since this shares the same mach driver as beagle you should share the > > Kconfig option too (like the Overo). > > > Heh, I had just

Re: [alsa-devel] [PATCHv3 3/4] Add ASoC support for DevKit8000

2010-02-11 Thread Liam Girdwood
On Wed, 2010-02-10 at 20:23 +0100, Thomas Weber wrote: > This patch expands the omap3beagle sound soc for the > beagle board clone Devkit8000. > > Change log > V2 > Expand omap3beagle sound soc for DevKit8000 support. > V3 > Separate Kconfig for Devkit8000. > > Signed-off-by: Thomas

Re: [PATCHv2 1/4] Regulator: OMAP: Creating TWL4030 file having supplies & init data

2010-02-05 Thread Liam Girdwood
On Fri, 2010-02-05 at 10:45 +0200, Eduardo Valentin wrote: > Hello Anuj, > > First of all, I liked the idea of unifying the regulator definitions > for boards that use twl regulators. > > But I guess we need to improve a little bit. > > See following comments. > > On Tue, Jan 12, 2010 at 10:13:

Re: [alsa-devel] [PATCH 1/1] ASoC: AIC23: Fixing writes to non-existing registers in resume function

2010-01-29 Thread Liam Girdwood
On Fri, 2010-01-29 at 13:58 +0530, Anuj Aggarwal wrote: > Commit e9ff5eb2 (Fixing infinite loop in resume path) uses wrong AIC23 > register in resume function because of which register writes happen > on some non-existing registers. > > Signed-off-by: Anuj Aggarwal Acked-by

Re: [alsa-devel] [PATCH 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-01-28 Thread Liam Girdwood
On Thu, 2010-01-28 at 17:46 +0200, Ilkka Koskinen wrote: > Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. > > Signed-off-by: Ilkka Koskinen > --- > sound/soc/omap/omap-mcbsp.c | 187 > +++ > sound/soc/omap/omap-mcbsp.h |2 + > 2 files chang

RE: [alsa-devel] [PATCHv2 6/6] ASoC: OMAP4: Add McPDM platform driver

2010-01-26 Thread Liam Girdwood
On Mon, 2010-01-25 at 15:06 -0600, Candelaria Villareal, Jorge wrote: > From: Liam Girdwood wrote: > > On Fri, 2010-01-22 at 17:15 -0600, Candelaria Villareal, Jorge wrote: snip > > > +static int omap_mcpdm_dai_hw_params(struct > > snd_

Re: [alsa-devel] [PATCHv2 6/6] ASoC: OMAP4: Add McPDM platform driver

2010-01-26 Thread Liam Girdwood
On Tue, 2010-01-26 at 10:27 +0200, Jarkko Nikula wrote: > Hi > > On Mon, 25 Jan 2010 15:06:44 -0600 > "Candelaria Villareal, Jorge" wrote: > > > > > +static int omap_mcpdm_dai_startup(struct snd_pcm_substream > > > *substream, > > > > + struct snd_soc_dai *dai) >

RE: [alsa-devel] [PATCHv2 5/6] ASoC: OMAP4: Add support for McPDM

2010-01-26 Thread Liam Girdwood
On Mon, 2010-01-25 at 15:06 -0600, Candelaria Villareal, Jorge wrote: > Liam Girdwood wrote: > > > > On Fri, 2010-01-22 at 17:15 -0600, Candelaria Villareal, Jorge wrote: > > > McPDM is the interface between Phoenix audio codec > > > and the OMAP4430 processor.

Re: [alsa-devel] [PATCHv2 5/6] ASoC: OMAP4: Add support for McPDM

2010-01-22 Thread Liam Girdwood
On Fri, 2010-01-22 at 17:15 -0600, Candelaria Villareal, Jorge wrote: > McPDM is the interface between Phoenix audio codec > and the OMAP4430 processor. It enables data to be transfered > to/from Phoenix at sample rates of 88.4 or 96 KHz. > > Signed-off-by: Jorge Eduardo Candelaria > Signed-off-b

Re: [alsa-devel] [PATCHv2 6/6] ASoC: OMAP4: Add McPDM platform driver

2010-01-22 Thread Liam Girdwood
On Fri, 2010-01-22 at 17:15 -0600, Candelaria Villareal, Jorge wrote: > From: Misael Lopez Cruz > > McPDM platform driver is configured to use sDMA in order to transfer > to/from memory. Support for interfacing with ABE will be added later. > > McPDM dai currently supports up to 4 downlink chann

Re: [alsa-devel] [PATCHv2 1/6] ASoC: OMAP: data_type and sync_mode configurable in audio dma

2010-01-22 Thread Liam Girdwood
On Fri, 2010-01-22 at 17:14 -0600, Candelaria Villareal, Jorge wrote: > From: Misael Lopez Cruz > > Allow client drivers to set the data_type (16, 32) and the > sync_mode (element, packet, etc) of the audio dma transferences. > Btw, how is 32bit mode used here ? Is it for compacted 2 channel 1

RE: [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms

2010-01-14 Thread Liam Girdwood
On Wed, 2010-01-13 at 22:25 +0530, Aggarwal, Anuj wrote: > Any comments on this version? Just had a quick scan, looks fine. Acked-by: Liam Girdwood -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More m

Re: [alsa-devel] [PATCH] Fix build of OMAP sound drivers

2009-12-10 Thread Liam Girdwood
data+0x43cc): undefined reference to `tlv320aic23_dai' > > Confused me quite a bit since the drivers that had references to the > codec weren't enabled. Turns out the Makefile was using the wrong > config option to enable them. Patch below. > > > > Reported-by: Anand

Re: [alsa-devel] [PATCH] ASoC: OMAP: enable Overo driver for CM-T35

2009-11-16 Thread Liam Girdwood
/soc/omap/overo.c > @@ -107,8 +107,8 @@ static int __init overo_soc_init(void) > { > int ret; > > - if (!machine_is_overo()) { > - pr_debug("Not Overo!\n"); > + if (!(machine_is_overo() || machine_is_cm_t35())) { > + pr_deb

Re: [alsa-devel] [PATCH] ASoC: OMAP: enable Overo driver for CM-T35

2009-11-16 Thread Liam Girdwood
On Mon, 2009-11-16 at 15:53 +0200, Mike Rapoport wrote: > Signed-off-by: Mike Rapoport > --- > sound/soc/omap/Kconfig |7 --- > sound/soc/omap/overo.c |2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig > index 65

Re: [PATCHv3 1/3] Regulator: Add TPS65023 regulator driver

2009-08-23 Thread Liam Girdwood
On Fri, 2009-08-21 at 00:39 +0530, Anuj Aggarwal wrote: > Adding support for TI TPS65023 regulator driver > > Signed-off-by: Anuj Aggarwal > --- > drivers/regulator/tps65023-regulator.c | 631 > > 1 files changed, 631 insertions(+), 0 deletions(-) > create mod

Re: [PATCHv2 1/8] Regulator: Add TPS65023 regulator driver

2009-08-13 Thread Liam Girdwood
On Wed, 2009-08-12 at 10:17 +0530, Anuj Aggarwal wrote: > Adding support for TI TPS65023 regulator driver > > Signed-off-by: Anuj Aggarwal > --- > drivers/regulator/tps65023-regulator.c | 638 > > 1 files changed, 638 insertions(+), 0 deletions(-) > create mod

Re: [PATCH 1/8] Regulator: Add TPS65023 regulator driver

2009-08-09 Thread Liam Girdwood
On Fri, 2009-08-07 at 16:53 +0100, Mark Brown wrote: > On Fri, Aug 07, 2009 at 08:55:26PM +0530, Anuj Aggarwal wrote: > > > +static const struct tps_info tps65023_regs[] = { > > + { > > + .name = "VDCDC1", > > + .min_uV = 80, > > + .max_uV = 160, > > + .fixed = 0, No need to a

Re: [PATCH] regulator core: fix double-free in regulator_register() error path

2009-04-27 Thread Liam Girdwood
On Sat, 2009-04-25 at 05:28 -0600, Paul Walmsley wrote: > During regulator registration, any error after device_register() will > cause a double-free on the struct regulator_dev 'rdev'. The bug is in > drivers/regulator/core.c:regulator_register(): > > ... > scrub: > device_unregister(&rd

Re: [PATCH] regulator: twl4030 VAUX3 supports 3.0V

2009-03-31 Thread Liam Girdwood
On Thu, 2009-03-26 at 16:21 +0200, Adrian Hunter wrote: > >From 51f946af56a5de9c25b2eb6e6a33660283f84195 Mon Sep 17 00:00:00 2001 > From: Adrian Hunter > Date: Fri, 6 Mar 2009 14:51:30 +0200 > Subject: [PATCH] regulator: twl4030 VAUX3 supports 3.0V > > TWL4030 and TWL5030 support 3.0V on VAUX3. >

Re: [patch] twl4030-regulator: expose VPLL2

2009-03-19 Thread Liam Girdwood
On Mon, 2009-03-16 at 15:51 +, Mark Brown wrote: > On Fri, Mar 13, 2009 at 05:54:54PM -0700, David Brownell wrote: > > From: David Brownell > > > > Add VPLL2 to the set of twl4030-family regulators exposed for > > use by various drivers. It's commonly used to power the digital > > video outp

Re: [PATCH] regulator: twl4030 VAUX3 supports 3.0V

2009-03-17 Thread Liam Girdwood
On Tue, 2009-03-17 at 09:36 +0200, Adrian Hunter wrote: > Liam Girdwood wrote: > > On Fri, 2009-03-06 at 14:48 -0800, David Brownell wrote: > >> On Friday 06 March 2009, Mark Brown wrote: > >>> Would it make sense to make this platform data so that if a given board &

  1   2   >