Re: [PATCH v7 00/12] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27

2011-02-20 Thread Manuel, Lesly Arackal
Hi Jean, On Fri, Feb 18, 2011 at 10:57 PM, Jean Pihet wrote: > On Fri, Feb 18, 2011 at 6:08 PM, Lesly A M wrote: >> Patch series for TWL4030 power scripts and workaround for TWL errata 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL4

Re: [PATCH 01/12] omap3: pm: Fix for the TRITON sleep/wakeup sequence

2011-02-21 Thread Manuel, Lesly Arackal
Hi David, On Sat, Feb 19, 2011 at 5:08 AM, David Cohen wrote: > Hi, > > On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M wrote: >> Since the function to populate the sleep script is getting called always >> irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data >> is getting over written

Re: [PATCH 09/12] omap3: pm: TWL5030 version checking

2011-02-21 Thread Manuel, Lesly Arackal
Hi David, On Sat, Feb 19, 2011 at 5:21 AM, David Cohen wrote: > Hi, > > On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M wrote: >> Added api to get the TWL5030 Si version from the IDCODE register. >> It is used for enabling the workaround for TWL errata 27. >> >> Signed-off-by: Lesly A M >> Cc: Nisha

Re: [PATCH 10/12] mfd: TWL4030: changes for TRITON Errata 27 workaround

2011-02-21 Thread Manuel, Lesly Arackal
On Sat, Feb 19, 2011 at 5:03 AM, David Cohen wrote: > Hi, > > On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M wrote: >> Workaround for TWL5030 Silicon Errata 27 & 28: >>        27 - VDD1, VDD2, may have glitches when their output value is updated. >>        28 - VDD1 and / or VDD2 DCDC clock may stop

Re: [PATCH 10/12] mfd: TWL4030: changes for TRITON Errata 27 workaround

2011-02-21 Thread Manuel, Lesly Arackal
Hi David, On Sun, Feb 20, 2011 at 3:32 AM, David Cohen wrote: > On Sat, Feb 19, 2011 at 2:44 AM, David Cohen wrote: >> On Sat, Feb 19, 2011 at 1:33 AM, David Cohen wrote: >>> Hi, >>> >>> On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M wrote: Workaround for TWL5030 Silicon Errata 27 & 28:

Re: [PATCH 09/12] omap3: pm: TWL5030 version checking

2011-02-21 Thread Manuel, Lesly Arackal
On Mon, Feb 21, 2011 at 5:44 PM, Krishnamoorthy, Balaji T wrote: > On Fri, Feb 18, 2011 at 10:38 PM, Lesly A M wrote: > > > >> +int twl5030_get_si_ver(u32 *value) >> +{ >> +       int ret = 0; >> +       static u32 twl_idcode; >> + >> +       if (twl_idcode == 0) >> +               ret = twl_rea

Re: [PATCH 5/8] omap3: pm: TWL5030 version checking

2011-02-28 Thread Manuel, Lesly Arackal
Hi Balaji, On Mon, Feb 28, 2011 at 12:54 PM, Krishnamoorthy, Balaji T wrote: > On Sat, Feb 26, 2011 at 5:55 PM, Lesly A M wrote: > > Minor comment you missed version number in subject. > > > >> +/** >> + * twl_get_si_type - api to get TWL Si type. >> + * >> + * Api to get the TWL Si type from I

Re: [PATCH v7 00/12] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27

2011-03-01 Thread Manuel, Lesly Arackal
Hi Kevin, On Wed, Mar 2, 2011 at 3:54 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Patch series for TWL4030 power scripts and workaround for TWL errata 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL4030 power script file, which

Re: [PATCH v7 0/8] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27

2011-03-01 Thread Manuel, Lesly Arackal
Hi Kevin, On Wed, Mar 2, 2011 at 4:01 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Patch series for TWL4030 power scripts and workaround for TWL errata 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL4030 power script file, which

Re: [PATCH 1/8] omap3: pm: Fix for the TRITON sleep/wakeup sequence

2011-03-01 Thread Manuel, Lesly Arackal
Hi Kevin, On Wed, Mar 2, 2011 at 4:03 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Since the function to populate the sleep script is getting called always >> irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data >> is getting over written by the sleep script. Adding the missin

Re: [PATCH 3/8] omap3: pm: Correcting the sys_offmode signal polarity

2011-03-01 Thread Manuel, Lesly Arackal
Hi Kevin, On Wed, Mar 2, 2011 at 4:05 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Changing the polarity of the sys_offmode signal to active low, >> to get a High to Low transition on the NSLEEP1 of PM IC when OMAP is >> entering offmode. Because on PM IC the power resources (LDO, DCDC regul

Re: [PATCH v8 3/7] omap3: pm: TWL4030 power scripts for OMAP3 boards

2011-03-07 Thread Manuel, Lesly Arackal
Hi Kevin, On Tue, Mar 8, 2011 at 2:32 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset. >> >> TWL4030 power scripts which can be used by different OMAP3 boards >> with the power companion chip (TWL4030 series). >> >> The twl

Re: [PATCH v8 6/7] omap3430: Updating the board file to use TWL4030 scripts

2011-03-07 Thread Manuel, Lesly Arackal
Hi Kevin, On Tue, Mar 8, 2011 at 1:12 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Using TWL4030 power scripts to control the LDOs and DCDC regulators >> while going to low power mode. >> >> Signed-off-by: Lesly A M > > Minor: Re: Subject: OMAP is an acronym, please capitalize. Ok >> Cc: N

Re: [PATCH v8 6/7] omap3430: Updating the board file to use TWL4030 scripts

2011-03-07 Thread Manuel, Lesly Arackal
Hi Kevin, On Tue, Mar 8, 2011 at 2:40 AM, Kevin Hilman wrote: > Kevin Hilman writes: > >> Lesly A M writes: >> >>> Using TWL4030 power scripts to control the LDOs and DCDC regulators >>> while going to low power mode. >>> >>> Signed-off-by: Lesly A M >> >> Minor: Re: Subject: OMAP is an acrony

Re: [PATCH v8 5/7] mfd: TWL4030: changes for TRITON Errata 27 workaround

2011-03-07 Thread Manuel, Lesly Arackal
Hi Kevin, On Tue, Mar 8, 2011 at 2:44 AM, Kevin Hilman wrote: > Hi Lesly, > > Lesly A M writes: > >> Workaround for TWL5030 Silicon Errata 27 & 28: >>       27 - VDD1, VDD2, may have glitches when their output value is updated. >>       28 - VDD1 and / or VDD2 DCDC clock may stop working when in

Re: [PATCH v8 0/8] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27

2011-03-07 Thread Manuel, Lesly Arackal
Hi Kevin, On Tue, Mar 8, 2011 at 2:55 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Patch series for TWL4030 power scripts and workaround for TWL errata 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL4030 power script file, which

Re: [PATCH v9 4/9] OMAP3: PM: TWL4030 power scripts for OMAP3 boards

2011-04-18 Thread Manuel, Lesly Arackal
Hi Tony, On Mon, Apr 18, 2011 at 6:02 PM, Tony Lindgren wrote: > Hi, > > * Lesly A M [110414 15:25]: >> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset. >> >> TWL4030 power scripts which can be used by different OMAP3 boards >> with the power companion chip (TWL4030 serie

Re: [PATCH v9 4/9] OMAP3: PM: TWL4030 power scripts for OMAP3 boards

2011-04-27 Thread Manuel, Lesly Arackal
Hi Tony, On Mon, Apr 18, 2011 at 6:28 PM, Tony Lindgren wrote: > * Manuel, Lesly Arackal [110418 15:52]: >> > >> > To me it seems this should go into drivers/mfd instead. >> > The script may contain omap specific values, but can be >> > a loadable driver m

Re: [PATCH v9 6/9] MFD: TWL4030: workaround changes for TWL4030 Erratum 27

2011-04-27 Thread Manuel, Lesly Arackal
Hi Samuel, On Tue, Apr 26, 2011 at 3:43 PM, Samuel Ortiz wrote: > Hi Lesly, > > On Thu, Apr 14, 2011 at 05:57:54PM +0530, Lesly A M wrote: >> Workaround for TWL5030 Silicon Errata 27 & 28: >>       27 - VDD1, VDD2, may have glitches when their output value is updated. >>       28 - VDD1 and / or

Re: [PATCH v9 0/9] OMAP3: PM: TWL4030 power scripts and workaround for TWL erratum 27

2011-05-04 Thread Manuel, Lesly Arackal
Hi Jean, On Tue, May 3, 2011 at 6:51 PM, Jean Pihet wrote: > On Thu, Apr 14, 2011 at 2:27 PM, Lesly A M wrote: >> Patch series for TWL4030 power scripts and workaround for TWL erratum 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL40

Re: [PATCH v10 3/7] MFD: TWL4030: Modifying the macro name Main_Ref to all caps

2011-05-13 Thread Manuel, Lesly Arackal
Hi Tony, On Thu, May 12, 2011 at 4:12 PM, Tony Lindgren wrote: > * Lesly A M [110506 06:14]: >> Modifying the macro name Main_Ref to all caps(MAIN_REF). > > This may get counted as "crazy churn" patch.. Please provide > some reason for doing this in the patch description. I will update the chan

Re: [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards

2011-05-13 Thread Manuel, Lesly Arackal
Hi Tony, On Thu, May 12, 2011 at 4:26 PM, Tony Lindgren wrote: > * Lesly A M [110506 06:14]: >> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset. >> >> TWL4030 power scripts which can be used by different OMAP3 boards >> with the power companion chip (TWL4030 series). >> >

Re: [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards

2011-05-17 Thread Manuel, Lesly Arackal
Hi Samuel, On Sat, May 14, 2011 at 12:09 AM, Samuel Ortiz wrote: > Hi Lesly, > > On Fri, May 06, 2011 at 06:47:10PM +0530, Lesly A M wrote: >> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset. >> >> TWL4030 power scripts which can be used by different OMAP3 boards >> with t

Re: [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards

2011-05-24 Thread Manuel, Lesly Arackal
Hi Samuel, On Mon, May 23, 2011 at 3:10 AM, Samuel Ortiz wrote: > Hi Lesly, > > On Tue, May 17, 2011 at 07:10:03PM +0530, Manuel, Lesly Arackal wrote: >> Hi Samuel, >> >> On Sat, May 14, 2011 at 12:09 AM, Samuel Ortiz wrote: >> > Hi Lesly, >> >

Re: [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards

2011-06-06 Thread Manuel, Lesly Arackal
Hi Kevin, On Thu, Jun 2, 2011 at 11:59 PM, Kevin Hilman wrote: > Lesly A M writes: > >> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset. >> >> TWL4030 power scripts which can be used by different OMAP3 boards >> with the power companion chip (TWL4030 series). >> >> The tw

Re: [PATCH v10 0/7] MFD: TWL4030: power script and workaround for erratum 27

2011-06-06 Thread Manuel, Lesly Arackal
Hi Kevin, On Fri, Jun 3, 2011 at 6:01 AM, Kevin Hilman wrote: > Lesly A M writes: > >> Patch series for TWL4030 power scripts for OMAP3 boards and >> workaround for TWL erratum 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL4030 powe