Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread Ohad Ben-Cohen
Hi Hiroshi, On Mon, Jun 14, 2010 at 3:58 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Does dspbridge really need its own defered work for sending mailbox messages? We do, according to http://permalink.gmane.org/gmane.linux.ports.arm.omap/38240 (thanks Rene for the explanation). For

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread Ohad Ben-Cohen
Hi Subbu, On Mon, Jun 14, 2010 at 10:56 AM, C.A, Subramaniam subramaniam...@ti.com wrote: Hi Ohad/Hiroshi, Good to see the new mailbox requirements. While we are at it can we add some more :)? ... Please provide your feedback! Feel free to send the patches ;) Thanks, Ohad. -- To

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-13 Thread Ohad Ben-Cohen
they are somewhat related, they have a common receiver, which was registered using only a single call to get). Something like this, pls tell me what you think: From 353d36d7fd6ec76c81689893338dfd4d33c8c89a Mon Sep 17 00:00:00 2001 From: Ohad Ben-Cohen o...@wizery.com Date: Sun, 13 Jun 2010 18:32:22 -0500

Re: [PATCH 09/10] omap: mailbox: convert block api to kfifo

2010-06-09 Thread Ohad Ben-Cohen
On Wed, Jun 9, 2010 at 12:38 AM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: From: Ohad Ben-Cohen [o...@wizery.com] But now that you point me to this irq on/off thing, it looks a bit broken in terms of multiple concurrent mbox support since it relies on a global rq_full state. I guess it'd

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Ohad Ben-Cohen
On Mon, Jun 7, 2010 at 6:14 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I think the best thing to do here is remove the spinlock I'm afraid we can't do that: we need it to support OMAP4 syslink IPC use cases which have multiple simultaneous sending contexts. , if not, you are

Re: [PATCH 09/10] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Ohad Ben-Cohen
Hi Rene, On Tue, Jun 8, 2010 at 7:16 PM, Sapiens, Rene rene.sapi...@ti.com wrote: In mbox_rx_work() you are removing the lines that enable back the  mbox irq for the RX case, but inside  __mbox_rx_interrupt() this interrupt  is disabled in the case that the kfifo for Rx mailbox gets full. So

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Ohad Ben-Cohen
Hi Deepak, On Mon, Jun 7, 2010 at 1:52 PM, Deepak Chitriki deepak.chitr...@ti.com wrote: With this patch I observed inconsistent lock state warning. Thanks for the report! Kfifo is acccessed in omap_mbox_msg_send() and mbox_tx_tasklet() functions.In order to protect this critical section we

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Ohad Ben-Cohen
Hi Deepak, On Mon, Jun 7, 2010 at 6:27 PM, Deepak Chitriki deepak.chitr...@ti.com wrote: Ohad Ben-Cohen wrote: Somewhat relevant note about mailbox performance: omap_mbox_msg_send often (i.e. when the kfifo is empty) can just send the message directly, without triggering the tasklet to do

[PATCH v3 0/7] DSPBRIDGE: fix mem+cache API issues

2010-05-27 Thread Ohad Ben-Cohen
and recovery scenarios. Many thanks to Ivan Gomez Castellanos for the help here. Also Many thanks to Felipe Contreras for the thorough review, comments and testing. Thanks, Ohad. --- If you want, you can also reach me at ohadb at ti dot com . Ohad Ben-Cohen (7): DSPBRIDGE: enhance

[PATCH v3 1/7] DSPBRIDGE: enhance dmm_map_object

2010-05-27 Thread Ohad Ben-Cohen
Enhance dmm_map_object to support additional mapping and page information. This will be used to keep track of mapping resources needed later to invoke DMA transfers to/from the DSP. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com

[PATCH v3 2/7] DSPBRIDGE: maintain mapping and page info

2010-05-27 Thread Ohad Ben-Cohen
mechanism. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/dspdefs.h |3 +- drivers/dsp/bridge/core/io_sm.c| 11 ++- drivers/dsp/bridge/core/tiomap3430.c |9

[PATCH v3 3/7] DSPBRIDGE: do not call follow_page

2010-05-27 Thread Ohad Ben-Cohen
Eliminate the call to follow_page. Instead, use the page information that was kept during the proc_map call. This also has the advantage that users can now only specify memory areas that were previously mapped. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- You can also reach me at ohadb

[PATCH v3 4/7] DSPBRIDGE: do not use low level cache manipulation API

2010-05-27 Thread Ohad Ben-Cohen
state of any random address; if the buffer is not part of a previous memory mapping of that application, the request is denied. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/drv.h | 13

[PATCH v3 5/7] DSPBRIDGE: remove mem_flush_cache

2010-05-27 Thread Ohad Ben-Cohen
Now that we use standard DMA API instead of low level cache manipulation API, mem_flush_cache can be removed. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/drv.h | 15 drivers

[PATCH v3 6/7] DSPBRIDGE: add dspbridge API to mark end of DMA

2010-05-27 Thread Ohad Ben-Cohen
Add new dspbridge API that ends DMA transfers. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . drivers/dsp/bridge/rmgr/proc.c | 68 1 files changed, 68 insertions(+), 0 deletions(-) diff

[PATCH v3 7/7] DSPBRIDGE: add new PROC_BEGINDMA and PROC_ENDDMA ioctls

2010-05-27 Thread Ohad Ben-Cohen
Add two new dspbridge ioctls that mark the beginnind and end of a DMA transfer. The direction of the DMA transfer is given as a parameter, thus all three directions (DMA_BIDIRECTIONAL, DMA_TO_DEVICE and DMA_FROM_DEVICE) are supported. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want

Re: [PATCH v2 2/7] DSPBRIDGE: maintain mapping and page info

2010-05-26 Thread Ohad Ben-Cohen
On Mon, May 24, 2010 at 7:05 PM, Ohad Ben-Cohen o...@wizery.com wrote: Every time the MM application calls proc_map to map a memory area, remember the details of that mapping, together with the related page structures. Whenever a buffer is unmapped, clean up the mapping information resources

[PATCH v2 0/7] DSPBRIDGE: fix mem+cache API issues

2010-05-24 Thread Ohad Ben-Cohen
application running on ZOOM2 / 2.6.33. Many thanks to Felipe Contreras for the thorough review, comments and testing, and for Ivan Gomez Castellanos for thorough testing of multiple scenarios. Thanks, Ohad. --- If you want, you can also reach me at ohadb at ti dot com . Ohad Ben-Cohen (7

[PATCH v2 1/7] DSPBRIDGE: enhance dmm_map_object

2010-05-24 Thread Ohad Ben-Cohen
Enhance dmm_map_object to support additional mapping and page information. This will be used to keep track of mapping resources needed later to invoke DMA transfers to/from the DSP. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com

[PATCH v2 2/7] DSPBRIDGE: maintain mapping and page info

2010-05-24 Thread Ohad Ben-Cohen
mechanism. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/dspdefs.h |3 +- drivers/dsp/bridge/core/io_sm.c| 11 ++- drivers/dsp/bridge/core/tiomap3430.c |9

[PATCH v2 3/7] DSPBRIDGE: do not call follow_page

2010-05-24 Thread Ohad Ben-Cohen
Eliminate the call to follow_page. Instead, use the page information that was kept during the proc_map call. This also has the advantage that users can now only specify memory areas that were previously mapped. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me

[PATCH v2 4/7] DSPBRIDGE: do not use low level cache manipulation API

2010-05-24 Thread Ohad Ben-Cohen
state of any random address; if the buffer is not part of a previous memory mapping of that application, the request is denied. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/drv.h | 13

[PATCH v2 5/7] DSPBRIDGE: remove mem_flush_cache

2010-05-24 Thread Ohad Ben-Cohen
Now that we use standard DMA API instead of low level cache manipulation API, mem_flush_cache can be removed. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/drv.h | 15 drivers

[PATCH v2 6/7] DSPBRIDGE: add dspbridge API to mark end of DMA

2010-05-24 Thread Ohad Ben-Cohen
Add new dspbridge API that ends DMA transfers. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . drivers/dsp/bridge/rmgr/proc.c | 68 1 files changed, 68 insertions(+), 0 deletions(-) diff

[PATCH v2 7/7] DSPBRIDGE: add new PROC_BEGINDMA and PROC_ENDDMA ioctls

2010-05-24 Thread Ohad Ben-Cohen
Add two new dspbridge ioctls that mark the beginnind and end of a DMA transfer. The direction of the DMA transfer is given as a parameter, thus all three directions (DMA_BIDIRECTIONAL, DMA_TO_DEVICE and DMA_FROM_DEVICE) are supported. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-24 Thread Ohad Ben-Cohen
On Fri, May 21, 2010 at 12:42 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Although I'm still worried that VM_IO != write-combine, but I guess it's a safe assumption to do for now. small update we missed: The original code is ignoring VM_IO buffers as well: static int

Re: [RFC/PATCH 0/2] omap: mailbox: hwmod experiment

2010-05-24 Thread Ohad Ben-Cohen
On Sat, May 22, 2010 at 8:25 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Hi, I played a bit with omap_hwmod/omap_device for the mailbox, and this is the result. Nice move Felipe :) Can you convert this to use the runtime PM layer, instead of directly calling omap_device functions

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-24 Thread Ohad Ben-Cohen
On Mon, May 24, 2010 at 10:21 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, May 24, 2010 at 7:19 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, May 21, 2010 at 12:42 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Although I'm still worried that VM_IO != write

Re: [RFC/PATCH 0/2] omap: mailbox: hwmod experiment

2010-05-24 Thread Ohad Ben-Cohen
On Mon, May 24, 2010 at 10:33 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, May 24, 2010 at 8:29 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Sat, May 22, 2010 at 8:25 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I played a bit with omap_hwmod/omap_device

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-21 Thread Ohad Ben-Cohen
On Fri, May 21, 2010 at 9:14 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, May 21, 2010 at 12:22 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Wed, May 19, 2010 at 7:50 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I don't know what VM_IO means, but essentially we

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-20 Thread Ohad Ben-Cohen
Hi Felipe, On Fri, May 14, 2010 at 10:27 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Also, I noticed an important problem. Your code assumes that we would always have a bunch of scattered pages, Just a small note: the pages can be contiguous even in normal memory allocation (not

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-18 Thread Ohad Ben-Cohen
Hi Felipe, On Mon, May 17, 2010 at 3:05 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, May 17, 2010 at 2:25 AM, Ohad Ben-Cohen o...@wizery.com wrote: Out of curiosity, what board/environment do you use to play with the code ? I'd like to run the same use cases you do, so I can

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-18 Thread Ohad Ben-Cohen
On Mon, May 17, 2010 at 2:51 AM, Felipe Contreras felipe.contre...@gmail.com wrote: So currently (v2.6.33), before sending a read-olny buffer (TO_DEVICE), we do dmac_flush_range (should be clean, but whatever) and before sending a write-only (FROM_DEVICE), we do dmac_inv_range. On v2.6.33 the

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-18 Thread Ohad Ben-Cohen
On Tue, May 18, 2010 at 2:02 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, May 18, 2010 at 11:05 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Mon, May 17, 2010 at 2:51 AM, Felipe Contreras felipe.contre...@gmail.com wrote: So currently (v2.6.33), before sending a read-olny

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-18 Thread Ohad Ben-Cohen
On Tue, May 18, 2010 at 2:43 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, May 18, 2010 at 2:14 PM, Ohad Ben-Cohen o...@wizery.com wrote: Unfortunately I don't have a setup right now to test this, but the code seems to be ok for our needs, don't you think ? But yeah, actually

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-18 Thread Ohad Ben-Cohen
On Tue, May 18, 2010 at 3:24 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Cool. I actually tried your patches to render to the framebuffer, and everything seemed to work fine. I didn't check for error codes or anything, so I'm not sure what's going on. How is the framebuffer mmap'ed

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-16 Thread Ohad Ben-Cohen
Hi Felipe, On Fri, May 14, 2010 at 10:27 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Hi, I spent some time looking deeper into this patch series, and I have some doubts. On Sun, May 2, 2010 at 8:47 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Sun, May 2, 2010 at 4:17 PM, Felipe

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-16 Thread Ohad Ben-Cohen
PM, Ohad Ben-Cohen o...@wizery.com wrote: Basically you're right, but the patches currently silently allow today's user space to somehow work (because if you don't use dma bounce buffers and you feel lucky about speculative prefetching then you might get away with not calling dma unmap). I

Re: [RFC/PATCH 2/6] DSPBRIDGE: remember mapping and page info in proc_map

2010-05-16 Thread Ohad Ben-Cohen
Hi Felipe, On Sat, May 15, 2010 at 11:34 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, May 1, 2010 at 11:44 PM, Ohad Ben-Cohen o...@wizery.com wrote: Every time the MM application calls proc_map to map a memory area, remember the details of that mapping, together

Re: [RFC/PATCH 3/6] DSPBRIDGE: remove mapping information in proc_unmap

2010-05-16 Thread Ohad Ben-Cohen
Hi Felipe, On Sat, May 15, 2010 at 11:38 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, May 1, 2010 at 11:44 PM, Ohad Ben-Cohen o...@wizery.com wrote: Clean up all mapping information resources whenever a buffer is unmapped. If I understand correctly the previous patch

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-16 Thread Ohad Ben-Cohen
On Mon, May 17, 2010 at 2:15 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Hi Ohad, On Mon, May 17, 2010 at 1:35 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, May 14, 2010 at 10:27 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I looked into the dma code (I guess it's

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-16 Thread Ohad Ben-Cohen
On Mon, May 17, 2010 at 2:15 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Hi Ohad, On Mon, May 17, 2010 at 1:35 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, May 14, 2010 at 10:27 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I looked into the dma code (I guess it's

Re: [PATCH v2 3/4] omap: mailbox: fix reverse likeliness

2010-05-05 Thread Ohad Ben-Cohen
On Wed, May 5, 2010 at 6:21 PM, Tony Lindgren t...@atomide.com wrote: * Ohad Ben-Cohen o...@wizery.com [100504 04:42]: On Mon, May 3, 2010 at 9:02 PM, Tony Lindgren t...@atomide.com wrote: * Ohad Ben-Cohen o...@wizery.com [100502 08:40]: Fix reverse likeliness Signed-off-by: Ohad Ben

[PATCH v3 0/4] omap: mailbox: cleanup simplify

2010-05-05 Thread Ohad Ben-Cohen
This series includes comments from Hiroshi and Tony (thanks!). Changes since v2: - add mbox_kfifo_size module parameter sanity checks - remove (un)likely macros from cold mailbox paths Thanks, Ohad. --- If you want, you can also reach me at ohadb at ti dot com . Ohad Ben-Cohen (4): omap

[PATCH v3 1/4] omap: mailbox: convert rwlocks to spinlock

2010-05-05 Thread Ohad Ben-Cohen
rwlocks are slower and have potential starvation issues therefore spinlocks are generally preferred. see also: http://lwn.net/Articles/364583/ Signed-off-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Kanigeri Hari h-kanige...@ti.com --- If you want, you can also reach me at ohadb at ti dot

[PATCH v3 2/4] omap: mailbox cleanup: split MODULE_AUTHOR line

2010-05-05 Thread Ohad Ben-Cohen
use multiple MODULE_AUTHOR lines for multiple authors Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/mach-omap2/mailbox.c |3 ++- arch/arm/plat-omap/mailbox.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions

[PATCH v3 3/4] omap: mailbox: remove (un)likely macros from cold paths

2010-05-05 Thread Ohad Ben-Cohen
Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/mailbox.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 5140efc

[PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-05-05 Thread Ohad Ben-Cohen
(via the mbox_kfifo_size module parameter). Signed-off-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/Kconfig|9 +++ arch/arm/plat-omap/include/plat/mailbox.h

Re: [PATCH v2 3/4] omap: mailbox: fix reverse likeliness

2010-05-04 Thread Ohad Ben-Cohen
On Mon, May 3, 2010 at 9:02 PM, Tony Lindgren t...@atomide.com wrote: * Ohad Ben-Cohen o...@wizery.com [100502 08:40]: Fix reverse likeliness Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com .  arch/arm/plat-omap/mailbox.c |    4

Re: [PATCH v2 4/4] omap: mailbox: convert block api to kfifo

2010-05-03 Thread Ohad Ben-Cohen
On Mon, May 3, 2010 at 8:30 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: [PATCH v2 4/4] omap: mailbox: convert block api to kfifo Date: Sun, 2 May 2010 17:44:31 +0200 The underlying buffering implementation of mailbox

Re: [PATCH v2 4/4] omap: mailbox: convert block api to kfifo

2010-05-03 Thread Ohad Ben-Cohen
On Mon, May 3, 2010 at 9:07 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: Hiroshi DOYU hiroshi.d...@nokia.com Subject: Re: [PATCH v2 4/4] omap: mailbox: convert block api to kfifo Date: Mon, 03 May 2010 08:30:36 +0300 (EEST) Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject

[PATCH 4/4] omap: mailbox: convert block api to kfifo

2010-05-03 Thread Ohad Ben-Cohen
(via the mbox_kfifo_size module parameter). Signed-off-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- if you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/Kconfig|9 +++ arch/arm/plat-omap/include/plat/mailbox.h

Re: [RFC/PATCH 5/6] DSPBRIDGE: do not use low level cache manipulation API

2010-05-02 Thread Ohad Ben-Cohen
On Sat, May 1, 2010 at 11:44 PM, Ohad Ben-Cohen o...@wizery.com wrote: Instead of using low level cache manipulation API, use the standard DMA API.  This changes the concept of the dspbridge cache API a little, hence the naming changes: * Flush marks the beginning of a DMA transfer from

[PATCH v2 0/4] omap: mailbox: cleanup simplify

2010-05-02 Thread Ohad Ben-Cohen
. Ohad Ben-Cohen (4): omap: mailbox: convert rwlocks to spinlock omap: mailbox cleanup: split MODULE_AUTHOR line omap: mailbox: fix reverse likeliness omap: mailbox: convert block api to kfifo arch/arm/mach-omap2/mailbox.c |3 +- arch/arm/plat-omap/Kconfig|9

[PATCH v2 1/4] omap: mailbox: convert rwlocks to spinlock

2010-05-02 Thread Ohad Ben-Cohen
rwlocks are slower and have potential starvation issues therefore spinlocks are generally preferred. see also: http://lwn.net/Articles/364583/ Signed-off-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Kanigeri Hari h-kanige...@ti.com --- If you want, you can also reach me at ohadb at ti dot

[PATCH v2 2/4] omap: mailbox cleanup: split MODULE_AUTHOR line

2010-05-02 Thread Ohad Ben-Cohen
use multiple MODULE_AUTHOR lines for multiple authors Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/mach-omap2/mailbox.c |3 ++- arch/arm/plat-omap/mailbox.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions

Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-02 Thread Ohad Ben-Cohen
On Sun, May 2, 2010 at 4:17 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, May 1, 2010 at 11:44 PM, Ohad Ben-Cohen o...@wizery.com wrote: This patchset introduces an approach to eliminate the direct calls to follow_page and to the low level cache APIs. The patchset works

[RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues

2010-05-01 Thread Ohad Ben-Cohen
reach me at ohadb at ti dot com . Ohad Ben-Cohen (6): DSPBRIDGE: add memory_map_info to PROC DSPBRIDGE: remember mapping and page info in proc_map DSPBRIDGE: remove mapping information in proc_unmap DSPBRIDGE: do not call follow_page DSPBRIDGE: do not use low level cache manipulation

[RFC/PATCH 1/6] DSPBRIDGE: add memory_map_info to PROC

2010-05-01 Thread Ohad Ben-Cohen
Add the memory_map_info structure which will be used to maintain mapping and page information. Every memory mapping requested by the MM application will be remembered and kept in a linked list inside the proc object. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also

[RFC/PATCH 2/6] DSPBRIDGE: remember mapping and page info in proc_map

2010-05-01 Thread Ohad Ben-Cohen
Every time the MM application calls proc_map to map a memory area, remember the details of that mapping, together with the related page structures. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include

[RFC/PATCH 3/6] DSPBRIDGE: remove mapping information in proc_unmap

2010-05-01 Thread Ohad Ben-Cohen
Clean up all mapping information resources whenever a buffer is unmapped. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . drivers/dsp/bridge/rmgr/proc.c | 43 1 files changed, 43

[RFC/PATCH 4/6] DSPBRIDGE: do not call follow_page

2010-05-01 Thread Ohad Ben-Cohen
Eliminate the call to follow_page. Instead, use the page information that was kept during the proc_map call. This also has the advantage that users can now only specify memory areas that were previously mapped. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me

[RFC/PATCH 5/6] DSPBRIDGE: do not use low level cache manipulation API

2010-05-01 Thread Ohad Ben-Cohen
memory mapping of that application, the request is denied. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/_dcd.h |4 +- arch/arm/plat-omap/include/dspbridge/proc.h |4 +- arch/arm

[RFC/PATCH 6/6] DSPBRIDGE: add dspbridge API to mark end of DMA

2010-05-01 Thread Ohad Ben-Cohen
application can mark the end of a DMA transfer (and thus regain ownership of the buffer). Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- If you want, you can also reach me at ohadb at ti dot com . arch/arm/plat-omap/include/dspbridge/_dcd.h |2 + arch/arm/plat-omap/include/dspbridge/proc.h

Re: [PATCH 1/4] omap: mailbox cleanup: convert rwlocks to spinlock

2010-04-30 Thread Ohad Ben-Cohen
-ops-shutdown(mbox); -               write_unlock(mboxes_lock); +               spin_unlock(mboxes_lock);        }  } -- -Original Message- From: Ohad Ben-Cohen [mailto:o...@wizery.com] Sent: Tuesday, April 27, 2010 12:56 PM To: linux-omap@vger.kernel.org Cc

Re: [PATCH 1/4] omap: mailbox cleanup: convert rwlocks to spinlock

2010-04-30 Thread Ohad Ben-Cohen
On Thu, Apr 29, 2010 at 4:14 PM, Ohad Ben-Cohen o...@wizery.com wrote: Hi Hari, On Thu, Apr 29, 2010 at 3:44 PM, Kanigeri, Hari h-kanige...@ti.com wrote: Ohad, Looks like the conversion was missed in few places resulting in compile warnings. Thanks for pointing that out - that's really

Re: [PATCH 1/4] omap: mailbox cleanup: convert rwlocks to spinlock

2010-04-28 Thread Ohad Ben-Cohen
Hi Hiroshi, On Wed, Apr 28, 2010 at 10:50 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: [PATCH 1/4] omap: mailbox cleanup: convert rwlocks to spinlock Date: Tue, 27 Apr 2010 19:56:19 +0200 rwlocks are slower and have potential

Re: [PATCH 4/4] omap: mailbox: convert block api to kfifo

2010-04-28 Thread Ohad Ben-Cohen
Hi Hiroshi, On Wed, Apr 28, 2010 at 8:52 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: [PATCH 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 27 Apr 2010 19:56:22 +0200 The underlying buffering implementation of mailbox

Re: [PATCH 4/4] omap: mailbox: convert block api to kfifo

2010-04-28 Thread Ohad Ben-Cohen
On Wed, Apr 28, 2010 at 8:56 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Ohad Ben-Cohen o...@wizery.com Subject: [PATCH 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 27 Apr 2010 19:56:22 +0200 The underlying buffering implementation of mailbox is converted from block

Re: [PATCH 4/4] omap: mailbox: convert block api to kfifo

2010-04-28 Thread Ohad Ben-Cohen
On Wed, Apr 28, 2010 at 2:16 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH 4/4] omap: mailbox: convert block api to kfifo Date: Wed, 28 Apr 2010 13:02:06 +0200 diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap

Re: [PATCH 4/4] omap: mailbox: convert block api to kfifo

2010-04-28 Thread Ohad Ben-Cohen
On Wed, Apr 28, 2010 at 2:52 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH 4/4] omap: mailbox: convert block api to kfifo Date: Wed, 28 Apr 2010 13:25:41 +0200 On Wed, Apr 28, 2010 at 2:16 PM, Hiroshi DOYU hiroshi.d...@nokia.com

[PATCH 0/4] omap: mailbox: cleanup simplify

2010-04-27 Thread Ohad Ben-Cohen
. Please review and let me know your comments. Thanks, Ohad Ben-Cohen (4): omap: mailbox cleanup: convert rwlocks to spinlock omap: mailbox cleanup: split MODULE_AUTHOR line omap: mailbox: fix reverse likeliness omap: mailbox: convert block api to kfifo arch/arm/mach-omap2/mailbox.c

[PATCH 1/4] omap: mailbox cleanup: convert rwlocks to spinlock

2010-04-27 Thread Ohad Ben-Cohen
rwlocks are slower and have potential starvation issues so spinlocks are generally preferred Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- arch/arm/plat-omap/mailbox.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b

[PATCH 2/4] omap: mailbox cleanup: split MODULE_AUTHOR line

2010-04-27 Thread Ohad Ben-Cohen
use multiple MODULE_AUTHOR lines for multiple authors Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- arch/arm/mach-omap2/mailbox.c |3 ++- arch/arm/plat-omap/mailbox.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach

[PATCH 3/4] omap: mailbox: fix reverse likeliness

2010-04-27 Thread Ohad Ben-Cohen
Fix reverse likeliness Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- arch/arm/plat-omap/mailbox.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 8abf0e8..72b17ad 100644 --- a/arch/arm/plat-omap

[PATCH 4/4] omap: mailbox: convert block api to kfifo

2010-04-27 Thread Ohad Ben-Cohen
The underlying buffering implementation of mailbox is converted from block API to kfifo due to the simplicity and speed of kfifo. Signed-off-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |5 +- arch/arm/plat

<    3   4   5   6   7   8