> +static ssize_t cs_char_read(struct file *file, char __user *buf, size_t
> count,
> + loff_t *unused)
> +{
> + struct cs_char *csdata = file->private_data;
> + u32 data;
> + ssize_t retval;
> +
> + if (count < sizeof(da
On Mon, 2015-03-02 at 05:38 +0100, Sebastian Reichel wrote:
> +static int cs_alloc_cmds(struct cs_hsi_iface *hi)
> +{
> + struct hsi_msg *msg;
> + u32 *buf;
> + unsigned int i;
> +
> + INIT_LIST_HEAD(&hi->cmdqueue);
> +
> + for (i = 0; i < CS_MAX_CMDS; i++) {
> +
Hi,
a few remarks about possible issues.
Regards
Oliver
> +static int h4p_send_negotiation(struct h4p_info *info)
> +{
> + struct h4p_neg_cmd *neg_cmd;
> + struct h4p_neg_hdr *neg_hdr;
> + struct sk_buff *skb;
> + int err, len;
> + u16 sysclk = 38400;
On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote:
> Small patchset addressing break redundancy on drivers/usb branch
> (suggested by Joe Perches).
Frankly, that is not a good idea. Somebody will remove a "goto"
and forget to readd the "break"
Regards
Oliver
--
T
Am Donnerstag, 25. November 2010, 16:52:39 schrieb Alan Stern:
> When a device is declared irq-safe in this way, the PM core increments
> the parent's usage count, so the parent will never be runtime
> suspended. This prevents difficult situations in which an irq-safe
> device can't resume because
Am Freitag, 26. Februar 2010 12:20:05 schrieb Gupta, Ajay Kumar:
Hello,
> > -Original Message-
> > From: Oliver Neukum [mailto:oli...@neukum.org]
> > Sent: Friday, February 26, 2010 4:33 PM
> > To: Gupta, Ajay Kumar
> > Cc: linux-...@vger.kernel.org; linu
Am Freitag, 26. Februar 2010 11:39:06 schrieb Ajay Kumar Gupta:
> +struct queue *create(void)
> +{
> + struct queue *new;
> + new = kmalloc(sizeof(struct queue), GFP_ATOMIC);
> + if (!new)
> + return NULL;
> + new->next = NULL;
> + return new;
> +}
> +voi
Am Dienstag, 26. Januar 2010 15:14:43 schrieb Felipe Balbi:
> >There are load bursting issues too. All part of the USB spec;
> >a load that's OK for 1 millisecond might not be OK for 1 second.
>
> if you get a SetConfiguration(config), then you can use that load for as
> long as needed, the limi