Hi Benoit,
OMAP: Put the audio nodes to disabled styate by default and board dts files
should
enable the nodes which is used on the board.
am335x: correct the audio mclk clock. This patch has been marked to go to 3.13
stable as well.
Regards,
Peter
---
Peter Ujfalusi (9):
ARM: DTS
All audio nodes has been set to disabled state in omap4.dtsi file.
Signed-off-by: Peter Ujfalusi
---
arch/arm/boot/dts/omap4-panda-common.dtsi | 12
1 file changed, 12 deletions(-)
diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi
b/arch/arm/boot/dts/omap4-panda-common.dtsi
On 01/08/2014 12:53 AM, Tony Lindgren wrote:
> Well we cannot sanely deprecate the "ti,hwmods" and move on to
> matching hwmod data with DT data based on the compatible flag.
> So it's a bit of a blocker for v3.15 or so time frame.
>
>> Due to a 'hw feature' around the sidetone this is not as strai
Hi Benoit,
On 12/23/2013 11:28 AM, Peter Ujfalusi wrote:
> Hi,
>
> The audio frequency has been incorrectly set in the DTS file which results
> incorrect playback frequency on EVM-SK.
>
> The SD card can not be used without the second patch on 3.13-rc5.
Can you take a look
Hi Tony,
I have missed this mail...
On 12/05/2013 08:53 PM, Tony Lindgren wrote:
> * Tobias Jakobi [131203 14:45]:
>> And another one!
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=66451
>
> Maybe Peter can take a look at this one?
It has been already fixed (bug in the arch/arm/mm/dma-mapp
Hi,
The audio frequency has been incorrectly set in the DTS file which results
incorrect playback frequency on EVM-SK.
The SD card can not be used without the second patch on 3.13-rc5.
Regards,
Peter
---
Peter Ujfalusi (2):
ARM: DTS: am335x-evmsk: Correct audio clock frequency
ARM: dts
Add pinctrl section and cd-gpio to mmc1. Without these the SD card is not
working on EVM-SK board.
Signed-off-by: Peter Ujfalusi
---
arch/arm/boot/dts/am335x-evmsk.dts | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts
b/arch/arm/boot/dts/am335x
The clock for audio is sourced from virt_2400_ck, so the correct
frequency is 2400.
Signed-off-by: Peter Ujfalusi
---
arch/arm/boot/dts/am335x-evmsk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts
b/arch/arm/boot/dts/am335x
Hi Benoit,
On 11/28/2013 11:35 AM, Benoit Cousson wrote:
> Hi Peter,
>
> On 28/11/2013 10:28, Peter Ujfalusi wrote:
>> Since in DT booted kernel dummy regulators are no longer supported we need
>> to provide valid phandle for the regulator needed by the backlight.
>> O
Since in DT booted kernel dummy regulators are no longer supported we need
to provide valid phandle for the regulator needed by the backlight.
On the board VBAT is used to power the LCD backlight(s).
Signed-off-by: Peter Ujfalusi
---
Hi,
This patch is needed for 3.13 to get the LCD backlight to
ff-by: Victor Kamensky
> Signed-off-by: Taras Kondratiuk
Acked-by: Peter Ujfalusi
> ---
> sound/soc/omap/mcbsp.c | 12 ++--
> sound/soc/omap/omap-dmic.c |4 ++--
> sound/soc/omap/omap-mcpdm.c |4 ++--
> 3 files changed, 10 insertions(+), 10 deletion
ion properly in many cases.
> This fixes at least the LCD panel not turning on omap3 LDP for
> example.
Thanks for catching this. I have a recollection that I have tested the GPIO
and it appeared to be working fine..
Reviewed-by: Peter Ujfalusi
> Cc: Linus Walleij
> Cc: Peter
Hi,
When the omap5-evm.dts file has been renamed to omap5-uevm.dts and the sEVM
support got deprecated in favor of uEVM (or Panda5) the content was not
validated.
The reset GPIO is different on uEVM compared to sEVM and uEVM does not have
support for dmic.
Regards,
Peter
---
Peter Ujfalusi (2
When the omap5-evm.dts file has been renamed to omap5-uevm.dts and the sEVM
support got deprecated in favor of uEVM (or Panda5) the content was not
validated.
On uEVM the twl6040 reset GPIO is from gpio5_141 and not via gpio5_145, which
was the case in sEVM.
Signed-off-by: Peter Ujfalusi
When the omap5-evm.dts file has been renamed to omap5-uevm.dts and the sEVM
support got deprecated in favor of uEVM (or Panda5) the content was not
validated.
Panda5 does not have support for digital microphones so remove the pinmux
section for it.
Signed-off-by: Peter Ujfalusi
---
arch/arm
Hi,
On 10/21/2013 10:01 PM, Sergei Shtylyov wrote:
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index c328d5c..defaad1 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -633,5 +633,32 @@
>> dma-names = "tx"
Add nodes for McASP0 and McASP1 for AM43xx.
Signed-off-by: Peter Ujfalusi
---
arch/arm/boot/dts/am4372.dtsi | 27 +++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index c328d5c..defaad1 100644
--- a/arch/arm
On 10/10/2013 07:59 PM, Mark Rutland wrote:
>> No, they're not actually of much practical use to us at the minute but
>> it was generally felt better to include the information and not use it
>> so that if someone does come up with a use for them then the trees for
>> deployed systems already have
On 10/08/2013 10:36 PM, Jyri Sarha wrote:
> This patch adds a second tuple to reg property. The new property tuple
> describes the memory location for data port registers mapped trough
> L3 bus on am33xx. The both property tuples are named accordingly in
> the reg-names property.
>
> Signed-off-by
Hi Jyri,
On 10/08/2013 10:36 PM, Jyri Sarha wrote:
> @@ -407,6 +442,25 @@
>
> #include "tps65910.dtsi"
>
> +&mcasp1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&am335x_evm_audio_pins>;
> +
> + status = "okay";
> +
> + op-mode = <0>;
Hi,
On 10/08/2013 12:13 PM, Jyri Sarha wrote:
>> I have some questions however. I took a look at the McASP (TMS320C6000)
>> reference guide, and the registers appeared to all be in one contiguous
>> bank, and "mpu" and "dma" don't appear to be names of particular
>> registers or names of banks of
On 07/21/2013 06:24 PM, Michael Trimarchi wrote:
> Add SND_SOC_DAIFMT_CBM_CFS support for omap3/omap4. The patch was tested on
> a pandaboard-es board connected to the pcm1792a codec. mcbspx_fsx must
> configured as output and mcbspx_clkx must be configured as input.
Acked-by: Peter
ded in this patch:
SND_OMAP_SOC_OMAP_TWL4030
> Signed-off-by: Mark Brown
> ---
Otherwise:
Acked-by: Peter Ujfalusi
> sound/soc/omap/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
> index 9f5d55e..68dfc0a
On 07/11/2013 05:45 PM, Peter Ujfalusi wrote:
>> We could get rid of all the #ifdef from the code that way. OMAP3 is the
>> only platform that still depends on this - Further, with this change,
>
> Yep, I can do that. I'll send a separate patch to do this.
Now that I
On 07/09/2013 10:23 AM, Tony Lindgren wrote:
>> ASoC looks dead too:
>>
>> omap-abe-twl6040 sound.10: ASoC: CPU DAI (null) not registered
>> omap-abe-twl6040 sound.10: snd_soc_register_card() failed: -517
>
> Peter, I think you've had audio working with devicetree for at least
> a year or somethin
On 07/11/2013 06:35 PM, Nishanth Menon wrote:
> right - now that we removed the set_voltage/get_voltage custom code,
> there are no longer any way the code introduced in the commit can be
> exercised.
If we boot with DT (which is the case with OMAP4/5) this part was not even
executed, so the custo
On 07/12/2013 09:26 AM, Tony Lindgren wrote:
> * Peter Ujfalusi [130711 07:30]:
>> OMAP4 no longer boots in legacy mode so the code here is no longer used.
>>
>> Signed-off-by: Peter Ujfalusi
>> ---
>> arch/arm/mach-omap2/twl-common.c | 332
>> ++---
On 07/11/2013 04:59 PM, Nishanth Menon wrote:
> On 16:23-20130711, Peter Ujfalusi wrote:
>> OMAP4 no longer boots in legacy mode so the code here is no longer used.
>>
>> Signed-off-by: Peter Ujfalusi
>> ---
>> arch/
OMAP4 no longer boots in legacy mode so the code here is no longer used.
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/twl-common.c | 332 ++-
arch/arm/mach-omap2/twl-common.h | 8 -
2 files changed, 12 insertions(+), 328 deletions(-)
diff --git a
McPDM and DMIC only available on OMAP4/5 which no longer boots in legacy
mode.
The code to create the devices in legacy mode can be removed.
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/devices.c | 40
1 file changed, 40 deletions(-)
diff --git
sted.
>
> Test branch also still available (with O4 support only):
>git://gitorious.org/~kristo/omap-pm/omap-pm-work.git
>branch: mainline-3.10-rc6-omap4-dt-clks-v3
I have tested this branch on PandaBoardES. Audio works as it worked before.
To all:
Tested-by: Peter Ujfalusi
Hi,
Small patches to silence the hwmod lookup failures in case when we boot the
kernel on boards where the IPs are not present (OMAP2/3 vs McPDM, DMIC,
HDMI audio).
Regards,
Peter
---
Peter Ujfalusi (3):
ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
ARM: OMAP2
The dss_hdmi hwmod is used to create the HDMI audio device for OMAP4+
When we boot the kernel we can silently ignore the failure since the IP
does not exist on them.
Reported-by: Paul Walmsley
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion
It means that the SoC does not have DMIC IP
.
Reported-by: Paul Walmsley
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index b82538d..8f268b4
It means that the SoC does not have McPDM IP.
Reported-by: Paul Walmsley
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 4269fc1..b82538d
Hi Paul,
On 06/10/2013 09:22 AM, Paul Walmsley wrote:
>
> Hi folks -- particularly TIers working on mainline,
>
> There are several regressions that started with v3.10-rc that no one's
> fixed for over a month. Some of them should be quite easy:
>
> * 2430SDP, 3730 Beagle XM, 3530 Beagle, 351
Use module_platform_driver() to register the platform driver.
Signed-off-by: Peter Ujfalusi
Acked-by: Kevin Hilman
---
drivers/rtc/rtc-twl.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index c9060e9..e1776fd
finished it's
init.
Reported-by: Christoph Fritz
Signed-off-by: Peter Ujfalusi
Tested-by: Kevin Hilman
Tested-by: Grygorii Strashko
---
Hi,
Changes since v2:
- Acked-by and Tested-by added to patches
- Recreated on top of 3.10-rc4
Regards,
Peter
drivers/rtc/rtc-twl.c | 11 ++
With this we can remove the free_irq() calls from probe and remove.
Signed-off-by: Peter Ujfalusi
---
drivers/bus/omap_l3_noc.c | 23 +--
1 file changed, 5 insertions(+), 18 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index ca95d3d
We can remove the kfree() calls from probe and remove.
Signed-off-by: Peter Ujfalusi
---
drivers/bus/omap_l3_noc.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index feeecae..d25d727 100644
--- a/drivers
It is NOP after the devm_* conversion.
Signed-off-by: Peter Ujfalusi
---
drivers/bus/omap_l3_noc.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index 2bbc87b..ed428ad 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus
Use dev_err() which will going to print the driver's name as well and the
KERN_ERR level is sufficient in this case (we also print via dev_err when
there is an error with the mem resources)
Signed-off-by: Peter Ujfalusi
---
drivers/bus/omap_l3_noc.c | 7 +++
1 file changed, 3 inser
We can then remove the iounmap() calls from probe and remove.
Since the driver requests the resources via index we can do the mem resource
request within a for loop.
Signed-off-by: Peter Ujfalusi
---
drivers/bus/omap_l3_noc.c | 63 +++
1 file changed
Hi,
Cleanup of platform probe and remove (removing the remove function at the end)
with converting the driver to use the devm_* versions kzalloc, ioremap and
request_irq.
Regards,
Peter
---
Peter Ujfalusi (5):
drivers: bus: omap_l3: Convert to use devm_kzalloc
drivers: bus: omap_l3: Convert
Hi,
On 04/22/2013 04:38 PM, Felipe Balbi wrote:
>> Is it possible to handle ABE no_idle_on_suspend uscase the way I am
>> trying to handle it for UART in the 2nd patch of this series?
>
> let's ask Péter.
>
> Péter, OMAP_DEVICE_NO_IDLE_ON_SUSPEND should be removed as driver's can
> get same beh
Use module_platform_driver() to register the platform driver.
Signed-off-by: Peter Ujfalusi
---
drivers/rtc/rtc-twl.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index c385e9b..22b2fd6 100644
--- a/drivers/rtc
finished it's
init.
Reported-by: Christoph Fritz
Signed-off-by: Peter Ujfalusi
---
Hi,
As Tomi commented on the first version:
www.spinics.net/lists/linux-omap/msg90064.html
www.spinics.net/lists/linux-omap/msg90066.html
I have separated the actual fix from the module_platform_driver
Hi Tomi,
On 04/16/2013 10:10 AM, Tomi Valkeinen wrote:
> Hi,
>
> On 2013-04-16 10:44, Peter Ujfalusi wrote:
>> Convert the driver to use module_platform_driver() to register the platform
>> driver and relocate the rtc_reg_map initialization to platform driver's
>>
On 04/15/2013 06:25 PM, Tony Lindgren wrote:
> This fix should not be needed. It just means the real
> problem is somewhere else. Pinctrl is already before the i2c
> in drivers/Makefile. Maybe one of the MFD drivers has
> a wrong initcall level?
FYI; I just sent a patch which I believe is the corr
it's probe function.
Reported-by: Christoph Fritz
Signed-off-by: Peter Ujfalusi
---
Hi Tony, Alessandro, Christoph,
I think this patch is the correct solution for the issue Christoph reported:
http://www.spinics.net/lists/linux-omap/msg89980.html
We can make sure that the twl-core has be
Boards supported upstream all use TWL6040 as audio codec, enable the common
ASoC machine driver by default for them.
Signed-off-by: Peter Ujfalusi
---
arch/arm/configs/omap2plus_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/omap2plus_defconfig
b/arch/arm
cyclic DMA is only used by audio which needs DMA to be started without a
delay.
If the DMA for audio is started using the tasklet we experience random
channel switch (to be more precise: channel shift).
Reported-by: Peter Meerwald
CC: sta...@vger.kernel.org # v3.7+
Signed-off-by: Peter Ujfalusi
On 04/09/2013 09:26 AM, Vinod Koul wrote:
> Yes it should go thru dmaengine tree, sorry was travelling hence the delay,
> pls
> resend the patch and I will do the needful
I already have the patch rebased on today's linux-next, just waiting for
Russell to confirm that I can add his Acked-by to the
Russell,
On 04/09/2013 09:19 AM, Peter Ujfalusi wrote:
> On 04/08/2013 07:09 PM, Russell King - ARM Linux wrote:
>> Now that I'm back from a short 4 day break, then yes, and the answer is
>> that it's fine. Who's handling the patch?
>
> Thank you,
> Pét
On 04/08/2013 07:09 PM, Russell King - ARM Linux wrote:
> Now that I'm back from a short 4 day break, then yes, and the answer is
> that it's fine. Who's handling the patch?
Thank you,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to major
On 04/09/2013 08:52 AM, Santosh Shilimkar wrote:
>> I suggest Peter resend the patch with also Grant + Linus W cc:d so
>> they can queue it unless there are other related patches pending
>> somewhere else.
>>
> Am curious on your suggestion. DMA engine patches are going via Vinod
> Koul's tree so I
Russell,
On 04/03/2013 01:17 PM, Peter Ujfalusi wrote:
> cyclic DMA is only used by audio which needs DMA to be started without a
> delay.
> If the DMA for audio is started using the tasklet we experience random
> channel switch (to be more precise: channel shift).
>
>
Signed-off-by: Peter Ujfalusi
---
Tony, Matthias,
Changes since v3:
- remove the __initdata from all the structures introduced by this patch
If it is OK, I'll send a pull with this patch.
Regards,
Peter
arch/arm/mach-omap2/twl-common.c | 38 ++
arch/arm
Whata...
On 04/03/2013 01:59 PM, Peter Ujfalusi wrote:
> From: Matthias Brugger
>
> This patch adds a generic power script configuration.
> When rebooting an OMAP3530 at 125 MHz, the reboot hangs.
> With the generic power script, TWL4030 will be reset
> when a warm reset occ
Signed-off-by: Peter Ujfalusi
---
Tony, Matthias,
Changes since v2:
- remove the __initdata from all the structures introduced by this patch
Regards,
Peter
arch/arm/mach-omap2/twl-common.c | 38 ++
arch/arm/mach-omap2/twl-common.h | 1 +
2 files changed, 39
On 04/03/2013 01:24 PM, Santosh Shilimkar wrote:
> On Wednesday 03 April 2013 04:47 PM, Peter Ujfalusi wrote:
>> cyclic DMA is only used by audio which needs DMA to be started without a
>> delay.
>> If the DMA for audio is started using the tasklet we experience random
>
cyclic DMA is only used by audio which needs DMA to be started without a
delay.
If the DMA for audio is started using the tasklet we experience random
channel switch (to be more precise: channel shift).
Reported-by: Peter Meerwald
Signed-off-by: Peter Ujfalusi
---
Hi Russell,
Instead of
Russell,
On 03/29/2013 06:31 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 29, 2013 at 03:12:03PM +0100, Peter Ujfalusi wrote:
>> Remove the use of a tasklet to start the DMA channel when issue_pending is
>> called.
>> The use of tasklet delays the DMA start which can ca
Remove the use of a tasklet to start the DMA channel when issue_pending is
called.
The use of tasklet delays the DMA start which can cause issues at drivers,
for example the audio drivers expect that the DMA is started right away.
Signed-off-by: Peter Ujfalusi
---
Hi Russell,
I know you are
Signed-off-by: Peter Ujfalusi
---
Tony, Matthias,
I have marked the structs as __initdata to fix the section mismatch.
Regards,
Peter
arch/arm/mach-omap2/twl-common.c | 38 ++
arch/arm/mach-omap2/twl-common.h | 1 +
2 files changed, 39 insertions(+)
diff
Hi Tony,
On 03/27/2013 07:38 PM, Tony Lindgren wrote:
> Sorry just noticed that this one adds:
>
> Section mismatch in reference from the variable omap3_power_pdata to the
> (unknown reference) .init.data:(unknown)
> The variable omap3_power_pdata references
> the (unknown reference) __initdata
On 03/25/2013 06:15 PM, Russell King - ARM Linux wrote:
> What I'm talking about is having a physical channel scheduler in place
> across DMA engines which have more virtual channels than physical
> channels. Some DMA engine implementations sort of do this already (eg,
> AMBA PL08x stuff) but agai
eed to set
custom McBSP threshold...
But looking at the non upstream code I think I can handle things just fine
with this change as well.
Acked-by: Peter Ujfalusi
>
> Signed-off-by: Lars-Peter Clausen
> ---
> sound/soc/omap/omap-mcbsp.c | 12 +---
> sound/soc/omap/omap
On 03/22/2013 05:35 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 22, 2013 at 02:04:42PM +0100, Peter Ujfalusi wrote:
>> Russell: can we remove the tasklet use from dma-omap and start the DMA right
>> away in omap_dma_issue_pending()? This is the only way to prevent chann
to bisect it down.
>
> here it is:
> 946cc36ae550ea52adee0f42ac5034a34b5393be is the first bad commit
> commit 946cc36ae550ea52adee0f42ac5034a34b5393be
> Author: Peter Ujfalusi
> Date: Fri Sep 14 15:05:58 2012 +0300
>
> ASoC: omap-pcm: Convert to use dmaengine
>
Hi Tony,
I have rebased the branch on 3.9-rc3 tag.
Is it still possible to send this for 3.9?
Regards,
Péter
---
The following changes since commit a937536b868b8369b98967929045f1df54234323:
Linux 3.9-rc3 (2013-03-17 15:59:32 -0700)
are available in the git repository at:
git://gitorious.or
Hi Tony,
On 03/12/2013 05:57 PM, Tony Lindgren wrote:
> Sorry looks like this got missed. I suggest Peter collects the twl
> patches and then provides me + mfd + asoc and whoever needs the
> pull requests.
OK. Lets get things going forward. I have sent a pull request for you with
this patch.
--
Hi Tony,
The branch is on top of today's mainline.
Is it still possible to send this for 3.9?
Regards,
Péter
---
The following changes since commit a2362d24764a4e9a3187fc46b14e1d2cd0657700:
mm/fremap.c: fix possible oops on error path (2013-03-14 17:00:39 -0700)
are available in the git repos
e... Other than that the backlight works after the
series.
To both patch:
Tested-by: Peter Ujfalusi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/12/2013 04:20 PM, Roger Quadros wrote:
> Adding Peter to the loop. I faintly remember him mentioning this issue before
> for beagle. We really need the deferred probe mechanism or we need to resort
> to device registering order.
Yes, BeagleBoard is a good example. Long story short: we have e
On 03/12/2013 11:22 PM, Andrew Chew wrote:
> Many backlights need to be explicitly enabled. Typically, this is done
> with a GPIO. For flexibility, we generalize the enable mechanism to a
> regulator.
>
> If an enable regulator is not needed, then a dummy regulator can be given
> to the backligh
On 03/12/2013 11:22 PM, Andrew Chew wrote:
> The pwm-backlight driver now takes a mandatory regulator that is gotten
> during driver probe. Initialize a dummy regulator to satisfy this
> requirement.
I can test this tomorrow, but I have one comment:
>
> Signed-off-by: Andrew Chew
> ---
> arch
On 03/12/2013 05:33 PM, Levi Pearson wrote:
> I spent some more time looking at clk-twl6030.c, and it seems it just turns
> the
> twl6030 chip on when you ask it to enable the clock, and as far as I
> can tell that
> happens based on module dependencies? There aren't any explicit references to
>
Hi,
On 03/12/2013 02:54 AM, Andrew Chew wrote:
> The pwm-backlight driver now takes a mandatory regulator that is gotten
> during driver probe. Initialize a dummy regulator to satisfy this
> requirement.
Can you point me to the commit which makes a regulator mandatory for
pwm-backlight?
Why the
messages can be removed from the failure code paths.
Acked-by: Peter Ujfalusi
>
> Signed-off-by: Silviu-Mihai Popescu
> ---
> sound/soc/omap/omap-dmic.c |9 +++--
> sound/soc/omap/omap-mcpdm.c |8 +++-
> 2 files changed, 6 insertions(+), 11 deletions(-)
>
On 03/12/2013 09:24 AM, Silviu Popescu wrote:
> As far as I can tell from the mails that you have provided, those
> patches replace devm_request_mem_region(), followed by devm_ioremap()
> with devm_request_and_ioremap().
> What this patch attempts to do is replace devm_request_and_ioremap()
> with
Hi,
On 03/11/2013 04:58 PM, Silviu-Mihai Popescu wrote:
> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
>
> devm_ioremap_resource() provides its own error messages so all explicit
> error messages ca
On 03/11/2013 08:50 AM, Sebastien Guiriec wrote:
> Populate DMA client information for McBSP DMIC and McPDM periperhal on
> OMAP2+ devices.
Looks good to me:
Reviewed-by: Peter Ujfalusi
>
> Signed-off-by: Sebastien Guiriec
> ---
> arch/arm/boot/dts/omap2420.dtsi |6
On 03/11/2013 08:50 AM, Sebastien Guiriec wrote:
> Update OMAP2+ driver in order to use OMAP DMA DT binding for OMAP2+.
> In case of DT boot snd_dmaengine_generic_pcm_open function is used.
Acked-by: Peter Ujfalusi
>
> Signed-off-by: Sebastien Guiriec
> ---
> soun
Use pwm_leds driver for the keyboard light and pwm-backlight for the lcd
backlight control (instead of implementing the PWM driver part in the board
file).
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/board-zoom-display.c | 56
arch/arm/mach-omap2/board
On 03/11/2013 09:58 AM, Roger Quadros wrote:
> (+ Peter, Luca, Balaji)
>
> else your e-mail might just go unnoticed ;)
>
> On 03/07/2013 10:37 PM, Levi Pearson wrote:
>> I recently upgraded from a 3.4 kernel to a 3.8 kernel and found that
>> the drivers for the functionality provided by the TiWi
On 03/08/2013 08:25 AM, Jarkko Nikula wrote:
>> The content of the patches looks about right for me, however I would
>> squash together the IP and platform driver patches so we avoid breakage
>> within the series. Also I would put the patch for the .dtsi files as
>> first one.
>>
> Looks ok to me
Hi Sebastien,
On 03/07/2013 01:43 PM, Sebastien Guiriec wrote:
> This patch serie is converting OMAP Audio IPs in order to use OMAP sDMA DT
> binding in case of DT boot on OMAP2+ platforms.
The content of the patches looks about right for me, however I would squash
together the IP and platform dr
t;if (ret < 0)" or "if (ret)". I would use:
+ if (ret) {
> + dev_err(w->dapm.dev, "Failed to power DAC: %d\n", ret);
> + return ret;
> + }
> mdelay(1);
> gpio_set_value(OMAP3_PANDORA_DAC_P
Hi Matthias,
On 02/15/2013 04:59 PM, Matthias Brugger wrote:
> 2013/2/1 Tony Lindgren :
>> Hi,
>>
>> * Robert Nelson [130124 07:58]:
>>> On Wed, Jan 23, 2013 at 12:50 PM, Matthias Brugger
>>> wrote:
This patch adds a generic power script configuration.
When rebooting an OMAP3530 at 125
On 02/16/2013 08:33 AM, Anil Kumar wrote:
> Add the needed sections to enable audio support on
> Devkit8000 when booted with DT blob.
>
> Signed-off-by: Anil Kumar
Looks good:
Acked-by: Peter Ujfalusi
> ---
> This patch is based on top of kernel 3.8-rc5 and
> the followin
On 02/13/2013 06:02 PM, Anil Kumar wrote:
> 8---
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index b7e84a7..9000f4a 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1044,6 +1044,13 @@ static void soc_remove_dai_links(struct
> snd_soc_ca
On 02/13/2013 05:40 PM, Anil Kumar wrote:
> It looks issue is different here.
> I have done some testing here with patch[1]. In this patch i tried to
> get same "of_device" node pointer
> again and found refcount for this dt node is 1 [Result].
>
> As of_parse_phandle() says it "returns the device
On 02/13/2013 07:04 AM, Kumar, Anil wrote:
> Hi Peter,
>
> Just trying to understand.
>
> In omap-twl4030.c file probe function :-
>
> dai_node = of_parse_phandle(node, "ti,mcbsp", 0);
> if (!dai_node) {
> dev_err(&pdev->dev, "McBSP node is not provide
Hi Jon,
On 02/12/2013 05:15 PM, Jon Hunter wrote:
>
> On 02/12/2013 01:26 AM, Peter Ujfalusi wrote:
>> On 02/11/2013 09:22 PM, Jon Hunter wrote:
>>> Good point. I just noticed that none of my omap2+ board were booting and
>>> on omap3/4 I was the panic in the twl co
On 02/13/2013 08:21 AM, Sebastien Guiriec wrote:
> Clean up McPDM driver with devm_ function.
Acked-by: Peter Ujfalusi
>
> Signed-off-by: Sebastien Guiriec
> ---
> sound/soc/omap/omap-mcpdm.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
>
On 02/13/2013 08:22 AM, Sebastien Guiriec wrote:
> Clean up dmic code with devm_request_and_ioremap function.
Acked-by: Peter Ujfalusi
>
> Signed-off-by: Sebastien Guiriec
> ---
> sound/soc/omap/omap-dmic.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(
On 02/11/2013 09:22 PM, Jon Hunter wrote:
> Good point. I just noticed that none of my omap2+ board were booting and
> on omap3/4 I was the panic in the twl code. I can't say that I checked
> the panic on omap2, so may be that was another problem?
Do you have insights on the code path leading to a
Hi Sebastien,
On 02/11/2013 02:02 PM, Sebastien Guiriec wrote:
> Remove unused memory ressource get from McPDM driver.
I have no idea how this remain in the driver ;)
Acked-by: Peter Ujfalusi
> Signed-off-by: Sebastien Guiriec
> ---
> sound/soc/omap/omap-mcpdm.c |4 --
8a6aaa3 (mfd: twl-core: Collect global variables behind one
> private structure (global)) removed the variable "inuse" that is used
> to determine if the device has been initialised and now use the
> twl_priv structure instead. This is causing the kernel to panic on all
> OMAP2
801 - 900 of 2001 matches
Mail list logo
