RE: [PATCH] OMAP4: hwmod: Disable hardware-controlled idle for GPT1

2011-03-10 Thread Santosh Shilimkar
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, March 10, 2011 8:15 PM > To: Santosh Shilimkar > Cc: Benoit Cousson; Rajendra Nayak; linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Kevin Hilman > Subject: RE:

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-10 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 11, 2011 7:13 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; rna...@ti.com; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 00/19] OMAP4: PM: Sus

RE: [PATCH 0/3] [pm-wip/cpufreq] cpufreq cleanup and SMP support

2011-03-10 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 11, 2011 3:59 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; vishwanath...@ti.com > Subject: Re: [PATCH 0/3] [pm-wip/cpufreq] cpufreq cleanup and SMP > support > &

[PATCH V3] OMAP4: PM: Set static dependency between MPUSS-EMIF and MPUSS-L3_1

2011-03-10 Thread Santosh Shilimkar
dependency is not set between MPUSS<->EMIF and MPUSS<->L3_MAIN_1 clockdomains. At times, CPU dead-locks with above static dependencies cleared. The issue is under investigation with hardware team. Signed-off-by: Rajendra Nayak Signed-off-by: Santosh Shilimkar Acked-by: Paul Walmsle

[PATCH] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0

2011-03-11 Thread Santosh Shilimkar
supervised clockdomain mode isn't functional for all clockdomains on OMAP4430 ES1.0 silicon so avoid the same. Signed-off-by: Santosh Shilimkar Reported-by: Kevin Hilman Cc: Kevin Hilman --- Patch applies on top of OMAP4 PM series arch/arm/mach-omap2/pm44xx.c |5 + 1 files chang

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-11 Thread Santosh Shilimkar
Kevin, > -Original Message- > From: Santosh Shilimkar [mailto:santosh.shilim...@ti.com] > Sent: Friday, March 11, 2011 11:22 AM > To: Kevin Hilman > Cc: 'linux-omap@vger.kernel.org'; Rajendra Nayak; 'linux-arm- > ker...@lists.infradead.org' >

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-11 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 11, 2011 9:26 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; Rajendra Nayak; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 00/19] OMAP4: PM: Sus

RE: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and CPUilde support.

2011-03-11 Thread Santosh Shilimkar
Kevin, > -Original Message- > From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux- > arm-kernel-boun...@lists.infradead.org] On Behalf Of Kevin Hilman > Sent: Friday, March 11, 2011 9:22 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org

RE: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and CPUilde support.

2011-03-11 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 11, 2011 11:20 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; Rajendra Nayak > Subject: Re: [PATCH v2 00/19] OMAP4: PM: Su

RE: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and CPUilde support.

2011-03-11 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 11, 2011 11:34 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; Rajendra Nayak > Subject: Re: [PATCH v2 00/19] OMAP4: PM: Su

RE: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and CPUilde support.

2011-03-11 Thread Santosh Shilimkar
Kevin, > -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 11, 2011 11:34 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; Rajendra Nayak > Subject: Re: [PATCH v2 00/19] OMAP4: PM

RE: [PATCH 1/3] omap2plus: clock: Add an alias cpu_ck to be used in common cpufreq driver

2011-03-14 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 11, 2011 3:43 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; vishwanath...@ti.com > Subject: Re: [PATCH 1/3] omap2plus: clock: Add an alias cpu_ck to be > used in

[PATCH v2 0/2] [pm-wip/cpufreq] OMAP: CPUfreq cleanup and SMP support

2011-03-14 Thread Santosh Shilimkar
The series is generated against Kevin's latest cpufreq branch. The following changes since commit 444a22eb04ae07aef45cd4d0154f6f2bbe76daa9: Kevin Hilman (1): cpufreq: fixup after new OPP layer merged Santosh Shilimkar (2): OMAP: cpufreq: Split OMAP1 and OMAP2PLUS CPUfreq dr

[PATCH v2 2/2] OMAP2PLUS: cpufreq: Add SMP support to cater OMAP4430

2011-03-14 Thread Santosh Shilimkar
On OMAP SMP configuartion, both processors share the voltage and clock. So both CPUs needs to be scaled together and hence needs software co-ordination. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman cc: Vishwanath BS --- arch/arm/mach-omap2/omap2plus-cpufreq.c | 73

[PATCH v2 1/2] OMAP: cpufreq: Split OMAP1 and OMAP2PLUS CPUfreq drivers.

2011-03-14 Thread Santosh Shilimkar
This patch is an attempt to cleanup the #ifdeferry in the omap CPUfreq drivers. The split betwenn OMAP1 and OMAP2PLUS is logical because - OMAP1 doesn't support opp layer. - OMAP1 build is seperate from omap2plus. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman Cc: Vishw

RE: [GIT PULL] OMAP PM updates for 2.6.39

2011-03-14 Thread Santosh Shilimkar
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Stephan Raue > Sent: Tuesday, March 15, 2011 1:21 AM > To: Tony Lindgren > Cc: Kevin Hilman; linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject:

RE: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value

2011-03-16 Thread Santosh Shilimkar
nit(void) > > WARN(IS_ERR(od), "could not build omap_device for %s\n", > oh_name); > > - return PTR_ERR(od); > + return IS_ERR(od) ? PTR_ERR(od) : 0; > } > postcore_initcall(omap3_l3_init); > Looks good. Acked-by: Santosh Shilimkar -

RE: [PATCH 2/2] arm: mach-omap2: omap_l3_smx: fix irq handler setup

2011-03-16 Thread Santosh Shilimkar
> Right. Thanks. > Signed-off-by: Aaro Koskinen > --- Acked-by: Santosh Shilimkar > arch/arm/mach-omap2/omap_l3_smx.c | 11 --- > 1 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach- > omap2/omap

RE: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value

2011-03-17 Thread Santosh Shilimkar
> -Original Message- > From: Cousson, Benoit [mailto:b-cous...@ti.com] > Sent: Thursday, March 17, 2011 1:50 PM > To: Shilimkar, Santosh > Cc: Aaro Koskinen; linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; t...@atomide.com > Subject: Re: [PATCH 1/2] arm: mach-omap2: dev

RE: [PATCH v12 4/9] OMAP2+: dmtimer: convert to platform devices

2011-03-18 Thread Santosh Shilimkar
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Tony Lindgren > Sent: Saturday, March 19, 2011 5:57 AM > To: Kevin Hilman > Cc: DebBarma, Tarun Kanti; linux-omap@vger.kernel.org; Gopinath, > Thara > Subject: Re: [PATCH

RE: [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure

2011-03-18 Thread Santosh Shilimkar
Minor comment. > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Kevin Hilman > Sent: Saturday, March 19, 2011 5:49 AM > To: linux-omap@vger.kernel.org > Cc: Paul Walmsely; Benoit Cousson > Subject: [PATCH 2/7] OMAP2+: vo

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-25 Thread Santosh Shilimkar
Kevin, > -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Thursday, March 24, 2011 8:40 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; Rajendra Nayak; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 00/19] OM

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-25 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 25, 2011 8:54 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; Rajendra Nayak; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 00/19] OMAP4: PM: Sus

RE: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message

2011-03-27 Thread Santosh Shilimkar
> -Original Message- > From: Omar Ramirez Luna [mailto:omar.rami...@ti.com] > Sent: Saturday, March 26, 2011 6:00 AM > To: Tony Lindgren > Cc: Russell King; l-o; lak; sricharan; Santosh Shilimkar; Felipe > Balbi; Benoit Cousson; Omar Ramirez Luna > Subject: [PATCH] OM

[pm-core][PATCH v3 06/21] OMAP4: PM: Initialise all the clockdomains to supported states

2011-03-28 Thread Santosh Shilimkar
Initialise hardware supervised mode for all clockdomains if it's supported. Initiate sleep transition for other clockdomains, if they are not being used. Signed-off-by: Santosh Shilimkar Signed-off-by: Rajendra Nayak Cc: Kevin Hilman --- arch/arm/mach-omap2/pm44xx.c |

[pm-core][PATCH v3 03/21] OMAP4: PM: Export omap4_get_base*() rather than global address pointers

2011-03-28 Thread Santosh Shilimkar
This patch exports APIs to get base address for GIC distributor, CPU interface, SCU and PL310 L2 Cache which are used in OMAP4 PM code. This was suggested by Kevin Hilman during OMAP4 PM code review. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/include/mach/omap4

[pm-core][PATCH v3 08/21] OMAP4: PM: CPU1 wakeup workaround from Low power modes

2011-03-28 Thread Santosh Shilimkar
clockdomain hardware supervised mode. More details can be found in OMAP4430 TRM - Version J Section : 4.3.4.2 Power States of CPU0 and CPU1 Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/omap-hotplug.c |8 arch/arm/mach-omap2/omap-smp.c | 26

[pm-core][PATCH v3 11/21] OMAP4: PM: Add WakeupGen save/restore support

2011-03-28 Thread Santosh Shilimkar
n and GIC so that interrupts are not lost. Considering this GIC and WakeupGen save and restore is done together. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/include/mach/omap-wakeupgen.h |1 + arch/arm/mach-omap2/omap-wakeupgen.c |

[pm-core][PATCH v3 04/21] OMAP4: PM: Add SAR RAM support

2011-03-28 Thread Santosh Shilimkar
This patch adds SAR RAM support on OMAP4430. SAR RAM used to save and restore the HW context in low power modes. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/include/mach/omap4-common.h |1 + arch/arm/mach-omap2/omap4-common.c | 31

[pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
. Hence this patch hooks up the omap WakeupGen mask/unmask along with GIC using architecture specific hooks. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/Makefile |3 +- arch/arm/mach-omap2/include/mach/omap-wakeupgen.h | 40 arch/arm

[pm-core][PATCH v3 02/21] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit

2011-03-28 Thread Santosh Shilimkar
OMAP L2X0 and GIC initialisation code uses BUG_ON() for the ioremap() failure scenarios. Use WARN_ON() instead and allow graceful function exits. This was suggsted by Kevin Hilman during OMAP4 PM code review. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/omap4

[pm-core][PATCH v3 20/21] OMAP4: PM: Set static dependency between MPUSS-EMIF and MPUSS-L3_1

2011-03-28 Thread Santosh Shilimkar
dependency is not set between MPUSS<->EMIF and MPUSS<->L3_MAIN_1 clockdomains. At times, CPU dead-locks with above static dependencies cleared. The issue is under investigation with hardware team. Signed-off-by: Rajendra Nayak Signed-off-by: Santosh Shilimkar Acked-by: Paul Walmsle

[pm-core][PATCH v3 00/21] OMAP4: PM: suspend, CPU-hotplug and CPUilde support

2011-03-28 Thread Santosh Shilimkar
v3 Rajendra Nayak (1): OMAP4: cpuidle: Basic CPUidle support Santosh Shilimkar (20): OMAP4: PM: Add omap WakeupGen module support OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit OMAP4: PM: Export omap4_get_base*() rather than global address pointers OMAP4:

[pm-core][PATCH v3 10/21] OMAP4: PM: Add GIC save/restore support

2011-03-28 Thread Santosh Shilimkar
SAR RAM layout. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/omap-hotplug.c |4 + arch/arm/mach-omap2/omap4-mpuss-lowpower.c | 195 +++- arch/arm/mach-omap2/omap4-sar-layout.h | 20 +++ 3 files changed, 213 insertions(+), 6

[pm-core][PATCH v3 15/21] OMAP4: cpuidle: Basic CPUidle support

2011-03-28 Thread Santosh Shilimkar
From: Rajendra Nayak The patch adds a basic CPUidle driver for OMAP4. Just one C state is registered for CPU0 which does a WFI. CPU1 is left with defualt idle and the low power state for it is managed via cpu-hotplug. Signed-off-by: Rajendra Nayak Signed-off-by: Santosh Shilimkar Cc: Kevin

[pm-core][PATCH v3 07/21] OMAP4: PM: Program CPU1 to hit OFF when off-lined

2011-03-28 Thread Santosh Shilimkar
Program non-boot CPUs to hit lowest supported power state when it is off-lined using cpu hotplug framework. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/omap-hotplug.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/arch

[pm-core][PATCH v3 09/21] OMAP4: PM: Add GIC distributor and interface enable/disable accessory API

2011-03-28 Thread Santosh Shilimkar
time being this is kept under OMAP code so that OMAP4 PM can continue to work. Discussion thread: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg42940.html Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman Cc: Russell King --- arch/arm/mach-omap2/include/mach/omap4-common.h

[pm-core][PATCH v3 05/21] OMAP4: PM: Add CPUX OFF mode support

2011-03-28 Thread Santosh Shilimkar
This patch adds the CPU0 and CPU1 off mode support. CPUX close switch retention (CSWR) is not supported by hardware design. The CPUx OFF mode isn't supported on OMAP4430 ES1.0 CPUx sleep code is common for hotplug, suspend and CPUilde. Signed-off-by: Santosh Shilimkar Cc: Kevin H

[pm-core][PATCH v3 12/21] OMAP4: PM: Add L2 cache lowpower support

2011-03-28 Thread Santosh Shilimkar
When MPUSS hits off-mode e, L2 cache is lost. This patch adds L2X0 necessary maintenance operations and context restoration in the low power code. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/omap4-mpuss-lowpower.c | 18 arch/arm/mach-omap2/omap4-sar

[pm-core][PATCH v3 16/21] OMAP4: cpuidle: Add MPUSS RET OFF states

2011-03-28 Thread Santosh Shilimkar
profiling. Signed-off-by: Rajendra Nayak Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/cpuidle44xx.c | 129 +++-- 1 files changed, 124 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/

[pm-core][PATCH v3 21/21] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0

2011-03-28 Thread Santosh Shilimkar
supervised clockdomain mode isn't functional for all clockdomains on OMAP4430 ES1.0 silicon so avoid the same. Signed-off-by: Santosh Shilimkar Reported-by: Kevin Hilman Cc: Kevin Hilman --- arch/arm/mach-omap2/pm44xx.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a

[pm-core][PATCH v3 18/21] OMAP4: cpuidle: Add CPU hotplug notifier and prepare() hook.

2011-03-28 Thread Santosh Shilimkar
suggested by Kevin Hilman during OMAP4 PM code review. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/cpuidle44xx.c | 64 + 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch

[pm-core][PATCH v3 19/21] OMAP4: Remove un-used do_wfi() macro.

2011-03-28 Thread Santosh Shilimkar
With OMAP4 suspend, idle and hotplug series, we no longer need do_wfi() macro. Remove the same. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/include/mach/omap4-common.h | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/arch/arm

[pm-core][PATCH v3 17/21] OMAP4: cpuidle: Switch to gptimer from twd in deeper C-states.

2011-03-28 Thread Santosh Shilimkar
with local timers marked with (mis)feature flag CLOCK_EVT_FEAT_C3STOP. Then notify the clock events layer from idle code using CLOCK_EVT_NOTIFY_BROADCAST_ENTER/EXIT). Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/cpuidle44xx.c |8 1 files changed, 8

[pm-core][PATCH v3 13/21] OMAP4: suspend: Add MPUSS RET and OFF support

2011-03-28 Thread Santosh Shilimkar
This patch adds MPUSS(MPU Sub System) RET and OFF mode support to suspend path. For both MPUSS RET and OFF support, CPUs are programmed to OFF state. Only MPUSS RET and OFF supported at this point of time. CORE RET will be added subsequently. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman

[pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
This patch adds configurable wakeup timer support in suspend. Also for statistics pm counter support is added. Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/omap4-mpuss-lowpower.c |4 arch/arm/mach-omap2/pm-debug.c | 11 +-- arch/arm

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-28 Thread Santosh Shilimkar
Kevin > -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 25, 2011 8:54 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; Rajendra Nayak; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 00/19] OMAP4: PM:

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-28 Thread Santosh Shilimkar
Kevin, > -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Friday, March 25, 2011 8:54 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; Rajendra Nayak; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 00/19] OMAP4: PM:

RE: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Monday, March 28, 2011 9:27 PM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; Rajendra Nayak; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 00/19] OMAP4: PM: Sus

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [PATCH 01/10] omap: Use separate init_irq functions to avoidcpu_is_omap tests early

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Tony Lindgren > Sent: Tuesday, March 29, 2011 3:51 AM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Subject: [PATCH 01/10] omap: Use separa

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [PATCH 01/10] omap: Use separate init_irq functions to avoidcpu_is_omap tests early

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Tony Lindgren > Sent: Tuesday, March 29, 2011 3:51 AM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Subject: [PATCH 01/10] omap: Use separa

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [PATCH 01/10] omap: Use separate init_irq functions to avoidcpu_is_omap tests early

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Tony Lindgren > Sent: Tuesday, March 29, 2011 3:51 AM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Subject: [PATCH 01/10] omap: Use separa

RE: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

RE: [PATCH 01/10] omap: Use separate init_irq functions to avoidcpu_is_omap tests early

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Tony Lindgren > Sent: Tuesday, March 29, 2011 3:51 AM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Subject: [PATCH 01/10] omap: Use separa

RE: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters

2011-03-28 Thread Santosh Shilimkar
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, March 29, 2011 2:31 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; rna...@ti.com; > linux-arm-ker...@lists.infradead.org > Subject: Re: [pm-core][PATC

Re: [PATCH 1/5] OMAP3: l3: fix for "irq 10: nobody cared" message

2011-03-29 Thread Santosh Shilimkar
source of the error. Removed parenthesis that are not needed for the touched lines. Signed-off-by: Omar Ramirez Luna --- Acked-by: Santosh Shilimkar arch/arm/mach-omap2/omap_l3_smx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/omap_l3_smx

Re: [PATCH 2/5] OMAP3: l3: fix omap3_l3_probe error path

2011-03-29 Thread Santosh Shilimkar
() change looks good. Other changes are not necessary though because its is personnel choice to return from one place or from every error path. In both forms ... Acked-by: Santosh Shilimkar arch/arm/mach-omap2/omap_l3_smx.c | 23 ++- 1 files changed, 10 insertions(+), 13

Re: [PATCH 0/5] OMAP: l3: fixes and cleanup

2011-03-29 Thread Santosh Shilimkar
Omar, On 3/29/2011 10:50 PM, Omar Ramirez Luna wrote: Based on the comments received for the first patch: OMAP3: l3: fix for "irq 10: nobody cared" message[1], and quick skimming through the code. Although there are still parenthesis that are not needed because of operator precedence, they were

Re: [PATCH 00/10] omap init_early changes for irq and timer init

2011-03-30 Thread Santosh Shilimkar
mtimer driver code. When we move the dmtimer driver to say some drivers/ directory. Is it allowed to share such functions from device drivers Apart from above comments, I really liked this series. If you like you can add my, Reviewed-by: Santosh Shilimkar Regards Santosh -- To u

Re: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-03-30 Thread Santosh Shilimkar
On 3/31/2011 12:10 AM, Tony Lindgren wrote: * Santosh [110329 23:13]: On 3/29/2011 10:31 PM, Tony Lindgren wrote: * Santosh Shilimkar [110328 22:47]: From: Tony Lindgren [mailto:t...@atomide.com] Do you really need to initialize all of this that early? Yes. It's a interrupt contr

Re: [PATCH 00/10] omap init_early changes for irq and timer init

2011-03-31 Thread Santosh Shilimkar
On 3/30/2011 11:52 PM, Tony Lindgren wrote: * Santosh Shilimkar [110330 00:53]: After going through entire series again, it looks very good clean-up and right step towards moving rest of the timer to drivers/ directory. I also realized that the discussion we had before this series was

Re: [pm-core][PATCH v3 02/21] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit

2011-03-31 Thread Santosh Shilimkar
On 3/29/2011 2:23 AM, Tony Lindgren wrote: * Santosh Shilimkar [110328 02:20]: OMAP L2X0 and GIC initialisation code uses BUG_ON() for the ioremap() failure scenarios. Use WARN_ON() instead and allow graceful function exits. This was suggsted by Kevin Hilman during OMAP4 PM code review

[RFC PATCH] ARM: GIC: Convert GIC library to use the IO relaxed operations

2011-03-31 Thread Santosh Shilimkar
x27;t go through L2X0 write buffer. Also since a DSB does not guarantee that the device state has been changed, a read back from the device is introduced wherever necessary. Signed-off-by: Santosh Shilimkar Cc: Catalin Marinas Cc: Will Deacon --- Tested on OMAP4430 SDP. arch/arm/common/

Re: [RFC PATCH] ARM: GIC: Convert GIC library to use the IO relaxed operations

2011-03-31 Thread Santosh Shilimkar
On 3/31/2011 7:33 PM, Catalin Marinas wrote: On Thu, 2011-03-31 at 13:55 +0100, Santosh Shilimkar wrote: diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c index f70ec7d..e013f65 100644 --- a/arch/arm/common/gic.c +++ b/arch/arm/common/gic.c @@ -89,7 +89,9 @@ static void gic_ack_irq

Re: [pm-core][PATCH v3 02/21] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit

2011-03-31 Thread Santosh Shilimkar
On 3/31/2011 7:34 PM, Kevin Hilman wrote: Santosh Shilimkar writes: On 3/29/2011 2:23 AM, Tony Lindgren wrote: * Santosh Shilimkar [110328 02:20]: [...] L2 cache is no problem and kernel can boot without L2 cache support. I agree with you on interrupt controller init though. Will

Re: [PATCH 00/10] omap init_early changes for irq and timer init

2011-04-01 Thread Santosh Shilimkar
On 3/31/2011 11:02 PM, Tony Lindgren wrote: * Santosh Shilimkar [110331 01:14]: On 3/30/2011 11:52 PM, Tony Lindgren wrote: What it does not have is the code to dedicate gpt1 for PM code, which can be done later once all the other dmtimer changes are done. Which not possible to do unless

[PATCH v2] ARM: GIC: Convert GIC library to use the IO relaxed operations

2011-04-01 Thread Santosh Shilimkar
x27;t go through L2X0 write buffer. Also since a DSB does not guarantee that the device state has been changed, a read back from the device is introduced wherever necessary. Signed-off-by: Santosh Shilimkar Cc: Catalin Marinas Cc: Will Deacon --- V2: Incorporated comments from Catalin Marinas.

Re: [PATCH 06/10] omap2+: Remove gptimer_wakekup for now

2011-04-01 Thread Santosh Shilimkar
Kevin, On 4/1/2011 3:39 AM, Kevin Hilman wrote: Tony Lindgren writes: This removes the support for setting the wake-up timer for debugging. Later on we can reserve gptimer1 for PM code only and have similar functionality. Signed-off-by: Tony Lindgren While we work on an alternative, rathe

Re: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-04-02 Thread Santosh Shilimkar
On 4/2/2011 11:40 AM, Colin Cross wrote: On Mon, Mar 28, 2011 at 2:22 AM, Santosh Shilimkar wrote: This patch adds OMAP WakeupGen support. The WakeupGen unit is responsible for generating wakeup event from the incoming interrupts and enable bits. The WakeupGen is implemented in MPU Always-On

Re: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support

2011-04-02 Thread Santosh Shilimkar
On 4/3/2011 1:17 AM, Colin Cross wrote: On Sat, Apr 2, 2011 at 2:40 AM, Santosh Shilimkar wrote: On 4/2/2011 11:40 AM, Colin Cross wrote: [] +#ifdef CONFIG_PM +/* + * Architecture specific set_wake extension + */ +static int wakeupgen_set_wake(struct irq_data *d, unsigned int on

Re: RFC, GIC based smp_cross_call cleanup suggestion

2011-04-02 Thread Santosh Shilimkar
+ Thomas G, On 4/2/2011 2:40 PM, Colin Cross wrote: On Sat, Apr 2, 2011 at 1:51 AM, Russell King - ARM Linux wrote: On Fri, Apr 01, 2011 at 04:55:02PM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 4:26 PM, John Linn wrote: I’m getting ready to submit a patch to add SMP to Xilinx code.

Re: [PATCH] OMAP4: clockdomain: Follow recommended enable sequence

2011-04-03 Thread Santosh Shilimkar
Paul, On 4/4/2011 12:17 PM, Paul Walmsley wrote: On Fri, 1 Apr 2011, Rajendra Nayak wrote: On 4/1/2011 8:21 PM, Rajendra Nayak wrote: In omap_hwmod.c:_enable(), what do you think about: 1. saving the current idle mode of the clockdomain, 2. forcing the clockdomain to software-supervised wake

Re: RFC, GIC based smp_cross_call cleanup suggestion

2011-04-04 Thread Santosh Shilimkar
On 4/3/2011 7:18 PM, Russell King - ARM Linux wrote: On Sun, Apr 03, 2011 at 04:23:41PM +0530, Santosh Shilimkar wrote: If you plan to commit this change then I can move these to other OMAP4 header file. Can you send me a patch to do that please? Here it is.. Generated against latest

<    1   2   3   4   5   6   7   8   9   10   >