[4.230102] dev_id = 62 ch = 30 free_ch = 4
[4.234313] dev_id = 62 ch = 31 free_ch = 4
...
I was also wondering, what is special about dev_id == 0? The current
code treats that special and does break immediately?
Scott
On Fri, 2011-07-01 at 00:19 -0700, Tony Lindgren wrote:
* Scott Ellis sc
Break from dma channel search when a free one is found.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
---
arch/arm/plat-omap/dma.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index c22217c..3d36fcf 100644
I had exactly the same problem. It looks like the struct omap_mcbsp array was
intended to be accessible
From include/plat/mcbsp.h
extern struct omap_mcbsp **mcbsp_ptr;
I couldn't get access to mcbsp_ptr in an out of tree module. So I added this
arch/arm/plat-omap/include/plat/mcbsp.h
+struct
Looks like a typo from commit d6d834b010.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
---
arch/arm/plat-omap/mcbsp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index e31496e..0c8612f 100644
--- a/arch/arm
This was convenient in conjunction with some of the previous patches
since platform_device data was already getting read for max_clk_div and
num_cs was there too. Since max_clk_div is no more, maybe this patch
isn't worthwhile.
It's not a bug fix, so no harm ignoring.
I'll regenerate it if
Please ignore this patch.
Developer preference whether you want this much detail.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Check spi-chip_select for range before use.
The spi-controller_state check is already in 2.6.34-rc7
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
drivers/spi/omap2_mcspi.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/omap2_mcspi.c b
Only 3430 and 3630 TRMs says 0xd, 0xe, 0xf = Division not supported.
I tested a 3503 with clock divider values of 0x0d, 0x0e and 0x0f.
It worked fine.
I collected data off the SPI bus successfully at the expected
frequencies of 5859 Hz, 2929 Hz and 1464 Hz.
But then again, the TRMs can have
Hmm now it looks like you're missing 3630 handling?
If the max_clk_div is 0x0f for 2420 and 2430, then you
can just check for cpu_is_omap24xx(). If it's only
different for 2420, then you can check for cpu_is_omap2420().
That way it should be more future proof, and you don't
need to
The McSPI_CHxCONF.CLKD register field has different limits for
the OMAP3 then the OMAP24xx. New max_clk_div field added to
mcspi platform config structure to keep track of this.
Revised patch to not break multi-omap booting.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
arch/arm/mach-omap2
() and
then spi_add_device() fails. Calling spi_put_device() will
trigger the error.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
drivers/spi/omap2_mcspi.c | 30 +-
1 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/omap2_mcspi.c b
The McSPI_CHxCONF.CLKD register field has different limits for the
OMAP3 then the OMAP24xx. As per recommendation from the linux-omap
list, added a field for max_clk_div to the platform data for use in
omap2_mcspi.c.
Used in a subsequent patch.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
The MCSPI_CHxCONF.CLKD register field has different limits
for the OMAP3 then the OMAP24xx.
Use the new max_clk_div value from
omap2_mcspi_platform_config.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
drivers/spi/omap2_mcspi.c | 27 ++-
1 files changed, 18
omap2_mcspi_setup_transfer() gets called if a transfer has a non-zero
speed_hz value but it is never used in the function to override the
speed.
This patch enables its use.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
drivers/spi/omap2_mcspi.c | 14 ++
1 files changed, 10
The platform data already has the number of chip select lines
for each McSPI module. No need to figure it out again in
probe().
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
drivers/spi/omap2_mcspi.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers
Limit the debug messages put out in omap2_mcspi_setup_transfer().
If you are overriding the speed on transfers, the volume is
excessive.
Wrap it with VERBOSE.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
drivers/spi/omap2_mcspi.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions
to the OMAP24xxx manual could check if that is necessary.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
drivers/spi/omap2_mcspi.c | 24 +---
1 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index fe1b56d
Check spi-controller_state before dereferencing.
Check spi-chip_select for range before using.
Neither are guaranteed to be valid when spi_dev_put() is called.
Submitted previously to the linux-kernel list but without the
chip_select check.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
the call to omap2_mcsp_transfer() if the only reason was a
non-zero speed_hz and it's not going to be used.
2. Use the new speed_hz value provided
The patch below uses the speed_hz value.
The OMAP2_MCSPI_MAX_CLK_DIV comes from a previous patch submission.
Signed-off-by: Scott Ellis sc
19 matches
Mail list logo
