Re: [PATCHv3 2/9] ir-rx51: Handle signals properly

2012-09-16 Thread Sean Young
On Fri, Sep 14, 2012 at 10:58:53AM +0300, Timo Kokkonen wrote: It appears that all modern lirc drivers are now using the rc-core functionalities to implement the common stuff. When the rx51 lirc driver was first written, the core was not in place yet. Therefore it is implementing the file

Re: [PATCHv3 2/9] ir-rx51: Handle signals properly

2012-09-03 Thread Sean Young
safety measure that this driver behaves well. In that case I think you should use wait_event_interruptible() instead. Well, that's what I had there in the first place. With interruptible wait we are left with problem with signals. I was told by Sean Young that the lirc API expects

Re: [PATCH 2/8] ir-rx51: Handle signals properly

2012-08-24 Thread Sean Young
On Wed, Aug 22, 2012 at 10:50:35PM +0300, Timo Kokkonen wrote: The lirc-dev expects the ir-code to be transmitted when the write call returns back to the user space. We should not leave TX ongoing no matter what is the reason we return to the user space. Easiest solution for that is to simply

Re: [PATCHv2 1/2] media: rc: Introduce RX51 IR transmitter driver

2012-08-13 Thread Sean Young
On Fri, Aug 10, 2012 at 01:16:36PM +0300, Timo Kokkonen wrote: This is the driver for the IR transmitter diode found on the Nokia N900 (also known as RX51) device. The driver is mostly the same as found in the original 2.6.28 based kernel that comes with the device. The following