Re: [PATCH 2/2] memory: omap-gpmc: Add Kconfig option for debug

2016-01-06 Thread Sebastian Reichel
Hi, On Tue, Jan 05, 2016 at 02:49:29PM -0800, Tony Lindgren wrote: > Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") > unified the GPMC debug for the SoCs with GPMC. The commit also left > out the option for HWMOD_INIT_NO_RESET as we now require proper timings > for GPMC to

Re: [PATCH v2 5/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping

2015-11-13 Thread Sebastian Reichel
Hi, On Fri, Nov 13, 2015 at 09:35:56PM +0100, H. Nikolaus Schaller wrote: > commit b98abe52fa8e ("Input: add common DT binding for touchscreens") > introduced common DT bindings for touchscreens [1] and a helper function to > parse the DT. > > This has been integrated and interpretation of the in

Re: [PATCH] Revert "ARM: dts: twl4030: Add iio properties for bci subnode"

2015-11-06 Thread Sebastian Reichel
Hi, On Sat, Nov 07, 2015 at 09:19:25AM +1100, Stephen Rothwell wrote: > On Fri, 6 Nov 2015 10:36:34 -0800 Kevin Hilman wrote: > > On Fri, Nov 6, 2015 at 8:13 AM, Sebastian Reichel wrote: > > > This reverts commit af19161aaed7ff8d1a52b2e517460f2fa0774e32, > > > which b

[GIT PULL] power supply fix for 4.4

2015-11-06 Thread Sebastian Reichel
-- power supply fixes for the v4.4 series Just a single revert for a patch, that I should not have queued. More detailed description is inside the patch. It's totally my fault, that this happened, sorry about that :( --------

[PATCH] Revert "ARM: dts: twl4030: Add iio properties for bci subnode"

2015-11-06 Thread Sebastian Reichel
miss Stephen's messages about the build failure in linux-next and since he switched to merging an older snapshot nobody else noticed the problem in my tree. I didn't notice myself, since I did not build any device tree files assuming none have changed by me. Signed-off-by: Sebastian Reichel

Re: Linus HEAD build break

2015-11-06 Thread Sebastian Reichel
Hi, On Fri, Nov 06, 2015 at 04:34:12PM +0100, Sebastian Reichel wrote: > On Fri, Nov 06, 2015 at 06:53:52AM -0800, Tony Lindgren wrote: > > * Felipe Balbi [151106 06:41]: > > > Belisko Marek writes: > > > > On Fri, Nov 6, 2015 at 3:24 PM, Felipe Balbi wrote:

Re: Linus HEAD build break

2015-11-06 Thread Sebastian Reichel
Hi, On Fri, Nov 06, 2015 at 06:53:52AM -0800, Tony Lindgren wrote: > * Felipe Balbi [151106 06:41]: > > Belisko Marek writes: > > > On Fri, Nov 6, 2015 at 3:24 PM, Felipe Balbi wrote: > > >> Felipe Balbi writes: > > >>> your commit af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci >

Re: [PATCH] regulator: tps65217: remove tps65217.dtsi file

2015-10-27 Thread Sebastian Reichel
Hi, On Mon, Oct 26, 2015 at 10:13:55AM +0100, Heiko Schocher wrote: > remove tps65217.dtsi and adapt all boards, which > used it. > > Signed-off-by: Heiko Schocher > --- > Suggested by Mark Brown, see: > https://lkml.org/lkml/2015/10/21/581 > > .../devicetree/bindings/regulator/tps65217.txt

bug in omap3_rom_rng_idle()

2015-10-19 Thread Sebastian Reichel
Hi, During N900 boot I get the trace found below. The problem can be seen in omap3_rom_rng_idle(), which is called by a kernel timer (=softirq). In that function you call clk_disable_unprepare(), which must not be called from atomic context, since clk_unprepare() may sleep. [1.885131] ---

[PATCH] twl4030_charger: add missing iio dependency

2015-10-15 Thread Sebastian Reichel
This driver fails to link without CONFIG_IIO, since there are no stubs for the iio_channels functions. Signed-off-by: Sebastian Reichel --- drivers/power/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig index 9e68853217ca

Re: [PATCH 1/2] hsi: omap_ssi_port: Prevent warning if cawake_gpio is not defined.

2015-10-14 Thread Sebastian Reichel
Hi, On Wed, Oct 14, 2015 at 01:44:15PM +0300, Roger Quadros wrote: > The error handling path is broken as cawake_gpio was defined as > unsigned integer causing the following warnings on boards that don't > use SSI port and so don't have cawake_gpio defined. e.g. beagleboard C4. > > [...] Thanks,

Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default

2015-10-14 Thread Sebastian Reichel
Hi, On Wed, Oct 14, 2015 at 02:27:27PM +0300, Roger Quadros wrote: > On 14/10/15 14:19, Sebastian Reichel wrote: > > On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote: > >> Let's keep the SSI ports disabled in the omap3.dtsi to avoid > >> getting the fo

Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default

2015-10-14 Thread Sebastian Reichel
is missing cawake gpio (err=-2)" > > As omap3-n900 uses one SSI port, mark it enabled there. > > Signed-off-by: Roger Quadros Acked-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default

2015-10-14 Thread Sebastian Reichel
Hi Pali, On Wed, Oct 14, 2015 at 12:53:04PM +0200, Pali Rohár wrote: > On Wednesday 14 October 2015 13:44:16 Roger Quadros wrote: > > Let's keep the SSI ports disabled in the omap3.dtsi to avoid > > getting the following noise on the console for boards that don't > > use the SSI ports. > > > > "o

Re: [PATCH] ARM: AM35xx: Add M-USB clk device ID

2015-10-13 Thread Sebastian Reichel
Hi, On Tue, Oct 13, 2015 at 05:57:59PM -0500, Felipe Balbi wrote: > Sebastian Reichel writes: > > On Tue, Oct 13, 2015 at 10:50:45AM -0500, Felipe Balbi wrote: > >> Rolf Peukert writes: > >> > On 13.10.2015 10:15, Tero Kristo wrote: > >> >&g

Re: [PATCH] ARM: AM35xx: Add M-USB clk device ID

2015-10-13 Thread Sebastian Reichel
Hi, On Tue, Oct 13, 2015 at 10:50:45AM -0500, Felipe Balbi wrote: > Rolf Peukert writes: > > On 13.10.2015 10:15, Tero Kristo wrote: > >> On 10/12/2015 06:22 PM, Rolf Peukert wrote: > >>> The glue code in drivers/usb/musb/am35x.c calls clk_get() to get its > >>> interface and function clocks for

Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode

2015-10-12 Thread Sebastian Reichel
Hi, On Mon, Oct 12, 2015 at 03:20:10PM -0700, Tony Lindgren wrote: > * Tony Lindgren [151012 14:43]: > > * Belisko Marek [150926 13:02]: > > > Tony sorry I forgot to add you to the recipients for this patchset. > > > Can you please queue this patch. Many thanks. > > > > OK applying into omap-fo

Re: [PATCH] arm: omap2: timer: don't disable our timers

2015-10-05 Thread Sebastian Reichel
Hi, On Mon, Oct 05, 2015 at 06:41:37PM -0500, Suman Anna wrote: > We will gain a user from OMAP remoteproc driver as well (out of tree at > the moment, but it does follow the DT phandle and > omap_dm_timer_request_by_node semantics). I do not think ir-rx51.c is > converted to DT, and also some of

Re: [PATCHv3 0/2] Add support for tps65217 charger

2015-09-24 Thread Sebastian Reichel
Hi, On Thu, Sep 24, 2015 at 09:44:19PM +0200, Enric Balletbo i Serra wrote: > The following series add initial support for tps65217 battery charger. Thanks, queued. -- Sebastian signature.asc Description: Digital signature

Re: [PATCHv2 2/2] power_supply: Add support for tps65217-charger.

2015-09-24 Thread Sebastian Reichel
Hi, On Thu, Sep 24, 2015 at 09:23:25AM +0200, Enric Balletbo i Serra wrote: > This patch adds support for the tps65217 charger driver. This driver is > responsible for controlling the charger aspect of the tps65217 mfd. > Currently, this mainly consists of turning on and off the charger, but > som

Re: [PATCH 2/3] power_supply: Add support for tps65217-charger.

2015-09-22 Thread Sebastian Reichel
Hi, On Tue, Sep 08, 2015 at 10:09:38AM +0200, Enric Balletbo i Serra wrote: > This patch adds support for the tps65217 charger driver. This driver is > responsible for controlling the charger aspect of the tps65217 mfd. > Currently, this mainly consists of turning on and off the charger, but > som

Re: [PATCH 3/3] mfd: Add battery charger as subdevice to the tps65217.

2015-09-22 Thread Sebastian Reichel
Hi, On Tue, Sep 22, 2015 at 09:43:50AM +0200, Enric Balletbo Serra wrote: > 2015-09-20 6:19 GMT+02:00 Lee Jones : > > On Tue, 08 Sep 2015, Enric Balletbo i Serra wrote: > > > >> Add tps65217 battery charger subdevice. > >> > >> Signed-off-by: Enric Balletbo i Serra > >> --- > >> drivers/mfd/tps6

Re: [PATCH 03/13] twl4030_charger: correctly handle -EPROBE_DEFER from devm_usb_get_phy_by_node

2015-09-10 Thread Sebastian Reichel
Hi, On Thu, Sep 10, 2015 at 10:08:50AM +0200, Sebastian Reichel wrote: > > Probably best that Sebastian does it as there's another fix needed > > too. It seems the following are needed: > > > > - Revert $subject patch 3fc3895e4fe1 ("twl4030_charger: correct

Re: [PATCH 03/13] twl4030_charger: correctly handle -EPROBE_DEFER from devm_usb_get_phy_by_node

2015-09-10 Thread Sebastian Reichel
Hi, On Tue, Sep 08, 2015 at 01:14:17PM -0700, Tony Lindgren wrote: > * Kevin Hilman [150908 11:36]: > > On Wed, Sep 2, 2015 at 6:07 AM, Tony Lindgren wrote: > > > * Neil Brown [150901 23:23]: > > >> Kevin Hilman writes: > > >> > > >> > ping... this boot failure has now landed in mainline > > >

Re: [PATCH 07/13] twl4030_charger: distinguish between USB current and 'AC' current

2015-08-06 Thread Sebastian Reichel
Hi, This actually slipped through my review. IMHO madc should be accessed through IIO, as already done for twl4030-madc-battery and rx51-battery. That way the custom API can be removed at some point. Anyway, I queued the below patch with Tony's ACK to fix the build issue in next. On Fri, Aug 07,

Re: [PATCH 00/13] Enhance twl4030_charger functionality. - V3

2015-08-04 Thread Sebastian Reichel
Hi, On Thu, Jul 30, 2015 at 10:11:24AM +1000, NeilBrown wrote: > Following is most of my twl4030_charger patches, rebased against > git://git.infradead.org/battery-2.6 > > Since the previous set I have added the conversion to > module_platform_driver so EPROBE_DEFER can be used, and fixed > a fe

Re: linux 4.2-rc1 broken Nokia N900

2015-07-28 Thread Sebastian Reichel
Hi Pali, On Tue, Jul 28, 2015 at 10:39:32AM +0200, Pali Rohár wrote: > Sebastian or Michael: Can you add check for pm_runtime_get_sync() > function and send patch for including in mainline kernel? This actually already happened before your Tested-By. I accidently did not CC you, sorry for that:

Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-27 Thread Sebastian Reichel
Hi Ben, On Mon, Jul 27, 2015 at 10:59:56AM +0100, Ben Dooks wrote: > > I think you missed the part adding the !ARCH_MULTIPLATFORM > > dependency in Kconfig for ARM_ERRATA_430973. I only removed the > > check in the sourcecode, since it is no longer required with the > > dependency being in Kcon

Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-26 Thread Sebastian Reichel
Hi, On Sun, Jul 26, 2015 at 11:51:45PM +0100, Russell King - ARM Linux wrote: > On Fri, Jul 24, 2015 at 02:16:06AM +0200, Sebastian Reichel wrote: > > On Thu, Jul 23, 2015 at 01:35:53PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebas

Re: [PATCH 00/14] Enhance twl4030_charger functionality. - V2

2015-07-24 Thread Sebastian Reichel
Hi Neil, On Mon, Mar 23, 2015 at 10:20:28AM +1100, NeilBrown wrote: > here is V2 of my patches to improve the twl4030 charger. > They include improved documentation and removal of changes > to the CVENAC bit which I didn't properly understand. I rebased and queued patches 1 and 2. Can you rebase

Re: [PATCH 02/14] twl4030_charger: use devres for power_supply_register and kzalloc.

2015-07-24 Thread Sebastian Reichel
Hi, On Mon, Mar 23, 2015 at 10:20:28AM +1100, NeilBrown wrote: > From: NeilBrown > > Final allocations/registrations are now managed by devres. > > Signed-off-by: NeilBrown Thanks for the patch, rebased to current master and queued with Pavel's ACK: http://git.infradead.org/battery-2.6.git/c

Re: [PATCH 01/14] twl4030_charger: use devm_request_threaded_irq

2015-07-24 Thread Sebastian Reichel
Hi, On Mon, Mar 23, 2015 at 10:20:28AM +1100, NeilBrown wrote: > From: NeilBrown > > This simplifies the error paths. > > Signed-off-by: NeilBrown I queued this with Pavel's ACK after a rebase to current master: http://git.infradead.org/battery-2.6.git/commit/1b7cac23419e1398eac4c28368da6671

Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-23 Thread Sebastian Reichel
Hi Russel, On Thu, Jul 23, 2015 at 01:35:53PM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebastian Reichel wrote: > > Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results > > in one option less to think about when configu

[PATCH 1/3] ARM: OMAP2+: N900: always enable IBE bit

2015-07-22 Thread Sebastian Reichel
900. Until e748994f5cc5, the flush at context switch required CONFIG_ARM_ERRATA_430973, so the same check has been used for setting the IBE bit. Since all sold N900s are assumed to be affected, the guard can be removed now, so that the IBE bit is always set. Signed-off-by: Sebastian Reichel ---

[PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-22 Thread Sebastian Reichel
Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results in one option less to think about when configuring the kernel. Signed-off-by: Sebastian Reichel --- arch/arm/Kconfig | 1 + arch/arm/mm/proc-v7.S | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH 2/3] ARM: update errata 430973 documentation

2015-07-22 Thread Sebastian Reichel
The Errata 430973 workaround config option only enables the IBE bit, which should be done by the bootloader if possible. Signed-off-by: Sebastian Reichel --- arch/arm/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 1c50210..0e4929b

[PATCH 0/3] Another Errata 430973 Update

2015-07-22 Thread Sebastian Reichel
t two patches update the errata's Kconfig entry, so that it's no longer shown for multiplatform kernels and informs about the bootloader method. -- Sebastian Sebastian Reichel (3): ARM: OMAP2+: N900: always enable IBE bit ARM: update errata 430973 documentation ARM: erra

[PATCH 2/5] Input: tsc2005 - fix Kconfig indentation

2015-07-22 Thread Sebastian Reichel
Replace spaces with tab, so that the tsc2005 Kconfig entry matches the other entries in drivers/input/touchscreen/Kconfig. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen

[PATCH 3/5] Input: tsc2005 - convert to regmap

2015-07-22 Thread Sebastian Reichel
Convert driver, so that it uses regmap instead of directly using spi_transfer for all register accesses. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/Kconfig | 1 + drivers/input/touchscreen/tsc2005.c | 171 +--- 2 files changed, 60

[PATCH 1/5] Input: tsc2005 - improve readability of register defines

2015-07-22 Thread Sebastian Reichel
Improve defines for first control byte by removing 0x00 prefix (the defines are for 8 bit values and not for 16 bit values) and expose register structure by exposing the shift. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/tsc2005.c | 28 ++-- 1 file

[PATCH 5/5] Input: tsc2005 - convert to gpiod

2015-07-22 Thread Sebastian Reichel
the patch fixes the after-probe reset GPIO state, so that the device is not kept in reset state. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/tsc2005.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/input

[PATCH 4/5] Input: tsc2005 - simplify drvdata acquisition

2015-07-22 Thread Sebastian Reichel
Using dev_*_drvdata() instead of spi_*_drvdata() reduces lines of code and prepares the driver for possible tsc2004 support, which is i2c based. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/tsc2005.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff

[PATCH 0/5] [input] tsc2005 cleanup

2015-07-22 Thread Sebastian Reichel
on regmap writes, since it has also been used before the regmap conversion. [0] http://permalink.gmane.org/gmane.linux.kernel.input/37513 [1] https://lkml.org/lkml/2015/7/15/500 -- Sebastian Sebastian Reichel (5): Input: tsc2005 - improve readability of register defines Input: tsc2005 - f

[PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-07-22 Thread Sebastian Reichel
: e5823018 e5902188 e5922000 e582302c (e592302c) [ 14.307403] ---[ end trace d21553dcaefcb5ac ]--- Reported-By: Pali Rohár Fixes: ddcad7e9068eb (spi: omap2-mcspi: Fix native cs with new set_cs) Tested-By: Pavel Machek Signed-off-by: Sebastian Reichel --- Hi Mark, Previous discussion about

Re: linux 4.2-rc1 broken Nokia N900

2015-07-22 Thread Sebastian Reichel
Hi, On Wed, Jul 22, 2015 at 09:27:32AM +0200, Pali Rohár wrote: > > > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c > > > index 5867384..f7d9ffd 100644 > > > --- a/drivers/spi/spi-omap2-mcspi.c > > > +++ b/drivers/spi/spi-omap2-mcspi.c > > > @@ -245,6 +245,7 @@ static

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Sebastian Reichel
Hi, On Tue, Jul 21, 2015 at 07:17:41PM -0500, Michael Welling wrote: > On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: > > This code has my head spinning. > > I found that the errors do not occur when the driver is built into the kernel. > > I also found that with the patch below

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-17 Thread Sebastian Reichel
Hi, To get a chance of this patch being considered for inclusion, you should send this to the maintainers of the phy and iio framework. There is a high chance, that none of them will see your mail. On Thu, Jul 16, 2015 at 03:20:27PM -0700, Adam YH Lee wrote: > MADC[3:6] reads incorrect values wit

Re: [PATCH 0/2] Drop two more omap3 legacy board files for v4.3 merge window

2015-07-17 Thread Sebastian Reichel
Hi, On Thu, Jul 16, 2015 at 04:59:09AM -0700, Tony Lindgren wrote: > I think we can drop these now. This just leaves n900 and ldp with > n900 pending patches for legacy proc support. So I guess n900 board file removal depends on the atag procfs support in DT. What's the problem with ldp? Its DT f

Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod

2015-07-16 Thread Sebastian Reichel
On Wed, Jul 15, 2015 at 05:25:32PM -0700, Dmitry Torokhov wrote: > On Thu, Jul 16, 2015 at 12:09:41AM +0200, Sebastian Reichel wrote: > > On Wed, Jul 15, 2015 at 02:34:04PM -0700, Dmitry Torokhov wrote: > > > [...] > > > > if (np) { > >

Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod

2015-07-15 Thread Sebastian Reichel
Hi, On Wed, Jul 15, 2015 at 02:34:04PM -0700, Dmitry Torokhov wrote: > [...] > > if (np) { > > - ts->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0); > > - if (ts->reset_gpio == -EPROBE_DEFER) > > - return ts->reset_gpio; > > - if (ts->reset

Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition

2015-07-15 Thread Sebastian Reichel
Hi, On Wed, Jul 15, 2015 at 02:31:07PM -0700, Dmitry Torokhov wrote: > On Wed, Jul 15, 2015 at 02:13:27PM +0200, Sebastian Reichel wrote: > > Do not convert device to spi_device just for getting > > the driver data, since spi_get_drvdata() just calls > > dev_get_drvdata(). &g

Re: [PATCH 2/4] Input: tsc2005 - convert to regmap

2015-07-15 Thread Sebastian Reichel
Hi Dmitry, On Wed, Jul 15, 2015 at 02:29:55PM -0700, Dmitry Torokhov wrote: > I also got: > > CC [M] drivers/input/touchscreen/tsc2005.o > Building modules, stage 2. > Kernel: arch/x86/boot/bzImage is ready (#1383) > MODPOST 1403 modules > ERROR: "devm_regmap_init_spi" [drivers/input/touc

[PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition

2015-07-15 Thread Sebastian Reichel
Do not convert device to spi_device just for getting the driver data, since spi_get_drvdata() just calls dev_get_drvdata(). Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/tsc2005.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/input

[PATCH 2/4] Input: tsc2005 - convert to regmap

2015-07-15 Thread Sebastian Reichel
Convert driver, so that it uses regmap instead of directly using spi_transfer for all register accesses. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/tsc2005.c | 170 1 file changed, 58 insertions(+), 112 deletions(-) diff --git a/drivers

[PATCH 1/4] Input: tsc2005 - improve readability of register defines

2015-07-15 Thread Sebastian Reichel
Improve defines for first control byte by removing 0x00 prefix (the defines are for 8 bit values and not for 16 bit values) and expose register structure by exposing the shift. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/tsc2005.c | 28 ++-- 1 file

[PATCH 4/4] Input: tsc2005 - convert to gpiod

2015-07-15 Thread Sebastian Reichel
Convert driver to descriptor based GPIO API. Also fix the after-probe reset GPIO state, so that the device is not kept in reset state. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/tsc2005.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff

[PATCH 0/4] [input] tsc2005 cleanup

2015-07-15 Thread Sebastian Reichel
-- Sebastian Sebastian Reichel (4): Input: tsc2005 - improve readability of register defines Input: tsc2005 - convert to regmap Input: tsc2005 - simplify drvdata acquisition Input: tsc2005 - convert to gpiod drivers/input/touchscreen/tsc2005.c | 235 ++-- 1

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Sebastian Reichel
Hi, On Mon, Jul 13, 2015 at 06:05:47PM +0200, Pali Rohár wrote: > now I'm testing 4.2-rc2 release and rtc is working: > > [ 27.426055] omap_i2c 48072000.i2c: controller timed out > [ 28.723358] twl_rtc 4807.i2c:twl@48:rtc: Power up reset detected. > [ 30.127014] twl_rtc 4807.i2c:twl

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Sebastian Reichel
Hi, On Sat, Jul 11, 2015 at 02:05:05PM +0200, Pali Rohár wrote: > now I tested 4.2-rc1 release on Nokia N900 and couple of drivers are > broken and cause kernel oops... > > Basically wifi, touchscreen and rtc drivers not working... I just tried 4.2-rc2 and I can't see any of the problems you hav

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Sebastian Reichel
[+cc Michael Welling , author of all omap-spi patches between 4.1 and 4.2-rc1] Hi, On Sun, Jul 12, 2015 at 11:44:25PM -0700, Tony Lindgren wrote: > * Pali Rohár [150711 05:07]: > > Hello, > > > > now I tested 4.2-rc1 release on Nokia N900 and couple of drivers are > > broken and cause kernel o

Re: rx51-battery.ko incompatiblity: board code vs DT

2015-07-07 Thread Sebastian Reichel
Hi, On Mon, Jul 06, 2015 at 09:44:22PM +0200, Pali Rohár wrote: > now I found out that rx51-battery.ko driver register sysnode > /sys/class/power_supply/rx51-battery/ when booting with legacy board > code. But when booting DT kernel it register sysnode with different name > /sys/class/power_sup

[PATCH] Input: of_touchscreen - remove interdependence of max/fuzz values

2015-05-29 Thread Sebastian Reichel
be used for the unspecified value. Reported-By: Pavel Machek Fixes: 3eea8b5d68c8 (Input: of_touchscreen - rework the DT parsing function) Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/of_touchscreen.c | 25 +++-- 1 file changed, 11 insertions(+), 14

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Sebastian Reichel
reen-fuzz-pressure = <2>; > - touchscreen-max-x = <4096>; > - touchscreen-max-y = <4096>; > + touchscreen-size-x = <4096>; > + touchscreen-size-y = <4096>; > touchscreen-max-pressure = <2048>; > >

Re: [PATCHv2 4/4] DTS: ARM: OMAP3-N900: Add lis3lv02d support

2015-05-20 Thread Sebastian Reichel
Hi, On Wed, May 20, 2015 at 10:21:22AM -0700, Tony Lindgren wrote: > * Sebastian Reichel [150514 15:41]: > > On Fri, Mar 27, 2015 at 03:39:46PM +0100, Sebastian Reichel wrote: > > > This adds support for the N900's accelerometer to > > > the Nokia N900 DTS

Re: ARM errata 430973 on multi platform kernels

2015-04-17 Thread Sebastian Reichel
On Thu, Apr 16, 2015 at 09:08:58AM -0700, Tony Lindgren wrote: > * Sebastian Reichel [150415 09:32]: > > Hi, > > > > On Thu, Apr 09, 2015 at 02:48:43PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Apr 09, 2015 at 12:06:58AM +0100, Russell King - ARM Linux

Re: ARM errata 430973 on multi platform kernels

2015-04-15 Thread Sebastian Reichel
Hi, On Thu, Apr 09, 2015 at 02:48:43PM +0100, Russell King - ARM Linux wrote: > On Thu, Apr 09, 2015 at 12:06:58AM +0100, Russell King - ARM Linux wrote: > > On Tue, Apr 07, 2015 at 08:22:08AM -0700, Tony Lindgren wrote: > > > Works for me. The above needs the following fix folded in to build: > >

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Sebastian Reichel
On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: > On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: > > On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: > > > [...] > > > +#include > > > +#include > > > [...] >

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Sebastian Reichel
Hi, On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: > [...] > +#include > +#include > [...] This should probably be #include #include -- Sebastian signature.asc Description: Digital signature

Re: ARM errata 430973 on multi platform kernels

2015-04-06 Thread Sebastian Reichel
Hi, On Mon, Apr 06, 2015 at 07:23:13PM -0700, Tony Lindgren wrote: > I'm now thinking the kernel should just always set the 430973 specific > cpu_v7_switch_mm for all cortex-a8 if IBE bit is set. That avoids > the whole mess of early SoC detection and smc calls. And if IBE bit > is not set, then w

Re: [PATCH v4 6/6] power: twl4030_madc_battery: Add missing MODULE_ALIAS

2015-04-06 Thread Sebastian Reichel
Hi, On Tue, Mar 10, 2015 at 10:27:27PM +0100, Marek Belisko wrote: > Without MODULE_ALIAS twl4030_madc_battery won't get loaded > automatically. Thanks, pulled. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v4 1/6] power: twl4030-madc-battery: Convert to iio consumer.

2015-04-06 Thread Sebastian Reichel
Hi, On Tue, Mar 10, 2015 at 10:27:22PM +0100, Marek Belisko wrote: > Because of added iio error handling private data allocation was > converted to managed to simplify code. Thanks, pulled (only PATCH 1/6 for now). -- Sebastian signature.asc Description: Digital signature

Re: ARM errata 430973 on multi platform kernels (was: OMAP3-N900: Add microphone bias voltages)

2015-04-06 Thread Sebastian Reichel
Hi, On Sun, Apr 05, 2015 at 03:52:10PM +0200, Pali Rohár wrote: > > So I suggest to enable the IBE bit in the kernel (that part is > > already done) *and* in u-boot. > > > > -- Sebastian > > Yes. Code for both (U-Boot and linux kernel) exists and are > already included. > > In linux kernel cod

Re: ARM errata 430973 on multi platform kernels (was: OMAP3-N900: Add microphone bias voltages)

2015-04-05 Thread Sebastian Reichel
Hi, On Sun, Apr 05, 2015 at 03:26:14PM +0200, Pali Rohár wrote: > > > > Yes so it seems, and the bootloaders should really set it. > > > > It's also disabled for multiplatform builds. > > > > > > These are now done in u-boot as of: v2015.04-rc4 > > > > > > http://git.denx.de/?p=u-boot.git;a=comm

Re: ARM errata 430973 on multi platform kernels

2015-04-05 Thread Sebastian Reichel
Hi, On Sun, Apr 05, 2015 at 06:13:47AM +0200, Matthijs van Duin wrote: > On 4 April 2015 at 00:52, Tony Lindgren wrote: > > Right, it affects n900 for sure. My point is that it also seems to > > affect 37xx versions not listed to suffer from this issue. > > They shouldn't... erratum 430973 only

Re: ARM errata 430973 on multi platform kernels (was: OMAP3-N900: Add microphone bias voltages)

2015-04-05 Thread Sebastian Reichel
On Fri, Apr 03, 2015 at 02:21:48PM -0500, Robert Nelson wrote: > >> And yes, for armhf userland one gets random oopses at least on the > >> Nokia N900. AFAIK this is not true for all ARMv7 processors > >> (especially non omaps), though. > >> > >> > http://www.spinics.net/lists/linux-omap/msg108511.

ARM errata 430973 on multi platform kernels (was: OMAP3-N900: Add microphone bias voltages)

2015-04-03 Thread Sebastian Reichel
Hi, On Wed, Apr 01, 2015 at 12:47:36PM -0700, Tony Lindgren wrote: > > > OK I think debian is using v3.16 kernel > > > > Yes. It will be used for Debian jessie (not yet released) and the > > N900 related drivers are enabled in the armmp flavour. Unfortunately > > it does not work together with th

Re: [PATCHv4] media: i2c/adp1653: devicetree support for adp1653

2015-04-03 Thread Sebastian Reichel
Hi, On Fri, Apr 03, 2015 at 10:49:12AM +0200, Javier Martinez Canillas wrote: > >> The convention nowadays is to not use unnamed DT properties for GPIOs > >> but instead use a prefix that explains what those GPIOs are used for. > >> So something like "power-gpios" or "power-gpio" (if there is only

Re: [PATCHv3 0/2] N900 Modem Speech Support

2015-03-31 Thread Sebastian Reichel
Hi, On Sat, Mar 21, 2015 at 08:09:15PM +0100, Sebastian Reichel wrote: > This patchset contains the missing speech data support for the > Nokia N900 modem. > > [...] > > HSI: cmt_speech: Add cmt-speech driver > HSI: nokia-modem: Add cmt-speech support > >

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-31 Thread Sebastian Reichel
Hi, On Mon, Mar 30, 2015 at 10:50:52AM -0700, Tony Lindgren wrote: > * Jarkko Nikula [150330 10:46]: > > Well, there has been regression but finding exactly how far should the > > fix go didn't look instantly straightforward due all DT, codec driver > > mic bias etc changes and I ended up not cc'

Re: [PATCH 1/1] omap3isp: Don't pass uninitialised arguments to of_graph_get_next_endpoint()

2015-03-30 Thread Sebastian Reichel
Hi, On Tue, Mar 31, 2015 at 02:13:28AM +0300, Sakari Ailus wrote: > isp_of_parse_nodes() passed an uninitialised prev argument to > of_graph_get_next_endpoint(). This is bad, fix it by assigning NULL to it in > the initialisation. > > Signed-off-by: Sakari Ailus > Reported-by:

[PATCHv2] arm: dts: omap3: Add #iommu-cells to isp and iva iommu

2015-03-30 Thread Sebastian Reichel
-cells for /ocp/mmu@480bd400 Signed-off-by: Sebastian Reichel Cc: Sakari Ailus Cc: Laurent Pinchart --- Changes since PATCHv1: * Also add property to mmu_iva --- arch/arm/boot/dts/omap3.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts

[PATCH] arm: dts: omap3: Add #iommu-cells to isp iommu

2015-03-30 Thread Sebastian Reichel
t get #iommu-cells for /ocp/mmu@480bd400 Signed-off-by: Sebastian Reichel Cc: Sakari Ailus Cc: Laurent Pinchart --- arch/arm/boot/dts/omap3.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index fe0b293..77751ef 100644 --- a

Re: [PATCH v2 14/15] omap3isp: Add support for the Device Tree

2015-03-30 Thread Sebastian Reichel
Hi, The code crashed for me on Nokia N900. I found the following problem: On Thu, Mar 26, 2015 at 12:57:38AM +0200, Sakari Ailus wrote: > [...] > +static int isp_of_parse_nodes(struct device *dev, > + struct v4l2_async_notifier *notifier) > +{ > + struct device_node

Re: [PATCHv3 0/2] N900 Modem Speech Support

2015-03-21 Thread Sebastian Reichel
Hi, On Sat, Mar 21, 2015 at 08:09:15PM +0100, Sebastian Reichel wrote: > [1] git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git > branch/cmt-speech-2 This should actually be: git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git branch/cmt-speech-3 -- Seb

[PATCHv2 4/4] DTS: ARM: OMAP3-N900: Add lis3lv02d support

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel This adds support for the N900's accelerometer to the Nokia N900 DTS file. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/omap3-n900.dts | 52 1 file changed, 52 insertions(+) diff --git a/arch/arm/boot/dts/omap3

[PATCHv2 1/4] lis3lv02d: DT: use s32 to support negative values

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel st,axis-{x,y,z} can be negative to imply inverted axis. Apart from that the minimal and maximal threshold may be negative. Signed-off-by: Sebastian Reichel --- drivers/misc/lis3lv02d/lis3lv02d.c | 39 +++--- 1 file changed, 20

[PATCHv2 3/4] Documentation: DT: lis302: update wakeup binding

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel This updated the documentation of the DT binding to describe the added wakeup threshold and second wakeup engine. It also adds a note, that the axis values may be negative. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/misc/lis302.txt | 9

[PATCHv2 2/4] lis3lv02d: DT: add wakeup unit 2 and wakeup threshold

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel This adds support for the the wakeup threshold and support for the second wakeup unit to the DT based setup. Signed-off-by: Sebastian Reichel --- drivers/misc/lis3lv02d/lis3lv02d.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/misc

[PATCHv2 0/4] lis3lv02d: update DT binding for use with Nokia N900

2015-03-21 Thread Sebastian Reichel
on of second wakeup unit and wakeup threshold support. The series is based on top of v4.0-rc1 and has been tested on my Nokia N900. [0] Documentation/devicetree/bindings/misc/lis302.txt -- Sebastian Sebastian Reichel (4): lis3lv02d: DT: use s32 to support negative values lis3lv02d: DT: add wakeup

[PATCHv3 1/2] HSI: cmt_speech: Add cmt-speech driver

2015-03-21 Thread Sebastian Reichel
om DT) Signed-off-by: Sebastian Reichel --- drivers/hsi/clients/Kconfig | 10 + drivers/hsi/clients/Makefile |1 + drivers/hsi/clients/cmt_speech.c | 1456 ++ include/uapi/linux/hsi/Kbuild|2 +- include/uapi/linux/hsi/cs-proto

[PATCHv3 2/2] HSI: nokia-modem: Add cmt-speech support

2015-03-21 Thread Sebastian Reichel
Register cmt-speech driver in nokia-modem driver and forward hsi channel information. Signed-off-by: Sebastian Reichel --- drivers/hsi/clients/Kconfig | 2 +- drivers/hsi/clients/nokia-modem.c | 32 +++- 2 files changed, 32 insertions(+), 2 deletions(-) diff

[PATCHv3 0/2] N900 Modem Speech Support

2015-03-21 Thread Sebastian Reichel
82 [3] https://lkml.org/lkml/2015/3/4/1139 -- Sebastian Kai Vehmanen (1): HSI: cmt_speech: Add cmt-speech driver Sebastian Reichel (1): HSI: nokia-modem: Add cmt-speech support drivers/hsi/clients/Kconfig | 12 +- drivers/hsi/clients/Makefile |1 + drivers/hsi/clients/

Re: [PATCH 3/3] ARM: omap2plus_defconfig: Enable n900 modem as loadable modules

2015-03-17 Thread Sebastian Reichel
Hi Tony, On Mon, Mar 16, 2015 at 01:00:03PM -0700, Tony Lindgren wrote: > Enable n900 modem as loadable modules. Acked-By: Sebastian Reichel > [...] > +CONFIG_HSI_CHAR=m > [...] I think this one should be disabled by default. It's only needed by very few people (it expos

Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data

2015-03-16 Thread Sebastian Reichel
Hi, On Mon, Mar 16, 2015 at 08:29:39AM -0700, Tony Lindgren wrote: > * Arnd Bergmann [150315 05:10]: > > On Sunday 15 March 2015 10:50:42 Eliad Peller wrote: > > > yeah, i missed it :/ > > > > > > looks like there's no platform that defines platform data for it. > > > i'll replace the dev_get_pl

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-12 Thread Sebastian Reichel
Hi, On Wed, Mar 11, 2015 at 10:43:17AM -0700, Tony Lindgren wrote: > No no, "capacity-uah" is what we should use, but you need an ack from > the battery and device tree people that this is OK. Let's not add > "ti,capacity-uah” as that can obviously be a generic property. I'm okay with capacity-ua

Re: twl4030_charger: need changes to get probed?

2015-03-09 Thread Sebastian Reichel
Hi, On Mon, Mar 09, 2015 at 11:06:53AM +1100, NeilBrown wrote: > On Sat, 7 Mar 2015 22:01:02 +0100 Sebastian Reichel wrote: > > platform_driver_probe() does not support deferred probing. > > > > Neil, can you take this patch into your series for the next round? > >

Re: twl4030_charger: need changes to get probed?

2015-03-07 Thread Sebastian Reichel
Hi, On Fri, Mar 06, 2015 at 10:24:17PM +0100, Pavel Machek wrote: > According to n900 dts, twl4030-bci (aka charger) should be > included. its part of twl, but not used on N900 afaik. > (But it does not seem to do anything useful on n900. I was hoping for > measurement of input voltage, but .. n

Re: [PATCH 09/15] twl4030_charger: allow max_current to be managed via sysfs.

2015-03-07 Thread Sebastian Reichel
Hi, On Thu, Mar 05, 2015 at 05:26:00PM +1100, NeilBrown wrote: > [...] > +What: /sys/class/power_supply/twl4030_ac/max_current > + /sys/class/power_supply/twl4030_usb/max_current > +Description: > + Read/Write limit on current which which may > + be drawn from the ac (Accessory Ch

Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-07 Thread Sebastian Reichel
Hi Pavel, On Wed, Mar 04, 2015 at 11:24:15AM +0100, Pavel Machek wrote: > (Now I'd need to study the datasheets... and figure out how to enable > this on N900). The N900 uses bq24150a for charging ;) -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 03/15] twl4030_charger: use devres for power_supply_register and kzalloc.

2015-03-07 Thread Sebastian Reichel
Hi, On Tue, Feb 24, 2015 at 03:33:50PM +1100, NeilBrown wrote: > [...] > @@ -667,13 +667,6 @@ static int __init twl4030_bci_probe(struct > platform_device *pdev) > return 0; > > fail: > - power_supply_unregister(&bci->usb); > -fail_register_usb: > - power_supply_unregister(&bci->

  1   2   3   4   5   6   >