Re: [PATCH] DSPBRIDGE: Fix error handling in NODE_GetUUIDProps

2009-03-23 Thread Seth Forshee
On Mon, Mar 23, 2009 at 03:15:07PM +0200, Ameya Palande wrote: From: Seth Forshee seth.fors...@gmail.com The error handling is ineffective and can lead to an oops. Acked-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Seth Forshee seth.fors...@gmail.com Ah, hadn't seen this one

Re: [PATCH] DSPBRIDGE: Fix error handling in NODE_GetUUIDProps

2009-03-23 Thread Seth Forshee
On Mon, Mar 23, 2009 at 09:38:47AM -0500, Seth Forshee wrote: On Mon, Mar 23, 2009 at 03:15:07PM +0200, Ameya Palande wrote: From: Seth Forshee seth.fors...@gmail.com The error handling is ineffective and can lead to an oops. Acked-by: Ameya Palande ameya.pala...@nokia.com Signed

AUTO_EXTVOLT on OMAP2430

2008-10-19 Thread Seth Forshee
I'm working with what basically amounts to an older version of the linux-omap kernel with substantial modifications. I found that in some situations I was getting about 4 mA more current draw during suspend than at other times. This was ultimately being caused by some of the code that runs in

[PATCH] ARM: OMAP: Fix MMC2 device configuration for OMAP2430

2008-04-24 Thread Seth Forshee
Currently the MMC2 device configuration is defined for OMAP2430 when CONFIG_ARCH_OMAP243X is defined. This should be CONFIG_ARCH_OMAP2430. Signed-off-by: Seth Forshee [EMAIL PROTECTED] --- arch/arm/plat-omap/devices.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

PRCM_CLKSRC_CTRL bits set incorrectly in omap2_en_osc_ck

2008-04-24 Thread Seth Forshee
() is to blame. If this is the case, the patch below fixes the problem. -- From: Seth Forshee [EMAIL PROTECTED] Subject: [PATCH] ARM: OMAP2: Set PRCM_CLKSRC_CTRL correctly in omap2_enable_osc_ck This patch fixes an incorrect use of prm_rmw_reg_bits() in omap2_enable_osc_ck() which is changing

Re: [RFC/PATH] OMAP: HSMMC: Fixes for 1.8V MMC2 interface

2008-04-01 Thread Seth Forshee
On Tue, Apr 01, 2008 at 08:44:47PM +0530, Madhusudhan Chikkature Rajashekar wrote: Hi, I did not see any board level code to power up the second slot along with this patch. Where is the code that enables 1.8V to the second slot? I am working with a custom board that isn't supported in the

Re: [RFC/PATH] OMAP: HSMMC: Fixes for 1.8V MMC2 interface

2008-03-31 Thread Seth Forshee
On Mon, Mar 31, 2008 at 11:45:21PM +0300, Francisco Alecrim wrote: Hello Seth, It's fine and work for 3430! Maybe you should resend changing the commit message. It's too big. Remove RFC from subject. What do you think? if(changes) Acked-by: Francisco Alecrim [EMAIL PROTECTED]

[PATCH] OMAP: HSMMC: Fix 1.8V MMC2 host on OMAP2430/3430

2008-03-31 Thread Seth Forshee
OMAP2430/3430 contain an 1.8V-only MMC2 host that is not properly supported by the current driver. This patch contains changes to correctly set up this host. Signed-off-by: Seth Forshee [EMAIL PROTECTED] Acked-by: Francisco Alecrim [EMAIL PROTECTED] --- drivers/mmc/host/omap_hsmmc.c | 32

[PATCH] I2C: Fix OMAP I2C status register handling in IRQ processing

2008-03-12 Thread Seth Forshee
The IRQ handler in omap-i2c.c can sometimes clear status bits without actually processing them. In particular, error status bits will be ignored if any of the ARDY, RRDY, RDR, XRDY, or XDR bits are concurrently set. Signed-off-by: Seth Forshee [EMAIL PROTECTED] --- More information: I

Re: [PATCH] I2C: Fix OMAP I2C status register handling in IRQ processing

2008-03-12 Thread Seth Forshee
On Wed, Mar 12, 2008 at 01:14:32PM -0500, Felipe Balbi wrote: - int count = 0; + int err, count = 0; int err = 0, count = 0; will be better and you avoid that err=0 before using err right below. No, the err = 0 I added is in a while loop. It needs to be reinitialized for each