[PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check

2010-11-26 Thread Vasiliy Kulikov
clk_get() returns ERR_PTR() on error, not NULL. Signed-off-by: Vasiliy Kulikov --- Cannot compile this driver, so it is not tested at all. arch/arm/plat-omap/counter_32k.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm

[PATCH] arm: mach-omap2: potential NULL dereference

2011-01-17 Thread Vasiliy Kulikov
If kzalloc() failed, return -ENOMEM. sr_dev_init() should signal by return value that there is an error. Signed-off-by: Vasiliy Kulikov --- Cannot compile this driver, so it is not tested at all. arch/arm/mach-omap2/sr_device.c | 19 +++ 1 files changed, 15 insertions(+), 4

[PATCH] arm: mach-omap2: potential NULL dereference

2011-01-17 Thread Vasiliy Kulikov
kzalloc() may fail, if so return -ENOMEM. Signed-off-by: Vasiliy Kulikov --- Cannot compile this driver, so it is not tested at all. arch/arm/mach-omap2/smartreflex.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach

[PATCH v2] arm: mach-omap2: potential NULL dereference

2011-01-19 Thread Vasiliy Kulikov
kzalloc() may fail, if so return -ENOMEM. Also Walter Harms suggested to use kasprintf() instead of kzalloc+strcpy+strcat. Signed-off-by: Vasiliy Kulikov --- Cannot compile this driver, so it is not tested at all. arch/arm/mach-omap2/smartreflex.c |8 +--- 1 files changed, 5

[PATCH 01/20] mach-omap2: mux: world-writable debugfs files

2011-02-04 Thread Vasiliy Kulikov
Do not create mux debugfs files as world-writable. Signed-off-by: Vasiliy Kulikov --- Cannot compile the driver, so it is not tested at all. arch/arm/mach-omap2/mux.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2

[PATCH 02/20] mach-omap2: pm: world-writable debugfs timer files

2011-02-04 Thread Vasiliy Kulikov
Don't allow all users to change timer settings. Signed-off-by: Vasiliy Kulikov --- Cannot compile the driver, so it is not tested at all. arch/arm/mach-omap2/pm-debug.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/pm-debug.c b/arc

[PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs voltage files

2011-02-04 Thread Vasiliy Kulikov
Don't allow everybody to change voltage settings. Signed-off-by: Vasiliy Kulikov --- Cannot compile the driver, so it is not tested at all. arch/arm/mach-omap2/smartreflex.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b

[PATCH 00/20] world-writable files in sysfs and debugfs

2011-02-04 Thread Vasiliy Kulikov
le is ./staging/speakup/speakup.h, but it explitly calls macros as world-writable. I didn't check what speakup's world-writable files provide because it requires some knowledge about the hardware. Vasiliy Kulikov (20): mach-omap2: mux: world-writable debugfs files mach-omap2: pm:

Re: [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-12 Thread Vasiliy Kulikov
> Vasiliy Kulikov (20): >  mach-ux500: mbox-db5500: world-writable sysfs fifo file >  leds: lp5521: world-writable sysfs engine* files >  leds: lp5523: world-writable engine* sysfs files >  misc: ep93xx_pwm: world-writable sysfs files >  rtc: rtc-ds1511: world-writable sysfs

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread Vasiliy Kulikov
enient for him. If sysfs is implemented via filesystem then it must support POSIX permissions semantic. MAC is very good in _some_ cases, but not instead of DAC. Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments -- To unsubscribe from thi