Re: [PATCH] dmaengine: edma: Add probe callback to edma_tptc_driver

On Wed, Dec 16, 2015 at 03:19:05PM +0200, Peter Ujfalusi wrote: > Due to changes in device and platform code drivers w/o probe will fail to > load. This means that the devices for eDMA TPTCs are goign to be without > driver and omap hwmod code will turn them off after the kernel finished >

Re: [PATCH V03 0/5] dmaengine: New 'universal' API for requesting channel

On Mon, Dec 14, 2015 at 10:47:37PM +0200, Peter Ujfalusi wrote: > Hi, > > As it has been discussed in the following thread: > http://www.gossamer-threads.com/lists/linux/kernel/2181487#2181487 > > With this series I have taken a path which would result two new API, which can > be used to convert

Re: [PATCH v02 0/2] ARM: DTS: am33xx/am437x: Use the new eDMA bindings

On Thu, Dec 17, 2015 at 09:48:44AM -0800, Tony Lindgren wrote: > * Peter Ujfalusi [151217 05:33]: > > Hi, > > > > Changes since v1: > > - Updated to use the non 16bit arrays [1] > > - send the two patch as a series > > > > [1] > > As it has been discussed earlier: > >

Re: [PATCH for 4.4 0/2] DT/dmaengine: edma: Convert 16bit arrays to 32bit

On Wed, Dec 09, 2015 at 12:12:27PM -0800, Tony Lindgren wrote: > * Peter Ujfalusi [151209 00:19]: > > Hi, > > > > Based on the discussion regarding to (convert am33xx to use the new eDMA > > bindings): > >

Re: [PATCH 0/4] dmaengine: omap-dma: transfer start and short memcpy improvement

On Wed, Nov 11, 2015 at 12:37:54PM +0200, Peter Ujfalusi wrote: > Hi, > > The first two patch is trivial fix. > The third (remove the tasklet use for starting the transfer): > I had been wondering about this for a while and now I was able to spend some > time to look at this in more detail. > In

Re: [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel

On Mon, Nov 30, 2015 at 03:45:30PM +0200, Peter Ujfalusi wrote: > Hi, > > Changes since RFC v01: > - dma_request_chan(); lost the mask parameter > - The new API does not rely on RESOURCE_DMA, instead the dma_filter_map table > will be used to provide the needed information to the filter

Re: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()

On Tue, Dec 01, 2015 at 02:58:35PM +0200, Andy Shevchenko wrote: > On Tue, Dec 1, 2015 at 11:47 AM, Peter Ujfalusi wrote: > > On 11/30/2015 04:35 PM, Andy Shevchenko wrote: > >> On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi > >> wrote: > >>> Treat

Re: [RFC v02 04/15] dmaengine: edma: Add support for DMA filter mapping to slave devices

On Mon, Nov 30, 2015 at 03:45:34PM +0200, Peter Ujfalusi wrote: > Add support for providing device to filter_fn mapping so client drivers > can switch to use the dma_request_chan() API. Any reason why we dont want to go with DT based only for edma here? > > Signed-off-by: Peter Ujfalusi

Re: [RFC v02 04/15] dmaengine: edma: Add support for DMA filter mapping to slave devices

On Tue, Dec 01, 2015 at 09:20:28PM +0100, Arnd Bergmann wrote: > On Tuesday 01 December 2015 22:52:12 Vinod Koul wrote: > > On Mon, Nov 30, 2015 at 03:45:34PM +0200, Peter Ujfalusi wrote: > > > Add support for providing device to filter_fn mapping so client drivers >

Re: [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel

On Tue, Dec 01, 2015 at 09:17:06PM +0100, Arnd Bergmann wrote: > On Tuesday 01 December 2015 22:29:54 Vinod Koul wrote: > > On Mon, Nov 30, 2015 at 03:45:30PM +0200, Peter Ujfalusi wrote: > > > channel via DT, ACPI or in case if the kernel booted in non DT/ACPI mode > >

Re: [PATCH v2 0/3] dmaengine: ti-dma-crossbar: channel reserving and edma3-tpcc support

On Fri, Oct 30, 2015 at 10:00:35AM +0200, Peter Ujfalusi wrote: > Hi, > > Changes since v1: > - Fixed issue introduced by the bitops patch: wrong error check, also switch > to > use find_first_zero_bit() instead of find_next_zero_bit() > > Cover letter: > > This series depends on the eDMA

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Wed, Nov 18, 2015 at 04:51:54PM +0100, Arnd Bergmann wrote: > On Wednesday 18 November 2015 17:43:04 Andy Shevchenko wrote: > > > > > > I assume that the sst-firmware.c case is a mistake, it should just use a > > > plain DMA_SLAVE and not DMA_MEMCPY. > > > > Other way around. > > > > Ok, I

Re: [PATCH] dmaengine: edma: fix build without CONFIG_OF

On Tue, Nov 03, 2015 at 03:00:57PM +0100, Arnd Bergmann wrote: > During the edma rework, a build error was introduced for the > case that CONFIG_OF is disabled: > > drivers/built-in.o: In function `edma_tc_set_pm_state': > :(.text+0x43bf0): undefined reference to `of_find_device_by_node' > > As

Re: [PATCH] dmaengine: edma: Add dummy driver skeleton for edma3-tptc

On Wed, Nov 04, 2015 at 10:33:27AM -0600, Felipe Balbi wrote: > Peter Ujfalusi writes: > > > The eDMA3 TPTC does not need any software configuration, but it is a > > separate IP block in the SoC. In order the omap hwmod core to be able to > > handle the TPTC resources

Re: [PATCH v2 13/14] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3

On Mon, Nov 02, 2015 at 05:46:05PM +0200, Peter Ujfalusi wrote: > > Okay I have reverted the two and applied the edma patch sent, can you please > > verify topic/edma_fix before I merge it and send my PULL request. > > The branch looks good. Thank you! > It would have been great if the DTS

Re: [PATCH v2 13/14] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3

On Mon, Nov 02, 2015 at 02:13:01PM +0200, Peter Ujfalusi wrote: > Vinod, > > On 11/02/2015 12:04 PM, Vinod Koul wrote: > > On Mon, Nov 02, 2015 at 01:21:19AM -0800, Olof Johansson wrote: > >> Hi, > >> > >> 1) This seems to have broken BBB in -next

Re: [PATCH v2 13/14] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3

On Mon, Nov 02, 2015 at 01:21:19AM -0800, Olof Johansson wrote: > Hi, > > 1) This seems to have broken BBB in -next for me, bisected down to this patch. > > For bootlog: > http://arm-soc.lixom.net/bootlogs/next/next-20151102/bbb-arm-omap2plus_defconfig.html > > 2) Please avoid merging

Re: [PATCH] ARM: OMAP: hwmod: AM33xx/43xx: Add HWMOD_INIT_NO_IDLE flag to tptc

On Mon, Nov 02, 2015 at 12:11:00PM +0200, Peter Ujfalusi wrote: > In Linux we do not have driver for TPTCs of eDMA3 since there is no need to > do any configuration within TPTC for the eDMA3 to be operational. All > configuration is via the TPCC. > To prevent the omap_device_late_idle() to disable

Re: [PATCH v2 00/14] dmaenigne: edma/ti-crossbar: fixes, new bindings

On Fri, Oct 16, 2015 at 10:17:58AM +0300, Peter Ujfalusi wrote: > Hi, > > Changes since v1: > - Comments in the memcpy optimization patch extended > - The crossbar patch has been improved: > - debug prints changed > - fallback xbar parameters now type specific as the fallback values for DRA7 >

Re: [PATCH 10/13] dmaengine: ti-dma-crossbar: Add support for crossbar on AM33xx/AM43xx

On Wed, Oct 14, 2015 at 04:12:21PM +0300, Peter Ujfalusi wrote: > The DMA event crossbar on AM33xx/AM43xx is different from the one found in > DRA7x family. > Instead of a single event crossbar it has 64 identical mux attached to each > eDMA event line. When the 0 event mux is selected, the

Re: [PATCH 02/13] dmaengine: edma: Optimize memcpy operation

On Wed, Oct 14, 2015 at 04:12:13PM +0300, Peter Ujfalusi wrote: > @@ -1320,41 +1317,92 @@ static struct dma_async_tx_descriptor > *edma_prep_dma_memcpy( > struct dma_chan *chan, dma_addr_t dest, dma_addr_t src, > size_t len, unsigned long tx_flags) > { > - int ret; > + int

Re: [PATCH v5 00/24] dmaengine/ARM: Merge the edma drivers into one

On Wed, Oct 14, 2015 at 02:42:42PM +0300, Peter Ujfalusi wrote: > Hi, > > Cover letter: > > with this series the edma two driver setup will be changed to have only one > driver to support eDMA3. The legacy edma interface will be removed and eDMA > can > only be used via dmaengine API from this

Re: [PATCH v4 20/25] dmaengine: edma: Simplify the interrupt handling

On Thu, Sep 24, 2015 at 01:02:07PM +0300, Peter Ujfalusi wrote: > + if (edesc->cyclic) { > + vchan_cyclic_callback(>vdesc); > + spin_unlock(>vchan.lock); > + return; > + } else if (edesc->processed == edesc->pset_nr) { > + dev_dbg(dev,

Re: [PATCH v4 00/25] dmaengine/ARM: Merge the edma drivers into one

On Thu, Sep 24, 2015 at 01:01:47PM +0300, Peter Ujfalusi wrote: > Hi, > > Cover letter: > > with this series the edma two driver setup will be changed to have only one > driver to support eDMA3. The legacy edma interface will be removed and eDMA > can > only be used via dmaengine API from this

Re: [PATCH 02/13] dmaengine: edma: Optimize memcpy operation

On Wed, Oct 14, 2015 at 06:02:18PM +0300, Peter Ujfalusi wrote: > On 10/14/2015 05:41 PM, Vinod Koul wrote: > > On Wed, Oct 14, 2015 at 04:12:13PM +0300, Peter Ujfalusi wrote: > >> @@ -1320,41 +1317,92 @@ static struct dma_async_tx_descriptor > >> *edma_prep_dma_memc

Re: [PATCH v4 11/25] ARM/dmaengine: edma: Merge the two drivers under drivers/dma/

On Thu, Sep 24, 2015 at 01:01:58PM +0300, Peter Ujfalusi wrote: > Move the code out from arch/arm/common and merge it inside of the dmaengine > driver. > This change is done with as minimal change to the code as possible to avoid > any possibilities to introducing regression. Is this a pure move

Re: [PATCH] dmaengine: omap-dma: Enable packed accesses for cyclic transfers

On Mon, Sep 14, 2015 at 03:31:05PM +0300, Peter Ujfalusi wrote: > From: Misael Lopez Cruz > > The L3 throughput can be higher than expected when packed access > is not enabled. The ratio depends on the number of bytes in a > transaction and the EMIF interface width. > >

Re: [PATCH 2/3] dma: add __must_check annotation for dmaengine_pause()

On Tue, Aug 11, 2015 at 02:34:29PM +0200, Sebastian Andrzej Siewior wrote: On 08/11/2015 12:06 PM, Russell King - ARM Linux wrote: I think what people need to learn is that an API in the kernel which returns an int _can_ fail - it returns an int so it _can_ return an error code. If it

Re: [PATCH 1/3] tty: serial: 8250_omap: do not use RX DMA if pause is not supported

On Sat, Aug 08, 2015 at 10:03:43AM +0100, Russell King - ARM Linux wrote: On Fri, Aug 07, 2015 at 08:28:57PM -0400, Peter Hurley wrote: Even dma_get_slave_caps() returns _true_ for cmd_pause support; ok, that interface is pointless. How about reporting that as a bug then, because if you

Re: [PATCH 2/3] dma: add __must_check annotation for dmaengine_pause()

On Fri, Aug 07, 2015 at 10:00:18PM +0200, Sebastian Andrzej Siewior wrote: In 8250-omap I learned it the hard way that ignoring the return code of dmaengine_pause() might be bad because the underlying DMA driver might not support the function at all and so not doing what one is expecting.

Re: [PATCH v3 0/2] dmaengine: ti-dma-crossbar: Support for eDMA

On Wed, Jul 22, 2015 at 11:48:08AM +0300, Peter Ujfalusi wrote: Hi Vinod, Strange, for me the v2 series applied cleanly on top of rc1, but to be safe I have generated this series on top of 4.2-rc3 Applied now, thanks -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 0/2] dmaengine: ti-dma-crossbar: Support for eDMA

On Fri, Jul 03, 2015 at 05:10:46PM +0300, Peter Ujfalusi wrote: On 07/02/2015 06:56 PM, Vinod Koul wrote: On Wed, Jul 01, 2015 at 03:41:26PM +0300, Peter Ujfalusi wrote: Hi, On 06/08/2015 04:22 PM, Peter Ujfalusi wrote: Hi, Changes since v01: - Drop change in compatible

Re: [PATCH v2 0/2] dmaengine: ti-dma-crossbar: Support for eDMA

On Wed, Jul 01, 2015 at 03:41:26PM +0300, Peter Ujfalusi wrote: Hi, On 06/08/2015 04:22 PM, Peter Ujfalusi wrote: Hi, Changes since v01: - Drop change in compatible for the crossbar driver and do the configuration based on the DT structure. The ti-dma-crossbar driver in it's

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Mon, Jun 22, 2015 at 02:31:00PM +0300, Peter Ujfalusi wrote: On 06/12/2015 03:58 PM, Vinod Koul wrote: Sorry this slipped thru I was away for a week anyways ;) Thinking about it again, I think we should coverge to two APIs and mark the legacy depracuated and look to convert folks

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Thu, Jun 04, 2015 at 06:58:06PM +0300, Peter Ujfalusi wrote: Vinod, On 06/02/2015 03:55 PM, Vinod Koul wrote: On Fri, May 29, 2015 at 05:32:50PM +0300, Peter Ujfalusi wrote: On 05/29/2015 01:18 PM, Vinod Koul wrote: On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Fri, May 29, 2015 at 05:32:50PM +0300, Peter Ujfalusi wrote: On 05/29/2015 01:18 PM, Vinod Koul wrote: On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: On Fri, May 29, 2015 at 11:33 AM, Vinod Koul vinod.k...@intel.com wrote: On Tue, May 26, 2015 at 04:25:57PM +0300

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote: dma_request_slave_channel_compat() 'eats' up the returned error codes which prevents drivers using the compat call to be able to do deferred probing. The new wrapper is identical in functionality but it will return with error

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: On Fri, May 29, 2015 at 11:33 AM, Vinod Koul vinod.k...@intel.com wrote: On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote: dma_request_slave_channel_compat() 'eats' up the returned error codes which prevents

Re: [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback

On Mon, Mar 23, 2015 at 09:35:01PM +0100, Petr Kulhavy wrote: The data parameter passed indirectly to the edma_callback() should be edma_chan and not the dma_chan. This bug was so far harmless since the offset of struct dma_chan within struct edma_chan is 0. However as soon as someone

Re: [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer

On Fri, Mar 27, 2015 at 01:35:52PM +0200, Peter Ujfalusi wrote: In omap_dma_start_desc the vdesc-node is removed from the virt-dma framework managed lists (to be precise from the desc_issued list). If a terminate_all comes before the transfer finishes the omap_desc will not be freed up because

Re: [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers

On Fri, Mar 27, 2015 at 01:35:51PM +0200, Peter Ujfalusi wrote: From: Petr Kulhavy p...@barix.com If edma_terminate_all() was called while a transfer was running (i.e. after edma_execute() but before edma_callback()) the echan-edesc was not freed. This was due to the fact that a running

Re: [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

On Fri, Mar 27, 2015 at 02:25:29PM +0200, Peter Ujfalusi wrote: On 03/26/2015 05:32 PM, Vinod Koul wrote: I have added the DT binding document since this series adds support for routers for platforms booting with DT: Documentation/devicetree/bindings/dma/dma.txt | 28 I meant

Re: [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

On Wed, Mar 11, 2015 at 03:23:24PM +0200, Peter Ujfalusi wrote: DMA routers are transparent devices used to mux DMA requests from peripherals to DMA controllers. They are used when the SoC integrates more devices with DMA requests then their controller can handle. DRA7x is one example of such

Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count

On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote: Instead of magic numbers in the code, use define for number of logical DMA channels and DMA requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 7 +-- 1 file changed, 5

Re: [PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x

On Wed, Mar 11, 2015 at 03:23:26PM +0200, Peter Ujfalusi wrote: The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific sDMA request.

Re: [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

On Thu, Mar 26, 2015 at 02:11:38PM +0200, Peter Ujfalusi wrote: On 03/26/2015 12:50 PM, Vinod Koul wrote: On Wed, Mar 11, 2015 at 03:23:24PM +0200, Peter Ujfalusi wrote: DMA routers are transparent devices used to mux DMA requests from peripherals to DMA controllers. They are used when

Re: [PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x

On Thu, Mar 26, 2015 at 02:31:30PM +0200, Peter Ujfalusi wrote: On 03/26/2015 12:56 PM, Vinod Koul wrote: +#define TI_XBAR_OUTPUTS 127 +#define TI_XBAR_INPUTS256 Ideally this should be moved to DT. Will next revision of this chip always support these output and inputs

Re: [PATCH] dma: cppi41: add missing directions bitfield

On Wed, Feb 25, 2015 at 04:54:02PM -0600, Felipe Balbi wrote: Without those we will see a kernel WARN() when loading musb on am335x devices. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/dma/cppi41.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/cppi41.c

Re: [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file

On Thu, Nov 27, 2014 at 12:41:31PM +0200, Peter Ujfalusi wrote: include/linux/platform_data/ is not a correct place to keep the API definitions for edma, it is meant to be only for the pdata for the device. Clean up this by moving the API to include/linux/edma.h Signed-off-by: Peter Ujfalusi

Re: [PATCH 09/13] dmaengine: edma: check for echan-edesc = NULL in edma_dma_pause()

On Mon, Sep 29, 2014 at 08:06:45PM +0200, Sebastian Andrzej Siewior wrote: I added book keeping of whether or not the 8250-dma driver has an RX transfer pending or not so we don't BUG here if it calls dmaengine_pause() on a channel which has not a pending transfer. Guess what, this is not

Re: [PATCH 09/13] dmaengine: edma: check for echan-edesc = NULL in edma_dma_pause()

On Mon, Sep 29, 2014 at 08:06:45PM +0200, Sebastian Andrzej Siewior wrote: I added book keeping of whether or not the 8250-dma driver has an RX transfer pending or not so we don't BUG here if it calls dmaengine_pause() on a channel which has not a pending transfer. Guess what, this is not

Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

On Wed, Sep 24, 2014 at 10:28:07PM +0200, Rafael J. Wysocki wrote: OK, I guess this is as good as it gets. What tree would you like it go through? Since rest of the patches are dependent upon 1st patch which should go thru your tree, we should merge this thru your tree Thanks -- ~Vinod

[PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

replacements. If all are okay, this should be merged thru PM tree as it depends on macro addition. Subhransu S. Prusty (1): PM: Add helper pm_runtime_last_busy_and_autosuspend() Vinod Koul (26): dmaengine: ste_dma: use pm_runtime_last_busy_and_autosuspend helper extcon: arizona: use

[PATCH 09/27] i2c: omap: use pm_runtime_last_busy_and_autosuspend helper

Use the new pm_runtime_last_busy_and_autosuspend helper instead of open coding the same code Signed-off-by: Vinod Koul vinod.k...@intel.com --- drivers/i2c/busses/i2c-omap.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c

[PATCH 26/27] usb: musb: omap2430: use pm_runtime_last_busy_and_autosuspend helper

Use the new pm_runtime_last_busy_and_autosuspend helper instead of open coding the same code Signed-off-by: Vinod Koul vinod.k...@intel.com --- drivers/usb/musb/omap2430.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb

[PATCH 16/27] mmc: omap_hsmmc: use pm_runtime_last_busy_and_autosuspend helper

Use the new pm_runtime_last_busy_and_autosuspend helper instead of open coding the same code This patch also changes return value from macro rather than 0 always! Signed-off-by: Vinod Koul vinod.k...@intel.com --- drivers/mmc/host/omap_hsmmc.c | 19 --- 1 files changed, 4

Re: [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume

On Tue, Sep 16, 2014 at 10:45:55PM +0300, Peter Ujfalusi wrote: Hi, Changes since v2: - fix typo in patch two - Acked-by added from Russell When the audio is paused/resumed (application paused the sream or board suspend) the audio was only playing back one period worth of data and then

Re: [PATCH 1/7] dmaengine: edma: fix two faults which happen with the 8250_dma user

On Thu, Aug 21, 2014 at 03:09:12PM +0200, Sebastian Andrzej Siewior wrote: On 08/19/2014 05:12 PM, Vinod Koul wrote: desc = dmaengine_prep_slave_single(rxchan, …); rx_cookie = dmaengine_submit(desc); dma_async_issue_pending(rxchan); ssleep(2); /* Now assume

Re: [PATCH 1/7] dmaengine: edma: fix two faults which happen with the 8250_dma user

On Fri, Aug 08, 2014 at 06:29:50PM +0200, Sebastian Andrzej Siewior wrote: * Vinod Koul | 2014-07-31 17:47:02 [+0530]: On Tue, Jul 29, 2014 at 08:58:58PM +0200, Sebastian Andrzej Siewior wrote: The rx path of the 8250_dma user in the RX-timeout case: - it starts the RX transfer

Re: [PATCH 1/2] dmaengine: edma: Do not change the error code returned from edma_alloc_slot

On Thu, Jul 31, 2014 at 01:12:37PM +0300, Peter Ujfalusi wrote: In case of edma_alloc_slot() failure during probe we should return the error unchanged to make debugging easier. Applied both Thanks -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 1/7] dmaengine: edma: fix two faults which happen with the 8250_dma user

. terminate_all(() needs to do a proper cleanup of the channel And this looks a series, without cover letter sent to all. Which makes it a bit hard to see what is getting done -- ~Vinod Cc: Joel Fernandes jo...@ti.com Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi

Re: [PATCH 0/2] dma: edma: Allow to disable eDMA IRQ during cyclic transfer

On Wed, Jul 16, 2014 at 03:29:19PM +0300, Peter Ujfalusi wrote: Hi, After this series clients can ask to not receive notifications after each period. In this case we can disable the completion interrupt since the position reporting does not rely on it for cyclic mode. Patchset for ASoC

Re: [PATCH 0/3] ARM/dma: edma: Serve cyclic clients via high priority queue

On Tue, Jul 08, 2014 at 01:46:35PM +0300, Peter Ujfalusi wrote: Hi, It is preferred that audio is served with the highest priority queue in order to avoid delays in data transfer between memory and audio IP. The following series will add an API to arch code to assign a channel to a

Re: [PATCH v3 00/13] ARM/DT: edma: IP configuration from hardware and cleanups

On Tue, May 20, 2014 at 04:26:09PM +0530, Sekhar Nori wrote: On Monday 19 May 2014 10:23 PM, Peter Ujfalusi wrote: On 05/19/2014 04:06 PM, Sekhar Nori wrote: On Friday 16 May 2014 05:47 PM, Peter Ujfalusi wrote: Hi, Changes since v2: - Comments from Sekhar and Arnd has been addressed

Re: [RESEND] dmaengine: edma: Add channel number to debug prints

On Thu, Apr 24, 2014 at 10:29:50AM +0300, Peter Ujfalusi wrote: It helps to identify issues if we have some information regarding to the channel which the event is associated. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Acked-by: Joel Fernandes jo...@ti.com Applied, thanks --

Re: [patch V2 0/6] dma: edma: Provide granular residue accounting

On Mon, Apr 28, 2014 at 03:47:37PM -0500, Joel Fernandes wrote: On 04/28/2014 05:49 AM, Thomas Gleixner wrote: A simpler version to provide granular residue accounting and readout for EDMA. Delta to V1: - Removed the double read of the address in PaRAM - Simplified

Re: [patch V2 0/6] dma: edma: Provide granular residue accounting

On Tue, Apr 29, 2014 at 11:25:02PM -0500, Joel Fernandes wrote: On 04/29/2014 03:46 AM, Vinod Koul wrote: [..] commit 770f0f3a20188b7e17db2790803b9da925dc0b94 Author: Thomas Gleixner t...@linutronix.de Date: Mon Apr 28 10:49:43 2014 + dmaengine: edma: Make reading

Re: [PATCH] dmaengine: edma: No need save/restore interrupt flags during spin_lock in IRQ

On Thu, Apr 17, 2014 at 12:58:33AM -0500, Joel Fernandes wrote: The vchan lock in edma_callback is acquired in hard interrupt context. As interrupts are already disabled, there's no point in save/restoring interrupt mask bit or cpsr flags. Get rid of flags local variable and use spin_lock

Re: [PATCH v3 00/10] dma: edma: Fixes for cyclic (audio) operation

On Mon, Apr 14, 2014 at 02:41:55PM +0300, Peter Ujfalusi wrote: Hi, Changes since v2: - Dropped patch 10 from v2 (simplify direction configuration...) - Dropped the channel priority related patches since we are going to go via different route for configuring the priority. - Added ACK

Re: [PATCH] dmaengine: edma: Add DMA memcpy support

On Fri, Apr 18, 2014 at 09:50:33PM -0500, Joel Fernandes wrote: We add DMA memcpy support to EDMA driver. Successful tests performed using dmatest kernel module. Copy alignment is set to DMA_SLAVE_BUSWIDTH_4_BYTES and users must ensure length is aligned so that copy is performed fully.

Re: [PATCH] [FIX] dmaengine: virt-dma: Free descriptor after callback

On Fri, Apr 18, 2014 at 11:34:50AM -0500, Joel Fernandes wrote: On 04/18/2014 03:50 AM, Russell King - ARM Linux wrote: On Thu, Apr 17, 2014 at 07:56:50PM -0500, Joel Fernandes wrote: Free the vd (virt descriptor) after the callback is called. In EDMA driver atleast which uses virt-dma, we

Re: [PATCH 1/1] dma: edma: fix incorrect SG list handling

On Mon, Apr 14, 2014 at 02:01:11PM +0530, Sekhar Nori wrote: Vinod, On Wednesday 19 March 2014 11:25 AM, Sekhar Nori wrote: The code to handle any length SG lists calls edma_resume() even before edma_start() is called. This is incorrect because edma_resume() enables edma events on the

Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

On Fri, Apr 11, 2014 at 12:38:00PM +0300, Peter Ujfalusi wrote: On 04/11/2014 11:56 AM, Sekhar Nori wrote: On Friday 11 April 2014 02:20 PM, Peter Ujfalusi wrote: On 04/11/2014 11:17 AM, Sekhar Nori wrote: On Tuesday 01 April 2014 06:36 PM, Peter Ujfalusi wrote: Use the EVENTQ_1 for

Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

On Fri, Apr 11, 2014 at 02:32:28PM +0300, Peter Ujfalusi wrote: Hi Vinod, On 04/11/2014 12:42 PM, Vinod Koul wrote: On Fri, Apr 11, 2014 at 12:38:00PM +0300, Peter Ujfalusi wrote: On 04/11/2014 11:56 AM, Sekhar Nori wrote: On Friday 11 April 2014 02:20 PM, Peter Ujfalusi wrote: On 04

Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

On Fri, Apr 11, 2014 at 03:23:54PM +0300, Peter Ujfalusi wrote: On 04/11/2014 02:31 PM, Vinod Koul wrote: I would say that it is channel based config. I don't see the reason why would one mix different priorities on a configured channel between descriptors. If not then we can add

Re: [PATCH v2 03/14] dma: edma: Add support for DMA_PAUSE/RESUME operation

On Tue, Apr 01, 2014 at 04:06:04PM +0300, Peter Ujfalusi wrote: Pause/Resume can be used by the audio stack when the stream is paused/resumed The edma platform code has support for this and the legacy audio stack used this. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

Re: [PATCH v2 08/14] DMA: edma: Use different eventq for cyclic channels

On Thu, Apr 10, 2014 at 11:36:30AM -0500, Joel Fernandes wrote: On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: To improve latency with cyclic DMA operation it is preferred to use different eventq/tc than the default which is used by all other drivers (mmc, spi, i2c, etc). When preparing

Re: [PATCH v2 00/14] dma: edma: Fixes for cyclic (audio) operation

On Tue, Apr 01, 2014 at 04:06:01PM +0300, Peter Ujfalusi wrote: Hi, This is basically a resend of the previous series: https://lkml.org/lkml/2014/3/13/119 with removed ASoC patches (most of them are applied already). Changes since v1: - ASoC patches removed - Comments from Andriy

Re: [PATCH 00/26] OMAP dma engine rework

On Sat, Mar 29, 2014 at 06:13:06PM +, Russell King - ARM Linux wrote: On Tue, Mar 18, 2014 at 09:18:45PM +0530, Vinod Koul wrote: On Mon, Feb 10, 2014 at 09:25:31PM +0530, Russell King - ARM Linux wrote: This is the current set of patches for the OMAP DMA engine rework, which should

Re: [PATCH] dma: omap-dma: Implement device_slave_caps callback

On Fri, Mar 07, 2014 at 03:36:44PM +0200, Peter Ujfalusi wrote: With the callback implemented omap-dma can provide information to client drivers regarding to supported address widths, directions, residue granularity, etc. Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the

Re: [PATCH 00/26] OMAP dma engine rework

On Mon, Feb 10, 2014 at 09:25:31PM +0530, Russell King - ARM Linux wrote: This is the current set of patches for the OMAP DMA engine rework, which should now work correctly on OMAP1 platforms thanks to Tony's testing. It would be good to get this validated by others across a range of OMAP

Re: [PATCH RFC 00/26] Migrate more OMAP DMA code to DMA engine

On Thu, Jan 02, 2014 at 03:08:36PM +, Russell King - ARM Linux wrote: The following patch series moves code to setup the DMA hardware and service interrupts from the hardware to the DMA engine driver. This reduces the dependency on the legacy DMA implementation. Didnt the code getting

Re: cppi41: pending patches

On Tue, Oct 22, 2013 at 12:14:02PM +0200, Sebastian Andrzej Siewior wrote: Hi Vinod, this series contains patches which are floating on the mainling list so I hope it is easier to collect them. It contains two of Daniel's which were not yet applied and two of mine. The patch redo descriptor

Re: [PATCH v2] dma: edma: Add support for Cyclic DMA

On Thu, Oct 31, 2013 at 04:31:23PM -0500, Joel Fernandes wrote: Using the PaRAM configuration function that we split for reuse by the different DMA types, we implement Cyclic DMA support. For the cyclic case, we pass different configuration parameters to this function, and handle all the

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

On Thu, Oct 24, 2013 at 12:57:02PM -0500, Joel Fernandes wrote: Rebased on slave-dma/next branch and reapplied: Looks like your MUA caused lines to get wrapped and patch is corrupt, can you pls resend again using git-send email. I tried even the patch from patchworks but that too failed!

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

On Tue, Oct 22, 2013 at 10:30:43AM -0500, Joel Fernandes wrote: On 10/21/2013 01:53 AM, Vinod Koul wrote: On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote: + nr_periods = (buf_len / period_len) + 1; ? consider the case of buf = period_len, above makes nr_period = 2

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote: @@ -449,6 +455,138 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( return vchan_tx_prep(echan-vchan, edesc-vdesc, tx_flags); } +static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( + struct

Re: [PATCH 1/3] dma: edma: Split out PaRAM set calculations into its own function

On Mon, Sep 23, 2013 at 06:05:13PM -0500, Joel Fernandes wrote: PaRAM set calculation is abstracted into its own function to enable better reuse for other DMA cases such as cyclic. We adapt the Slave SG case to use the new function. This provides a much cleaner abstraction to the internals

Re: [PATCH 3/3] dma: edma: Increase maximum SG limit to 20

On Mon, Sep 23, 2013 at 06:05:15PM -0500, Joel Fernandes wrote: davinci-pcm uses 16 as the no.of periods. With this, in EDMA we have to allocate atleast 17 slots: 1 slot for channel, and 16 slots the periods. Due to this, the MAX_NR_SG limitation causes problems, set it to 20 to make cyclic

Re: [PATCH v3 5/5] dma: cppi41: add support for suspend and resume

On Mon, Sep 23, 2013 at 07:53:11AM +0200, Daniel Mack wrote: On 23.09.2013 06:09, Vinod Koul wrote: On Sun, Sep 22, 2013 at 04:50:04PM +0200, Daniel Mack wrote: +#ifdef CONFIG_PM_SLEEP a +static int cppi41_suspend(struct device *dev) +{ + struct cppi41_dd *cdd

Re: [PATCH v3 5/5] dma: cppi41: add support for suspend and resume

On Sun, Sep 22, 2013 at 04:50:04PM +0200, Daniel Mack wrote: This patch adds support for suspend/resume functionality to the cppi41 DMA driver. The steps necessary to make the system resume properly were figured out by trial-and-error. The code as it stands now is the minimum that has to be

Re: [alsa-devel] [PATCH 23/51] DMA-API: dma: pl08x: add dma_set_mask_and_coherent() call

On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote: The DMA API requires drivers to call the appropriate dma_set_mask() functions before doing any DMA mapping. Add this required call to the AMBA PL08x driver. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod Koul vinod.k...@intel.com This also brings me question that should we force the driver to use the dma_set_mask_and_coherent() API or they have below flexiblity too? ~Vinod --- drivers/dma/edma.c |6 ++ 1 files changed

Re: [alsa-devel] [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

doing any DMA mapping. Add this required call to the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 Fixed, thanks. with fixed changelog... Acked-by: Vinod Koul vinod.k...@intel.com ~Vinod -- -- To unsubscribe from this list: send the line

Re: [PATCH v3 4/5] dma: cppi41: only allocate descriptor memory once

On Mon, Sep 23, 2013 at 04:51:06PM +0200, Sebastian Andrzej Siewior wrote: On 09/23/2013 06:17 AM, Vinod Koul wrote: Looks fine, Sebastian cna you test it pls Just noticed that you already applied some of them. I just got back after a few weeks of. Will review test as soon as I get

Re: [PATCH v3 5/5] dma: cppi41: add support for suspend and resume

On Sun, Sep 22, 2013 at 04:50:04PM +0200, Daniel Mack wrote: This patch adds support for suspend/resume functionality to the cppi41 DMA driver. The steps necessary to make the system resume properly were figured out by trial-and-error. The code as it stands now is the minimum that has to be

Re: [PATCH v3 2/5] dma: cppi41: s/deinit_cpii41/deinit_cppi41/

On Sun, Sep 22, 2013 at 04:50:01PM +0200, Daniel Mack wrote: Fix a misspelled function name. Signed-off-by: Daniel Mack zon...@gmail.com Applied, thanks ~Vinod -- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/5] dma: cppi41: pass around device instead of platform_device

On Sun, Sep 22, 2013 at 04:50:00PM +0200, Daniel Mack wrote: Instead of passing around struct plafform_device, use struct device and save one level of dereferencing. This affects the following functions: * cppi41_add_chans * purge_descs * deinit_cpii41 * init_descs * init_cppi41 *

Re: [PATCH v3 3/5] dma: cppi41: add shortcut to pdev-dev in cppi41_dma_probe()

On Sun, Sep 22, 2013 at 04:50:02PM +0200, Daniel Mack wrote: Makes the code more readable and compact. No functional change. Signed-off-by: Daniel Mack zon...@gmail.com Applied, thanks ~Vinod -- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v3 4/5] dma: cppi41: only allocate descriptor memory once

On Sun, Sep 22, 2013 at 04:50:03PM +0200, Daniel Mack wrote: cdd-cd and cdd-descs_phys are allocated DESCS_AREAS times from init_descs() and freed as often from purge_descs(). This leads to both memory leaks and double-frees. Fix this by pulling the calls to dma_{alloc,free}_coherent() out

  1   2   >