Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam Lee
Hi Peter, I sent a V2 with corrected wording. My bad! And yes I agree that register setting should be done in the ADC driver. Let me see what I can do, and will report back. Thanks, Adam On Mon, Jul 20, 2015 at 11:54 AM, Peter Meerwald wrote: > On Mon, 20 Jul 2015, Adam YH Lee wrote: > >> MADC

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Peter Meerwald
On Mon, 20 Jul 2015, Adam YH Lee wrote: > MADC[3:6] reads incorrect values without these two following changes: > > - enable the 3v1 bias regulator for ADC[3:6] > - configure ADC[3:6] lines as input, not as USB comments below > Signed-off-by: Adam YH Lee > --- > drivers/iio/adc/twl4030-madc.

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam Lee
Hello Jonathan, I sent the same patch with linux-iio cc'd. I expanded the cover letter with the quotes from TI's documents, but the text has been removed in the email somehow. The discussion in this thread should be enough (I think) for linux-iio maintainers, so we will see! Thanks, Adam On Mon,

[PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam YH Lee
MADC[3:6] reads incorrect values without these two following changes: - enable the 3v1 bias regulator for ADC[3:6] - configure ADC[3:6] lines as input, not as USB Signed-off-by: Adam YH Lee --- drivers/iio/adc/twl4030-madc.c | 14 ++ drivers/phy/phy-twl4030-usb.c | 7 +++ 2 fi

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Jonathan Cameron
On 20/07/15 18:47, Adam Lee wrote: > Hello, here is some more context from the TPS65950's TRM [1]. > > Quoting from section 15.3.1.2.1 VUSB3V1 section: > > "VUSB3V1 is also used to bias analog multiplexers on the four MCPC > pins between the carkit and the MADC (supplied by VINTANA2)." > >

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam Lee
Hello, here is some more context from the TPS65950's TRM [1]. Quoting from section 15.3.1.2.1 VUSB3V1 section: "VUSB3V1 is also used to bias analog multiplexers on the four MCPC pins between the carkit and the MADC (supplied by VINTANA2)." And from section 15.4.11. MADC Monitoring Using MCP

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-17 Thread Peter Meerwald
Hello, adding linux-iio... > To get a chance of this patch being considered for inclusion, you > should send this to the maintainers of the phy and iio framework. > There is a high chance, that none of them will see your mail. > > On Thu, Jul 16, 2015 at 03:20:27PM -0700, Adam YH Lee wrote: > >

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-17 Thread Sebastian Reichel
Hi, To get a chance of this patch being considered for inclusion, you should send this to the maintainers of the phy and iio framework. There is a high chance, that none of them will see your mail. On Thu, Jul 16, 2015 at 03:20:27PM -0700, Adam YH Lee wrote: > MADC[3:6] reads incorrect values wit

[PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-16 Thread Adam YH Lee
MADC[3:6] reads incorrect values without these two following changes: - enable the 3v1 bias regulator for ADC[3:6] - configure ADC[3:6] lines as input, not as USB Signed-off-by: Adam YH Lee --- drivers/iio/adc/twl4030-madc.c | 14 ++ drivers/phy/phy-twl4030-usb.c | 7 +++ 2 fi