Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-03-16 Thread Tony Lindgren
* Jon Hunter [150212 04:37]: > > On 02/12/2015 11:26 AM, Jon Hunter wrote: > > > > On 02/11/2015 09:14 PM, Tony Lindgren wrote: > >> * Paul Walmsley [150211 13:03]: > >>> On Wed, 11 Feb 2015, Tony Lindgren wrote: > >>> > * Paul Walmsley [150210 18:28]: > > On Tue, 10 Feb 2015, Jon Hun

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-12 Thread Jon Hunter
On 02/12/2015 11:26 AM, Jon Hunter wrote: > > On 02/11/2015 09:14 PM, Tony Lindgren wrote: >> * Paul Walmsley [150211 13:03]: >>> On Wed, 11 Feb 2015, Tony Lindgren wrote: >>> * Paul Walmsley [150210 18:28]: > On Tue, 10 Feb 2015, Jon Hunter wrote: >> On 07/02/2015 00:23, Paul Walm

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-12 Thread Jon Hunter
On 02/11/2015 09:14 PM, Tony Lindgren wrote: > * Paul Walmsley [150211 13:03]: >> On Wed, 11 Feb 2015, Tony Lindgren wrote: >> >>> * Paul Walmsley [150210 18:28]: On Tue, 10 Feb 2015, Jon Hunter wrote: > On 07/02/2015 00:23, Paul Walmsley wrote: > Unfortunately, there is not a

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-11 Thread Tony Lindgren
* Paul Walmsley [150211 13:03]: > On Wed, 11 Feb 2015, Tony Lindgren wrote: > > > * Paul Walmsley [150210 18:28]: > > > On Tue, 10 Feb 2015, Jon Hunter wrote: > > > > On 07/02/2015 00:23, Paul Walmsley wrote: > > > > > > > Unfortunately, there is not a single TRM for the omap5910 but > > > > i

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-11 Thread Tony Lindgren
* Paul Walmsley [150210 18:28]: > On Tue, 10 Feb 2015, Jon Hunter wrote: > > On 07/02/2015 00:23, Paul Walmsley wrote: > > > Unfortunately, there is not a single TRM for the omap5910 but individual > > documents for each chapter in the original TRM. Check out the "OMAP5910 > > Dual-Core Process

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-11 Thread Tony Lindgren
* Jon Hunter [150211 09:43]: > > Thinking about this some more, I don't understand the dependency on the > DM_TIMER here. For an omap1 device, regardless of whether the DM_TIMERs > are enable or not, the device should be able to enter low power if the > 32K is enabled. Hence, shouldn't this have

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-11 Thread Paul Walmsley
On Wed, 11 Feb 2015, Tony Lindgren wrote: > * Paul Walmsley [150210 18:28]: > > On Tue, 10 Feb 2015, Jon Hunter wrote: > > > On 07/02/2015 00:23, Paul Walmsley wrote: > > > > > Unfortunately, there is not a single TRM for the omap5910 but individual > > > documents for each chapter in the origi

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-11 Thread Jon Hunter
Hi Paul, On 02/11/2015 02:25 AM, Paul Walmsley wrote: > Hi John, > > thanks for the review, > > On Tue, 10 Feb 2015, Jon Hunter wrote: [snip] > Subject: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs > > Building an OMAP1510-only Kconfig

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-10 Thread Paul Walmsley
LED(CONFIG_OMAP_32K_TIMER) && > > + IS_ENABLED(CONFIG_OMAP_DM_TIMER) && cpu_is_omap16xx()) { > > Do you need cpu_is_omap16xx() here? I believe DM_TIMER is only available > on omap16xx onwards. Makes sense, I'll drop the cpu_is* test. > > + p

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-10 Thread Jon Hunter
Hi Paul, On 07/02/2015 00:23, Paul Walmsley wrote: > > Building an OMAP1510-only Kconfig generates the following warnings: > > arch/arm/mach-omap1/pm.c: In function ‘omap1_pm_idle’: > arch/arm/mach-omap1/pm.c:123:2: warning: #warning Enable 32kHz OS timer > in order to allow sleep states in idle

[PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-06 Thread Paul Walmsley
Building an OMAP1510-only Kconfig generates the following warnings: arch/arm/mach-omap1/pm.c: In function ‘omap1_pm_idle’: arch/arm/mach-omap1/pm.c:123:2: warning: #warning Enable 32kHz OS timer in order to allow sleep states in idle [-Wcpp] #warning Enable 32kHz OS timer in order to allow slee