Re: [PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary

2012-10-17 Thread Rajendra Nayak
On Thursday 18 October 2012 02:07 AM, Jon Hunter wrote: Ok, thanks. Yes, only updating the register when the cache value changed would not work due to the possibility of context being lost. So Rajendra's change makes sense. However, I think there is room to optimise this. With this change, on id

Re: [PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary

2012-10-17 Thread Jon Hunter
On 10/17/2012 03:58 PM, Paul Walmsley wrote: > On Wed, 17 Oct 2012, Jon Hunter wrote: > >> Are you looking to go one step further and only update the sysconfig on >> enabling when the context has been lost? That would require more >> changes. > > Yes that's exactly it. That would avoid adding a

Re: [PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary

2012-10-17 Thread Paul Walmsley
On Wed, 17 Oct 2012, Jon Hunter wrote: > Are you looking to go one step further and only update the sysconfig on > enabling when the context has been lost? That would require more > changes. Yes that's exactly it. That would avoid adding a special case for what should be the common case. From

Re: [PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary

2012-10-17 Thread Jon Hunter
On 10/17/2012 03:25 PM, Paul Walmsley wrote: > cc Rajendra > > Hi Jon > > On Wed, 17 Oct 2012, Jon Hunter wrote: > >> Currently, whenever we idle a device _idle_sysc() is called and writes to the >> devices SYSCONFIG register to set the idle mode. A lot devices are using the >> smart-idle mode

Re: [PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary

2012-10-17 Thread Paul Walmsley
cc Rajendra Hi Jon On Wed, 17 Oct 2012, Jon Hunter wrote: > Currently, whenever we idle a device _idle_sysc() is called and writes to the > devices SYSCONFIG register to set the idle mode. A lot devices are using the > smart-idle mode and so the write to the SYSCONFIG register is programming the

[PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary

2012-10-17 Thread Jon Hunter
Currently, whenever we idle a device _idle_sysc() is called and writes to the devices SYSCONFIG register to set the idle mode. A lot devices are using the smart-idle mode and so the write to the SYSCONFIG register is programming the same value that is already stored in the register. Writes to the