Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-22 Thread Matt Porter
On Tue, Feb 14, 2012 at 11:08:36AM +, Russell King - ARM Linux wrote: > Two more points: > > On Mon, Feb 13, 2012 at 11:43:42AM -0500, Matt Porter wrote: > > This fixes smsc911x support on platforms using gpmc_smsc911x_init(). > > Commit c7e963f616f04d1f5da0e07bec4e0092f227 added the requi

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-21 Thread Matt Porter
On Tue, Feb 21, 2012 at 10:46:48AM -0800, Tony Lindgren wrote: > * Mark Brown [120213 10:27]: > > On Mon, Feb 13, 2012 at 10:14:10AM -0800, Tony Lindgren wrote: > > > * Russell King - ARM Linux [120213 09:31]: > > > > On Mon, Feb 13, 2012 at 09:52:34AM -0800, Tony Lindgren wrote: > > > > > > > C

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-21 Thread Tony Lindgren
* Mark Brown [120213 10:27]: > On Mon, Feb 13, 2012 at 10:14:10AM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [120213 09:31]: > > > On Mon, Feb 13, 2012 at 09:52:34AM -0800, Tony Lindgren wrote: > > > > > Can't we just leave out the .id and have it automatically assigned? > > It'

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-14 Thread Russell King - ARM Linux
Two more points: On Mon, Feb 13, 2012 at 11:43:42AM -0500, Matt Porter wrote: > This fixes smsc911x support on platforms using gpmc_smsc911x_init(). > Commit c7e963f616f04d1f5da0e07bec4e0092f227 added the requirement Always include the commit summary as well here, so: Commit c7e963f616 (

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Mark Brown
On Mon, Feb 13, 2012 at 10:14:10AM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [120213 09:31]: > > On Mon, Feb 13, 2012 at 09:52:34AM -0800, Tony Lindgren wrote: > > > Can't we just leave out the .id and have it automatically assigned? It'd be nice but... > > Unfortunately, there's

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Matt Porter
On Mon, Feb 13, 2012 at 08:56:18AM -0800, Mark Brown wrote: > On Mon, Feb 13, 2012 at 04:52:09PM +, Russell King - ARM Linux wrote: > > > I think OMAP (or even the reg-fixed-voltage folk) needs to create an enum > > similar to what I did for 8250 to control the allocation of platform > > devic

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Tony Lindgren
* Russell King - ARM Linux [120213 09:31]: > On Mon, Feb 13, 2012 at 09:52:34AM -0800, Tony Lindgren wrote: > > * Mark Brown [120213 08:25]: > > > On Mon, Feb 13, 2012 at 04:52:09PM +, Russell King - ARM Linux wrote: > > > > > > > I think OMAP (or even the reg-fixed-voltage folk) needs to cr

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Russell King - ARM Linux
On Mon, Feb 13, 2012 at 09:52:34AM -0800, Tony Lindgren wrote: > * Mark Brown [120213 08:25]: > > On Mon, Feb 13, 2012 at 04:52:09PM +, Russell King - ARM Linux wrote: > > > > > I think OMAP (or even the reg-fixed-voltage folk) needs to create an enum > > > similar to what I did for 8250 to c

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Tony Lindgren
* Mark Brown [120213 08:25]: > On Mon, Feb 13, 2012 at 04:52:09PM +, Russell King - ARM Linux wrote: > > > I think OMAP (or even the reg-fixed-voltage folk) needs to create an enum > > similar to what I did for 8250 to control the allocation of platform > > device IDs for this, otherwise we'r

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Mark Brown
On Mon, Feb 13, 2012 at 04:52:09PM +, Russell King - ARM Linux wrote: > I think OMAP (or even the reg-fixed-voltage folk) needs to create an enum > similar to what I did for 8250 to control the allocation of platform > device IDs for this, otherwise we're going to keep on running over this > p

Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Russell King - ARM Linux
On Mon, Feb 13, 2012 at 11:43:42AM -0500, Matt Porter wrote: > This fixes smsc911x support on platforms using gpmc_smsc911x_init(). > Commit c7e963f616f04d1f5da0e07bec4e0092f227 added the requirement > that platforms provide vdd33a and vddvario supplies. Thanks. Only one comment on this. > +

[PATCH] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators

2012-02-13 Thread Matt Porter
This fixes smsc911x support on platforms using gpmc_smsc911x_init(). Commit c7e963f616f04d1f5da0e07bec4e0092f227 added the requirement that platforms provide vdd33a and vddvario supplies. Signed-off-by: Matt Porter --- arch/arm/mach-omap2/gpmc-smsc911x.c | 44 ++