Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-15 Thread Tony Lindgren
* Felipe Balbi [110715 01:25]: > > possibly something like this (still missing MACHINE_START a few more > things): Yes and it would be better to initialize data in the .init_machine to avoid adding machine_is tests in multiple places. > diff --git a/arch/arm/mach-omap2/board-omap4panda.c > b/

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-15 Thread Tony Lindgren
* Jan Weitzel [110715 02:42]: > Am Freitag, den 15.07.2011, 00:50 -0700 schrieb Tony Lindgren: > > Well we can add it even before device tree support if it makes > > sense from code coalescing point of view. In this case it would > > mean creating board-panda-common.c or similar so the code can >

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-15 Thread Jan Weitzel
Am Freitag, den 15.07.2011, 00:50 -0700 schrieb Tony Lindgren: > Well we can add it even before device tree support if it makes > sense from code coalescing point of view. In this case it would > mean creating board-panda-common.c or similar so the code can > be shared amongst the panda variants. >

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-15 Thread Felipe Balbi
Hi, On Fri, Jul 15, 2011 at 01:20:12AM -0700, Tony Lindgren wrote: > * Felipe Balbi [110715 00:53]: > > Hi, > > > > On Fri, Jul 15, 2011 at 12:50:24AM -0700, Tony Lindgren wrote: > > > * Jan Weitzel [110714 01:34]: > > > > Am Donnerstag, den 14.07.2011, 00:34 -0700 schrieb Tony Lindgren: > > >

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-15 Thread Tony Lindgren
* Felipe Balbi [110715 00:53]: > Hi, > > On Fri, Jul 15, 2011 at 12:50:24AM -0700, Tony Lindgren wrote: > > * Jan Weitzel [110714 01:34]: > > > Am Donnerstag, den 14.07.2011, 00:34 -0700 schrieb Tony Lindgren: > > > > * Jan Weitzel [110713 05:51]: > > > > > Am Mittwoch, den 13.07.2011, 16:13 +0

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-15 Thread Felipe Balbi
Hi, On Fri, Jul 15, 2011 at 12:50:24AM -0700, Tony Lindgren wrote: > * Jan Weitzel [110714 01:34]: > > Am Donnerstag, den 14.07.2011, 00:34 -0700 schrieb Tony Lindgren: > > > * Jan Weitzel [110713 05:51]: > > > > Am Mittwoch, den 13.07.2011, 16:13 +0400 schrieb Sergei Shtylyov: > > > > > > > >

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-15 Thread Tony Lindgren
* Jan Weitzel [110714 01:34]: > Am Donnerstag, den 14.07.2011, 00:34 -0700 schrieb Tony Lindgren: > > * Jan Weitzel [110713 05:51]: > > > Am Mittwoch, den 13.07.2011, 16:13 +0400 schrieb Sergei Shtylyov: > > > > > > > > > > > Have you added that 'i' at the end intentionally? > > > > > > >

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-14 Thread Jan Weitzel
Am Donnerstag, den 14.07.2011, 00:34 -0700 schrieb Tony Lindgren: > * Jan Weitzel [110713 05:51]: > > Am Mittwoch, den 13.07.2011, 16:13 +0400 schrieb Sergei Shtylyov: > > > > > > > > Have you added that 'i' at the end intentionally? > > > > > Thank you. It was a tribute to vim. > > :i) >

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-14 Thread Tony Lindgren
* Jan Weitzel [110713 05:51]: > Am Mittwoch, den 13.07.2011, 16:13 +0400 schrieb Sergei Shtylyov: > > > > > Have you added that 'i' at the end intentionally? > > > Thank you. It was a tribute to vim. :i) I'll fold the fixed patch into your original patch. Will also keep the new board file

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-13 Thread Jan Weitzel
Am Mittwoch, den 13.07.2011, 16:13 +0400 schrieb Sergei Shtylyov: > > Have you added that 'i' at the end intentionally? > Thank you. It was a tribute to vim. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-13 Thread Sergei Shtylyov
Hello. On 13-07-2011 14:59, Jan Weitzel wrote: vusim is not used. Signed-off-by: Jan Weitzel --- arch/arm/mach-omap2/board-omap4pcm049.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap4pcm049.c b/arch/arm/mach-omap

[PATCH] ARM: OMAP4: PCM049: remove vusim regulator

2011-07-13 Thread Jan Weitzel
vusim is not used. Signed-off-by: Jan Weitzel --- arch/arm/mach-omap2/board-omap4pcm049.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap4pcm049.c b/arch/arm/mach-omap2/board-omap4pcm049.c index ad8cb46..85193ec 100644 ---