Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-25 Thread Turquette, Mike
On Tue, Jan 24, 2012 at 1:53 AM, Cousson, Benoit b-cous...@ti.com wrote: + Mike On 1/19/2012 12:39 AM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@ti.com Assuming that you will re-send with Kevin's comment taken into account, the fix is indeed very valid. Acked-by:

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-25 Thread Paul Walmsley
On Tue, 24 Jan 2012, Ameya Palande wrote: According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines following fields for multiplication and division factors: DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-25 Thread Paul Walmsley
Hi one important question first: On Tue, 24 Jan 2012, Ameya Palande wrote: According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines following fields for multiplication and division factors: DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) DPLL_DIV (bits 7:0) DPLL

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-25 Thread Cousson, Benoit
Hi Paul, On 1/25/2012 8:05 PM, Paul Walmsley wrote: Hi one important question first: On Tue, 24 Jan 2012, Ameya Palande wrote: According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines following fields for multiplication and division factors: DPLL_MULT (bits 19:8) DPLL

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-25 Thread Palande, Ameya
Hi Mike, On Wed, Jan 25, 2012 at 10:10 AM, Turquette, Mike mturque...@ti.com wrote: On Tue, Jan 24, 2012 at 1:53 AM, Cousson, Benoit b-cous...@ti.com wrote: + Mike On 1/19/2012 12:39 AM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@ti.com Assuming that you will re-send

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-24 Thread Cousson, Benoit
+ Mike On 1/19/2012 12:39 AM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@ti.com Assuming that you will re-send with Kevin's comment taken into account, the fix is indeed very valid. Acked-by: Benoit Cousson b-cous...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |

[PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-24 Thread Ameya Palande
According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines following fields for multiplication and division factors: DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) Acked-by: Benoit Cousson b-cous...@ti.com Signed-off-by:

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-23 Thread Kevin Hilman
Palande, Ameya ameya.pala...@ti.com writes: Any update on this? A descriptive changelog would be helpful here, ideally with a TRM reference to the correct values such that a reviewer could verify this quickly. Also, please Cc linux-arm-ker...@lists.infradead.org for upstream patches. Thanks,

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-20 Thread Palande, Ameya
Any update on this? On Wed, Jan 18, 2012 at 3:39 PM, Ameya Palande ameya.pala...@ti.com wrote: Signed-off-by: Ameya Palande ameya.pala...@ti.com ---  arch/arm/mach-omap2/clock44xx_data.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-18 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 08e86d7..053cc15 100644 ---