Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure

2012-09-06 Thread Mark Brown
On Sat, Sep 01, 2012 at 11:09:18AM +0200, Janusz Krzysztofik wrote: I see your point, however for now I can see no better way of referencing the data (of type struct snd_soc_card) then passing it to snd_soc_register_card(). But for this to work, I would have to register successfully an

Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure

2012-09-01 Thread Janusz Krzysztofik
Dnia piÄ…tek, 31 sierpnia 2012 14:31:04 Mark Brown pisze: On Wed, Aug 29, 2012 at 07:04:48AM +0200, Janusz Krzysztofik wrote: On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote: The above looks like you already have a platform driver? Mark, I should have rather answered: No, ams-delta.c is not

Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure

2012-08-31 Thread Mark Brown
On Wed, Aug 29, 2012 at 07:04:48AM +0200, Janusz Krzysztofik wrote: On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote: The above looks like you already have a platform driver? All I'm suggesting is changing the above to use platform rather than driver data. The ams-delta asoc driver doesn't

Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure

2012-08-28 Thread Janusz Krzysztofik
On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote: On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote: - platform_set_drvdata(ams_delta_audio_platform_device, - ams_delta_audio_card); - - ret =

Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure

2012-08-28 Thread Mark Brown
On Tue, Aug 28, 2012 at 05:13:05PM +0200, Janusz Krzysztofik wrote: On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote: On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote: - platform_set_drvdata(ams_delta_audio_platform_device, - ams_delta_audio_card);

Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure

2012-08-28 Thread Janusz Krzysztofik
On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote: On Tue, Aug 28, 2012 at 05:13:05PM +0200, Janusz Krzysztofik wrote: On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote: On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote: -

Re: [PATCH] ASoC: ams-delta: fix card initalization failure

2012-08-27 Thread Mark Brown
On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote: - platform_set_drvdata(ams_delta_audio_platform_device, - ams_delta_audio_card); - - ret = platform_device_add(ams_delta_audio_platform_device); - if (ret) - goto err;

[PATCH] ASoC: ams-delta: fix card initalization failure

2012-08-27 Thread Janusz Krzysztofik
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d, 'device-core: Ensure drvdata = NULL when no driver is bound', the Amstrad Delta sound card no longer initializes correctly due to drvdata reset to NULL by an upper layer before the codec device, required for successful card setup, is