On 1/21/2010 7:40 AM, Ameya Palande wrote:
This patch contains indentation fixes and cleans up various warnings
uncovered with extra warning flags:
- empty if() bodies
- incorrect use of unsigned variables
- bad comparison of pointer value
- pointless check of unsigned value being sm
>-Original Message-
>From: Palande Ameya (Nokia-D/Helsinki)
>Sent: 25 January, 2010 19:03
>To: ext Omar Ramirez Luna
>Cc: linux-omap@vger.kernel.org; Menon, Nishanth; Chitriki
>Rudramuni, Deepak; Kukkonen Mika (Nokia-D/Helsinki)
>Subject: RE: [PATCH] DSPBRIDGE: Va
/Helsinki)
Cc: linux-omap@vger.kernel.org; Menon, Nishanth; Chitriki Rudramuni, Deepak;
Kukkonen Mika (Nokia-D/Helsinki)
Subject: Re: [PATCH] DSPBRIDGE: Various compile warning fixes
Patch looks good, just one question:
> This patch contains indentation fixes and cleans up various warni
Patch looks good, just one question:
This patch contains indentation fixes and cleans up various warnings
uncovered with extra warning flags:
- empty if() bodies
am i missing something? which hunk fix this?
- incorrect use of unsigned variables
- bad comparison of pointer value
- po
>-Original Message-
>From: Palande Ameya (Nokia-D/Helsinki)
>Sent: 21 January, 2010 18:33
>To: ext Andy Shevchenko
>Cc: linux-omap@vger.kernel.org; omar.rami...@ti.com;
>n...@ti.com; deepak.chitr...@ti.com; Kukkonen Mika (Nokia-D/Helsinki)
>Subject: Re: [PATCH] DSPBR
On Thu, 2010-01-21 at 17:01 +0100, ext Andy Shevchenko wrote:
> On Thu, Jan 21, 2010 at 3:40 PM, Ameya Palande
> wrote:
> > --- a/drivers/dsp/bridge/wmd/io_sm.c
> > +++ b/drivers/dsp/bridge/wmd/io_sm.c
> > @@ -1210,7 +1210,7 @@ static void InputChnl(struct IO_MGR *pIOMgr, struct
> > CHNL_OBJECT
On Thu, Jan 21, 2010 at 3:40 PM, Ameya Palande wrote:
> --- a/drivers/dsp/bridge/wmd/io_sm.c
> +++ b/drivers/dsp/bridge/wmd/io_sm.c
> @@ -1210,7 +1210,7 @@ static void InputChnl(struct IO_MGR *pIOMgr, struct
> CHNL_OBJECT *pChnl,
> pChnlMgr->uWordSize;
> chnlId =
This patch contains indentation fixes and cleans up various warnings
uncovered with extra warning flags:
- empty if() bodies
- incorrect use of unsigned variables
- bad comparison of pointer value
- pointless check of unsigned value being smaller than zero
- keyword 'extern' has to be fi
From: Mika Kukkonen
This patch cleans up various warnings uncovered with extra warning flags:
- empty if() bodies
- bad comparison of pointer value
- pointless check of unsigned value being smaller than zero
- keyword 'extern' has to be first one in variable declaration
- indentation fi
egards,
Hari
> -Original Message-
> From: mika.kukko...@nokia.com [mailto:mika.kukko...@nokia.com]
> Sent: Monday, April 20, 2009 12:23 AM
> To: Kanigeri, Hari; Gupta, Ramesh; ameya.pala...@nokia.com
> Cc: linux-omap@vger.kernel.org
> Subject: RE: [PATCH] [DSPBRIDGE]
>-Original Message-
>From: linux-omap-ow...@vger.kernel.org
>[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of ext
>Kanigeri, Hari
>Sent: 17 April, 2009 17:21
>To: Gupta, Ramesh; Palande Ameya (Nokia-D/Helsinki);
>linux-omap@vger.kernel.org
>Subject: RE: [PA
Ameya,
- if (!(chnlId >= 0) || !(chnlId < CHNL_MAXCHANNELS)) {
+ if (chnlId >= CHNL_MAXCHANNELS) {
-- How about declaring chnlId as s32 so that the checks can be extended to
negative values too ?
Thank you,
Best regards,
Hari
--
To unsubscribe from this list: send the line "unsubsc
To: linux-omap@vger.kernel.org
> Subject: [PATCH] [DSPBRIDGE] Various compile warning fixes
>
> From: Mika Kukkonen
>
> This patch cleans up various warnings uncovered with extra
> warning flags:
> - empty if() bodies
> - incorrect use of unsigned variable
From: Mika Kukkonen
This patch cleans up various warnings uncovered with extra warning flags:
- empty if() bodies
- incorrect use of unsigned variables
- bad comparison of pointer value
- pointless check of unsigned value being smaller than zero
- keyword 'extern' has to be first one in
14 matches
Mail list logo
