Re: [PATCH] I2C: Fix OMAP I2C status register handling in IRQ processing

2008-03-28 Thread Tony Lindgren
* Seth Forshee <[EMAIL PROTECTED]> [080318 05:39]: > On Wed, Mar 12, 2008 at 12:56:10PM -0500, Seth Forshee wrote: > > The IRQ handler in omap-i2c.c can sometimes clear status bits without > > actually processing them. In particular, error status bits will be > > ignored if any of the ARDY, RRDY,

Re: [PATCH] I2C: Fix OMAP I2C status register handling in IRQ processing

2008-03-17 Thread Seth Forshee
On Wed, Mar 12, 2008 at 12:56:10PM -0500, Seth Forshee wrote: > The IRQ handler in omap-i2c.c can sometimes clear status bits without > actually processing them. In particular, error status bits will be > ignored if any of the ARDY, RRDY, RDR, XRDY, or XDR bits are > concurrently set. Are there a

Re: [PATCH] I2C: Fix OMAP I2C status register handling in IRQ processing

2008-03-12 Thread Seth Forshee
On Wed, Mar 12, 2008 at 01:14:32PM -0500, Felipe Balbi wrote: > > - int count = 0; > > + int err, count = 0; > > int err = 0, count = 0; will be better and you avoid that err=0 before > using err right below. No, the err = 0 I added is in a while loop. It needs to be reinitialized for each i

Re: [PATCH] I2C: Fix OMAP I2C status register handling in IRQ processing

2008-03-12 Thread Felipe Balbi
On Wed, 12 Mar 2008 12:56:10 -0500, Seth Forshee <[EMAIL PROTECTED]> wrote: > The IRQ handler in omap-i2c.c can sometimes clear status bits without > actually processing them. In particular, error status bits will be > ignored if any of the ARDY, RRDY, RDR, XRDY, or XDR bits are > concurrently s

[PATCH] I2C: Fix OMAP I2C status register handling in IRQ processing

2008-03-12 Thread Seth Forshee
The IRQ handler in omap-i2c.c can sometimes clear status bits without actually processing them. In particular, error status bits will be ignored if any of the ARDY, RRDY, RDR, XRDY, or XDR bits are concurrently set. Signed-off-by: Seth Forshee <[EMAIL PROTECTED]> --- More information: I origina