Re: [PATCH] OMAP: Dereference of NULL autodep in _autodep_lookup()

2010-02-24 Thread roel kluin
> Thanks for the patch, but I don't understand what problem you're > pointing out.  If autodeps is NULL entering clkdm_init(), then the > for-loop won't even be entered. My first patch was wrong, but there's something I think could be wrong. In clkdm_init() we have: for (autodep = autodeps; autod

Re: [PATCH] OMAP: Dereference of NULL autodep in _autodep_lookup()

2010-02-22 Thread Paul Walmsley
Hi Roel, On Sun, 14 Feb 2010, Roel Kluin wrote: > Don't dereference autodep when it's NULL. In _autodep_lookup() an > ERR_PTR(-ENOENT) is assigned to autodep->pwrdm.ptr if pwrdm_lookup() fails. > > Signed-off-by: Roel Kluin Thanks for the patch, but I don't understand what problem you're point

Re: [PATCH] OMAP: Dereference of NULL autodep in _autodep_lookup()

2010-02-14 Thread Roel Kluin
Op 14-02-10 17:00, Roel Kluin schreef: > Don't dereference autodep when it's NULL. In _autodep_lookup() an > ERR_PTR(-ENOENT) is assigned to autodep->pwrdm.ptr if pwrdm_lookup() fails. I am not sure whether my patch was right, if indeed a dereference, then it appears to also occur in _clkdm_add_au

[PATCH] OMAP: Dereference of NULL autodep in _autodep_lookup()

2010-02-14 Thread Roel Kluin
Don't dereference autodep when it's NULL. In _autodep_lookup() an ERR_PTR(-ENOENT) is assigned to autodep->pwrdm.ptr if pwrdm_lookup() fails. Signed-off-by: Roel Kluin --- Alternatively we could do: - for (autodep = autodeps; autodep->pwrdm.ptr; autodep++) + for (aut