Re: [PATCH] OMAP3: RX51: support sleep indicator LEDs

2009-10-05 Thread Roger Quadros
ext Kevin Hilman wrote: The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace: It would also make more sense to use gpio_export_link() to provide a

Re: [PATCH] OMAP3: RX51: support sleep indicator LEDs

2009-10-05 Thread Roger Quadros
ext Kevin Hilman wrote: Jonathan McDowell nood...@earth.li writes: On Fri, Oct 02, 2009 at 08:35:55AM -0700, Kevin Hilman wrote: The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so

[PATCH] OMAP3: RX51: support sleep indicator LEDs

2009-10-02 Thread Kevin Hilman
The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace: To enable: # echo 1 /sys/class/gpio/gpio162/value To disable: # echo 0

Re: [PATCH] OMAP3: RX51: support sleep indicator LEDs

2009-10-02 Thread Kevin Hilman
Jonathan McDowell nood...@earth.li writes: On Fri, Oct 02, 2009 at 08:35:55AM -0700, Kevin Hilman wrote: The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from

Re: [PATCH] OMAP3: RX51: support sleep indicator LEDs

2009-10-02 Thread Jonathan McDowell
On Fri, Oct 02, 2009 at 08:35:55AM -0700, Kevin Hilman wrote: The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace: Wouldn't this be better done using